Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

2016-04-12 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/#review128368
---


Fix it, then Ship it!




I'll change the wording and commit shortly.


src/tests/master_allocator_tests.cpp (lines 669 - 670)


How about:
```
// Set the `executor_shutdown_grace_period` to a small value so that
// the agent does not wait for executors to clean up for too long.
```


- Alexander Rukletsov


On April 9, 2016, 3:39 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43329/
> ---
> 
> (Updated April 9, 2016, 3:39 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3775
> https://issues.apache.org/jira/browse/MESOS-3775
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speeded up MasterAllocatorTest.SlaveLost test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_allocator_tests.cpp 
> 404ff098baf89bf2a1c6e32424d591a6ea1a093c 
> 
> Diff: https://reviews.apache.org/r/43329/diff/
> 
> 
> Testing
> ---
> 
> ```
> [--] 1 test from MasterAllocatorTest/0, where TypeParam = 
> mesos::internal::master::allocator::MesosAllocator torProcess mesos::internal::master::allocator::DRFSorter> >
> [ RUN  ] MasterAllocatorTest/0.SlaveLost
> [   OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
> [--] 1 test from MasterAllocatorTest/0 (369 ms total)
> 
> [--] 1 test from MasterAllocatorTest/1, where TypeParam = 
> mesos::internal::tests::Module (mesos::internal::tests::ModuleID)6>
> [ RUN  ] MasterAllocatorTest/1.SlaveLost
> [   OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
> [--] 1 test from MasterAllocatorTest/1 (120 ms total)
> ```
> 
> Tested repeatedly with:
> ```
> ./bin/mesos-tests.sh --gtest_filter=MasterAllocatorTest*.SlaveLost 
> --gtest_repeat=1000 --gtest_break_on_failure'
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

2016-04-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/#review127968
---



Patch looks great!

Reviews applied: [43329]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 3:39 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43329/
> ---
> 
> (Updated April 9, 2016, 3:39 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3775
> https://issues.apache.org/jira/browse/MESOS-3775
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speeded up MasterAllocatorTest.SlaveLost test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_allocator_tests.cpp 
> 404ff098baf89bf2a1c6e32424d591a6ea1a093c 
> 
> Diff: https://reviews.apache.org/r/43329/diff/
> 
> 
> Testing
> ---
> 
> ```
> [--] 1 test from MasterAllocatorTest/0, where TypeParam = 
> mesos::internal::master::allocator::MesosAllocator torProcess mesos::internal::master::allocator::DRFSorter> >
> [ RUN  ] MasterAllocatorTest/0.SlaveLost
> [   OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
> [--] 1 test from MasterAllocatorTest/0 (369 ms total)
> 
> [--] 1 test from MasterAllocatorTest/1, where TypeParam = 
> mesos::internal::tests::Module (mesos::internal::tests::ModuleID)6>
> [ RUN  ] MasterAllocatorTest/1.SlaveLost
> [   OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
> [--] 1 test from MasterAllocatorTest/1 (120 ms total)
> ```
> 
> Tested repeatedly with:
> ```
> ./bin/mesos-tests.sh --gtest_filter=MasterAllocatorTest*.SlaveLost 
> --gtest_repeat=1000 --gtest_break_on_failure'
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

2016-04-08 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/
---

(Updated April 9, 2016, 3:39 a.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Added a comment about why use a small value for 
`executor_shutdown_grace_period` flag.


Bugs: MESOS-3775
https://issues.apache.org/jira/browse/MESOS-3775


Repository: mesos


Description
---

Speeded up MasterAllocatorTest.SlaveLost test.


Diffs (updated)
-

  src/tests/master_allocator_tests.cpp 404ff098baf89bf2a1c6e32424d591a6ea1a093c 

Diff: https://reviews.apache.org/r/43329/diff/


Testing (updated)
---

```
[--] 1 test from MasterAllocatorTest/0, where TypeParam = 
mesos::internal::master::allocator::MesosAllocator >
[ RUN  ] MasterAllocatorTest/0.SlaveLost
[   OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
[--] 1 test from MasterAllocatorTest/0 (369 ms total)

[--] 1 test from MasterAllocatorTest/1, where TypeParam = 
mesos::internal::tests::Module
[ RUN  ] MasterAllocatorTest/1.SlaveLost
[   OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
[--] 1 test from MasterAllocatorTest/1 (120 ms total)
```

Tested repeatedly with:
```
./bin/mesos-tests.sh --gtest_filter=MasterAllocatorTest*.SlaveLost 
--gtest_repeat=1000 --gtest_break_on_failure'
```


Thanks,

Shuai Lin

Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

2016-04-08 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/#review127783
---


Fix it, then Ship it!




Could you please run tests in repetition? Thanks!


src/tests/master_allocator_tests.cpp (line 652)


I think it's fine to do this, but let's explain why we adjust the flag.


- Alexander Rukletsov


On March 30, 2016, 1:22 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43329/
> ---
> 
> (Updated March 30, 2016, 1:22 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3775
> https://issues.apache.org/jira/browse/MESOS-3775
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speeded up MasterAllocatorTest.SlaveLost test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_allocator_tests.cpp 
> cba7c36471f93b678d94e1da0251a28a893696b1 
> 
> Diff: https://reviews.apache.org/r/43329/diff/
> 
> 
> Testing
> ---
> 
> ```
> [--] 1 test from MasterAllocatorTest/0, where TypeParam = 
> mesos::internal::master::allocator::MesosAllocator torProcess mesos::internal::master::allocator::DRFSorter> >
> [ RUN  ] MasterAllocatorTest/0.SlaveLost
> [   OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
> [--] 1 test from MasterAllocatorTest/0 (369 ms total)
> 
> [--] 1 test from MasterAllocatorTest/1, where TypeParam = 
> mesos::internal::tests::Module (mesos::internal::tests::ModuleID)6>
> [ RUN  ] MasterAllocatorTest/1.SlaveLost
> [   OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
> [--] 1 test from MasterAllocatorTest/1 (120 ms total)
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

2016-02-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/#review118269
---



Patch looks great!

Reviews applied: [43329]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 8, 2016, 5:09 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43329/
> ---
> 
> (Updated Feb. 8, 2016, 5:09 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3775
> https://issues.apache.org/jira/browse/MESOS-3775
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speeded up MasterAllocatorTest.SlaveLost test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_allocator_tests.cpp 
> cba7c36471f93b678d94e1da0251a28a893696b1 
> 
> Diff: https://reviews.apache.org/r/43329/diff/
> 
> 
> Testing
> ---
> 
> ```
> [--] 1 test from MasterAllocatorTest/0, where TypeParam = 
> mesos::internal::master::allocator::MesosAllocator torProcess mesos::internal::master::allocator::DRFSorter> >
> [ RUN  ] MasterAllocatorTest/0.SlaveLost
> [   OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
> [--] 1 test from MasterAllocatorTest/0 (369 ms total)
> 
> [--] 1 test from MasterAllocatorTest/1, where TypeParam = 
> mesos::internal::tests::Module (mesos::internal::tests::ModuleID)6>
> [ RUN  ] MasterAllocatorTest/1.SlaveLost
> [   OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
> [--] 1 test from MasterAllocatorTest/1 (120 ms total)
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Review Request 43329: Speeded up MasterAllocatorTest.SlaveLost test.

2016-02-08 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43329/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-3775
https://issues.apache.org/jira/browse/MESOS-3775


Repository: mesos


Description
---

Speeded up MasterAllocatorTest.SlaveLost test.


Diffs
-

  src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 

Diff: https://reviews.apache.org/r/43329/diff/


Testing
---

```
[--] 1 test from MasterAllocatorTest/0, where TypeParam = 
mesos::internal::master::allocator::MesosAllocator >
[ RUN  ] MasterAllocatorTest/0.SlaveLost
[   OK ] MasterAllocatorTest/0.SlaveLost (369 ms)
[--] 1 test from MasterAllocatorTest/0 (369 ms total)

[--] 1 test from MasterAllocatorTest/1, where TypeParam = 
mesos::internal::tests::Module
[ RUN  ] MasterAllocatorTest/1.SlaveLost
[   OK ] MasterAllocatorTest/1.SlaveLost (120 ms)
[--] 1 test from MasterAllocatorTest/1 (120 ms total)
```


Thanks,

Shuai Lin