Re: Review Request 43806: Add comments for rebalance.

2016-03-03 Thread Yongqiao Wang 


> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069
> > 
> >
> > For posterity, we backtick types and variables names.
> 
> Yongqiao Wang wrote:
> Do you mean we should update the comment to :
> 
> // The allocator only needs to 'rebalance' if there is a framework
> // registered with this role. The 'roleSorter' contains only roles
> // for registered frameworks, but 'quotaRoleSorter' contains any role
> // with quota set, regardless of whether any frameworks are registered
> // with that role.
> 
> Alexander Rukletsov wrote:
> First, I didn't mean to include "rebalance" because it is a proper 
> English word in this context. Second, I meant backticks ` and not single 
> quotes '. Third, I don't think we should start another review to fix it, but 
> let's avoid it in the future.

OK, I see. Thanks!


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/#review121641
---


On Feb. 27, 2016, 12:26 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43806/
> ---
> 
> (Updated Feb. 27, 2016, 12:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add comments for rebalance.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1b69fa801cd3f08cfcdce71ee3a3ca266b2fde57 
> 
> Diff: https://reviews.apache.org/r/43806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43806: Add comments for rebalance.

2016-03-03 Thread Alexander Rukletsov 


> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069
> > 
> >
> > For posterity, we backtick types and variables names.
> 
> Yongqiao Wang wrote:
> Do you mean we should update the comment to :
> 
> // The allocator only needs to 'rebalance' if there is a framework
> // registered with this role. The 'roleSorter' contains only roles
> // for registered frameworks, but 'quotaRoleSorter' contains any role
> // with quota set, regardless of whether any frameworks are registered
> // with that role.

First, I didn't mean to include "rebalance" because it is a proper English word 
in this context. Second, I meant backticks ` and not single quotes '. Third, I 
don't think we should start another review to fix it, but let's avoid it in the 
future.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/#review121641
---


On Feb. 27, 2016, 12:26 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43806/
> ---
> 
> (Updated Feb. 27, 2016, 12:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add comments for rebalance.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1b69fa801cd3f08cfcdce71ee3a3ca266b2fde57 
> 
> Diff: https://reviews.apache.org/r/43806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43806: Add comments for rebalance.

2016-03-03 Thread Yongqiao Wang 


> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069
> > 
> >
> > For posterity, we backtick types and variables names.

Do you mean we should update the comment to :

// The allocator only needs to 'rebalance' if there is a framework
// registered with this role. The 'roleSorter' contains only roles
// for registered frameworks, but 'quotaRoleSorter' contains any role
// with quota set, regardless of whether any frameworks are registered
// with that role.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/#review121641
---


On Feb. 27, 2016, 12:26 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43806/
> ---
> 
> (Updated Feb. 27, 2016, 12:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add comments for rebalance.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1b69fa801cd3f08cfcdce71ee3a3ca266b2fde57 
> 
> Diff: https://reviews.apache.org/r/43806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43806: Add comments for rebalance.

2016-03-02 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/#review121641
---




src/master/allocator/mesos/hierarchical.cpp (lines 1066 - 1069)


For posterity, we backtick types and variables names.


- Alexander Rukletsov


On Feb. 27, 2016, 12:26 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43806/
> ---
> 
> (Updated Feb. 27, 2016, 12:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add comments for rebalance.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1b69fa801cd3f08cfcdce71ee3a3ca266b2fde57 
> 
> Diff: https://reviews.apache.org/r/43806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43806: Add comments for rebalance.

2016-02-27 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/#review121087
---


Ship it!




Ship It!

- Adam B


On Feb. 27, 2016, 4:26 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43806/
> ---
> 
> (Updated Feb. 27, 2016, 4:26 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add comments for rebalance.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1b69fa801cd3f08cfcdce71ee3a3ca266b2fde57 
> 
> Diff: https://reviews.apache.org/r/43806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43806: Add comments for rebalance.

2016-02-27 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/
---

(Updated Feb. 27, 2016, 12:26 p.m.)


Review request for mesos, Adam B and Alexander Rukletsov.


Changes
---

Update the comment for rebalance by Adam's comment.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add comments for rebalance.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
1b69fa801cd3f08cfcdce71ee3a3ca266b2fde57 

Diff: https://reviews.apache.org/r/43806/diff/


Testing
---


Thanks,

Yongqiao Wang

Re: Review Request 43806: Add comments for rebalance.

2016-02-27 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/#review121079
---



I took a stab at rewording your comment. I particularly didn't like starting 
with an ambiguous "It".


src/master/allocator/mesos/hierarchical.cpp (line 1069)


"The allocator only needs to rebalance if there is a framework registered 
with this role. The roleSorter contains only roles for registered frameworks, 
but quotaRoleSorter contains any role with quota set, regardless of whether any 
frameworks are registered with that role."
This might belong above both the quota and roleSorter checks.


- Adam B


On Feb. 20, 2016, 6:26 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43806/
> ---
> 
> (Updated Feb. 20, 2016, 6:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add comments for rebalance.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
> 
> Diff: https://reviews.apache.org/r/43806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 43806: Add comments for rebalance.

2016-02-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/#review120057
---



Patch looks great!

Reviews applied: [43806]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 21, 2016, 2:26 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43806/
> ---
> 
> (Updated Feb. 21, 2016, 2:26 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3943
> https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add comments for rebalance.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 
> 
> Diff: https://reviews.apache.org/r/43806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Review Request 43806: Add comments for rebalance.

2016-02-20 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/
---

Review request for mesos, Adam B and Alexander Rukletsov.


Bugs: MESOS-3943
https://issues.apache.org/jira/browse/MESOS-3943


Repository: mesos


Description
---

Add comments for rebalance.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d 

Diff: https://reviews.apache.org/r/43806/diff/


Testing
---


Thanks,

Yongqiao Wang