Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-25 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review130427
---


Ship it!




Ship It!

- Kapil Arya


On April 15, 2016, 3:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> ---
> 
> (Updated April 15, 2016, 3:01 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
> 
> 
> Diffs
> -
> 
>   src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47 
> 
> Diff: https://reviews.apache.org/r/46262/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-18 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review129309
---


Ship it!




Ship It!

- Alexander Rojas


On April 15, 2016, 9:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> ---
> 
> (Updated April 15, 2016, 9:01 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
> 
> 
> Diffs
> -
> 
>   src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47 
> 
> Diff: https://reviews.apache.org/r/46262/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-15 Thread Greg Mann 


> On April 15, 2016, 12:03 p.m., Alexander Rojas wrote:
> > src/tests/logging_tests.cpp, line 148
> > 
> >
> > Too keep it consistent, could you add subtests for wrong credentials 
> > and one which succeeds?

Regarding this comment, see my replies in the patches for MetricsTests.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review129105
---


On April 15, 2016, 7:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> ---
> 
> (Updated April 15, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
> 
> 
> Diffs
> -
> 
>   src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47 
> 
> Diff: https://reviews.apache.org/r/46262/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-15 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review129105
---




src/tests/logging_tests.cpp (line 148)


Too keep it consistent, could you add subtests for wrong credentials and 
one which succeeds?


- Alexander Rojas


On April 15, 2016, 9:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> ---
> 
> (Updated April 15, 2016, 9:01 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
> 
> 
> Diffs
> -
> 
>   src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47 
> 
> Diff: https://reviews.apache.org/r/46262/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46262: Added a LoggingTest with authentication.

2016-04-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/#review129090
---



Patch looks great!

Reviews applied: [46254, 46255, 46258, 46259, 46260, 46261, 46262]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 15, 2016, 7:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46262/
> ---
> 
> (Updated April 15, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
> https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test `LoggingTest.ToggleAuthenticationEnabled`
> is added in this patch.
> 
> 
> Diffs
> -
> 
>   src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47 
> 
> Diff: https://reviews.apache.org/r/46262/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 46262: Added a LoggingTest with authentication.

2016-04-15 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46262/
---

Review request for mesos, Adam B and Alexander Rojas.


Bugs: MESOS-4902
https://issues.apache.org/jira/browse/MESOS-4902


Repository: mesos


Description
---

The test `LoggingTest.ToggleAuthenticationEnabled`
is added in this patch.


Diffs
-

  src/tests/logging_tests.cpp 675a3f852baf5b4ffd10b674a0abc82c88a34c47 

Diff: https://reviews.apache.org/r/46262/diff/


Testing
---

`sudo make check` on OSX.


Thanks,

Greg Mann