Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review133020
---



Patch looks great!

Reviews applied: [46620, 46814, 46621, 46622, 46623, 46624, 46669, 46863, 
46818, 46815, 46670]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 12, 2016, 10:38 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> ---
> 
> (Updated May 12, 2016, 10:38 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
> https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `--authenticate` is made a deprecated alias for
> `--authenticate_frameworks` master flag. Also updated the example tests
> to use the new flag.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
>   src/examples/docker_no_executor_framework.cpp 
> 2b82b4f0e2424b98ea29fb08b21993b1713b364e 
>   src/examples/dynamic_reservation_framework.cpp 
> 4ad5f4b846052ec9a2067a5ce21fb017f681debf 
>   src/examples/java/TestExceptionFramework.java 
> 12bf60325567eb7a61c5811cbbac66f1b8e9ae2b 
>   src/examples/java/TestFramework.java 
> 295e54fde11fc9938d00ec03cbeaa7225b76a86c 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/examples/python/test_framework.py 
> 5f8e470721b303a60797c41db3c5587b89b5cf58 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
>   src/tests/script.cpp 5f2e2729b1d95b061bf3cbe0a052b397e366277d 
>   src/tests/test_http_framework_test.sh 
> 3a2b24cd5017f3535340cb8ade13b34e341cd7ce 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review133005
---


Fix it, then Ship it!





src/master/flags.cpp (lines 18 - 23)


Mind committing this bit separately? You also need duration.hpp, error.hpp, 
none.hpp, stringify.hpp.


- Ben Mahler


On May 12, 2016, 10:38 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> ---
> 
> (Updated May 12, 2016, 10:38 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
> https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `--authenticate` is made a deprecated alias for
> `--authenticate_frameworks` master flag. Also updated the example tests
> to use the new flag.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
>   src/examples/docker_no_executor_framework.cpp 
> 2b82b4f0e2424b98ea29fb08b21993b1713b364e 
>   src/examples/dynamic_reservation_framework.cpp 
> 4ad5f4b846052ec9a2067a5ce21fb017f681debf 
>   src/examples/java/TestExceptionFramework.java 
> 12bf60325567eb7a61c5811cbbac66f1b8e9ae2b 
>   src/examples/java/TestFramework.java 
> 295e54fde11fc9938d00ec03cbeaa7225b76a86c 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/examples/python/test_framework.py 
> 5f8e470721b303a60797c41db3c5587b89b5cf58 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
>   src/tests/script.cpp 5f2e2729b1d95b061bf3cbe0a052b397e366277d 
>   src/tests/test_http_framework_test.sh 
> 3a2b24cd5017f3535340cb8ade13b34e341cd7ce 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated May 12, 2016, 10:38 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description (updated)
---

`--authenticate` is made a deprecated alias for
`--authenticate_frameworks` master flag. Also updated the example tests
to use the new flag.


Diffs (updated)
-

  src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
  src/examples/docker_no_executor_framework.cpp 
2b82b4f0e2424b98ea29fb08b21993b1713b364e 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/java/TestExceptionFramework.java 
12bf60325567eb7a61c5811cbbac66f1b8e9ae2b 
  src/examples/java/TestFramework.java 295e54fde11fc9938d00ec03cbeaa7225b76a86c 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/python/test_framework.py 
5f8e470721b303a60797c41db3c5587b89b5cf58 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
  src/tests/script.cpp 5f2e2729b1d95b061bf3cbe0a052b397e366277d 
  src/tests/test_http_framework_test.sh 
3a2b24cd5017f3535340cb8ade13b34e341cd7ce 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review132859
---



Bad patch!

Reviews applied: [46670, 46815, 46818, 46863, 46669, 46624, 46623, 46622, 
46621, 46814, 46620]

Failed command: ./support/apply-review.sh -n -r 46620

Error:
2016-05-12 09:44:08 URL:https://reviews.apache.org/r/46620/diff/raw/ 
[6751/6751] -> "46620.patch" [1]
error: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp: does 
not exist in index
error: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp: does 
not exist in index

Full log: https://builds.apache.org/job/mesos-reviewbot/13022/console

- Mesos ReviewBot


On May 12, 2016, 1:38 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> ---
> 
> (Updated May 12, 2016, 1:38 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
> https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added deprecated alias for `--authenticate_frameworks` master flag.
> 
> 
> Diffs
> -
> 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated May 12, 2016, 1:38 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased to re-kick reviewbot.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
---

Added deprecated alias for `--authenticate_frameworks` master flag.


Diffs (updated)
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review131244
---



Patch looks great!

Reviews applied: [46620, 46814, 46621, 46622, 46623, 46624, 46669, 46863, 
46818, 46815, 46670]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 30, 2016, 3:45 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> ---
> 
> (Updated April 30, 2016, 3:45 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
> https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added deprecated alias for `--authenticate_frameworks` master flag.
> 
> 
> Diffs
> -
> 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated April 30, 2016, 3:45 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
---

Added deprecated alias for `--authenticate_frameworks` master flag.


Diffs (updated)
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review131239
---



Bad patch!

Reviews applied: [46670, 46815, 46818, 46669, 46624, 46623, 46622, 46621, 
46814, 46620]

Failed command: ./support/apply-review.sh -n -r 46621

Error:
2016-04-30 03:11:56 URL:https://reviews.apache.org/r/46621/diff/raw/ 
[14455/14455] -> "46621.patch" [1]
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp:498:  
Redundant blank line at the start of a code block should be deleted.  
[whitespace/blank_line] [2]
Total errors found: 1
Checking 2 files

Full log: https://builds.apache.org/job/mesos-reviewbot/12816/console

- Mesos ReviewBot


On April 30, 2016, 2:03 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> ---
> 
> (Updated April 30, 2016, 2:03 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
> https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added deprecated alias for `--authenticate_frameworks` master flag.
> 
> 
> Diffs
> -
> 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated April 30, 2016, 2:03 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased to re-kick reviewbot.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
---

Added deprecated alias for `--authenticate_frameworks` master flag.


Diffs (updated)
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/#review131221
---



Patch looks great!

Reviews applied: [46620, 46814, 46621, 46622, 46623, 46624, 46669, 46818, 
46815, 46670]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 7:10 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46670/
> ---
> 
> (Updated April 29, 2016, 7:10 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4386
> https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added deprecated alias for `--authenticate_frameworks` master flag.
> 
> 
> Diffs
> -
> 
>   src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 
> 
> Diff: https://reviews.apache.org/r/46670/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Teste manually by running ./bin/mesos-master.sh --authenticate
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated April 29, 2016, 7:10 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased to re-kick reviewbot.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
---

Added deprecated alias for `--authenticate_frameworks` master flag.


Diffs (updated)
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated April 29, 2016, 3:29 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
---

Added deprecated alias for `--authenticate_frameworks` master flag.


Diffs (updated)
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

(Updated April 26, 2016, 2:24 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

empty diff update to just re-kick reviewbot.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
---

Added deprecated alias for `--authenticate_frameworks` master flag.


Diffs (updated)
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone

Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46670/
---

Review request for mesos.


Bugs: MESOS-4386
https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
---

Added deprecated alias for `--authenticate_frameworks` master flag.


Diffs
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46670/diff/


Testing
---

make check

Teste manually by running ./bin/mesos-master.sh --authenticate


Thanks,

Vinod Kone