Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review167316
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On May 13, 2016, 2 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 13, 2016, 2 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> 
> Diff: https://reviews.apache.org/r/46965/diff/4/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/
---

(Updated 五月 13, 2016, 2 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Using ARIA landmarks to identify regions of a page.


Diffs
-

  src/webui/master/static/css/mesos.css 
5b1227e9d64757f9fc106e497f7fa3ed72112c10 
  src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 

Diff: https://reviews.apache.org/r/46965/diff/


Testing
---

we should Using ARIA landmarks to identify regions of a page.

1.Should add "main" role to main content page and use "banner" role for header
refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11

2. Providing heading elements at the beginning of each section of content. So 
for the header section we need provide a h1
refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html


Thanks,

Chen Nan Li

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132707
---



Patch looks great!

Reviews applied: [46965]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 11, 2016, 9:16 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 11, 2016, 9:16 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/
---

(Updated 五月 11, 2016, 9:16 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Changes
---

Drive comments


Repository: mesos


Description
---

Using ARIA landmarks to identify regions of a page.


Diffs (updated)
-

  src/webui/master/static/css/mesos.css 
5b1227e9d64757f9fc106e497f7fa3ed72112c10 
  src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 

Diff: https://reviews.apache.org/r/46965/diff/


Testing
---

we should Using ARIA landmarks to identify regions of a page.

1.Should add "main" role to main content page and use "banner" role for header
refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11

2. Providing heading elements at the beginning of each section of content. So 
for the header section we need provide a h1
refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html


Thanks,

Chen Nan Li

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Chen Nan Li]

> On 五月 10, 2016, 5:55 p.m., haosdent huang wrote:
> > src/webui/master/static/css/mesos.css, line 5
> > 
> >
> > Because this isn't belongs to `BOOTSTRAP OVERRIEDS`, please put it at 
> > the end of this css style file.

That's right. Thanks


- Chen Nan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132496
---


On 五月 8, 2016, 12:04 p.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated 五月 8, 2016, 12:04 p.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132496
---


Fix it, then Ship it!




Ship It!


src/webui/master/static/css/mesos.css (line 5)


Because this isn't belongs to `BOOTSTRAP OVERRIEDS`, please put it at the 
end of this css style file.


- haosdent huang


On May 8, 2016, 12:04 p.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 8, 2016, 12:04 p.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132176
---



Patch looks great!

Reviews applied: [46965]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 8, 2016, 12:04 p.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 8, 2016, 12:04 p.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/
---

(Updated May 8, 2016, 12:04 p.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Changes
---

Drive comments


Repository: mesos


Description
---

Using ARIA landmarks to identify regions of a page.


Diffs (updated)
-

  src/webui/master/static/css/mesos.css 
5b1227e9d64757f9fc106e497f7fa3ed72112c10 
  src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 

Diff: https://reviews.apache.org/r/46965/diff/


Testing
---

we should Using ARIA landmarks to identify regions of a page.

1.Should add "main" role to main content page and use "banner" role for header
refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11

2. Providing heading elements at the beginning of each section of content. So 
for the header section we need provide a h1
refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html


Thanks,

Chen Nan Li

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/
---

(Updated May 8, 2016, noon)


Review request for mesos, Zhiwei Chen and haosdent huang.


Changes
---

Drive comments


Repository: mesos


Description (updated)
---

Using ARIA landmarks to identify regions of a page.


Diffs (updated)
-

  src/webui/master/static/css/mesos.css 
5b1227e9d64757f9fc106e497f7fa3ed72112c10 
  src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 

Diff: https://reviews.apache.org/r/46965/diff/


Testing
---

we should Using ARIA landmarks to identify regions of a page.

1.Should add "main" role to main content page and use "banner" role for header
refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11

2. Providing heading elements at the beginning of each section of content. So 
for the header section we need provide a h1
refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html


Thanks,

Chen Nan Li

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Chen Nan Li]

> On May 6, 2016, 3:24 p.m., haosdent huang wrote:
> > src/webui/master/static/index.html, line 21
> > 
> >
> > Actualy I think here is not the main.
> > 
> > ```
> > 
> > ```
> > 
> > should be the main.
> > 
> > Contains `banner` in `main` looks wired as well.
> > 
> > Or we could delegate this to templates. Because we have two major 
> > layout styles, one is a left `dashboard` + a `main`. The other one is 
> > `main`.

yes, 



should be the main, it's more reasonable.


- Chen Nan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132041
---


On May 5, 2016, 5:03 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 5, 2016, 5:03 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page and Providing heading 
> elements at the beginning of each section of content.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Chen Nan Li]

> On May 6, 2016, 3:24 p.m., haosdent huang wrote:
> >
> 
> haosdent huang wrote:
> I think also need
> 
> 1. Update the bug field to jira ticket
> 2. Description should be limited in 72 characters.

Thanks hoasdent


- Chen Nan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132041
---


On May 5, 2016, 5:03 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 5, 2016, 5:03 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page and Providing heading 
> elements at the beginning of each section of content.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[haosdent huang]

> On May 6, 2016, 3:24 p.m., haosdent huang wrote:
> > src/webui/master/static/index.html, line 22
> > 
> >
> > +1 For use `banner` :-)

Use `banner` is more boostrap style.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132041
---


On May 5, 2016, 5:03 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 5, 2016, 5:03 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page and Providing heading 
> elements at the beginning of each section of content.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[haosdent huang]

> On May 6, 2016, 3:24 p.m., haosdent huang wrote:
> >

I think also need

1. Update the bug field to jira ticket
2. Description should be limited in 72 characters.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132041
---


On May 5, 2016, 5:03 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 5, 2016, 5:03 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page and Providing heading 
> elements at the beginning of each section of content.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132041
---




src/webui/master/static/css/mesos.css (line 5)


I think need to use `.navbar-header h1` as selector here, because I think 
we don't want to overwrite the margin of `h1` globally.



src/webui/master/static/index.html (line 21)


Actualy I think here is not the main.

```

```

should be the main.

Contains `banner` in `main` looks wired as well.

Or we could delegate this to templates. Because we have two major layout 
styles, one is a left `dashboard` + a `main`. The other one is `main`.



src/webui/master/static/index.html (line 22)


+1 For use `banner` :-)



src/webui/master/static/index.html (line 32)


Fix the incorrent indent here.
```

  Mesos

```


- haosdent huang


On May 5, 2016, 5:03 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 5, 2016, 5:03 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page and Providing heading 
> elements at the beginning of each section of content.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review131640
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On May 4, 2016, 7:55 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 4, 2016, 7:55 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page and Providing heading 
> elements at the beginning of each section of content.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Review Request 46965: Using ARIA landmarks to identify regions of a page.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/
---

Review request for mesos.


Repository: mesos


Description
---

Using ARIA landmarks to identify regions of a page and Providing heading 
elements at the beginning of each section of content.


Diffs
-

  src/webui/master/static/css/mesos.css 
5b1227e9d64757f9fc106e497f7fa3ed72112c10 
  src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 

Diff: https://reviews.apache.org/r/46965/diff/


Testing
---

we should Using ARIA landmarks to identify regions of a page.

1.Should add "main" role to main content page and use "banner" role for header
refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11

2. Providing heading elements at the beginning of each section of content. So 
for the header section we need provide a h1
refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html


Thanks,

Chen Nan Li