Re: Review Request 47389: Stout: Added support for correct path delimiters in Windows.

2016-05-23 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47389/#review134464
---




3rdparty/stout/include/stout/os/mkdir.hpp (line 51)


this can just be `path = os::PATH_SEPARATOR;`



3rdparty/stout/include/stout/os/mkdir.hpp (line 60)


This can just be `path += os::PATH_SEPARATOR;`



3rdparty/stout/include/stout/path.hpp (lines 20 - 21)


alphabetize.



3rdparty/stout/include/stout/path.hpp (lines 32 - 34)


`char_separator` -> `separator_`
`string_separator` -> `separator`



3rdparty/stout/include/stout/path.hpp (line 34)


this can be `stringify`.



3rdparty/stout/include/stout/path.hpp (line 81)


Can remove the `For obvious reasons, this was not spelled out every time.`


- Joris Van Remoortere


On May 23, 2016, 5:03 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47389/
> ---
> 
> (Updated May 23, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Added support for correct path delimiters in Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/constants.hpp 
> 438840aaef189ef4fb457b856790efb3b6333a7d 
>   3rdparty/stout/include/stout/os/mkdir.hpp 
> e86dbfd2416fc2835ef7c6c55a20f00429f7b4c6 
>   3rdparty/stout/include/stout/path.hpp 
> ef538045a8b7a1e3d8962c869317d86a85e0259f 
> 
> Diff: https://reviews.apache.org/r/47389/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47389: Stout: Added support for correct path delimiters in Windows.

2016-05-23 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47389/
---

(Updated May 23, 2016, 5:03 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout: Added support for correct path delimiters in Windows.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/constants.hpp 
438840aaef189ef4fb457b856790efb3b6333a7d 
  3rdparty/stout/include/stout/os/mkdir.hpp 
e86dbfd2416fc2835ef7c6c55a20f00429f7b4c6 
  3rdparty/stout/include/stout/path.hpp 
ef538045a8b7a1e3d8962c869317d86a85e0259f 

Diff: https://reviews.apache.org/r/47389/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47389: Stout: Added support for correct path delimiters in Windows.

2016-05-23 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47389/
---

(Updated May 23, 2016, 12:39 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout: Added support for correct path delimiters in Windows.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/constants.hpp 
438840aaef189ef4fb457b856790efb3b6333a7d 
  3rdparty/stout/include/stout/path.hpp 
ef538045a8b7a1e3d8962c869317d86a85e0259f 

Diff: https://reviews.apache.org/r/47389/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47389: Stout: Added support for correct path delimiters in Windows.

2016-05-16 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47389/#review133422
---




3rdparty/stout/include/stout/os/constants.hpp (lines 20 - 28)


Can we have just the char versions?
I think you can add support for `stringify(char)` to resolve the case where 
you want to construct just the string from a character.

From the name `WINDOWS_SEPARATOR_CHAR` it' not clear what this means. Is 
this the path separator?
The other variable is called `DIRECTORY_SEPARATOR`, which is more intuitive.

Why can't the `char` versions be `constexpr`?



3rdparty/stout/include/stout/path.hpp (line 31)


Not sure what `char_separator` means. Can you name this differently?
Is this just the `separator`?


- Joris Van Remoortere


On May 14, 2016, 11:58 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47389/
> ---
> 
> (Updated May 14, 2016, 11:58 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Added support for correct path delimiters in Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/constants.hpp 
> 438840aaef189ef4fb457b856790efb3b6333a7d 
>   3rdparty/stout/include/stout/path.hpp 
> ef538045a8b7a1e3d8962c869317d86a85e0259f 
> 
> Diff: https://reviews.apache.org/r/47389/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 47389: Stout: Added support for correct path delimiters in Windows.

2016-05-14 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47389/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout: Added support for correct path delimiters in Windows.


Diffs
-

  3rdparty/stout/include/stout/os/constants.hpp 
438840aaef189ef4fb457b856790efb3b6333a7d 
  3rdparty/stout/include/stout/path.hpp 
ef538045a8b7a1e3d8962c869317d86a85e0259f 

Diff: https://reviews.apache.org/r/47389/diff/


Testing
---


Thanks,

Alex Clemmer