Re: Review Request 50417: Improved consistency of test code for partitioning an agent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50417/ --- (Updated July 28, 2016, 9:42 a.m.) Review request for mesos and Vinod Kone. Changes --- Update commit message. Repository: mesos Description (updated) --- Removed unnecessary `Clock::settle` calls: `Clock::settle` should typically only be used when a test case does not have an easy way to wait for a _specific_ event to occur. In this case, `Clock::settle` was unnecessary because the test code immediately proceeded to `AWAIT_READY` for a more specific event. Also fixed up some whitespace. Diffs (updated) - src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 src/tests/slave_recovery_tests.cpp 470fb26a2985f912b2b91d647cd7a27b8748c2a5 src/tests/slave_tests.cpp b9fa85dc1ae0922a100786fcb01156b90a013d2a Diff: https://reviews.apache.org/r/50417/diff/ Testing --- make check Thanks, Neil Conway
Re: Review Request 50417: Improved consistency of test code for partitioning an agent.
> On July 27, 2016, 11:44 p.m., Vinod Kone wrote: > > I'm assuming the `Clock::settle()` is no longer necessary because `AWAIT_*` > > does Clock::settle() implicitly? Can you add the reason in the description > > for posterity? > > > > Also, I'm guessing you ran these tests in a loop to check for flakiness? Re: `Clock::settle()`, yeah -- `AWAIT_*` sorta does an implicit `Clock::settle`. In other words, `Clock::settle` waits for all pending events to be handled, `AWAIT_READY` waits for a single, specific future to be ready. I updated the commit comment. Yep, I ran these tests in a loop to check for flakiness. - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50417/#review143852 --- On July 25, 2016, 9:35 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50417/ > --- > > (Updated July 25, 2016, 9:35 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Remove unnecessary `Clock::settle` calls, whitespace fixes. > > > Diffs > - > > src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 > src/tests/slave_recovery_tests.cpp 470fb26a2985f912b2b91d647cd7a27b8748c2a5 > src/tests/slave_tests.cpp b9fa85dc1ae0922a100786fcb01156b90a013d2a > > Diff: https://reviews.apache.org/r/50417/diff/ > > > Testing > --- > > make check > > > Thanks, > > Neil Conway > >
Re: Review Request 50417: Improved consistency of test code for partitioning an agent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50417/#review143852 --- Ship it! I'm assuming the `Clock::settle()` is no longer necessary because `AWAIT_*` does Clock::settle() implicitly? Can you add the reason in the description for posterity? Also, I'm guessing you ran these tests in a loop to check for flakiness? - Vinod Kone On July 25, 2016, 9:35 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50417/ > --- > > (Updated July 25, 2016, 9:35 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Remove unnecessary `Clock::settle` calls, whitespace fixes. > > > Diffs > - > > src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 > src/tests/slave_recovery_tests.cpp 470fb26a2985f912b2b91d647cd7a27b8748c2a5 > src/tests/slave_tests.cpp b9fa85dc1ae0922a100786fcb01156b90a013d2a > > Diff: https://reviews.apache.org/r/50417/diff/ > > > Testing > --- > > make check > > > Thanks, > > Neil Conway > >
Review Request 50417: Improved consistency of test code for partitioning an agent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50417/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --- Remove unnecessary `Clock::settle` calls, whitespace fixes. Diffs - src/tests/partition_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1 src/tests/slave_recovery_tests.cpp 470fb26a2985f912b2b91d647cd7a27b8748c2a5 src/tests/slave_tests.cpp b9fa85dc1ae0922a100786fcb01156b90a013d2a Diff: https://reviews.apache.org/r/50417/diff/ Testing --- make check Thanks, Neil Conway
