Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-09-13 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Sept. 13, 2016, 8:04 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 
  src/Makefile.am 2dd7913a1477f3c3560be4e2c1450b93fb3afc78 
  src/slave/containerizer/mesos/containerizer.cpp 
1a120f191e4ff0e2b31dd0a9a6bced784a56612c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
452eeddcf81232174f00afc1f0ddbd410e4540b4 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
dcbc499a7ac60a7be28cd889abc73155a6c1ac83 
  src/tests/containerizer/isolator_tests.cpp 
f8056ca08029feed5f164d4f94e24d521183bdfc 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-09-11 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review148445
---


Ship it!




Ship It!

- Jie Yu


On Sept. 11, 2016, 3:59 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> ---
> 
> (Updated Sept. 11, 2016, 3:59 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5976
> https://issues.apache.org/jira/browse/MESOS-5976
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 
>   src/Makefile.am fa71381741083d3148ddaec715a862d65fc5c990 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1a120f191e4ff0e2b31dd0a9a6bced784a56612c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> 452eeddcf81232174f00afc1f0ddbd410e4540b4 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> dcbc499a7ac60a7be28cd889abc73155a6c1ac83 
>   src/tests/containerizer/isolator_tests.cpp 
> f8056ca08029feed5f164d4f94e24d521183bdfc 
>   src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 
> 
> Diff: https://reviews.apache.org/r/50750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-09-11 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Sept. 11, 2016, 3:59 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 
  src/Makefile.am fa71381741083d3148ddaec715a862d65fc5c990 
  src/slave/containerizer/mesos/containerizer.cpp 
1a120f191e4ff0e2b31dd0a9a6bced784a56612c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
452eeddcf81232174f00afc1f0ddbd410e4540b4 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
dcbc499a7ac60a7be28cd889abc73155a6c1ac83 
  src/tests/containerizer/isolator_tests.cpp 
f8056ca08029feed5f164d4f94e24d521183bdfc 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-09-11 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Sept. 11, 2016, 2:59 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 
  src/Makefile.am fa71381741083d3148ddaec715a862d65fc5c990 
  src/slave/containerizer/mesos/containerizer.cpp 
1a120f191e4ff0e2b31dd0a9a6bced784a56612c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
452eeddcf81232174f00afc1f0ddbd410e4540b4 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
dcbc499a7ac60a7be28cd889abc73155a6c1ac83 
  src/tests/containerizer/cgroups_isolator_tests.cpp 
c4e467c8227f9e4129b05d173812592f39a04e06 
  src/tests/containerizer/isolator_tests.cpp 
f8056ca08029feed5f164d4f94e24d521183bdfc 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-09-11 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Sept. 11, 2016, 10:31 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 
  src/Makefile.am fa71381741083d3148ddaec715a862d65fc5c990 
  src/slave/containerizer/mesos/containerizer.cpp 
89b7e8db38916d69d9b2d4fe305d4397b0859a10 
  src/tests/containerizer/isolator_tests.cpp 
f8056ca08029feed5f164d4f94e24d521183bdfc 
  src/tests/containerizer/net_cls_isolator_tests.cpp PRE-CREATION 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-09-05 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Sept. 5, 2016, 4:04 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt b14132abf49a73defd3e4774330b5227726b9207 
  src/Makefile.am e296e31be6706ac9e9e052b7cc81bad0572d6028 
  src/slave/containerizer/mesos/containerizer.cpp 
89b7e8db38916d69d9b2d4fe305d4397b0859a10 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
f8056ca08029feed5f164d4f94e24d521183bdfc 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-27 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 27, 2016, 3:29 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt ccd9892f5327a70f001411faf3199329f12cd472 
  src/Makefile.am b577b42f11a4848666d3c00bc5de60de0f68d765 
  src/slave/containerizer/mesos/containerizer.cpp 
89b7e8db38916d69d9b2d4fe305d4397b0859a10 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
f8056ca08029feed5f164d4f94e24d521183bdfc 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-22 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 22, 2016, 4:50 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 7ffe377aa1b6e726c964f7b9f0f4ea067d8fddf9 
  src/Makefile.am 83db8829aa51eed08daa81d0064034f385c5b95a 
  src/slave/containerizer/mesos/containerizer.cpp 
77a502f853e3e04ea8e274419544601778be9421 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
05620d2411d464593cdb5aeaea10cb147047569b 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-21 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 21, 2016, 9:30 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt ff51705202569b85922d877ef95750d7943372d8 
  src/Makefile.am 61c941f42bdccdf1745f72f875cb5c5a9901dc76 
  src/slave/containerizer/mesos/containerizer.cpp 
77a502f853e3e04ea8e274419544601778be9421 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
05620d2411d464593cdb5aeaea10cb147047569b 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-20 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 20, 2016, 9:20 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt a83dde9f51e5601d02be6c233b1fcd5bee324ba1 
  src/Makefile.am bfda83d112149cd3e5c579a33252e463212a9c5b 
  src/slave/containerizer/mesos/containerizer.cpp 
77a502f853e3e04ea8e274419544601778be9421 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
05620d2411d464593cdb5aeaea10cb147047569b 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-18 Thread haosdent huang 


> On Aug. 17, 2016, 8:06 a.m., Qian Zhang wrote:
> > src/tests/environment.cpp, line 438
> > 
> >
> > Here can we change it to the following?
> > ```
> > if (matches(test, "ROOT_CGROUPS_Isolate") ||
> > matches(test, "ROOT_CGROUPS_ContainerStatus") {
> > ```
> > In this way, I think you can still name the test class as 
> > `CgroupsIsolatorTest` which will be consistent with other cgroup's related 
> > tests.
> 
> haosdent huang wrote:
> I found `ROOT_CGROUPS_Isolate` and `ROOT_CGROUPS_ContainerStatus` are not 
> exactly enough here because it only test net_cls. Should we use 
> `ROOT_CGROUPS_NetSubsystemIsolate` and 
> `ROOT_CGROUPS_NetSubsystemContainerStatus` respectively.
> 
> Qian Zhang wrote:
> I think they should be `ROOT_CGROUPS_NetClsIsolate` (rather than 
> `ROOT_CGROUPS_Isolate`) and `ROOT_CGROUPS_ContainerStatus` which are the 
> original test names. So can you please let me know if 
> `ROOT_CGROUPS_NetClsIsolate` and `ROOT_CGROUPS_ContainerStatus` are enough? I 
> think it should be OK since we are doing the similar thing in 
> `PerfCPUCyclesFilter::disable()`, right?
> 
> haosdent huang wrote:
> `CgroupsIsolatorTest.ROOT_CGROUPS_ContainerStatus` sounds not exactly, 
> how about `CgroupsIsolatorTest.ROOT_CGROUPS_ContainerNetClsStatus`?
> 
> Qian Zhang wrote:
> What about name it as `ROOT_CGROUPS_NetClsContainerStatus` which seems 
> more consistent with `ROOT_CGROUPS_NetClsIsolate`?

Make sense, let me update.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review145965
---


On Aug. 18, 2016, 4:10 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> ---
> 
> (Updated Aug. 18, 2016, 4:10 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5976
> https://issues.apache.org/jira/browse/MESOS-5976
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 77a502f853e3e04ea8e274419544601778be9421 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b3fd8c85476bf46368bd79f052b7923ad9d32199 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
>   src/tests/containerizer/isolator_tests.cpp 
> 05620d2411d464593cdb5aeaea10cb147047569b 
>   src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 
> 
> Diff: https://reviews.apache.org/r/50750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-18 Thread Qian Zhang 


> On Aug. 17, 2016, 4:06 p.m., Qian Zhang wrote:
> > src/tests/environment.cpp, line 438
> > 
> >
> > Here can we change it to the following?
> > ```
> > if (matches(test, "ROOT_CGROUPS_Isolate") ||
> > matches(test, "ROOT_CGROUPS_ContainerStatus") {
> > ```
> > In this way, I think you can still name the test class as 
> > `CgroupsIsolatorTest` which will be consistent with other cgroup's related 
> > tests.
> 
> haosdent huang wrote:
> I found `ROOT_CGROUPS_Isolate` and `ROOT_CGROUPS_ContainerStatus` are not 
> exactly enough here because it only test net_cls. Should we use 
> `ROOT_CGROUPS_NetSubsystemIsolate` and 
> `ROOT_CGROUPS_NetSubsystemContainerStatus` respectively.
> 
> Qian Zhang wrote:
> I think they should be `ROOT_CGROUPS_NetClsIsolate` (rather than 
> `ROOT_CGROUPS_Isolate`) and `ROOT_CGROUPS_ContainerStatus` which are the 
> original test names. So can you please let me know if 
> `ROOT_CGROUPS_NetClsIsolate` and `ROOT_CGROUPS_ContainerStatus` are enough? I 
> think it should be OK since we are doing the similar thing in 
> `PerfCPUCyclesFilter::disable()`, right?
> 
> haosdent huang wrote:
> `CgroupsIsolatorTest.ROOT_CGROUPS_ContainerStatus` sounds not exactly, 
> how about `CgroupsIsolatorTest.ROOT_CGROUPS_ContainerNetClsStatus`?

What about name it as `ROOT_CGROUPS_NetClsContainerStatus` which seems more 
consistent with `ROOT_CGROUPS_NetClsIsolate`?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review145965
---


On Aug. 19, 2016, 12:10 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> ---
> 
> (Updated Aug. 19, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5976
> https://issues.apache.org/jira/browse/MESOS-5976
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 77a502f853e3e04ea8e274419544601778be9421 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b3fd8c85476bf46368bd79f052b7923ad9d32199 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
>   src/tests/containerizer/isolator_tests.cpp 
> 05620d2411d464593cdb5aeaea10cb147047569b 
>   src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 
> 
> Diff: https://reviews.apache.org/r/50750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-18 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 18, 2016, 4:10 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
  src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
  src/slave/containerizer/mesos/containerizer.cpp 
77a502f853e3e04ea8e274419544601778be9421 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
05620d2411d464593cdb5aeaea10cb147047569b 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-18 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 18, 2016, 1:50 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Address @qianzhang's comments.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
  src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
  src/slave/containerizer/mesos/containerizer.cpp 
77a502f853e3e04ea8e274419544601778be9421 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
05620d2411d464593cdb5aeaea10cb147047569b 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-18 Thread haosdent huang 


> On Aug. 17, 2016, 8:06 a.m., Qian Zhang wrote:
> > src/tests/environment.cpp, line 438
> > 
> >
> > Here can we change it to the following?
> > ```
> > if (matches(test, "ROOT_CGROUPS_Isolate") ||
> > matches(test, "ROOT_CGROUPS_ContainerStatus") {
> > ```
> > In this way, I think you can still name the test class as 
> > `CgroupsIsolatorTest` which will be consistent with other cgroup's related 
> > tests.
> 
> haosdent huang wrote:
> I found `ROOT_CGROUPS_Isolate` and `ROOT_CGROUPS_ContainerStatus` are not 
> exactly enough here because it only test net_cls. Should we use 
> `ROOT_CGROUPS_NetSubsystemIsolate` and 
> `ROOT_CGROUPS_NetSubsystemContainerStatus` respectively.
> 
> Qian Zhang wrote:
> I think they should be `ROOT_CGROUPS_NetClsIsolate` (rather than 
> `ROOT_CGROUPS_Isolate`) and `ROOT_CGROUPS_ContainerStatus` which are the 
> original test names. So can you please let me know if 
> `ROOT_CGROUPS_NetClsIsolate` and `ROOT_CGROUPS_ContainerStatus` are enough? I 
> think it should be OK since we are doing the similar thing in 
> `PerfCPUCyclesFilter::disable()`, right?

`CgroupsIsolatorTest.ROOT_CGROUPS_ContainerStatus` sounds not exactly, how 
about `CgroupsIsolatorTest.ROOT_CGROUPS_ContainerNetClsStatus`?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review145965
---


On Aug. 17, 2016, 5:50 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> ---
> 
> (Updated Aug. 17, 2016, 5:50 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5976
> https://issues.apache.org/jira/browse/MESOS-5976
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 77a502f853e3e04ea8e274419544601778be9421 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b3fd8c85476bf46368bd79f052b7923ad9d32199 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
>   src/tests/containerizer/isolator_tests.cpp 
> 05620d2411d464593cdb5aeaea10cb147047569b 
>   src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 
> 
> Diff: https://reviews.apache.org/r/50750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-18 Thread Qian Zhang 


> On Aug. 17, 2016, 4:06 p.m., Qian Zhang wrote:
> > src/tests/environment.cpp, line 438
> > 
> >
> > Here can we change it to the following?
> > ```
> > if (matches(test, "ROOT_CGROUPS_Isolate") ||
> > matches(test, "ROOT_CGROUPS_ContainerStatus") {
> > ```
> > In this way, I think you can still name the test class as 
> > `CgroupsIsolatorTest` which will be consistent with other cgroup's related 
> > tests.
> 
> haosdent huang wrote:
> I found `ROOT_CGROUPS_Isolate` and `ROOT_CGROUPS_ContainerStatus` are not 
> exactly enough here because it only test net_cls. Should we use 
> `ROOT_CGROUPS_NetSubsystemIsolate` and 
> `ROOT_CGROUPS_NetSubsystemContainerStatus` respectively.

I think they should be `ROOT_CGROUPS_NetClsIsolate` (rather than 
`ROOT_CGROUPS_Isolate`) and `ROOT_CGROUPS_ContainerStatus` which are the 
original test names. So can you please let me know if 
`ROOT_CGROUPS_NetClsIsolate` and `ROOT_CGROUPS_ContainerStatus` are enough? I 
think it should be OK since we are doing the similar thing in 
`PerfCPUCyclesFilter::disable()`, right?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review145965
---


On Aug. 18, 2016, 1:50 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> ---
> 
> (Updated Aug. 18, 2016, 1:50 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5976
> https://issues.apache.org/jira/browse/MESOS-5976
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 77a502f853e3e04ea8e274419544601778be9421 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b3fd8c85476bf46368bd79f052b7923ad9d32199 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
>   src/tests/containerizer/isolator_tests.cpp 
> 05620d2411d464593cdb5aeaea10cb147047569b 
>   src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 
> 
> Diff: https://reviews.apache.org/r/50750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-17 Thread haosdent huang 


> On Aug. 17, 2016, 8:06 a.m., Qian Zhang wrote:
> > src/tests/environment.cpp, line 438
> > 
> >
> > Here can we change it to the following?
> > ```
> > if (matches(test, "ROOT_CGROUPS_Isolate") ||
> > matches(test, "ROOT_CGROUPS_ContainerStatus") {
> > ```
> > In this way, I think you can still name the test class as 
> > `CgroupsIsolatorTest` which will be consistent with other cgroup's related 
> > tests.

I found `ROOT_CGROUPS_Isolate` and `ROOT_CGROUPS_ContainerStatus` are not 
exactly enough here because it only test net_cls. Should we use 
`ROOT_CGROUPS_NetSubsystemIsolate` and 
`ROOT_CGROUPS_NetSubsystemContainerStatus` respectively.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review145965
---


On Aug. 17, 2016, 5:50 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> ---
> 
> (Updated Aug. 17, 2016, 5:50 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5976
> https://issues.apache.org/jira/browse/MESOS-5976
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 77a502f853e3e04ea8e274419544601778be9421 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b3fd8c85476bf46368bd79f052b7923ad9d32199 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
>   src/tests/containerizer/isolator_tests.cpp 
> 05620d2411d464593cdb5aeaea10cb147047569b 
>   src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 
> 
> Diff: https://reviews.apache.org/r/50750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-17 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 17, 2016, 5:50 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Address @qianzhang's comments.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
  src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
  src/slave/containerizer/mesos/containerizer.cpp 
77a502f853e3e04ea8e274419544601778be9421 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
05620d2411d464593cdb5aeaea10cb147047569b 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-17 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review145965
---




src/tests/containerizer/isolator_tests.cpp (line 1018)


Why removed `create` here? I think this test will also cover the `create()` 
method of `NetClsSubsystem`, right?



src/tests/containerizer/isolator_tests.cpp (line 1024)


s/CgroupsIsolator/CgroupsIsolatorProcess/
s/cleans/clean/



src/tests/environment.cpp (line 438)


Here can we change it to the following?
```
if (matches(test, "ROOT_CGROUPS_Isolate") ||
matches(test, "ROOT_CGROUPS_ContainerStatus") {
```
In this way, I think you can still name the test class as 
`CgroupsIsolatorTest` which will be consistent with other cgroup's related 
tests.


- Qian Zhang


On Aug. 17, 2016, 1:47 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> ---
> 
> (Updated Aug. 17, 2016, 1:47 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5976
> https://issues.apache.org/jira/browse/MESOS-5976
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 5ed894d18258f6516866a2acd343c03281039c3c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b3fd8c85476bf46368bd79f052b7923ad9d32199 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
>   src/tests/containerizer/isolator_tests.cpp 
> f917db78157f799efc00b0c7af0230ddb6f26b0b 
>   src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 
> 
> Diff: https://reviews.apache.org/r/50750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-16 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 16, 2016, 5:47 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Address @alexr's comment.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
  src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
  src/slave/containerizer/mesos/containerizer.cpp 
5ed894d18258f6516866a2acd343c03281039c3c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
f917db78157f799efc00b0c7af0230ddb6f26b0b 
  src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-16 Thread haosdent huang 


> On Aug. 16, 2016, 2:28 p.m., Qian Zhang wrote:
> > src/tests/containerizer/isolator_tests.cpp, line 1025
> > 
> >
> > I think changing test name from `NetClsIsolatorTest` to 
> > `CgroupsIsolatorTest` will make this test fail, I have verified in Ubuntu 
> > 14.04:
> > ```
> > [==] Running 1 test from 1 test case.
> > [--] Global test environment set-up.
> > [--] 1 test from CgroupsIsolatorTest
> > [ RUN  ] CgroupsIsolatorTest.ROOT_CGROUPS_NetClsSubsystemIsolate
> > ../../src/tests/containerizer/isolator_tests.cpp:1038: Failure
> > _containerizer: Failed to create isolator 'cgroups/net_cls': Failed to 
> > prepare hierarchy for the subsystem 'net_cls': Failed to mount cgroups 
> > hierarchy at '/sys/fs/cgroup/net_cls': 'net_cls' not found
> > [  FAILED  ] CgroupsIsolatorTest.ROOT_CGROUPS_NetClsSubsystemIsolate 
> > (1734 ms)
> > ```
> > Basically this test should be disabled on Ubuntu 14.04 which does not 
> > have `net_cls` subsystem turned on, please see the following code about why 
> > it is not disabled when the test name is changed.
> > 
> > https://github.com/apache/mesos/blob/0d3793e94adcd6dc91d06404f205639cebd753fd/src/tests/environment.cpp#L436:L442

Nice catch! I only test my patches in CentOS 7 before. Let me try the Ubuntu 
14.04


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review145863
---


On Aug. 15, 2016, 1:12 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> ---
> 
> (Updated Aug. 15, 2016, 1:12 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5976
> https://issues.apache.org/jira/browse/MESOS-5976
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 5ed894d18258f6516866a2acd343c03281039c3c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b3fd8c85476bf46368bd79f052b7923ad9d32199 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
>   src/tests/containerizer/isolator_tests.cpp 
> f917db78157f799efc00b0c7af0230ddb6f26b0b 
> 
> Diff: https://reviews.apache.org/r/50750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-16 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review145863
---




src/tests/containerizer/isolator_tests.cpp (line 1023)


I think changing test name from `NetClsIsolatorTest` to 
`CgroupsIsolatorTest` will make this test fail, I have verified in Ubuntu 14.04:
```
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from CgroupsIsolatorTest
[ RUN  ] CgroupsIsolatorTest.ROOT_CGROUPS_NetClsSubsystemIsolate
../../src/tests/containerizer/isolator_tests.cpp:1038: Failure
_containerizer: Failed to create isolator 'cgroups/net_cls': Failed to 
prepare hierarchy for the subsystem 'net_cls': Failed to mount cgroups 
hierarchy at '/sys/fs/cgroup/net_cls': 'net_cls' not found
[  FAILED  ] CgroupsIsolatorTest.ROOT_CGROUPS_NetClsSubsystemIsolate (1734 
ms)
```
Basically this test should be disabled on Ubuntu 14.04 which does not have 
`net_cls` subsystem turned on, please see the following code about why it is 
not disabled when the test name is changed.

https://github.com/apache/mesos/blob/0d3793e94adcd6dc91d06404f205639cebd753fd/src/tests/environment.cpp#L436:L442



src/tests/containerizer/isolator_tests.cpp (line 1145)


Ditto.


- Qian Zhang


On Aug. 15, 2016, 9:12 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> ---
> 
> (Updated Aug. 15, 2016, 9:12 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5976
> https://issues.apache.org/jira/browse/MESOS-5976
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 5ed894d18258f6516866a2acd343c03281039c3c 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b3fd8c85476bf46368bd79f052b7923ad9d32199 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
>   src/tests/containerizer/isolator_tests.cpp 
> f917db78157f799efc00b0c7af0230ddb6f26b0b 
> 
> Diff: https://reviews.apache.org/r/50750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-15 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 15, 2016, 1:12 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
  src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
  src/slave/containerizer/mesos/containerizer.cpp 
5ed894d18258f6516866a2acd343c03281039c3c 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
f917db78157f799efc00b0c7af0230ddb6f26b0b 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-14 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review145720
---


Ship it!




Ship It!

- Qian Zhang


On Aug. 11, 2016, 10:20 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> ---
> 
> (Updated Aug. 11, 2016, 10:20 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5976
> https://issues.apache.org/jira/browse/MESOS-5976
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16 
>   src/Makefile.am 33706e56189eb3f9a571d9aacf1050e188410d7c 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> b3fd8c85476bf46368bd79f052b7923ad9d32199 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
>   src/tests/containerizer/isolator_tests.cpp 
> 4f047ae6b2e85e177e8b73d60b9dfca913c832a5 
> 
> Diff: https://reviews.apache.org/r/50750/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-11 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 11, 2016, 2:20 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16 
  src/Makefile.am 33706e56189eb3f9a571d9aacf1050e188410d7c 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
4f047ae6b2e85e177e8b73d60b9dfca913c832a5 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-10 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 10, 2016, 4:36 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16 
  src/Makefile.am cf76a699c33debb129722b7cba63a4e9e09f84f7 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
bebefbba7153d4b0e9a8d7179cfb642e6e802bea 
  src/tests/containerizer/isolator_tests.cpp 
827c9f06b97191a5b74bb8fa2ef716c4282e7518 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-09 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 9, 2016, 6:45 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 39e3199a03860edf7321b442b87582b0564a318c 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
827c9f06b97191a5b74bb8fa2ef716c4282e7518 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-03 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

(Updated Aug. 3, 2016, 5:32 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
---

Rebase.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs (updated)
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

2016-08-03 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/
---

Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Bugs: MESOS-5976
https://issues.apache.org/jira/browse/MESOS-5976


Repository: mesos


Description
---

Removed CgroupsNetClsIsolatorProcess.


Diffs
-

  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/Makefile.am 30d8f7289200b8741fe9a108f55d45c7a0e307ca 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
b3fd8c85476bf46368bd79f052b7923ad9d32199 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
2665b022260b9228d4d34f030feb0d2f5de54bb3 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
  src/tests/containerizer/isolator_tests.cpp 
488747347f71a6a1bb6bc01477143d077d4fd3eb 

Diff: https://reviews.apache.org/r/50750/diff/


Testing
---


Thanks,

haosdent huang