Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
---

(Updated Dec. 9, 2016, 4:50 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Tweaked the JIRA -- Joseph Wu.


Bugs: MESOS-5966
https://issues.apache.org/jira/browse/MESOS-5966


Repository: mesos


Description
---

This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


Diffs
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
2a19b3b1e09517151bddb43a128f45457da4ca8a 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
7fa46e4cc3e1225e9c9591fb5a1fb8d90c165c01 

Diff: https://reviews.apache.org/r/51065/diff/


Testing
---

Testing details are found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
---

(Updated Dec. 8, 2016, 6:33 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Updated comments.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
2a19b3b1e09517151bddb43a128f45457da4ca8a 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
7fa46e4cc3e1225e9c9591fb5a1fb8d90c165c01 

Diff: https://reviews.apache.org/r/51065/diff/


Testing
---

Testing details are found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/#review158482
---



Still LGTM.


3rdparty/libprocess/include/process/ssl/gtest.hpp (lines 305 - 306)


This comment needs an update.



3rdparty/libprocess/src/tests/ssl_tests.cpp (lines 144 - 145)


This comment needs an update.


- Joseph Wu


On Nov. 30, 2016, 3:16 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51065/
> ---
> 
> (Updated Nov. 30, 2016, 3:16 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This changes the SSL helpers in libprocess to generate
> certs using a hostname determined using the same address
> that is advertised by libprocess. This assures that
> validation of the certificates will succeed. The test
> `SSLTest.BasicSameProcess` is also updated to accommodate
> this change.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 2a19b3b1e09517151bddb43a128f45457da4ca8a 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 7fa46e4cc3e1225e9c9591fb5a1fb8d90c165c01 
> 
> Diff: https://reviews.apache.org/r/51065/diff/
> 
> 
> Testing
> ---
> 
> Testing details are found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
---

(Updated Nov. 30, 2016, 11:16 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
2a19b3b1e09517151bddb43a128f45457da4ca8a 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
7fa46e4cc3e1225e9c9591fb5a1fb8d90c165c01 

Diff: https://reviews.apache.org/r/51065/diff/


Testing
---

Testing details are found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
---

(Updated Nov. 22, 2016, 7:55 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


Diffs
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
21a0fc45b55a368a21b3e616c751ab43eebd4902 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
55c8c309571b1892b0acc4d766eda9bb98085a6f 

Diff: https://reviews.apache.org/r/51065/diff/


Testing (updated)
---

Testing details are found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
---

(Updated Nov. 16, 2016, 1:14 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description (updated)
---

This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
21a0fc45b55a368a21b3e616c751ab43eebd4902 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
55c8c309571b1892b0acc4d766eda9bb98085a6f 

Diff: https://reviews.apache.org/r/51065/diff/


Testing
---

`make check` on Ubuntu 14.04


Thanks,

Greg Mann

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
---

(Updated Oct. 17, 2016, 6:54 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
21a0fc45b55a368a21b3e616c751ab43eebd4902 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
55c8c309571b1892b0acc4d766eda9bb98085a6f 

Diff: https://reviews.apache.org/r/51065/diff/


Testing
---

`make check` on Ubuntu 14.04


Thanks,

Greg Mann

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
---

(Updated Sept. 22, 2016, 3:46 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
21a0fc45b55a368a21b3e616c751ab43eebd4902 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
a5ac03969694c4345c2c5004051b08b6d1da8555 

Diff: https://reviews.apache.org/r/51065/diff/


Testing
---

`make check` on Ubuntu 14.04


Thanks,

Greg Mann

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/#review149773
---


Ship it!




LGTM.

- Joseph Wu


On Sept. 19, 2016, 11:47 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51065/
> ---
> 
> (Updated Sept. 19, 2016, 11:47 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This changes the SSL helpers in libprocess to generate
> certs using a hostname determined using the same address
> that is advertised by libprocess. This assures that
> validation of the certificates will succeed. The test
> `SSLTest.BasicSameProcess` is also updated to accommodate
> this change.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 2ad623a5ea3b3286983e895010af756f14f51b64 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> a5ac03969694c4345c2c5004051b08b6d1da8555 
> 
> Diff: https://reviews.apache.org/r/51065/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
---

(Updated Sept. 19, 2016, 6:47 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
2ad623a5ea3b3286983e895010af756f14f51b64 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
a5ac03969694c4345c2c5004051b08b6d1da8555 

Diff: https://reviews.apache.org/r/51065/diff/


Testing
---

`make check` on Ubuntu 14.04


Thanks,

Greg Mann

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/#review148746
---



Looks like this needs a rebase?

- Greg Mann


On Aug. 13, 2016, 6:15 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51065/
> ---
> 
> (Updated Aug. 13, 2016, 6:15 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This changes the SSL helpers in libprocess to generate
> certs using a hostname determined using the same address
> that is advertised by libprocess. This assures that
> validation of the certificates will succeed. The test
> `SSLTest.BasicSameProcess` is also updated to accommodate
> this change.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 83778bbfcc75f3f39b98d03a3580398e7d1062ea 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> a5ac03969694c4345c2c5004051b08b6d1da8555 
> 
> Diff: https://reviews.apache.org/r/51065/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
---

(Updated Aug. 13, 2016, 6:15 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description (updated)
---

This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
83778bbfcc75f3f39b98d03a3580398e7d1062ea 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
a5ac03969694c4345c2c5004051b08b6d1da8555 

Diff: https://reviews.apache.org/r/51065/diff/


Testing
---

`make check` on Ubuntu 14.04


Thanks,

Greg Mann

Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
---

Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This changes an SSL helper in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed.


Diffs
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
83778bbfcc75f3f39b98d03a3580398e7d1062ea 

Diff: https://reviews.apache.org/r/51065/diff/


Testing
---

`make check` on Ubuntu 14.04


Thanks,

Greg Mann