Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-11-25 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/
---

(Updated Nov. 25, 2016, 11:49 a.m.)


Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
Joseph Wu.


Repository: mesos


Description
---

Additionally persist health check parameters from the `HealthCheck`
protobuf as class members to avoid code duplication.


Diffs (updated)
-

  src/health-check/health_checker.hpp 837d1358e418d21536da488e4a23cbfa41db6060 
  src/health-check/health_checker.cpp af5500be249c74a4a5e64bf38dea607173e2f998 

Diff: https://reviews.apache.org/r/52867/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-11-24 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/#review156852
---


Ship it!




Ship It!

- Gastón Kleiman


On Nov. 23, 2016, 12:44 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52867/
> ---
> 
> (Updated Nov. 23, 2016, 12:44 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
> Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Additionally persist health check parameters from the `HealthCheck`
> protobuf as class members to avoid code duplication.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> 837d1358e418d21536da488e4a23cbfa41db6060 
>   src/health-check/health_checker.cpp 
> af5500be249c74a4a5e64bf38dea607173e2f998 
> 
> Diff: https://reviews.apache.org/r/52867/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-11-22 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/
---

(Updated Nov. 23, 2016, 12:44 a.m.)


Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
Joseph Wu.


Repository: mesos


Description
---

Additionally persist health check parameters from the `HealthCheck`
protobuf as class members to avoid code duplication.


Diffs (updated)
-

  src/health-check/health_checker.hpp 837d1358e418d21536da488e4a23cbfa41db6060 
  src/health-check/health_checker.cpp af5500be249c74a4a5e64bf38dea607173e2f998 

Diff: https://reviews.apache.org/r/52867/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-11-20 Thread haosdent huang 


> On Nov. 18, 2016, 8:56 a.m., Benjamin Mahler wrote:
> > src/health-check/health_checker.cpp, line 371
> > 
> >
> > Still want these timeout variables?

Refer @gaston's comment at https://reviews.apache.org/r/52867/#comment222016 , 
it would compile fail if don't use these timeout variables here.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/#review156286
---


On Nov. 14, 2016, 10:28 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52867/
> ---
> 
> (Updated Nov. 14, 2016, 10:28 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
> Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Additionally persist health check parameters from the `HealthCheck`
> protobuf as class members to avoid code duplication.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> a1dc72493ff31b87068d5691f4d5b794392caf76 
>   src/health-check/health_checker.cpp 
> e2b32e2d57515202f547d12ba492ad8eb633641b 
> 
> Diff: https://reviews.apache.org/r/52867/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-11-18 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/#review156286
---


Ship it!





src/health-check/health_checker.cpp (line 369)


Still want these timeout variables?



src/health-check/health_checker.cpp (line 445)


Still want these timeout variables?



src/health-check/health_checker.cpp (line 569)


Still want these timeout variables?


- Benjamin Mahler


On Nov. 14, 2016, 10:28 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52867/
> ---
> 
> (Updated Nov. 14, 2016, 10:28 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
> Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Additionally persist health check parameters from the `HealthCheck`
> protobuf as class members to avoid code duplication.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> a1dc72493ff31b87068d5691f4d5b794392caf76 
>   src/health-check/health_checker.cpp 
> e2b32e2d57515202f547d12ba492ad8eb633641b 
> 
> Diff: https://reviews.apache.org/r/52867/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-11-15 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/#review155935
---


Ship it!




Ship It!

- haosdent huang


On Nov. 14, 2016, 10:28 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52867/
> ---
> 
> (Updated Nov. 14, 2016, 10:28 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
> Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Additionally persist health check parameters from the `HealthCheck`
> protobuf as class members to avoid code duplication.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> a1dc72493ff31b87068d5691f4d5b794392caf76 
>   src/health-check/health_checker.cpp 
> e2b32e2d57515202f547d12ba492ad8eb633641b 
> 
> Diff: https://reviews.apache.org/r/52867/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-11-14 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/
---

(Updated Nov. 14, 2016, 10:28 a.m.)


Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
Joseph Wu.


Repository: mesos


Description
---

Additionally persist health check parameters from the `HealthCheck`
protobuf as class members to avoid code duplication.


Diffs (updated)
-

  src/health-check/health_checker.hpp a1dc72493ff31b87068d5691f4d5b794392caf76 
  src/health-check/health_checker.cpp e2b32e2d57515202f547d12ba492ad8eb633641b 

Diff: https://reviews.apache.org/r/52867/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-10-17 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/#review152891
---




src/health-check/health_checker.cpp (line 208)


Here need to be `checkGracePeriod.secs()`, otherwise would compile failed.


- haosdent huang


On Oct. 14, 2016, 3:26 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52867/
> ---
> 
> (Updated Oct. 14, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
> Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Additionally persist health check parameters from the `HealthCheck`
> protobuf as class members to avoid code duplication.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> 392b4d5bd1e5831994b9366c1eb5a2911e19860f 
>   src/health-check/health_checker.cpp 
> 96ae1a733ff3d211b84d0893b4603873af1c89f0 
> 
> Diff: https://reviews.apache.org/r/52867/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-10-17 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/#review152851
---




src/health-check/health_checker.cpp (lines 356 - 357)


I asked the same to AlexR in private. Apparently it is not possible to 
capture object members in C++11.


- Gastón Kleiman


On Oct. 14, 2016, 3:26 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52867/
> ---
> 
> (Updated Oct. 14, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
> Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Additionally persist health check parameters from the `HealthCheck`
> protobuf as class members to avoid code duplication.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> 392b4d5bd1e5831994b9366c1eb5a2911e19860f 
>   src/health-check/health_checker.cpp 
> 96ae1a733ff3d211b84d0893b4603873af1c89f0 
> 
> Diff: https://reviews.apache.org/r/52867/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-10-17 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/#review152830
---




src/health-check/health_checker.cpp (lines 356 - 357)


Is it possible to use `checkTimeout` here directly?


- haosdent huang


On Oct. 14, 2016, 3:26 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52867/
> ---
> 
> (Updated Oct. 14, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
> Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Additionally persist health check parameters from the `HealthCheck`
> protobuf as class members to avoid code duplication.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> 392b4d5bd1e5831994b9366c1eb5a2911e19860f 
>   src/health-check/health_checker.cpp 
> 96ae1a733ff3d211b84d0893b4603873af1c89f0 
> 
> Diff: https://reviews.apache.org/r/52867/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-10-14 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/
---

(Updated Oct. 14, 2016, 3:26 p.m.)


Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
Joseph Wu.


Repository: mesos


Description
---

Additionally persist health check parameters from the `HealthCheck`
protobuf as class members to avoid code duplication.


Diffs (updated)
-

  src/health-check/health_checker.hpp 392b4d5bd1e5831994b9366c1eb5a2911e19860f 
  src/health-check/health_checker.cpp 96ae1a733ff3d211b84d0893b4603873af1c89f0 

Diff: https://reviews.apache.org/r/52867/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-10-14 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/#review152675
---


Ship it!




Ship It!

- Gastón Kleiman


On Oct. 14, 2016, 12:51 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52867/
> ---
> 
> (Updated Oct. 14, 2016, 12:51 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
> Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Additionally persist health check parameters from the `HealthCheck`
> protobuf as class members to avoid code duplication.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> 392b4d5bd1e5831994b9366c1eb5a2911e19860f 
>   src/health-check/health_checker.cpp 
> 96ae1a733ff3d211b84d0893b4603873af1c89f0 
> 
> Diff: https://reviews.apache.org/r/52867/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

2016-10-14 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/
---

(Updated Oct. 14, 2016, 12:51 p.m.)


Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
Joseph Wu.


Summary (updated)
-

Used `Duration::create()` for double -> Duration conversion.


Repository: mesos


Description
---

Additionally persist health check parameters from the `HealthCheck`
protobuf as class members to avoid code duplication.


Diffs
-

  src/health-check/health_checker.hpp 392b4d5bd1e5831994b9366c1eb5a2911e19860f 
  src/health-check/health_checker.cpp 96ae1a733ff3d211b84d0893b4603873af1c89f0 

Diff: https://reviews.apache.org/r/52867/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov

Review Request 52867: Used `Duration::create` for double -> Duration conversion.

2016-10-14 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52867/
---

Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and 
Joseph Wu.


Repository: mesos


Description
---

Additionally persist health check parameters from the `HealthCheck`
protobuf as class members to avoid code duplication.


Diffs
-

  src/health-check/health_checker.hpp 392b4d5bd1e5831994b9366c1eb5a2911e19860f 
  src/health-check/health_checker.cpp 96ae1a733ff3d211b84d0893b4603873af1c89f0 

Diff: https://reviews.apache.org/r/52867/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov