> On Nov. 18, 2016, 8:56 a.m., Benjamin Mahler wrote: > > src/health-check/health_checker.cpp, line 371 > > <https://reviews.apache.org/r/52867/diff/3/?file=1562965#file1562965line371> > > > > Still want these timeout variables?
Refer @gaston's comment at https://reviews.apache.org/r/52867/#comment222016 , it would compile fail if don't use these timeout variables here. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/#review156286 ----------------------------------------------------------- On Nov. 14, 2016, 10:28 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52867/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 10:28 a.m.) > > > Review request for mesos, Daniel Pravat, Gastón Kleiman, haosdent huang, and > Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Additionally persist health check parameters from the `HealthCheck` > protobuf as class members to avoid code duplication. > > > Diffs > ----- > > src/health-check/health_checker.hpp > a1dc72493ff31b87068d5691f4d5b794392caf76 > src/health-check/health_checker.cpp > e2b32e2d57515202f547d12ba492ad8eb633641b > > Diff: https://reviews.apache.org/r/52867/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >