Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-10-07 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/#review187358
---



Summary and description need to follow Mesos standards (past-tense, 
full-sentence summary, with description in the body).


3rdparty/stout/include/stout/os/write.hpp
Lines 118 (patched)


Style (`#endif // __WINDOWS__`).


- Andrew Schwartzmeyer


On Oct. 5, 2017, 9:04 p.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60620/
> ---
> 
> (Updated Oct. 5, 2017, 9:04 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and 
> Li Li.
> 
> 
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify os::write to write binary files on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/write.hpp 
> 9ff749f209e6dd6ca3695907108a029c9a2b4f05 
> 
> 
> Diff: https://reviews.apache.org/r/60620/diff/3/
> 
> 
> Testing
> ---
> 
> Built successfully on both Linux (with autotools and cmake) and Windows (with 
> cmake).
> 
> Ran stout-tests and mesos-tests successfully on both Windows and Linux.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-10-05 Thread Jeff Coffler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/
---

(Updated Oct. 6, 2017, 4:04 a.m.)


Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li 
Li.


Bugs: MESOS-6705
https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description
---

Modify os::write to write binary files on Windows.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/write.hpp 
9ff749f209e6dd6ca3695907108a029c9a2b4f05 


Diff: https://reviews.apache.org/r/60620/diff/3/

Changes: https://reviews.apache.org/r/60620/diff/2-3/


Testing
---

Built successfully on both Linux (with autotools and cmake) and Windows (with 
cmake).

Ran stout-tests and mesos-tests successfully on both Windows and Linux.


Thanks,

Jeff Coffler

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-08-24 Thread Jeff Coffler 


> On Aug. 16, 2017, 12:19 p.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/os/write.hpp
> > Lines 70 (patched)
> > 
> >
> > Should be an `#ifdef`.

I took care of this since I'm re-working the commits.


> On Aug. 16, 2017, 12:19 p.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/os/write.hpp
> > Lines 71 (patched)
> > 
> >
> > I'm going to drop a `NOTE:` comment here to explain the extra option.

I added the NOTE: explaining the O_BINARY option on Windows.


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/#review180778
---


On July 5, 2017, 5:43 p.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60620/
> ---
> 
> (Updated July 5, 2017, 5:43 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and 
> Li Li.
> 
> 
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify os::write to write binary files on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/write.hpp 
> beb5bd83b52565a75e34d32b5bb17951bc799578 
> 
> 
> Diff: https://reviews.apache.org/r/60620/diff/2/
> 
> 
> Testing
> ---
> 
> Built successfully on both Linux (with autotools and cmake) and Windows (with 
> cmake).
> 
> Ran stout-tests and mesos-tests successfully on both Windows and Linux.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-08-16 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/#review180778
---


Ship it!




I'll fix this up before committing the chain.


3rdparty/stout/include/stout/os/write.hpp
Lines 70 (patched)


Should be an `#ifdef`.



3rdparty/stout/include/stout/os/write.hpp
Lines 71 (patched)


I'm going to drop a `NOTE:` comment here to explain the extra option.


- Joseph Wu


On July 5, 2017, 10:43 a.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60620/
> ---
> 
> (Updated July 5, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and 
> Li Li.
> 
> 
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify os::write to write binary files on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/write.hpp 
> beb5bd83b52565a75e34d32b5bb17951bc799578 
> 
> 
> Diff: https://reviews.apache.org/r/60620/diff/2/
> 
> 
> Testing
> ---
> 
> Built successfully on both Linux (with autotools and cmake) and Windows (with 
> cmake).
> 
> Ran stout-tests and mesos-tests successfully on both Windows and Linux.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-08-15 Thread Andrew Schwartzmeyer 


> On Aug. 15, 2017, 10:47 a.m., Andrew Schwartzmeyer wrote:
> > Ship It!

You can remove the "depends on 60345" here to make the bot a bit happier.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/#review182962
---


On July 5, 2017, 10:43 a.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60620/
> ---
> 
> (Updated July 5, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and 
> Li Li.
> 
> 
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify os::write to write binary files on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/write.hpp 
> beb5bd83b52565a75e34d32b5bb17951bc799578 
> 
> 
> Diff: https://reviews.apache.org/r/60620/diff/2/
> 
> 
> Testing
> ---
> 
> Built successfully on both Linux (with autotools and cmake) and Windows (with 
> cmake).
> 
> Ran stout-tests and mesos-tests successfully on both Windows and Linux.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-08-15 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/#review182962
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On July 5, 2017, 10:43 a.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60620/
> ---
> 
> (Updated July 5, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and 
> Li Li.
> 
> 
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modify os::write to write binary files on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/write.hpp 
> beb5bd83b52565a75e34d32b5bb17951bc799578 
> 
> 
> Diff: https://reviews.apache.org/r/60620/diff/2/
> 
> 
> Testing
> ---
> 
> Built successfully on both Linux (with autotools and cmake) and Windows (with 
> cmake).
> 
> Ran stout-tests and mesos-tests successfully on both Windows and Linux.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>

Re: Review Request 60620: Modify os::write to write binary files on Windows.

2017-07-05 Thread Jeff Coffler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/
---

(Updated July 5, 2017, 5:43 p.m.)


Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li 
Li.


Bugs: MESOS-6705
https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description
---

Modify os::write to write binary files on Windows.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/write.hpp 
beb5bd83b52565a75e34d32b5bb17951bc799578 


Diff: https://reviews.apache.org/r/60620/diff/2/

Changes: https://reviews.apache.org/r/60620/diff/1-2/


Testing
---

Built successfully on both Linux (with autotools and cmake) and Windows (with 
cmake).

Ran stout-tests and mesos-tests successfully on both Windows and Linux.


Thanks,

Jeff Coffler

Review Request 60620: Modify os::write to write binary files on Windows.

2017-07-03 Thread Jeff Coffler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/
---

Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li 
Li.


Bugs: MESOS-6705
https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description
---

Modify os::write to write binary files on Windows.


Diffs
-

  3rdparty/stout/include/stout/os/write.hpp 
beb5bd83b52565a75e34d32b5bb17951bc799578 


Diff: https://reviews.apache.org/r/60620/diff/1/


Testing
---

Built successfully on both Linux (with autotools and cmake) and Windows (with 
cmake).

Ran stout-tests and mesos-tests successfully on both Windows and Linux.


Thanks,

Jeff Coffler