> On Aug. 16, 2017, 12:19 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 70 (patched) > > <https://reviews.apache.org/r/60620/diff/2/?file=1769603#file1769603line70> > > > > Should be an `#ifdef`.
I took care of this since I'm re-working the commits. > On Aug. 16, 2017, 12:19 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 71 (patched) > > <https://reviews.apache.org/r/60620/diff/2/?file=1769603#file1769603line71> > > > > I'm going to drop a `NOTE:` comment here to explain the extra option. I added the NOTE: explaining the O_BINARY option on Windows. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review180778 ----------------------------------------------------------- On July 5, 2017, 5:43 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60620/ > ----------------------------------------------------------- > > (Updated July 5, 2017, 5:43 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Modify os::write to write binary files on Windows. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/write.hpp > beb5bd83b52565a75e34d32b5bb17951bc799578 > > > Diff: https://reviews.apache.org/r/60620/diff/2/ > > > Testing > ------- > > Built successfully on both Linux (with autotools and cmake) and Windows (with > cmake). > > Ran stout-tests and mesos-tests successfully on both Windows and Linux. > > > Thanks, > > Jeff Coffler > >
