Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/
---

(Updated April 24, 2018, 11:55 a.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Removed TODO.


Bugs: MESOS-8675
https://issues.apache.org/jira/browse/MESOS-8675


Repository: mesos


Description
---

Replaced `open()` with `os::open()` in `http_proxy.cpp`.


Diffs (updated)
-

  3rdparty/libprocess/src/http_proxy.cpp 
25d63791e4788a488f96303aabeed0fa77ad7992 


Diff: https://reviews.apache.org/r/66440/diff/4/

Changes: https://reviews.apache.org/r/66440/diff/3-4/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/
---

(Updated April 9, 2018, 3:09 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Also check `ERROR_PATH_NOT_FOUND`.


Bugs: MESOS-8675
https://issues.apache.org/jira/browse/MESOS-8675


Repository: mesos


Description
---

Replaced `open()` with `os::open()` in `http_proxy.cpp`.


Diffs (updated)
-

  3rdparty/libprocess/src/http_proxy.cpp 
25d63791e4788a488f96303aabeed0fa77ad7992 


Diff: https://reviews.apache.org/r/66440/diff/3/

Changes: https://reviews.apache.org/r/66440/diff/2-3/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

[Andrew Schwartzmeyer]

> On April 9, 2018, 2:51 p.m., Akash Gupta wrote:
> > 3rdparty/libprocess/src/http_proxy.cpp
> > Lines 159 (patched)
> > 
> >
> > There's also `ERROR_PATH_NOT_FOUND`. To be safe, you might want to 
> > check both.

I didn't see `CreateFile` state it could set this... but who knows; yeah let's 
be safe.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/#review200764
---


On April 6, 2018, 4:17 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66440/
> ---
> 
> (Updated April 6, 2018, 4:17 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced `open()` with `os::open()` in `http_proxy.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http_proxy.cpp 
> 25d63791e4788a488f96303aabeed0fa77ad7992 
> 
> 
> Diff: https://reviews.apache.org/r/66440/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

[Akash Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/#review200764
---


Fix it, then Ship it!





3rdparty/libprocess/src/http_proxy.cpp
Lines 159 (patched)


There's also `ERROR_PATH_NOT_FOUND`. To be safe, you might want to check 
both.


- Akash Gupta


On April 6, 2018, 11:17 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66440/
> ---
> 
> (Updated April 6, 2018, 11:17 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced `open()` with `os::open()` in `http_proxy.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http_proxy.cpp 
> 25d63791e4788a488f96303aabeed0fa77ad7992 
> 
> 
> Diff: https://reviews.apache.org/r/66440/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/
---

(Updated April 6, 2018, 4:17 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Fixed error handling.

The saddest part is that the first iteration of this particular patch was 
written January 25th...


Bugs: MESOS-8675
https://issues.apache.org/jira/browse/MESOS-8675


Repository: mesos


Description
---

Replaced `open()` with `os::open()` in `http_proxy.cpp`.


Diffs (updated)
-

  3rdparty/libprocess/src/http_proxy.cpp 
25d63791e4788a488f96303aabeed0fa77ad7992 


Diff: https://reviews.apache.org/r/66440/diff/2/

Changes: https://reviews.apache.org/r/66440/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

[Akash Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/#review200616
---


Fix it, then Ship it!





3rdparty/libprocess/src/http_proxy.cpp
Line 155 (original), 155 (patched)


We might need to `#ifdef` here to handle the `GetLastError` on Windows and 
`errno` on Linux.


- Akash Gupta


On April 4, 2018, 5:57 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66440/
> ---
> 
> (Updated April 4, 2018, 5:57 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced `open()` with `os::open()` in `http_proxy.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http_proxy.cpp 
> 25d63791e4788a488f96303aabeed0fa77ad7992 
> 
> 
> Diff: https://reviews.apache.org/r/66440/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/#review200493
---


Ship it!




Ship It!

- John Kordich


On April 4, 2018, 5:57 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66440/
> ---
> 
> (Updated April 4, 2018, 5:57 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced `open()` with `os::open()` in `http_proxy.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http_proxy.cpp 
> 25d63791e4788a488f96303aabeed0fa77ad7992 
> 
> 
> Diff: https://reviews.apache.org/r/66440/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66440/
---

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Bugs: MESOS-8675
https://issues.apache.org/jira/browse/MESOS-8675


Repository: mesos


Description
---

Replaced `open()` with `os::open()` in `http_proxy.cpp`.


Diffs
-

  3rdparty/libprocess/src/http_proxy.cpp 
25d63791e4788a488f96303aabeed0fa77ad7992 


Diff: https://reviews.apache.org/r/66440/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer