Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

2018-04-30 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66578/
---

(Updated April 30, 2018, 1:44 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Added another test.


Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441


Repository: mesos


Description
---

Fixed `os::sleep()` to return an invalid parameter error if given a
negative value.

Fixed tests around the `cloexec` and `nonblock` stubs.

Extended the `bootid` test to use `std::chrono` to assert the boot
id (which is the system boot time) is a reasonable value.

Permanently disabled `OsTest.Libraries` because there is no
equivalent.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/bootid.hpp 
d24e115b97ebcabfa808a9437fb41512f25a5271 
  3rdparty/stout/include/stout/windows/os.hpp 
900baf9be4e3089cb43e444b14b155a80bcd1591 
  3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 


Diff: https://reviews.apache.org/r/66578/diff/3/

Changes: https://reviews.apache.org/r/66578/diff/2-3/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

2018-04-30 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66578/#review202128
---


Fix it, then Ship it!





3rdparty/stout/include/stout/windows/os.hpp
Lines 338 (patched)


The POSIX implementation ignores `EINTR` so I think the equivalent on 
Windows would be a non-alertable sleep.



3rdparty/stout/tests/os_tests.cpp
Lines 204 (patched)


I guess you can try if you can set a valid socket to non blocking mode.


- Akash Gupta


On April 27, 2018, 4:20 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66578/
> ---
> 
> (Updated April 27, 2018, 4:20 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed `os::sleep()` to return an invalid parameter error if given a
> negative value.
> 
> Fixed tests around the `cloexec` and `nonblock` stubs.
> 
> Extended the `bootid` test to use `std::chrono` to assert the boot
> id (which is the system boot time) is a reasonable value.
> 
> Permanently disabled `OsTest.Libraries` because there is no
> equivalent.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/bootid.hpp 
> d24e115b97ebcabfa808a9437fb41512f25a5271 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 900baf9be4e3089cb43e444b14b155a80bcd1591 
>   3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 
> 
> 
> Diff: https://reviews.apache.org/r/66578/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

2018-04-26 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66578/
---

(Updated April 26, 2018, 9:20 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Fixed tests to explicitly construct since `WindowsFD` constructors are now 
explicit.


Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441


Repository: mesos


Description
---

Fixed `os::sleep()` to return an invalid parameter error if given a
negative value.

Fixed tests around the `cloexec` and `nonblock` stubs.

Extended the `bootid` test to use `std::chrono` to assert the boot
id (which is the system boot time) is a reasonable value.

Permanently disabled `OsTest.Libraries` because there is no
equivalent.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/bootid.hpp 
d24e115b97ebcabfa808a9437fb41512f25a5271 
  3rdparty/stout/include/stout/windows/os.hpp 
900baf9be4e3089cb43e444b14b155a80bcd1591 
  3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 


Diff: https://reviews.apache.org/r/66578/diff/2/

Changes: https://reviews.apache.org/r/66578/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

2018-04-24 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66578/#review201865
---


Ship it!




The cloexec and nonblock "ports" are a bit funny looking :)  Better than 
otherwise though.

- Joseph Wu


On April 11, 2018, 7:06 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66578/
> ---
> 
> (Updated April 11, 2018, 7:06 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed `os::sleep()` to return an invalid parameter error if given a
> negative value.
> 
> Fixed tests around the `cloexec` and `nonblock` stubs.
> 
> Extended the `bootid` test to use `std::chrono` to assert the boot
> id (which is the system boot time) is a reasonable value.
> 
> Permanently disabled `OsTest.Libraries` because there is no
> equivalent.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/bootid.hpp 
> d24e115b97ebcabfa808a9437fb41512f25a5271 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 900baf9be4e3089cb43e444b14b155a80bcd1591 
>   3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 
> 
> 
> Diff: https://reviews.apache.org/r/66578/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

2018-04-12 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66578/#review200991
---



Patch looks great!

Reviews applied: [66420, 66421, 66422, 66423, 66424, 66425, 66426, 66427, 
66428, 66455, 66429, 66430, 66431, 66432, 66434, 66435, 66436, 66437, 66433, 
66438, 66439, 66440, 66442, 66443, 66444, 66445, 66578]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 12, 2018, 2:06 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66578/
> ---
> 
> (Updated April 12, 2018, 2:06 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed `os::sleep()` to return an invalid parameter error if given a
> negative value.
> 
> Fixed tests around the `cloexec` and `nonblock` stubs.
> 
> Extended the `bootid` test to use `std::chrono` to assert the boot
> id (which is the system boot time) is a reasonable value.
> 
> Permanently disabled `OsTest.Libraries` because there is no
> equivalent.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/bootid.hpp 
> d24e115b97ebcabfa808a9437fb41512f25a5271 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 900baf9be4e3089cb43e444b14b155a80bcd1591 
>   3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 
> 
> 
> Diff: https://reviews.apache.org/r/66578/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

2018-04-11 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66578/#review200965
---



PASS: Mesos patch 66578 was successfully built and tested.

Reviews applied: `['66423', '66424', '66425', '66426', '66427', '66428', 
'66455', '66429', '66430', '66431', '66432', '66434', '66435', '66436', 
'66437', '66433', '66438', '66439', '66440', '66442', '66443', '66444', 
'66445', '66578']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66578

- Mesos Reviewbot Windows


On April 12, 2018, 2:06 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66578/
> ---
> 
> (Updated April 12, 2018, 2:06 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed `os::sleep()` to return an invalid parameter error if given a
> negative value.
> 
> Fixed tests around the `cloexec` and `nonblock` stubs.
> 
> Extended the `bootid` test to use `std::chrono` to assert the boot
> id (which is the system boot time) is a reasonable value.
> 
> Permanently disabled `OsTest.Libraries` because there is no
> equivalent.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/bootid.hpp 
> d24e115b97ebcabfa808a9437fb41512f25a5271 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 900baf9be4e3089cb43e444b14b155a80bcd1591 
>   3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 
> 
> 
> Diff: https://reviews.apache.org/r/66578/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

2018-04-11 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66578/
---

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441


Repository: mesos


Description
---

Fixed `os::sleep()` to return an invalid parameter error if given a
negative value.

Fixed tests around the `cloexec` and `nonblock` stubs.

Extended the `bootid` test to use `std::chrono` to assert the boot
id (which is the system boot time) is a reasonable value.

Permanently disabled `OsTest.Libraries` because there is no
equivalent.


Diffs
-

  3rdparty/stout/include/stout/os/windows/bootid.hpp 
d24e115b97ebcabfa808a9437fb41512f25a5271 
  3rdparty/stout/include/stout/windows/os.hpp 
900baf9be4e3089cb43e444b14b155a80bcd1591 
  3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 


Diff: https://reviews.apache.org/r/66578/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer