Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

2018-05-01 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66790/
---

(Updated May 1, 2018, 3:42 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.


Changes
---

Enabled Flags test.


Bugs: MESOS-8833
https://issues.apache.org/jira/browse/MESOS-8833


Repository: mesos


Description
---

These tests mostly "just worked" on Windows, with only minor changes,
such as converting POSIX shell-script to Batch or PowerShell, and
expecting Windows line-endings and quoting semantics.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
be99bd6a88b2abcabed8d4d16763c2e29f38eb14 


Diff: https://reviews.apache.org/r/66790/diff/3/

Changes: https://reviews.apache.org/r/66790/diff/2-3/


Testing (updated)
---

~~13~~ ~~14~~ 15 more tests running on Windows :)


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

2018-05-01 Thread Andrew Schwartzmeyer 


> On May 1, 2018, 2:39 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/tests/subprocess_tests.cpp
> > Lines 651-652 (original), 697-698 (patched)
> > 
> >
> > What's wrong with this test?  (You might want to expand the TODO a bit)

I don't know what's wrong with it! I've naively tried just using `cmd.exe` and 
`{cmd.exe, cmd.exe, echo}` but some of the assertions fail. I was punting it, 
but am now debugging it.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66790/#review202220
---


On April 30, 2018, 2:11 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66790/
> ---
> 
> (Updated April 30, 2018, 2:11 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-8833
> https://issues.apache.org/jira/browse/MESOS-8833
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests mostly "just worked" on Windows, with only minor changes,
> such as converting POSIX shell-script to Batch or PowerShell, and
> expecting Windows line-endings and quoting semantics.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> be99bd6a88b2abcabed8d4d16763c2e29f38eb14 
> 
> 
> Diff: https://reviews.apache.org/r/66790/diff/2/
> 
> 
> Testing
> ---
> 
> ~~13~~ 14 more tests running on Windows :)
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

2018-05-01 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66790/#review202220
---


Fix it, then Ship it!





3rdparty/libprocess/src/tests/subprocess_tests.cpp
Lines 651-652 (original), 697-698 (patched)


What's wrong with this test?  (You might want to expand the TODO a bit)


- Joseph Wu


On April 30, 2018, 2:11 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66790/
> ---
> 
> (Updated April 30, 2018, 2:11 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-8833
> https://issues.apache.org/jira/browse/MESOS-8833
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests mostly "just worked" on Windows, with only minor changes,
> such as converting POSIX shell-script to Batch or PowerShell, and
> expecting Windows line-endings and quoting semantics.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> be99bd6a88b2abcabed8d4d16763c2e29f38eb14 
> 
> 
> Diff: https://reviews.apache.org/r/66790/diff/2/
> 
> 
> Testing
> ---
> 
> ~~13~~ 14 more tests running on Windows :)
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

2018-04-30 Thread Andrew Schwartzmeyer 


> On April 30, 2018, 1:18 p.m., Akash Gupta wrote:
> > 3rdparty/libprocess/src/tests/subprocess_tests.cpp
> > Line 234 (original), 233 (patched)
> > 
> >
> > I think the first half of this test could be out of the #ifdef.

Indeed!


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66790/#review202133
---


On April 30, 2018, 2:11 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66790/
> ---
> 
> (Updated April 30, 2018, 2:11 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-8833
> https://issues.apache.org/jira/browse/MESOS-8833
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests mostly "just worked" on Windows, with only minor changes,
> such as converting POSIX shell-script to Batch or PowerShell, and
> expecting Windows line-endings and quoting semantics.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> be99bd6a88b2abcabed8d4d16763c2e29f38eb14 
> 
> 
> Diff: https://reviews.apache.org/r/66790/diff/2/
> 
> 
> Testing
> ---
> 
> ~~13~~ 14 more tests running on Windows :)
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

2018-04-30 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66790/
---

(Updated April 30, 2018, 2:11 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.


Changes
---

Enabled yet another test!


Bugs: MESOS-8833
https://issues.apache.org/jira/browse/MESOS-8833


Repository: mesos


Description
---

These tests mostly "just worked" on Windows, with only minor changes,
such as converting POSIX shell-script to Batch or PowerShell, and
expecting Windows line-endings and quoting semantics.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
be99bd6a88b2abcabed8d4d16763c2e29f38eb14 


Diff: https://reviews.apache.org/r/66790/diff/2/

Changes: https://reviews.apache.org/r/66790/diff/1-2/


Testing (updated)
---

~~13~~ 14 more tests running on Windows :)


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

2018-04-30 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66790/#review202133
---


Fix it, then Ship it!





3rdparty/libprocess/src/tests/subprocess_tests.cpp
Line 234 (original), 233 (patched)


I think the first half of this test could be out of the #ifdef.


- Akash Gupta


On April 24, 2018, 11:18 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66790/
> ---
> 
> (Updated April 24, 2018, 11:18 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-8833
> https://issues.apache.org/jira/browse/MESOS-8833
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests mostly "just worked" on Windows, with only minor changes,
> such as converting POSIX shell-script to Batch or PowerShell, and
> expecting Windows line-endings and quoting semantics.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> be99bd6a88b2abcabed8d4d16763c2e29f38eb14 
> 
> 
> Diff: https://reviews.apache.org/r/66790/diff/1/
> 
> 
> Testing
> ---
> 
> 13 more tests running on Windows :)
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

2018-04-24 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66790/#review201886
---



PASS: Mesos patch 66790 was successfully built and tested.

Reviews applied: `['66423', '66424', '66425', '66426', '66427', '66428', 
'66455', '66429', '66430', '66431', '66432', '66434', '66435', '66436', 
'66437', '66433', '66438', '66439', '66440', '66442', '66443', '66444', 
'66445', '66578', '66641', '66773', '66790']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66790

- Mesos Reviewbot Windows


On April 24, 2018, 11:18 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66790/
> ---
> 
> (Updated April 24, 2018, 11:18 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-8833
> https://issues.apache.org/jira/browse/MESOS-8833
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests mostly "just worked" on Windows, with only minor changes,
> such as converting POSIX shell-script to Batch or PowerShell, and
> expecting Windows line-endings and quoting semantics.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> be99bd6a88b2abcabed8d4d16763c2e29f38eb14 
> 
> 
> Diff: https://reviews.apache.org/r/66790/diff/1/
> 
> 
> Testing
> ---
> 
> 13 more tests running on Windows :)
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.

2018-04-24 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66790/
---

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.


Bugs: MESOS-8833
https://issues.apache.org/jira/browse/MESOS-8833


Repository: mesos


Description
---

These tests mostly "just worked" on Windows, with only minor changes,
such as converting POSIX shell-script to Batch or PowerShell, and
expecting Windows line-endings and quoting semantics.


Diffs
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
be99bd6a88b2abcabed8d4d16763c2e29f38eb14 


Diff: https://reviews.apache.org/r/66790/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer