Re: Review Request 66923: Added documentation on volume resize support.

2018-05-04 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66923/#review202487
---



Patch looks great!

Reviews applied: [66218, 66049, 66733, 66050, 66219, 66858, 66220, 66531, 
66532, 66052, 66051, 66227, 66923]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 4, 2018, 4:49 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66923/
> ---
> 
> (Updated May 4, 2018, 4:49 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on volume resize support.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md fdbef770c38ab38ab748b4f943b331d4442a2ce1 
>   docs/operator-http-api.md 9be1e2db60562b369bdc6ee2c732a74fad049580 
>   docs/persistent-volume.md 1a5799b8d8e5302e0b01da6b9a16a3b9fb75c898 
> 
> 
> Diff: https://reviews.apache.org/r/66923/diff/2/
> 
> 
> Testing
> ---
> 
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/persistent-volume.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/operator-http-api.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/authorization.md
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66923: Added documentation on volume resize support.

2018-05-04 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66923/#review202482
---


Ship it!




- Greg Mann


On May 4, 2018, 4:49 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66923/
> ---
> 
> (Updated May 4, 2018, 4:49 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on volume resize support.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md fdbef770c38ab38ab748b4f943b331d4442a2ce1 
>   docs/operator-http-api.md 9be1e2db60562b369bdc6ee2c732a74fad049580 
>   docs/persistent-volume.md 1a5799b8d8e5302e0b01da6b9a16a3b9fb75c898 
> 
> 
> Diff: https://reviews.apache.org/r/66923/diff/2/
> 
> 
> Testing
> ---
> 
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/persistent-volume.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/operator-http-api.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/authorization.md
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66923: Added documentation on volume resize support.

2018-05-04 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66923/#review202460
---



PASS: Mesos patch 66923 was successfully built and tested.

Reviews applied: `['66923']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66923

- Mesos Reviewbot Windows


On May 4, 2018, 4:49 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66923/
> ---
> 
> (Updated May 4, 2018, 4:49 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on volume resize support.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md fdbef770c38ab38ab748b4f943b331d4442a2ce1 
>   docs/operator-http-api.md 9be1e2db60562b369bdc6ee2c732a74fad049580 
>   docs/persistent-volume.md 1a5799b8d8e5302e0b01da6b9a16a3b9fb75c898 
> 
> 
> Diff: https://reviews.apache.org/r/66923/diff/2/
> 
> 
> Testing
> ---
> 
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/persistent-volume.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/operator-http-api.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/authorization.md
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66923: Added documentation on volume resize support.

2018-05-04 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66923/
---

(Updated May 4, 2018, 9:49 a.m.)


Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Changes
---

Review comments.


Repository: mesos


Description
---

Added documentation on volume resize support.


Diffs (updated)
-

  docs/authorization.md fdbef770c38ab38ab748b4f943b331d4442a2ce1 
  docs/operator-http-api.md 9be1e2db60562b369bdc6ee2c732a74fad049580 
  docs/persistent-volume.md 1a5799b8d8e5302e0b01da6b9a16a3b9fb75c898 


Diff: https://reviews.apache.org/r/66923/diff/2/

Changes: https://reviews.apache.org/r/66923/diff/1-2/


Testing
---

https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/persistent-volume.md
https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/operator-http-api.md
https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/authorization.md


Thanks,

Zhitao Li

Re: Review Request 66923: Added documentation on volume resize support.

2018-05-03 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66923/#review202364
---




docs/operator-http-api.md
Lines 1987-1990 (patched)


Could you provide links to the persistent volume docs here and below for 
SHRINK_VOLUME? Since those docs provide lots of specific information about the 
API I think it would be helpful.



docs/persistent-volume.md
Lines 59-60 (original), 62-63 (patched)


Looks like this should also be updated?



docs/persistent-volume.md
Lines 271 (patched)


s/with same/with the same/



docs/persistent-volume.md
Lines 309 (patched)


s/sending a/sending an/



docs/persistent-volume.md
Lines 310 (patched)


If you're going to mention `acceptOffers` explicitly here, then we should 
also mention the ACCEPT call.

Something like:
"We can grow the persistent volume by including an `Offer::Operation` 
message when accepting an offer (this can be done via the `SchedulerDriver`'s 
`acceptOffers` method, or via the v1 scheduler API's `ACCEPT` call)."



docs/persistent-volume.md
Lines 311 (patched)


s/specified/specifies/



docs/persistent-volume.md
Lines 312 (patched)


s/specified/specifies/



docs/persistent-volume.md
Lines 317 (patched)


Nit: missing a space before the `{` on this line. Here and elsewhere.



docs/persistent-volume.md
Lines 347 (patched)


s/new size/the new size/



docs/persistent-volume.md
Lines 384 (patched)


s/IN/In/



docs/persistent-volume.md
Lines 415 (patched)


s/sending a/sending an/



docs/persistent-volume.md
Lines 416 (patched)


Ditto regarding mentioning `acceptOffers` here.



docs/persistent-volume.md
Lines 417-418 (patched)


s/specified/specifies/



docs/persistent-volume.md
Lines 447 (patched)


s/new size/the new size/



docs/persistent-volume.md
Lines 489-497 (patched)


Could you also include these restrictions in the docs for the new operator 
API calls that you're adding?



docs/persistent-volume.md
Lines 496-497 (patched)


Suggestion:
"Volume resize operations cannot be included in an ACCEPT call with other 
operations which make use of the resized volume."



docs/persistent-volume.md
Lines 500 (patched)


To better distinguish this heading and the next, I would recommend:
"Versioned HTTP Operator API"



docs/persistent-volume.md
Lines 508 (patched)


s/volume/volumes/



docs/persistent-volume.md
Lines 511-512 (patched)


I would recommend removing this statement, since it is already mentioned in 
the next section.



docs/persistent-volume.md
Lines 515 (patched)


To better distinguish this heading from the preceding one, I would 
recommend:
"Unversioned Operator HTTP Endpoints"



docs/persistent-volume.md
Lines 520 (patched)


s/encourage to use/encourage operators to use the/



docs/persistent-volume.md
Lines 521 (patched)


s/and new/as new/


- Greg Mann


On May 3, 2018, 12:01 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66923/
> ---
> 
> (Updated May 3, 2018, 12:01 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on volume resize support.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md fdbef770c38ab38ab748b4f943b331d4442a2ce1 
>   docs/operator-http-api.md 9be1e2db60562b369bdc6ee2c732a74fad049580 
>   docs/persistent-volume.md 1a5799b8d8e5302e0b01da6b9a16a3b9fb75c898 
> 
> 
> Diff: https://reviews.apache.org/r/66923/diff/1/
> 
> 
> Testing
> ---
> 
>

Re: Review Request 66923: Added documentation on volume resize support.

2018-05-03 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66923/#review202341
---



Patch looks great!

Reviews applied: [66218, 66049, 66733, 66050, 66219, 66858, 66220, 66531, 
66532, 66052, 66051, 66227, 66923]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 3, 2018, 12:01 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66923/
> ---
> 
> (Updated May 3, 2018, 12:01 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on volume resize support.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md fdbef770c38ab38ab748b4f943b331d4442a2ce1 
>   docs/operator-http-api.md 9be1e2db60562b369bdc6ee2c732a74fad049580 
>   docs/persistent-volume.md 1a5799b8d8e5302e0b01da6b9a16a3b9fb75c898 
> 
> 
> Diff: https://reviews.apache.org/r/66923/diff/1/
> 
> 
> Testing
> ---
> 
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/persistent-volume.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/operator-http-api.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/authorization.md
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66923: Added documentation on volume resize support.

2018-05-02 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66923/#review202340
---



PASS: Mesos patch 66923 was successfully built and tested.

Reviews applied: `['66218', '66049', '66733', '66050', '66219', '66858', 
'66220', '66531', '66532', '66052', '66051', '66227', '66923']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66923

- Mesos Reviewbot Windows


On May 3, 2018, 12:01 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66923/
> ---
> 
> (Updated May 3, 2018, 12:01 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on volume resize support.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md fdbef770c38ab38ab748b4f943b331d4442a2ce1 
>   docs/operator-http-api.md 9be1e2db60562b369bdc6ee2c732a74fad049580 
>   docs/persistent-volume.md 1a5799b8d8e5302e0b01da6b9a16a3b9fb75c898 
> 
> 
> Diff: https://reviews.apache.org/r/66923/diff/1/
> 
> 
> Testing
> ---
> 
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/persistent-volume.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/operator-http-api.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/authorization.md
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66923: Added documentation on volume resize support.

2018-05-02 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66923/#review202331
---



Haven't finished the review yet.

Have you tried using the example JSON through CURL?


docs/persistent-volume.md
Line 57 (original), 57 (patched)


s/`resonse`/`response`/


- Chun-Hung Hsiao


On May 3, 2018, 12:01 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66923/
> ---
> 
> (Updated May 3, 2018, 12:01 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on volume resize support.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md fdbef770c38ab38ab748b4f943b331d4442a2ce1 
>   docs/operator-http-api.md 9be1e2db60562b369bdc6ee2c732a74fad049580 
>   docs/persistent-volume.md 1a5799b8d8e5302e0b01da6b9a16a3b9fb75c898 
> 
> 
> Diff: https://reviews.apache.org/r/66923/diff/1/
> 
> 
> Testing
> ---
> 
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/persistent-volume.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/operator-http-api.md
> https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/authorization.md
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Review Request 66923: Added documentation on volume resize support.

2018-05-02 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66923/
---

Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Repository: mesos


Description
---

Added documentation on volume resize support.


Diffs
-

  docs/authorization.md fdbef770c38ab38ab748b4f943b331d4442a2ce1 
  docs/operator-http-api.md 9be1e2db60562b369bdc6ee2c732a74fad049580 
  docs/persistent-volume.md 1a5799b8d8e5302e0b01da6b9a16a3b9fb75c898 


Diff: https://reviews.apache.org/r/66923/diff/1/


Testing
---

https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/persistent-volume.md
https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/operator-http-api.md
https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/authorization.md


Thanks,

Zhitao Li