Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-23 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66952/#review203685
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On May 4, 2018, 10:15 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66952/
> ---
> 
> (Updated May 4, 2018, 10:15 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8670 and MESOS-8674
> https://issues.apache.org/jira/browse/MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8674
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an field to WindowsFD for functions that need to know if a
> Windows file is opened in overlapped mode, such as `os::read`, since
> Windows doesn't provide a Win32 API for it.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/dup.hpp 
> af98054f1bd9c8e55c52b246fda8734e3ca96e21 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> bab16e869e69c214e18de584d1615311316e001a 
>   3rdparty/stout/include/stout/os/windows/open.hpp 
> 701dcec7c4c1162d38d8f25596af29ed3b32691d 
> 
> 
> Diff: https://reviews.apache.org/r/66952/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-07 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66952/#review202567
---


Fix it, then Ship it!




Just nits on comments.


3rdparty/stout/include/stout/os/windows/fd.hpp
Lines 78 (patched)


`s/socket handles/sockets` just to not confuse with the `HANDLE` type above.



3rdparty/stout/include/stout/os/windows/fd.hpp
Lines 80 (patched)


`s/a/an`



3rdparty/stout/include/stout/os/windows/fd.hpp
Lines 170 (patched)


Nit: clang-format on this for style



3rdparty/stout/include/stout/os/windows/open.hpp
Lines 48 (patched)


`s/open/opens`


- Andrew Schwartzmeyer


On May 4, 2018, 10:15 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66952/
> ---
> 
> (Updated May 4, 2018, 10:15 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8670 and MESOS-8674
> https://issues.apache.org/jira/browse/MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8674
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an field to WindowsFD for functions that need to know if a
> Windows file is opened in overlapped mode, such as `os::read`, since
> Windows doesn't provide a Win32 API for it.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> bab16e869e69c214e18de584d1615311316e001a 
>   3rdparty/stout/include/stout/os/windows/open.hpp 
> 701dcec7c4c1162d38d8f25596af29ed3b32691d 
> 
> 
> Diff: https://reviews.apache.org/r/66952/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-04 Thread Radhika Jandhyala via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66952/#review202506
---


Ship it!




Ship It!

- Radhika Jandhyala


On May 4, 2018, 5:15 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66952/
> ---
> 
> (Updated May 4, 2018, 5:15 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8670 and MESOS-8674
> https://issues.apache.org/jira/browse/MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8674
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an field to WindowsFD for functions that need to know if a
> Windows file is opened in overlapped mode, such as `os::read`, since
> Windows doesn't provide a Win32 API for it.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> bab16e869e69c214e18de584d1615311316e001a 
>   3rdparty/stout/include/stout/os/windows/open.hpp 
> 701dcec7c4c1162d38d8f25596af29ed3b32691d 
> 
> 
> Diff: https://reviews.apache.org/r/66952/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-04 Thread Radhika Jandhyala via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66952/#review202464
---


Ship it!




Ship It!

- Radhika Jandhyala


On May 4, 2018, 5:15 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66952/
> ---
> 
> (Updated May 4, 2018, 5:15 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8670 and MESOS-8674
> https://issues.apache.org/jira/browse/MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8674
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an field to WindowsFD for functions that need to know if a
> Windows file is opened in overlapped mode, such as `os::read`, since
> Windows doesn't provide a Win32 API for it.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> bab16e869e69c214e18de584d1615311316e001a 
>   3rdparty/stout/include/stout/os/windows/open.hpp 
> 701dcec7c4c1162d38d8f25596af29ed3b32691d 
> 
> 
> Diff: https://reviews.apache.org/r/66952/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-04 Thread Eric Mumau via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66952/#review202463
---




3rdparty/stout/include/stout/os/windows/fd.hpp
Lines 183 (patched)


Shouldn't the overlapped_ member be constant?


- Eric Mumau


On May 4, 2018, 5:15 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66952/
> ---
> 
> (Updated May 4, 2018, 5:15 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8670 and MESOS-8674
> https://issues.apache.org/jira/browse/MESOS-8670
> https://issues.apache.org/jira/browse/MESOS-8674
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an field to WindowsFD for functions that need to know if a
> Windows file is opened in overlapped mode, such as `os::read`, since
> Windows doesn't provide a Win32 API for it.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> bab16e869e69c214e18de584d1615311316e001a 
>   3rdparty/stout/include/stout/os/windows/open.hpp 
> 701dcec7c4c1162d38d8f25596af29ed3b32691d 
> 
> 
> Diff: https://reviews.apache.org/r/66952/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Review Request 66952: Windows: Added overlapped field to WindowsFD.

2018-05-04 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66952/
---

Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
John Kordich, Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-8674
https://issues.apache.org/jira/browse/MESOS-8674


Repository: mesos


Description
---

Added an field to WindowsFD for functions that need to know if a
Windows file is opened in overlapped mode, such as `os::read`, since
Windows doesn't provide a Win32 API for it.


Diffs
-

  3rdparty/stout/include/stout/os/windows/fd.hpp 
bab16e869e69c214e18de584d1615311316e001a 
  3rdparty/stout/include/stout/os/windows/open.hpp 
701dcec7c4c1162d38d8f25596af29ed3b32691d 


Diff: https://reviews.apache.org/r/66952/diff/1/


Testing
---


Thanks,

Akash Gupta