Re: Review Request 66960: Windows: Added async version of `os::sendfile`.

2018-05-23 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66960/#review203696
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On May 22, 2018, 3:53 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66960/
> ---
> 
> (Updated May 22, 2018, 3:53 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8681
> https://issues.apache.org/jira/browse/MESOS-8681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Broke the original `os::sendfile` implementation into an asynchronous
> `os::sendfile_async`function and a synchronous `os::sendfile` function.
> The synchronous version simply calls the asynchronous version and waits.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/sendfile.hpp 
> 594d9c7beeff2766f59f16ba25986314f2f7ceb8 
> 
> 
> Diff: https://reviews.apache.org/r/66960/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 66960: Windows: Added async version of `os::sendfile`.

2018-05-22 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66960/
---

(Updated May 22, 2018, 10:53 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
John Kordich, Joseph Wu, and Radhika Jandhyala.


Changes
---

Addressed feedback.


Bugs: MESOS-8681
https://issues.apache.org/jira/browse/MESOS-8681


Repository: mesos


Description
---

Broke the original `os::sendfile` implementation into an asynchronous
`os::sendfile_async`function and a synchronous `os::sendfile` function.
The synchronous version simply calls the asynchronous version and waits.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/sendfile.hpp 
594d9c7beeff2766f59f16ba25986314f2f7ceb8 


Diff: https://reviews.apache.org/r/66960/diff/2/

Changes: https://reviews.apache.org/r/66960/diff/1-2/


Testing
---


Thanks,

Akash Gupta

Re: Review Request 66960: Windows: Added async version of `os::sendfile`.

2018-05-07 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66960/#review202587
---




3rdparty/stout/include/stout/os/windows/sendfile.hpp
Lines 27-31 (patched)


Should this be a public API?



3rdparty/stout/include/stout/os/windows/sendfile.hpp
Lines 36-43 (patched)


nit: `s/res/result` for consistency with other code.



3rdparty/stout/include/stout/os/windows/sendfile.hpp
Lines 37-43 (patched)


I had to pull up the docs to check a few of these arguments; perhaps we 
should document them inline.



3rdparty/stout/include/stout/os/windows/sendfile.hpp
Lines 45 (patched)


You can just replace this with a `WindowsError` and check `error.code`. 
Note that deleting `WindowsSocketError` is a pending TODO because 
`WSAGetLastError` and `GetLastError` are the same function.

You can also just use `WindowsSocketError` so that we're consistent until 
we take care of that TODO, but either way you don't have to manually call 
`GetLastError`.



3rdparty/stout/include/stout/os/windows/sendfile.hpp
Lines 82 (patched)


Shouldn't this return `result.error()`?


- Andrew Schwartzmeyer


On May 4, 2018, 10:18 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66960/
> ---
> 
> (Updated May 4, 2018, 10:18 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8681
> https://issues.apache.org/jira/browse/MESOS-8681
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Broke the original `os::sendfile` implementation into an asynchronous
> `os::sendfile_async`function and a synchronous `os::sendfile` function.
> The synchronous version simply calls the asynchronous version and waits.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/sendfile.hpp 
> 594d9c7beeff2766f59f16ba25986314f2f7ceb8 
> 
> 
> Diff: https://reviews.apache.org/r/66960/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Review Request 66960: Windows: Added async version of `os::sendfile`.

2018-05-04 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66960/
---

Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
John Kordich, Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-8674
https://issues.apache.org/jira/browse/MESOS-8674


Repository: mesos


Description
---

Broke the original `os::sendfile` implementation into an asynchronous
`os::sendfile_async`function and a synchronous `os::sendfile` function.
The synchronous version simply calls the asynchronous version and waits.


Diffs
-

  3rdparty/stout/include/stout/os/windows/sendfile.hpp 
594d9c7beeff2766f59f16ba25986314f2f7ceb8 


Diff: https://reviews.apache.org/r/66960/diff/1/


Testing
---


Thanks,

Akash Gupta