Re: Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type.

2018-06-22 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67384/#review205250
---


Ship it!




Ship It!

- Joseph Wu


On June 21, 2018, 4:34 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67384/
> ---
> 
> (Updated June 21, 2018, 4:34 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8668
> https://issues.apache.org/jira/browse/MESOS-8668
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Many Win32 functions that take in `HANDLE` also work on `SOCKET`, such
> as `ReadFile` or `CreateIoCompletionPort`. IOCP on Windows uses the
> `HANDLE` type uniformly, so we need to be able to convert socket
> `int_fd` to `HANDLE`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> 89a037af31ad68a275d2519afbe4f161b23efe91 
> 
> 
> Diff: https://reviews.apache.org/r/67384/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type.

2018-06-21 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67384/
---

(Updated June 21, 2018, 11:34 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
John Kordich, Joseph Wu, and Radhika Jandhyala.


Changes
---

address feedback.


Bugs: MESOS-8668
https://issues.apache.org/jira/browse/MESOS-8668


Repository: mesos


Description
---

Many Win32 functions that take in `HANDLE` also work on `SOCKET`, such
as `ReadFile` or `CreateIoCompletionPort`. IOCP on Windows uses the
`HANDLE` type uniformly, so we need to be able to convert socket
`int_fd` to `HANDLE`.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/fd.hpp 
89a037af31ad68a275d2519afbe4f161b23efe91 


Diff: https://reviews.apache.org/r/67384/diff/2/

Changes: https://reviews.apache.org/r/67384/diff/1-2/


Testing
---


Thanks,

Akash Gupta

Re: Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type.

2018-06-08 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67384/#review204496
---


Fix it, then Ship it!





3rdparty/stout/include/stout/os/windows/fd.hpp
Line 151 (original), 151 (patched)


This makes me want to mark these conversion ops as explicit even more...



3rdparty/stout/include/stout/os/windows/fd.hpp
Line 153 (original), 153-155 (patched)


We should at least leave a NOTE as to why this is valid and necessary.


- Andrew Schwartzmeyer


On May 30, 2018, 11:39 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67384/
> ---
> 
> (Updated May 30, 2018, 11:39 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8668
> https://issues.apache.org/jira/browse/MESOS-8668
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Many Win32 functions that take in `HANDLE` also work on `SOCKET`, such
> as `ReadFile` or `CreateIoCompletionPort`. IOCP on Windows uses the
> `HANDLE` type uniformly, so we need to be able to convert socket
> `int_fd` to `HANDLE`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> 5dbdff2680370d123579c5e3fdd9b0e0adaf512e 
> 
> 
> Diff: https://reviews.apache.org/r/67384/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type.

2018-05-30 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67384/#review204068
---



PASS: Mesos patch 67384 was successfully built and tested.

Reviews applied: `['67384']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67384

- Mesos Reviewbot Windows


On May 30, 2018, 6:39 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67384/
> ---
> 
> (Updated May 30, 2018, 6:39 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8668
> https://issues.apache.org/jira/browse/MESOS-8668
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Many Win32 functions that take in `HANDLE` also work on `SOCKET`, such
> as `ReadFile` or `CreateIoCompletionPort`. IOCP on Windows uses the
> `HANDLE` type uniformly, so we need to be able to convert socket
> `int_fd` to `HANDLE`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> 5dbdff2680370d123579c5e3fdd9b0e0adaf512e 
> 
> 
> Diff: https://reviews.apache.org/r/67384/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type.

2018-05-30 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67384/
---

Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
John Kordich, Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-8668
https://issues.apache.org/jira/browse/MESOS-8668


Repository: mesos


Description
---

Many Win32 functions that take in `HANDLE` also work on `SOCKET`, such
as `ReadFile` or `CreateIoCompletionPort`. IOCP on Windows uses the
`HANDLE` type uniformly, so we need to be able to convert socket
`int_fd` to `HANDLE`.


Diffs
-

  3rdparty/stout/include/stout/os/windows/fd.hpp 
5dbdff2680370d123579c5e3fdd9b0e0adaf512e 


Diff: https://reviews.apache.org/r/67384/diff/1/


Testing
---


Thanks,

Akash Gupta