Re: Review Request 67522: Moved some constant definitions into header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67522/#review204542 --- Patch looks great! Reviews applied: [67522] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 11, 2018, 5:58 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67522/ > --- > > (Updated June 11, 2018, 5:58 p.m.) > > > Review request for mesos and Jan Schlicht. > > > Repository: mesos > > > Description > --- > > Since we are using C++11 and the declared constants are either POD or > `constexpr` types, we can define them in the header as `constexpr`. > This also removes the need to declare the constants as `extern` which > should using them easier (e.g., simpler linkage requirements). > > > Diffs > - > > 3rdparty/libprocess/Makefile.am d434001fbc49d337b6e29f6ac8c9c7475922a819 > 3rdparty/libprocess/include/process/timeseries.hpp > 64b10a8d551ba33e252aa33987e3d5da8d56a1d6 > 3rdparty/libprocess/src/CMakeLists.txt > cf443dffd0663ecf02b7efd6f7094175b94aae19 > 3rdparty/libprocess/src/timeseries.cpp > 528adef504ea82eb4bec309d8d17e6347c652a29 > > > Diff: https://reviews.apache.org/r/67522/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 67522: Moved some constant definitions into header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67522/#review204534 --- PASS: Mesos patch 67522 was successfully built and tested. Reviews applied: `['67522']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67522 - Mesos Reviewbot Windows On June 11, 2018, 2:58 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67522/ > --- > > (Updated June 11, 2018, 2:58 a.m.) > > > Review request for mesos and Jan Schlicht. > > > Repository: mesos > > > Description > --- > > Since we are using C++11 and the declared constants are either POD or > `constexpr` types, we can define them in the header as `constexpr`. > This also removes the need to declare the constants as `extern` which > should using them easier (e.g., simpler linkage requirements). > > > Diffs > - > > 3rdparty/libprocess/Makefile.am d434001fbc49d337b6e29f6ac8c9c7475922a819 > 3rdparty/libprocess/include/process/timeseries.hpp > 64b10a8d551ba33e252aa33987e3d5da8d56a1d6 > 3rdparty/libprocess/src/CMakeLists.txt > cf443dffd0663ecf02b7efd6f7094175b94aae19 > 3rdparty/libprocess/src/timeseries.cpp > 528adef504ea82eb4bec309d8d17e6347c652a29 > > > Diff: https://reviews.apache.org/r/67522/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 67522: Moved some constant definitions into header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67522/#review204532 --- Ship it! Ship It! - Jan Schlicht On June 11, 2018, 11:58 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67522/ > --- > > (Updated June 11, 2018, 11:58 a.m.) > > > Review request for mesos and Jan Schlicht. > > > Repository: mesos > > > Description > --- > > Since we are using C++11 and the declared constants are either POD or > `constexpr` types, we can define them in the header as `constexpr`. > This also removes the need to declare the constants as `extern` which > should using them easier (e.g., simpler linkage requirements). > > > Diffs > - > > 3rdparty/libprocess/Makefile.am d434001fbc49d337b6e29f6ac8c9c7475922a819 > 3rdparty/libprocess/include/process/timeseries.hpp > 64b10a8d551ba33e252aa33987e3d5da8d56a1d6 > 3rdparty/libprocess/src/CMakeLists.txt > cf443dffd0663ecf02b7efd6f7094175b94aae19 > 3rdparty/libprocess/src/timeseries.cpp > 528adef504ea82eb4bec309d8d17e6347c652a29 > > > Diff: https://reviews.apache.org/r/67522/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Review Request 67522: Moved some constant definitions into header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67522/ --- Review request for mesos and Jan Schlicht. Repository: mesos Description --- Since we are using C++11 and the declared constants are either POD or `constexpr` types, we can define them in the header as `constexpr`. This also removes the need to declare the constants as `extern` which should using them easier (e.g., simpler linkage requirements). Diffs - 3rdparty/libprocess/Makefile.am d434001fbc49d337b6e29f6ac8c9c7475922a819 3rdparty/libprocess/include/process/timeseries.hpp 64b10a8d551ba33e252aa33987e3d5da8d56a1d6 3rdparty/libprocess/src/CMakeLists.txt cf443dffd0663ecf02b7efd6f7094175b94aae19 3rdparty/libprocess/src/timeseries.cpp 528adef504ea82eb4bec309d8d17e6347c652a29 Diff: https://reviews.apache.org/r/67522/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier
