Re: Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.

2019-05-02 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70431/
---

(Updated May 2, 2019, 10:42 p.m.)


Review request for mesos, Benjamin Bannier and Jan Schlicht.


Changes
---

Addressed Benjamin's comments.


Bugs: MESOS-9627
https://issues.apache.org/jira/browse/MESOS-9627


Repository: mesos


Description
---

This patch enables the unit test to test against CSI v1 through the
following changes:

  * The forwarding mode of the test CSI plugin now respects the
`--api_version` option. When specified, only requests of the proper
CSI version will be forwarded.

  * The expectations of `CreateVolume` and `DeleteVolume` calls in the
unit tests are parameterized against the CSI version string.

  * The mock CSI plugin now provides a default implementation for the
`GetCapacity` call so the unit test can be simplified.


Diffs (updated)
-

  src/examples/test_csi_plugin.cpp b54d666a878576f5845027fe6f704e10195079e1 
  src/tests/mock_csi_plugin.cpp cbcb59f720642c2801f5b86c438793e24437b414 
  src/tests/storage_local_resource_provider_tests.cpp 
8bf4d2331b59770a7b7f3768499047bec2d67677 


Diff: https://reviews.apache.org/r/70431/diff/2/

Changes: https://reviews.apache.org/r/70431/diff/1-2/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.

2019-04-16 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70431/#review214688
---


Fix it, then Ship it!





src/examples/test_csi_plugin.cpp
Lines 1855-1857 (patched)


Let's add documenting the expected method names here.



src/tests/storage_local_resource_provider_tests.cpp
Lines 374 (patched)


Let's add some log output here, e.g.,
```
FAIL() << "Unsupported CSI API version " << GetParam();
```



src/tests/storage_local_resource_provider_tests.cpp
Lines 414 (patched)


Ditto.


- Benjamin Bannier


On April 9, 2019, 8:09 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70431/
> ---
> 
> (Updated April 9, 2019, 8:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9627
> https://issues.apache.org/jira/browse/MESOS-9627
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the unit test to test against CSI v1 through the
> following changes:
> 
>   * The forwarding mode of the test CSI plugin now respects the
> `--api_version` option. When specified, only requests of the proper
> CSI version will be forwarded.
> 
>   * The expectations of `CreateVolume` and `DeleteVolume` calls in the
> unit tests are parameterized against the CSI version string.
> 
>   * The mock CSI plugin now provides a default implementation for the
> `GetCapacity` call so the unit test can be simplified.
> 
> 
> Diffs
> -
> 
>   src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 
>   src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb 
>   src/tests/storage_local_resource_provider_tests.cpp 
> da8db41b867d04b4236ad3515811fc00318c619c 
> 
> 
> Diff: https://reviews.apache.org/r/70431/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.

2019-04-09 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70431/#review214515
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70431']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3133/mesos-review-70431

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3133/mesos-review-70431/logs/mesos-tests.log):

```
I0410 04:35:27.857216 45436 master.cpp:1295] Agent 
5d59b4d8-4299-4c27-ad5b-2769958718bb-S0 at slave(501)@192.10.1.4:51022 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0410 04:35:27.858258 45436 master.cpp:] Disconnecting agent 
5d59b4d8-4299-4c27-ad5b-2769958718bb-S0 at slave(501)@192.10.1.4:51022 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0410 04:35:27.858258 45436 master.cpp:3352] Deactivating agent 
5d59b4d8-4299-4c27-ad5b-2769958718bb-S0 at slave(501)@192.10.1.4:51022 
(windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0410 04:35:27.858258 47724 hierarchical.cpp:392] Removed framework 
5d59b4d8-4299-4c27-ad5b-2769958718bb-
I0410 04:35:27.858258 47724 hierarchical.cpp:829] Agent 
5d59b4d8-4299-4c27-ad5b-2769958718bb-S0 deactivated
I0410 04:35:27.859236 47108 containerizer.cpp:2576] Destroying container 
3109879c-d625-4fac-b46b-8a5aba53c9f8 [   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (689 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (707 ms total)

[--] Global test environment tear-down
[==] 1159 tests from 108 test cases ran. (584546 ms total)
[  PASSED  ] 1157 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 2 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

in RUNNING state
I0410 04:35:27.860225 47108 containerizer.cpp:3278] Transitioning the state of 
container 3109879c-d625-4fac-b46b-8a5aba53c9f8 from RUNNING to DESTROYING
I0410 04:35:27.860225 47108 launcher.cpp:161] Asked to destroy container 
3109879c-d625-4fac-b46b-8a5aba53c9f8
W0410 04:35:27.861268 44952 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=5460 to peer '192.10.1.4:53435': IO failed with error 
code: The specified network name is no longer available.

W0410 04:35:27.862259 44952 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=5600 to peer '192.10.1.4:53436': IO failed with error 
code: The specified network name is no longer available.

I0410 04:35:27.883291 34684 containerizer.cpp:3117] Container 
3109879c-d625-4fac-b46b-8a5aba53c9f8 has exited
I0410 04:35:27.912210 39392 master.cpp:1135] Master terminating
I0410 04:35:27.914283 45436 hierarchical.cpp:680] Removed agent 
5d59b4d8-4299-4c27-ad5b-2769958718bb-S0
I0410 04:35:28.501292 44952 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 9, 2019, 6:09 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70431/
> ---
> 
> (Updated April 9, 2019, 6:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9627
> https://issues.apache.org/jira/browse/MESOS-9627
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the unit test to test against CSI v1 through the
> following changes:
> 
>   * The forwarding mode of the test CSI plugin now respects the
> `--api_version` option. When specified, only requests of the proper
> CSI version will be forwarded.
> 
>   * The expectations of `CreateVolume` and `DeleteVolume` calls in the
> unit tests are parameterized against the CSI version string.
> 
>   * The mock CSI plugin now provides a default implementation for the
> `GetCapacity` call so the unit test can be simplified.
> 
> 
> Diffs
> -
> 
>   src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 
>   src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb 
>   src/tests/storage_local_resource_provider_tests.cpp 
> da8db41b867d04b4236ad3515811fc00318c619c 
> 
> 
> Diff: https://reviews.apache.org/r/70431/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.

2019-04-09 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70431/#review214510
---



Patch looks great!

Reviews applied: [70313, 70314, 70315, 70316, 70331, 70245, 70168, 70247, 
70248, 70213, 70214, 70216, 70215, 70217, 70284, 70222, 70285, 70223, 70225, 
70302, 70303, 70321, 70360, 70361, 70362, 70363, 70399, 70400, 70401, 70402, 
70403, 70404, 70427, 70428, 70431]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 8, 2019, 11:09 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70431/
> ---
> 
> (Updated April 8, 2019, 11:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9627
> https://issues.apache.org/jira/browse/MESOS-9627
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the unit test to test against CSI v1 through the
> following changes:
> 
>   * The forwarding mode of the test CSI plugin now respects the
> `--api_version` option. When specified, only requests of the proper
> CSI version will be forwarded.
> 
>   * The expectations of `CreateVolume` and `DeleteVolume` calls in the
> unit tests are parameterized against the CSI version string.
> 
>   * The mock CSI plugin now provides a default implementation for the
> `GetCapacity` call so the unit test can be simplified.
> 
> 
> Diffs
> -
> 
>   src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 
>   src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb 
>   src/tests/storage_local_resource_provider_tests.cpp 
> da8db41b867d04b4236ad3515811fc00318c619c 
> 
> 
> Diff: https://reviews.apache.org/r/70431/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.

2019-04-09 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70431/#review214495
---



Patch looks great!

Reviews applied: [70313, 70314, 70315, 70316, 70331, 70245, 70168, 70247, 
70248, 70213, 70214, 70216, 70215, 70217, 70284, 70222, 70285, 70223, 70225, 
70302, 70303, 70321, 70360, 70361, 70362, 70363, 70399, 70400, 70401, 70402, 
70403, 70404, 70427, 70428, 70431]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 9, 2019, 6:09 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70431/
> ---
> 
> (Updated April 9, 2019, 6:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9627
> https://issues.apache.org/jira/browse/MESOS-9627
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the unit test to test against CSI v1 through the
> following changes:
> 
>   * The forwarding mode of the test CSI plugin now respects the
> `--api_version` option. When specified, only requests of the proper
> CSI version will be forwarded.
> 
>   * The expectations of `CreateVolume` and `DeleteVolume` calls in the
> unit tests are parameterized against the CSI version string.
> 
>   * The mock CSI plugin now provides a default implementation for the
> `GetCapacity` call so the unit test can be simplified.
> 
> 
> Diffs
> -
> 
>   src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 
>   src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb 
>   src/tests/storage_local_resource_provider_tests.cpp 
> da8db41b867d04b4236ad3515811fc00318c619c 
> 
> 
> Diff: https://reviews.apache.org/r/70431/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.

2019-04-09 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70431/
---

Review request for mesos, Benjamin Bannier and Jan Schlicht.


Bugs: MESOS-9627
https://issues.apache.org/jira/browse/MESOS-9627


Repository: mesos


Description
---

This patch enables the unit test to test against CSI v1 through the
following changes:

  * The forwarding mode of the test CSI plugin now respects the
`--api_version` option. When specified, only requests of the proper
CSI version will be forwarded.

  * The expectations of `CreateVolume` and `DeleteVolume` calls in the
unit tests are parameterized against the CSI version string.

  * The mock CSI plugin now provides a default implementation for the
`GetCapacity` call so the unit test can be simplified.


Diffs
-

  src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 
  src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb 
  src/tests/storage_local_resource_provider_tests.cpp 
da8db41b867d04b4236ad3515811fc00318c619c 


Diff: https://reviews.apache.org/r/70431/diff/1/


Testing
---

make check


Thanks,

Chun-Hung Hsiao