Re: Review Request 70450: Special cased HEARTBEAT call handling in agent.

2019-04-10 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70450/
---

(Updated April 10, 2019, 5:28 p.m.)


Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.


Changes
---

Reword a comment.


Bugs: MESOS-9727
https://issues.apache.org/jira/browse/MESOS-9727


Repository: mesos


Description
---

This silences a '400 Bad Request' response by the agent whenever an
executor sends a HEARTBEAT call.  These HEARTBEATs do not include a
valid value for required fields (FrameworkID and ExecutorID) because
they are not known by the library generating the HEARTBEATs.

The error is harmless because HEARTBEAT calls do not have any effect
besides generating traffic.


Diffs (updated)
-

  src/executor/executor.cpp e9439da2afec3746403a1fc8fbc4420a67f8e509 
  src/slave/http.cpp d66ae520f68b783caea8937a1a753608099d5926 


Diff: https://reviews.apache.org/r/70450/diff/3/

Changes: https://reviews.apache.org/r/70450/diff/2-3/


Testing
---

make check


Thanks,

Joseph Wu

Re: Review Request 70450: Special cased HEARTBEAT call handling in agent.

2019-04-10 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70450/#review214561
---


Fix it, then Ship it!





src/slave/http.cpp
Lines 794 (patched)


How about:

// We return early here before doing any validation because currently this 
proto contains
// dummy values for framework and executor ids (which is safe). See TODO 
inside `heartbeat()` in `src/executor/executor.cpp`.


- Vinod Kone


On April 11, 2019, 12:02 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70450/
> ---
> 
> (Updated April 11, 2019, 12:02 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-9727
> https://issues.apache.org/jira/browse/MESOS-9727
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This silences a '400 Bad Request' response by the agent whenever an
> executor sends a HEARTBEAT call.  These HEARTBEATs do not include a
> valid value for required fields (FrameworkID and ExecutorID) because
> they are not known by the library generating the HEARTBEATs.
> 
> The error is harmless because HEARTBEAT calls do not have any effect
> besides generating traffic.
> 
> 
> Diffs
> -
> 
>   src/executor/executor.cpp e9439da2afec3746403a1fc8fbc4420a67f8e509 
>   src/slave/http.cpp d66ae520f68b783caea8937a1a753608099d5926 
> 
> 
> Diff: https://reviews.apache.org/r/70450/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 70450: Special cased HEARTBEAT call handling in agent.

2019-04-10 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70450/
---

(Updated April 10, 2019, 5:02 p.m.)


Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.


Changes
---

Added a TODO message.


Repository: mesos


Description
---

This silences a '400 Bad Request' response by the agent whenever an
executor sends a HEARTBEAT call.  These HEARTBEATs do not include a
valid value for required fields (FrameworkID and ExecutorID) because
they are not known by the library generating the HEARTBEATs.

The error is harmless because HEARTBEAT calls do not have any effect
besides generating traffic.


Diffs (updated)
-

  src/executor/executor.cpp e9439da2afec3746403a1fc8fbc4420a67f8e509 
  src/slave/http.cpp d66ae520f68b783caea8937a1a753608099d5926 


Diff: https://reviews.apache.org/r/70450/diff/2/

Changes: https://reviews.apache.org/r/70450/diff/1-2/


Testing
---

make check


Thanks,

Joseph Wu

Re: Review Request 70450: Special cased HEARTBEAT call handling in agent.

2019-04-10 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70450/#review214558
---




src/slave/http.cpp
Lines 793 (patched)


Can you add a TODO to actually send the correct framework and executor id 
in HEARTBEAT calls. It seems weird/wrong that we send dummy values.


- Vinod Kone


On April 10, 2019, 11:55 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70450/
> ---
> 
> (Updated April 10, 2019, 11:55 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This silences a '400 Bad Request' response by the agent whenever an
> executor sends a HEARTBEAT call.  These HEARTBEATs do not include a
> valid value for required fields (FrameworkID and ExecutorID) because
> they are not known by the library generating the HEARTBEATs.
> 
> The error is harmless because HEARTBEAT calls do not have any effect
> besides generating traffic.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp d66ae520f68b783caea8937a1a753608099d5926 
> 
> 
> Diff: https://reviews.apache.org/r/70450/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 70450: Special cased HEARTBEAT call handling in agent.

2019-04-10 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70450/
---

Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.


Repository: mesos


Description
---

This silences a '400 Bad Request' response by the agent whenever an
executor sends a HEARTBEAT call.  These HEARTBEATs do not include a
valid value for required fields (FrameworkID and ExecutorID) because
they are not known by the library generating the HEARTBEATs.

The error is harmless because HEARTBEAT calls do not have any effect
besides generating traffic.


Diffs
-

  src/slave/http.cpp d66ae520f68b783caea8937a1a753608099d5926 


Diff: https://reviews.apache.org/r/70450/diff/1/


Testing
---

make check


Thanks,

Joseph Wu