Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-05 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220643
---



Patch looks great!

Reviews applied: [72368, 72364]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On May 5, 2020, 2:05 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72364/
> ---
> 
> (Updated May 5, 2020, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10116
> https://issues.apache.org/jira/browse/MESOS-10116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reactivation of a disconnected drained agent.
> 
> 
> Diffs
> -
> 
>   src/tests/master_draining_tests.cpp 
> f6b974f5f88f8563bd9cf6cca087b60cb5784e77 
> 
> 
> Diff: https://reviews.apache.org/r/72364/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-05 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220640
---


Ship it!




Ship It!

- Greg Mann


On May 5, 2020, 2:05 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72364/
> ---
> 
> (Updated May 5, 2020, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10116
> https://issues.apache.org/jira/browse/MESOS-10116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reactivation of a disconnected drained agent.
> 
> 
> Diffs
> -
> 
>   src/tests/master_draining_tests.cpp 
> f6b974f5f88f8563bd9cf6cca087b60cb5784e77 
> 
> 
> Diff: https://reviews.apache.org/r/72364/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-05 Thread Andrei Sekretenko 


> On May 5, 2020, 5:41 a.m., Greg Mann wrote:
> > src/tests/master_draining_tests.cpp
> > Lines 368-370 (patched)
> > 
> >
> > I don't usually need to resume the clock to get a task running update 
> > to go through, do you know exactly what's going on here?
> 
> Andrei Sekretenko wrote:
> Weird... after r72364 this test works without resuming the clock.
> 
> That's actually a good question why the task status update manager in 
> this test was not being resumed before your fix for MESOS-10118. I'm 
> investigating that.

For some reason, now I cannot reproduce the update manager being stuck in 
paused state. Neither in the current configuration nor in the previous one.

Removed this `Clock::resume()`.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220617
---


On May 5, 2020, 2:05 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72364/
> ---
> 
> (Updated May 5, 2020, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10116
> https://issues.apache.org/jira/browse/MESOS-10116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reactivation of a disconnected drained agent.
> 
> 
> Diffs
> -
> 
>   src/tests/master_draining_tests.cpp 
> f6b974f5f88f8563bd9cf6cca087b60cb5784e77 
> 
> 
> Diff: https://reviews.apache.org/r/72364/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-05 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220637
---



Patch looks great!

Reviews applied: [72368, 72364]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On May 5, 2020, 2:05 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72364/
> ---
> 
> (Updated May 5, 2020, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10116
> https://issues.apache.org/jira/browse/MESOS-10116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reactivation of a disconnected drained agent.
> 
> 
> Diffs
> -
> 
>   src/tests/master_draining_tests.cpp 
> f6b974f5f88f8563bd9cf6cca087b60cb5784e77 
> 
> 
> Diff: https://reviews.apache.org/r/72364/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-05 Thread Andrei Sekretenko 


> On May 5, 2020, 5:41 a.m., Greg Mann wrote:
> > src/tests/master_draining_tests.cpp
> > Lines 239 (patched)
> > 
> >
> > Nit: s/lead to crash/lead to a crash/

Rewrote the comment to reflect the fact that this also tests for regression in 
MESOS-10118.


> On May 5, 2020, 5:41 a.m., Greg Mann wrote:
> > src/tests/master_draining_tests.cpp
> > Lines 319-324 (patched)
> > 
> >
> > Nit: it's a little weird to have one update use 
> > `TaskStatusUpdateStateEq` but not the other? And both of these expectations 
> > use `WillRepeatedly`, but I think we could do `WillOnce`.

Changed the first one to use a negated expectation, and removed 
`WillRepeatedly` from the second one.


> On May 5, 2020, 5:41 a.m., Greg Mann wrote:
> > src/tests/master_draining_tests.cpp
> > Lines 368-370 (patched)
> > 
> >
> > I don't usually need to resume the clock to get a task running update 
> > to go through, do you know exactly what's going on here?

Weird... after r72364 this test works without resuming the clock.

That's actually a good question why the task status update manager in this test 
was not being resumed before your fix for MESOS-10118. I'm investigating that.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220617
---


On May 5, 2020, 2:05 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72364/
> ---
> 
> (Updated May 5, 2020, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10116
> https://issues.apache.org/jira/browse/MESOS-10116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reactivation of a disconnected drained agent.
> 
> 
> Diffs
> -
> 
>   src/tests/master_draining_tests.cpp 
> f6b974f5f88f8563bd9cf6cca087b60cb5784e77 
> 
> 
> Diff: https://reviews.apache.org/r/72364/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-05 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/
---

(Updated May 5, 2020, 2:05 p.m.)


Review request for mesos, Benjamin Mahler and Greg Mann.


Bugs: MESOS-10116
https://issues.apache.org/jira/browse/MESOS-10116


Repository: mesos


Description
---

Added test for reactivation of a disconnected drained agent.


Diffs (updated)
-

  src/tests/master_draining_tests.cpp f6b974f5f88f8563bd9cf6cca087b60cb5784e77 


Diff: https://reviews.apache.org/r/72364/diff/3/

Changes: https://reviews.apache.org/r/72364/diff/2-3/


Testing
---


Thanks,

Andrei Sekretenko

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-05 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220627
---



Patch looks great!

Reviews applied: [72368, 72364]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On May 5, 2020, 12:12 a.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72364/
> ---
> 
> (Updated May 5, 2020, 12:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10116
> https://issues.apache.org/jira/browse/MESOS-10116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reactivation of a disconnected drained agent.
> 
> 
> Diffs
> -
> 
>   src/tests/master_draining_tests.cpp 
> f6b974f5f88f8563bd9cf6cca087b60cb5784e77 
> 
> 
> Diff: https://reviews.apache.org/r/72364/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-04 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220617
---




src/tests/master_draining_tests.cpp
Lines 239 (patched)


Nit: s/lead to crash/lead to a crash/



src/tests/master_draining_tests.cpp
Lines 256-257 (patched)


Nit: fits on one line.



src/tests/master_draining_tests.cpp
Lines 319-324 (patched)


Nit: it's a little weird to have one update use `TaskStatusUpdateStateEq` 
but not the other? And both of these expectations use `WillRepeatedly`, but I 
think we could do `WillOnce`.



src/tests/master_draining_tests.cpp
Lines 368-370 (patched)


I don't usually need to resume the clock to get a task running update to go 
through, do you know exactly what's going on here?


- Greg Mann


On May 4, 2020, 4:12 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72364/
> ---
> 
> (Updated May 4, 2020, 4:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10116
> https://issues.apache.org/jira/browse/MESOS-10116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reactivation of a disconnected drained agent.
> 
> 
> Diffs
> -
> 
>   src/tests/master_draining_tests.cpp 
> f6b974f5f88f8563bd9cf6cca087b60cb5784e77 
> 
> 
> Diff: https://reviews.apache.org/r/72364/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-04 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220606
---



Bad patch!

Reviews applied: [72368, 72364]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72364"]

Error:
..
)/api/v1/resource_provider
I0504 18:19:49.941777  2187 process.cpp:3671] Handling HTTP event for process 
'slave(1247)' with path: '/slave(1247)/api/v1/resource_provider'
I0504 18:19:49.946017  2205 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.983256ms
I0504 18:19:49.947141  2185 master.cpp:9476] Sending offers [ 
3dfbc6f2-f928-4a58-a2e1-f9498886edc7-O3 ] to framework 
3dfbc6f2-f928-4a58-a2e1-f9498886edc7- (default) at 
scheduler-4fee5e34-bd9c-4bd7-bf46-0243ceadefa3@172.17.0.2:40073
I0504 18:19:49.948379  2193 sched.cpp:934] Scheduler::resourceOffers took 
108336ns
I0504 18:19:49.952947  2195 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I0504 18:19:49.955690  2186 http.cpp:1436] HTTP POST for /master/api/v1 from 
172.17.0.2:38790
I0504 18:19:49.955963  2186 http.cpp:277] Processing call CREATE_VOLUMES
I0504 18:19:49.957028  2186 master.cpp:3693] Authorizing principal 
'test-principal' to perform action CREATE_VOLUME on object 
{"value":"storage/default-role","resource":{"provider_id":{"value":"ceffd29f-ed62-4c30-b402-b293d9770f3b"},"name":"disk","type":"SCALAR","scalar":{"value":2048.0},"reservations":[{"type":"DYNAMIC","role":"storage"},{"type":"DYNAMIC","role":"storage/default-role","principal":"test-principal"}],"disk":{"persistence":{"id":"2607cfb8-8469-45ac-bb1a-49af4964a42f","principal":"test-principal"},"volume":{"mode":"RW","container_path":"volume"},"source":{"type":"MOUNT","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"vendor":"org.apache.mesos.csi.test.local","id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_qmHcEB/2GB-b39c4443-f320-4d72-8119-88bea7603581","profile":"test"
I0504 18:19:49.958791  2192 sched.cpp:960] Rescinded offer 
3dfbc6f2-f928-4a58-a2e1-f9498886edc7-O3
I0504 18:19:49.958904  2192 sched.cpp:971] Scheduler::offerRescinded took 
34095ns
I0504 18:19:49.959444  2190 hierarchical.cpp:1576] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_qmHcEB/2GB-b39c4443-f320-4d72-8119-88bea7603581,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_qmHcEB/2GB-b39c4443-f320-4d72-8119-88bea7603581,test)]:2048,
 offered or allocated: {}) on agent 3dfbc6f2-f928-4a58-a2e1-f9498886edc7-S0 
from framework 3dfbc
 6f2-f928-4a58-a2e1-f9498886edc7-
I0504 18:19:49.959580  2204 master.cpp:11775] Removing offer 
3dfbc6f2-f928-4a58-a2e1-f9498886edc7-O3
I0504 18:19:49.961390  2190 hierarchical.cpp:1625] Framework 
3dfbc6f2-f928-4a58-a2e1-f9498886edc7- filtered agent 
3dfbc6f2-f928-4a58-a2e1-f9498886edc7-S0 for 5secs
I0504 18:19:49.964745  2194 master.cpp:11640] Sending operation '' (uuid: 
0a4c08a8-4077-42fe-bb3d-0db501bcd93a) to agent 
3dfbc6f2-f928-4a58-a2e1-f9498886edc7-S0 at slave(1247)@172.17.0.2:40073 
(e72e52c70698)
I0504 18:19:49.965557  2197 slave.cpp:4557] Ignoring new checkpointed resources 
and operations identical to the current version
I0504 18:19:49.969734  2184 provider.cpp:498] Received APPLY_OPERATION event
I0504 18:19:49.969800  2184 provider.cpp:1351] Received CREATE operation '' 
(uuid: 0a4c08a8-4077-42fe-bb3d-0db501bcd93a)
I0504 18:19:49.970155  2186 master.cpp:5521] Processing REVIVE call for 
framework 3dfbc6f2-f928-4a58-a2e1-f9498886edc7- (default) at 
scheduler-4fee5e34-bd9c-4bd7-bf46-0243ceadefa3@172.17.0.2:40073
I0504 18:19:49.970742  2202 hierarchical.cpp:1721] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
3dfbc6f2-f928-4a58-a2e1-f9498886edc7-
I0504 18:19:49.972522  2202 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.490624ms
I0504 18:19:49.972906  2202 hierarchical.cpp:1853] Performed allocation for 1 
agents in 171581ns
I0504 18:19:49.973218  2189

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-04 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/
---

(Updated May 4, 2020, 4:12 p.m.)


Review request for mesos, Benjamin Mahler and Greg Mann.


Changes
---

Adjusted for MESOS-10118 fix in https://reviews.apache.org/r/72368/


Bugs: MESOS-10116
https://issues.apache.org/jira/browse/MESOS-10116


Repository: mesos


Description
---

Added test for reactivation of a disconnected drained agent.


Diffs (updated)
-

  src/tests/master_draining_tests.cpp f6b974f5f88f8563bd9cf6cca087b60cb5784e77 


Diff: https://reviews.apache.org/r/72364/diff/2/

Changes: https://reviews.apache.org/r/72364/diff/1-2/


Testing
---


Thanks,

Andrei Sekretenko

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-04 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220592
---



Bad patch!

Reviews applied: [72368, 72363, 72364]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72364"]

Error:
ubuntu-16.04: Pulling from mesos/mesos-build
18d680d61657: Pulling fs layer
0addb6fece63: Pulling fs layer
78e58219b215: Pulling fs layer
eb6959a66df2: Pulling fs layer
1105027a5560: Pulling fs layer
c36946130a38: Pulling fs layer
6a6a5e68faab: Pulling fs layer
80e07249924c: Pulling fs layer
c4c63e2501db: Pulling fs layer
668b207c2829: Pulling fs layer
ed76dddad568: Pulling fs layer
6a6a5e68faab: Waiting
eb6959a66df2: Waiting
ed76dddad568: Waiting
1105027a5560: Waiting
80e07249924c: Waiting
668b207c2829: Waiting
c36946130a38: Waiting
c4c63e2501db: Waiting
78e58219b215: Verifying Checksum
78e58219b215: Download complete
0addb6fece63: Download complete
eb6959a66df2: Download complete
18d680d61657: Verifying Checksum
18d680d61657: Download complete
6a6a5e68faab: Verifying Checksum
6a6a5e68faab: Download complete
c36946130a38: Verifying Checksum
c36946130a38: Download complete
668b207c2829: Verifying Checksum
668b207c2829: Download complete
c4c63e2501db: Verifying Checksum
c4c63e2501db: Download complete
ed76dddad568: Verifying Checksum
ed76dddad568: Download complete
18d680d61657: Pull complete
0addb6fece63: Pull complete
78e58219b215: Pull complete
eb6959a66df2: Pull complete
1105027a5560: Verifying Checksum
1105027a5560: Download complete
1105027a5560: Pull complete
c36946130a38: Pull complete
6a6a5e68faab: Pull complete
80e07249924c: Pull complete
c4c63e2501db: Pull complete
668b207c2829: Pull complete
ed76dddad568: Pull complete
Digest: sha256:fa967cbcfb44f55708a3cbc87f245c6d29dd891464db558af56a03ee321526bb
Status: Downloaded newer image for mesos/mesos-build:ubuntu-16.04
docker.io/mesos/mesos-build:ubuntu-16.04
Cloning into '/tmp/SRC'...
Note: checking out 'd2822e7c96a95594b56aa326b6b776069a91310c'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b 

autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --warnings=all -I m4
autoreconf: configure.ac: tracing
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross 
compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: running: libtoolize --copy
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: running: /usr/bin/autoconf --warnings=all
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross 
compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: configure.ac: not using Autoheader
autoreconf: running: automake --add-missing --copy --no-force --warnings=all
configure.ac:50: installing './ar-lib'
configure.ac:34: installing './compile'
configure.ac:24: installing './config.guess'
configure.ac:24: installing './config.sub'
configure.ac:46: installing './install-sh'
configure.ac:46: installing './missing'
3rdparty/Makefile.am:307: warning: source file '$(HTTP_PARSER)/http_parser.c' 
is in a subdirectory,
3rdparty/Makefile.am:307: but option 'subdir-objects' is disabled
automake:

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-05-04 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/
---

(Updated May 4, 2020, 12:28 p.m.)


Review request for mesos, Benjamin Mahler and Greg Mann.


Bugs: MESOS-10116
https://issues.apache.org/jira/browse/MESOS-10116


Repository: mesos


Description
---

Added test for reactivation of a disconnected drained agent.


Diffs
-

  src/tests/master_draining_tests.cpp f6b974f5f88f8563bd9cf6cca087b60cb5784e77 


Diff: https://reviews.apache.org/r/72364/diff/1/


Testing
---


Thanks,

Andrei Sekretenko

Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-04-14 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220315
---



Patch looks great!

Reviews applied: [72363, 72364]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On April 14, 2020, 6:24 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72364/
> ---
> 
> (Updated April 14, 2020, 6:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10116
> https://issues.apache.org/jira/browse/MESOS-10116
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reactivation of a disconnected drained agent.
> 
> 
> Diffs
> -
> 
>   src/tests/master_draining_tests.cpp 
> f6b974f5f88f8563bd9cf6cca087b60cb5784e77 
> 
> 
> Diff: https://reviews.apache.org/r/72364/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Review Request 72364: Added test for reactivation of a disconnected drained agent.

2020-04-14 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/
---

Review request for mesos, Benjamin Mahler and Greg Mann.


Bugs: MESOS-10116
https://issues.apache.org/jira/browse/MESOS-10116


Repository: mesos


Description
---

Added test for reactivation of a disconnected drained agent.


Diffs
-

  src/tests/master_draining_tests.cpp f6b974f5f88f8563bd9cf6cca087b60cb5784e77 


Diff: https://reviews.apache.org/r/72364/diff/1/


Testing
---


Thanks,

Andrei Sekretenko