Re: Review Request 72600: Remove credential text format support.

2020-07-27 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/#review221384
---


Ship it!




Ship It!

- Benjamin Mahler


On July 24, 2020, 9:46 a.m., Dong Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72600/
> ---
> 
> (Updated July 24, 2020, 9:46 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since text format for credential is no longer supported, remove it.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 11c5c9983b9c77b5ca4d3ff11232b4d4a66e3615 
>   src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 
> 
> 
> Diff: https://reviews.apache.org/r/72600/diff/4/
> 
> 
> Testing
> ---
> 
> Manually tested
> make check
> 
> 
> Thanks,
> 
> Dong Zhu
> 
>

Re: Review Request 72600: Remove credential text format support.

2020-07-24 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/#review221359
---



Patch looks great!

Reviews applied: [72620, 72600]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On July 24, 2020, 9:46 a.m., Dong Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72600/
> ---
> 
> (Updated July 24, 2020, 9:46 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since text format for credential is no longer supported, remove it.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 11c5c9983b9c77b5ca4d3ff11232b4d4a66e3615 
>   src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 
> 
> 
> Diff: https://reviews.apache.org/r/72600/diff/4/
> 
> 
> Testing
> ---
> 
> Manually tested
> make check
> 
> 
> Thanks,
> 
> Dong Zhu
> 
>

Re: Review Request 72600: Remove credential text format support.

2020-07-24 Thread Dong Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/
---

(Updated July 24, 2020, 9:46 a.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Since text format for credential is no longer supported, remove it.


Diffs (updated)
-

  CHANGELOG 11c5c9983b9c77b5ca4d3ff11232b4d4a66e3615 
  src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 


Diff: https://reviews.apache.org/r/72600/diff/4/

Changes: https://reviews.apache.org/r/72600/diff/3-4/


Testing
---

Manually tested
make check


Thanks,

Dong Zhu

Re: Review Request 72600: Remove credential text format support.

2020-07-23 Thread Benjamin Mahler 


> On June 19, 2020, 6:28 p.m., Benjamin Mahler wrote:
> > src/credentials/credentials.hpp
> > Line 67 (original), 65 (patched)
> > 
> >
> > Can you re-work the logic here so that errors are handled first and the 
> > error messages from the Trys are included?
> 
> Dong Zhu wrote:
> Hi Ben,
> 
> Sure. I have updated the patch per your suggestion.

Oh, the errors are still not handled first.. what I mean is:

```
  Try json = JSON::parse(read.get());
  if (!json.isError()) {
Try credentials = ::protobuf::parse(json.get());
if (!credentials.isError()) {
  return credentials.get();
} else {
  return Error("Failed to parse credentials: "
   + credentials.error());
}
  } else {
return Error("Invalid json format: " + json.error());
  }
```

Becomes:

```
  Try json = JSON::parse(read.get());
  
  if (json.isError()) {
return Error("Invalid json format: " + json.error());
  }
  
  Try credentials = ::protobuf::parse(*json);
  
  if (credentials.isError()) {
return Error("Failed to parse credentials: "
 + credentials.error());
  }

  return *credentials;
```

Ends up with less logical nesting and jumping needed, and so it's the way we 
generally try to format the code in mesos.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/#review221037
---


On July 8, 2020, 12:47 a.m., Dong Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72600/
> ---
> 
> (Updated July 8, 2020, 12:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since text format for credential is no longer supported, remove it.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 11c5c9983b9c77b5ca4d3ff11232b4d4a66e3615 
>   src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 
> 
> 
> Diff: https://reviews.apache.org/r/72600/diff/3/
> 
> 
> Testing
> ---
> 
> Manually tested
> make check
> 
> 
> Thanks,
> 
> Dong Zhu
> 
>

Re: Review Request 72600: Remove credential text format support.

2020-06-25 Thread Dong Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/
---

(Updated June 26, 2020, 5:47 a.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Since text format for credential is no longer supported, remove it.


Diffs (updated)
-

  CHANGELOG 11c5c9983b9c77b5ca4d3ff11232b4d4a66e3615 
  src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 


Diff: https://reviews.apache.org/r/72600/diff/3/

Changes: https://reviews.apache.org/r/72600/diff/2-3/


Testing
---

Manually tested
make check


Thanks,

Dong Zhu

Re: Review Request 72600: Remove credential text format support.

2020-06-25 Thread Benjamin Mahler 


> On June 19, 2020, 6:28 p.m., Benjamin Mahler wrote:
> > Can you mark down this breaking change in the changelog?
> > 
> > I think we'll need to send an email to users about this change, since it 
> > may break some users.
> 
> Dong Zhu wrote:
> You mean this file https://github.com/apache/mesos/blob/master/CHANGELOG 
> ? And which section should it be added to ?

Yes, you'll need to start the 1.11.0 section, how about adding it under 
'Additional API Changes' and mark it as a "breaking change" (look for past 
examples).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/#review221037
---


On June 24, 2020, 9:39 a.m., Dong Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72600/
> ---
> 
> (Updated June 24, 2020, 9:39 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since text format for credential is no longer supported, remove it.
> 
> 
> Diffs
> -
> 
>   src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 
> 
> 
> Diff: https://reviews.apache.org/r/72600/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested
> make check
> 
> 
> Thanks,
> 
> Dong Zhu
> 
>

Re: Review Request 72600: Remove credential text format support.

2020-06-23 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/#review221052
---



Bad patch!

Reviews applied: [72600]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72600"]

Error:
..
 Rescinded offer 3c2204ab-6d15-445d-a0e7-720d0a32f589-O3
I0623 07:52:16.820606  3444 sched.cpp:971] Scheduler::offerRescinded took 
37208ns
I0623 07:52:16.821358  3429 hierarchical.cpp:1643] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_mosYsJ/2GB-0084d8bf-3b5a-4eea-9234-fe11dce7fd8f,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_mosYsJ/2GB-0084d8bf-3b5a-4eea-9234-fe11dce7fd8f,test)]:2048,
 offered or allocated: {}) on agent 3c2204ab-6d15-445d-a0e7-720d0a32f589-S0 
from framework 3c220
 4ab-6d15-445d-a0e7-720d0a32f589-
I0623 07:52:16.821663  3431 master.cpp:11775] Removing offer 
3c2204ab-6d15-445d-a0e7-720d0a32f589-O3
I0623 07:52:16.824956  3429 hierarchical.cpp:1692] Framework 
3c2204ab-6d15-445d-a0e7-720d0a32f589- filtered agent 
3c2204ab-6d15-445d-a0e7-720d0a32f589-S0 for 5secs
I0623 07:52:16.829517  3433 master.cpp:11640] Sending operation '' (uuid: 
cba1409b-b965-4962-a738-795488dfbf33) to agent 
3c2204ab-6d15-445d-a0e7-720d0a32f589-S0 at slave(1246)@172.17.0.2:43897 
(339f494d23da)
I0623 07:52:16.830696  3448 slave.cpp:4557] Ignoring new checkpointed resources 
and operations identical to the current version
I0623 07:52:16.836056  3427 provider.cpp:498] Received APPLY_OPERATION event
I0623 07:52:16.836138  3427 provider.cpp:1351] Received CREATE operation '' 
(uuid: cba1409b-b965-4962-a738-795488dfbf33)
I0623 07:52:16.839687  3449 master.cpp:5521] Processing REVIVE call for 
framework 3c2204ab-6d15-445d-a0e7-720d0a32f589- (default) at 
scheduler-77d14167-d2ac-4074-84e2-4185b5570ab0@172.17.0.2:43897
I0623 07:52:16.840831  3433 http.cpp:1436] HTTP POST for 
/slave(1246)/api/v1/resource_provider from 172.17.0.2:40650
I0623 07:52:16.840850  3440 hierarchical.cpp:1788] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
3c2204ab-6d15-445d-a0e7-720d0a32f589-
I0623 07:52:16.842257  3430 slave.cpp:8714] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: e0adf2e6-34fc-4e50-99e9-b4136a2ce1f8) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I0623 07:52:16.842622  3430 slave.cpp:9167] Updating the state of operation 
with no ID (uuid: e0adf2e6-34fc-4e50-99e9-b4136a2ce1f8) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I0623 07:52:16.842736  3430 slave.cpp:8921] Forwarding status update of 
operation with no ID (operation_uuid: e0adf2e6-34fc-4e50-99e9-b4136a2ce1f8) for 
an operator API call
I0623 07:52:16.843538  3445 master.cpp:11292] Updating the state of operation 
'' (uuid: e0adf2e6-34fc-4e50-99e9-b4136a2ce1f8) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I0623 07:52:16.844627  3438 slave.cpp:4557] Ignoring new checkpointed resources 
and operations identical to the current version
I0623 07:52:16.845515  3440 hierarchical.cpp:1920] Performed allocation for 1 
agents in 4.00204ms
I0623 07:52:16.846909  3441 master.cpp:9476] Sending offers [ 
3c2204ab-6d15-445d-a0e7-720d0a32f589-O4 ] to framework 
3c2204ab-6d15-445d-a0e7-720d0a32f589- (default) at 
scheduler-77d14167-d2ac-4074-84e2-4185b5570ab0@172.17.0.2:43897
I0623 07:52:16.848012  3449 sched.cpp:934] Scheduler::resourceOffers took 
115146ns
I0623 07:52:16.955051  3431 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
21b75336-dae2-41a9-bec9-cd5ddca58847) for operation UUID 
cba1409b-b965-4962-a738-795488dfbf33 on agent 
3c2204ab-6d15-445d-a0e7-720d0a32f589-S0
I0623 07:52:16.955256  3431 status_update_manager_process.hpp:414] Creating 
operation status update stream cba1409b-b965-4962-a738-795488dfbf33 
checkpoint=true
I0623 07:52:16.955415  3427

Re: Review Request 72600: Remove credential text format support.

2020-06-22 Thread Dong Zhu 


> On June 19, 2020, 6:28 p.m., Benjamin Mahler wrote:
> > Can you mark down this breaking change in the changelog?
> > 
> > I think we'll need to send an email to users about this change, since it 
> > may break some users.

You mean this file https://github.com/apache/mesos/blob/master/CHANGELOG ? And 
which section should it be added to ?


> On June 19, 2020, 6:28 p.m., Benjamin Mahler wrote:
> > src/credentials/credentials.hpp
> > Line 67 (original), 65 (patched)
> > 
> >
> > Can you re-work the logic here so that errors are handled first and the 
> > error messages from the Trys are included?

Hi Ben,

Sure. I have updated the patch per your suggestion.


- Dong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/#review221037
---


On June 23, 2020, 3:40 a.m., Dong Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72600/
> ---
> 
> (Updated June 23, 2020, 3:40 a.m.)
> 
> 
> Review request for mesos, Adam Berry, Benjamin Bannier, and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since text format for credential is no longer supported, remove it.
> 
> 
> Diffs
> -
> 
>   src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 
> 
> 
> Diff: https://reviews.apache.org/r/72600/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested
> make check
> 
> 
> Thanks,
> 
> Dong Zhu
> 
>

Re: Review Request 72600: Remove credential text format support.

2020-06-22 Thread Dong Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/
---

(Updated June 23, 2020, 3:40 a.m.)


Review request for mesos, Adam Berry, Benjamin Bannier, and Benjamin Mahler.


Repository: mesos


Description
---

Since text format for credential is no longer supported, remove it.


Diffs (updated)
-

  src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 


Diff: https://reviews.apache.org/r/72600/diff/2/

Changes: https://reviews.apache.org/r/72600/diff/1-2/


Testing
---

Manually tested
make check


Thanks,

Dong Zhu

Re: Review Request 72600: Remove credential text format support.

2020-06-19 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/#review221037
---



Can you mark down this breaking change in the changelog?

I think we'll need to send an email to users about this change, since it may 
break some users.


src/credentials/credentials.hpp
Line 67 (original), 65 (patched)


Can you re-work the logic here so that errors are handled first and the 
error messages from the Trys are included?


- Benjamin Mahler


On June 19, 2020, 10:29 a.m., Dong Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72600/
> ---
> 
> (Updated June 19, 2020, 10:29 a.m.)
> 
> 
> Review request for mesos, Adam Berry, Benjamin Bannier, and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since text format for credential is no longer supported, remove it.
> 
> 
> Diffs
> -
> 
>   src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 
> 
> 
> Diff: https://reviews.apache.org/r/72600/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> make check
> 
> 
> Thanks,
> 
> Dong Zhu
> 
>

Re: Review Request 72600: Remove credential text format support.

2020-06-16 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/#review221020
---



Bad patch!

Reviews applied: [72600]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | 
tee build_72600"]

Error:
..
P event for process 'master' with path: '/master/api/v1'
I0617 05:23:14.535313  3186 http.cpp:1436] HTTP POST for /master/api/v1 from 
172.17.0.2:58422
I0617 05:23:14.535584  3186 http.cpp:277] Processing call CREATE_VOLUMES
I0617 05:23:14.536617  3186 master.cpp:3693] Authorizing principal 
'test-principal' to perform action CREATE_VOLUME on object 
{"value":"storage/default-role","resource":{"provider_id":{"value":"470999d8-684d-439c-a8c4-98b91b4593de"},"name":"disk","type":"SCALAR","scalar":{"value":2048.0},"reservations":[{"type":"DYNAMIC","role":"storage"},{"type":"DYNAMIC","role":"storage/default-role","principal":"test-principal"}],"disk":{"persistence":{"id":"fbf79205-ddac-44e3-9a6c-82d643fef5de","principal":"test-principal"},"volume":{"mode":"RW","container_path":"volume"},"source":{"type":"MOUNT","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"vendor":"org.apache.mesos.csi.test.local","id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_ePh6B8/2GB-4db83463-6b02-4818-9ecf-bd95bd56c590","profile":"test"
I0617 05:23:14.538064  3173 sched.cpp:960] Rescinded offer 
08cbfa6b-2d6a-4ade-ad1f-bca2f98156d3-O3
I0617 05:23:14.538153  3173 sched.cpp:971] Scheduler::offerRescinded took 
26392ns
I0617 05:23:14.538625  3185 hierarchical.cpp:1643] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_ePh6B8/2GB-4db83463-6b02-4818-9ecf-bd95bd56c590,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_ePh6B8/2GB-4db83463-6b02-4818-9ecf-bd95bd56c590,test)]:2048,
 offered or allocated: {}) on agent 08cbfa6b-2d6a-4ade-ad1f-bca2f98156d3-S0 
from framework 08cbf
 a6b-2d6a-4ade-ad1f-bca2f98156d3-
I0617 05:23:14.538818  3184 master.cpp:11775] Removing offer 
08cbfa6b-2d6a-4ade-ad1f-bca2f98156d3-O3
I0617 05:23:14.540771  3185 hierarchical.cpp:1692] Framework 
08cbfa6b-2d6a-4ade-ad1f-bca2f98156d3- filtered agent 
08cbfa6b-2d6a-4ade-ad1f-bca2f98156d3-S0 for 5secs
I0617 05:23:14.543710  3188 master.cpp:11640] Sending operation '' (uuid: 
fbb50eec-b8cd-4d94-af37-ec0b088637ef) to agent 
08cbfa6b-2d6a-4ade-ad1f-bca2f98156d3-S0 at slave(1246)@172.17.0.2:41631 
(5c2df703b2bd)
I0617 05:23:14.544349  3179 slave.cpp:4557] Ignoring new checkpointed resources 
and operations identical to the current version
I0617 05:23:14.547502  3177 provider.cpp:498] Received APPLY_OPERATION event
I0617 05:23:14.547555  3177 provider.cpp:1351] Received CREATE operation '' 
(uuid: fbb50eec-b8cd-4d94-af37-ec0b088637ef)
I0617 05:23:14.550858  3188 master.cpp:5521] Processing REVIVE call for 
framework 08cbfa6b-2d6a-4ade-ad1f-bca2f98156d3- (default) at 
scheduler-e6388fd6-6d75-4e80-bea1-89f59483a112@172.17.0.2:41631
I0617 05:23:14.551380  3181 hierarchical.cpp:1788] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
08cbfa6b-2d6a-4ade-ad1f-bca2f98156d3-
I0617 05:23:14.553051  3181 hierarchical.cpp:1920] Performed allocation for 1 
agents in 1.466467ms
I0617 05:23:14.553447  3181 hierarchical.cpp:1920] Performed allocation for 1 
agents in 157688ns
I0617 05:23:14.553956  3174 master.cpp:9476] Sending offers [ 
08cbfa6b-2d6a-4ade-ad1f-bca2f98156d3-O4 ] to framework 
08cbfa6b-2d6a-4ade-ad1f-bca2f98156d3- (default) at 
scheduler-e6388fd6-6d75-4e80-bea1-89f59483a112@172.17.0.2:41631
I0617 05:23:14.554677  3174 sched.cpp:934] Scheduler::resourceOffers took 
108091ns
I0617 05:23:14.572425  3173 http.cpp:1436] HTTP POST for 
/slave(1246)/api/v1/resource_provider from 172.17.0.2:58416
I0617 05:23:14.573650  3178 slave.cpp:8714] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 692b9a97-dfff-47cb-8432-6d91afa9bc4d) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'

Review Request 72600: Remove credential text format support.

2020-06-16 Thread Dong Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72600/
---

Review request for mesos, Benjamin Bannier and Benjamin Mahler.


Repository: mesos


Description
---

Since text format for credential is no longer supported, remove it.


Diffs
-

  src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d 


Diff: https://reviews.apache.org/r/72600/diff/1/


Testing
---

Manually tested
make check


Thanks,

Dong Zhu