Re: Review Request 41299: Allow DockerContainerizer log to console.

[haosdent huang]

> On Jan. 24, 2016, 8:21 a.m., Guangya Liu wrote:
> > I saw that all of the unit test are using `false` for `local`, can you 
> > please write some test scenarios in `Testing Done` area?

Sure, I test this local before. Add a new unit test would be better.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review116013
---


On Jan. 23, 2016, 8:58 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> ---
> 
> (Updated Jan. 23, 2016, 8:58 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4141
> https://issues.apache.org/jira/browse/MESOS-4141
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow DockerContainerizer log to console.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> 5e7e55e2dd4e451bb754a6a888e9683760d95873 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
>   src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
>   src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
> 
> Diff: https://reviews.apache.org/r/41299/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 41299: Allow DockerContainerizer log to console.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review116013
---



I saw that all of the unit test are using `false` for `local`, can you please 
write some test scenarios in `Testing Done` area?

- Guangya Liu


On 一月 23, 2016, 8:58 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> ---
> 
> (Updated 一月 23, 2016, 8:58 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4141
> https://issues.apache.org/jira/browse/MESOS-4141
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allow DockerContainerizer log to console.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> 5e7e55e2dd4e451bb754a6a888e9683760d95873 
>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
>   src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
>   src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
> 
> Diff: https://reviews.apache.org/r/41299/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 41790: Add tests for /weights endpoint.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/
---

(Updated Jan. 25, 2016, 1:51 a.m.)


Review request for mesos, Adam B, Neil Conway, and Qian Zhang.


Changes
---

Update the Unauthorized error HTTP response.


Bugs: MESOS-4200
https://issues.apache.org/jira/browse/MESOS-4200


Repository: mesos


Description
---

Add tests for /weights endpoint.


Diffs (updated)
-

  src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
  src/tests/dynamic_weights_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41790/diff/


Testing
---

Make and Make check successfully!

./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
[==] Running 11 tests from 1 test case.
[--] Global test environment set-up.
[--] 11 tests from DynamicWeightsTest
[ RUN  ] DynamicWeightsTest.PutInvalidRequest
[   OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
[ RUN  ] DynamicWeightsTest.ZeroWeight
[   OK ] DynamicWeightsTest.ZeroWeight (38 ms)
[ RUN  ] DynamicWeightsTest.NegativeWeight
[   OK ] DynamicWeightsTest.NegativeWeight (38 ms)
[ RUN  ] DynamicWeightsTest.MissingRole
[   OK ] DynamicWeightsTest.MissingRole (43 ms)
[ RUN  ] DynamicWeightsTest.UnknownRole
[   OK ] DynamicWeightsTest.UnknownRole (36 ms)
[ RUN  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[   OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
[ RUN  ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
[   OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
[ RUN  ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[   OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
[ RUN  ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[   OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
[ RUN  ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[   OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
(37 ms)
[ RUN  ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[   OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
[--] 11 tests from DynamicWeightsTest (492 ms total)

[--] Global test environment tear-down
[==] 11 tests from 1 test case ran. (503 ms total)
[  PASSED  ] 11 tests.


Thanks,

Yongqiao Wang

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41783/#review116041
---


Fix it, then Ship it!




I'll fix up the issue below and commit, thanks!


src/slave/container_loggers/logrotate.cpp (line 107)


{ on newline please.


- Benjamin Hindman


On Jan. 23, 2016, 9:07 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41783/
> ---
> 
> (Updated Jan. 23, 2016, 9:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4136
> https://issues.apache.org/jira/browse/MESOS-4136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a non-default ContainerLogger that constrains total log size by rotating 
> logs (i.e. renaming the head log file).
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.hpp PRE-CREATION 
>   src/slave/container_loggers/lib_logrotate.cpp PRE-CREATION 
>   src/slave/container_loggers/logrotate.hpp PRE-CREATION 
>   src/slave/container_loggers/logrotate.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41783/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/#review116039
---


Ship it!




Ship It!

- haosdent huang


On Jan. 21, 2016, 6:18 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42288/
> ---
> 
> (Updated Jan. 21, 2016, 6:18 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4328
> https://issues.apache.org/jira/browse/MESOS-4328
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Docker container REST API /monitor/statistics.json output have no timestamp 
> field, in docker.cpp function cgroupsStatistics add the timestamp value set.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 40f6f0b 
> 
> Diff: https://reviews.apache.org/r/42288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 41790: Add tests for /weights endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review116040
---



Bad patch!

Reviews applied: [41597]

Failed command: ./support/apply-review.sh -n -r 41597

Error:
 ..
2016-01-25 02:34:11 URL:https://reviews.apache.org/r/41597/diff/raw/ 
[7672/7672] -> "41597.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:1043
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11017/console

- Mesos ReviewBot


On Jan. 25, 2016, 1:51 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> ---
> 
> (Updated Jan. 25, 2016, 1:51 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
> https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> ---
> 
> Make and Make check successfully!
> 
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==] Running 11 tests from 1 test case.
> [--] Global test environment set-up.
> [--] 11 tests from DynamicWeightsTest
> [ RUN  ] DynamicWeightsTest.PutInvalidRequest
> [   OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN  ] DynamicWeightsTest.ZeroWeight
> [   OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN  ] DynamicWeightsTest.NegativeWeight
> [   OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN  ] DynamicWeightsTest.MissingRole
> [   OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN  ] DynamicWeightsTest.UnknownRole
> [   OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [   OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN  ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [   OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN  ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [   OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN  ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [   OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
> (37 ms)
> [ RUN  ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [   OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [--] 11 tests from DynamicWeightsTest (492 ms total)
> 
> [--] Global test environment tear-down
> [==] 11 tests from 1 test case ran. (503 ms total)
> [  PASSED  ] 11 tests.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Review Request 42695: Correct typo when create docker container.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42695/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Correct typo when create docker container.


Diffs
-

  src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0 

Diff: https://reviews.apache.org/r/42695/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 42704: Fixed non-linux build involving glog drop_log_meory flag.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42704/#review116043
---


Ship it!




Ship It!

- Neil Conway


On Jan. 25, 2016, 5:44 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42704/
> ---
> 
> (Updated Jan. 25, 2016, 5:44 a.m.)
> 
> 
> Review request for mesos and Jian Qiu.
> 
> 
> Bugs: MESOS-920
> https://issues.apache.org/jira/browse/MESOS-920
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The variable "FLAGS_drop_log_memory" is available only on Linux.
> 
> 
> Diffs
> -
> 
>   src/logging/logging.cpp 9cd6181b136e498facfb9cace33856d50f2c06de 
> 
> Diff: https://reviews.apache.org/r/42704/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 41590: Modulize the containerizer interface.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41590/#review116051
---



@haosdent, it is really a big patch, can you please highlight some key points 
for this patch in description part?

- Guangya Liu


On 一月 13, 2016, 6:05 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41590/
> ---
> 
> (Updated 一月 13, 2016, 6:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Ben Mahler, Till Toenshoff, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-3709
> https://issues.apache.org/jira/browse/MESOS-3709
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modulize the containerizer interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/containerizer.hpp PRE-CREATION 
>   src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
>   src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f 
>   src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38 
>   src/slave/containerizer/composing.hpp 
> 6b8757ebc75710b612f6ea5854ee2ff0ca0083ec 
>   src/slave/containerizer/composing.cpp 
> f0a7bba4a56702872c9b73a12128b5292708d0e7 
>   src/slave/containerizer/containerizer.hpp 
> 6964d136818ea9904fa35cd778eb9ef19e2c64fc 
>   src/slave/containerizer/containerizer.cpp 
> 5e7e55e2dd4e451bb754a6a888e9683760d95873 
>   src/slave/containerizer/docker.hpp 8927865a1e7b58bf17de02ead3a175275f1e14d7 
>   src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 
>   src/slave/containerizer/external_containerizer.hpp 
> feeb0278a3d8fec8c7177a9a3dc443ee0c198c5c 
>   src/slave/containerizer/external_containerizer.cpp 
> fe368dd52644b89e47ffd4d947de290b3998fb1a 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 89d18624b08f2c953b9fa21663aeda694d4aac12 
>   src/slave/containerizer/mesos/containerizer.cpp 
> f3c370aeb331beb6202fd30cd0278877da0b42e0 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> b2e23d82ea255e1c91d7537a58f86632763d9a56 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 89d06e94bd2255bb4f2dad3fae75c1b3d789611d 
>   src/slave/flags.hpp 6857fde027fd57b4934cb43ddf435d12900e0b87 
>   src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526 
>   src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
>   src/tests/cluster.hpp 576dcb8b7e27d1905425aa0f7cb319c19c17c15c 
>   src/tests/cluster.cpp 1a3a038e78999bca2fc3f08725f4ffaf4290bcb9 
>   src/tests/container_logger_tests.cpp 
> c6b2e597517c74a55649287dc5ae5a3115f9a640 
>   src/tests/containerizer.hpp 25b64dacca65aa0ac49a05a2fbaf526aa0761471 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> e7e3b622b6606a812aef046c761bf92368d34af2 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> cb58b7183c36d96b9ac4803c63980c278a50c97b 
>   src/tests/containerizer/external_containerizer_test.cpp 
> da52860f4a1d5363d7b61b9a8bb6abad02d89736 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 5bb85034c22caef64054c1629f6fd55d227e48b1 
>   src/tests/containerizer/isolator_tests.cpp 
> 91178b69ccbf5b6cbf64421e5602e6d554fc34ca 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> 4a03af2c9c0643d964b1d76e2096341b59bf5dce 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 95b493c6f479eef52ee0c9a44ac40254ed76ebae 
>   src/tests/containerizer/port_mapping_tests.cpp 
> e3aea53468fa00374320a8b89bdbb64f38e44b01 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 98d5a46149ef63cedcbf4915b5b6e9842ac67dbb 
>   src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 
>   src/tests/fetcher_cache_tests.cpp 1fb1e213d3c35479789688d1a3a49a3c6058b198 
>   src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67 
>   src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f 
>   src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
>   src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
>   src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 
>   src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6 
> 
> Diff: https://reviews.apache.org/r/41590/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/#review116054
---




src/tests/slave_tests.cpp (line 704)


Replace `///` with `//`


- Guangya Liu


On 一月 18, 2016, 11:14 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42247/
> ---
> 
> (Updated 一月 18, 2016, 11:14 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-4329
> https://issues.apache.org/jira/browse/MESOS-4329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Waiting for the launch result is not enough as it is unrelated to
> whether the launched container has terminated. If we do not wait for
> that the global teardown might find it still running and fail the tests
> (this can happen if we e.g., execute this test in isolation).
> 
> Also along the name of the launch result to following the canonical
> scheme.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 7fe566770bbd802111885de061a53a3edf914840 
> 
> Diff: https://reviews.apache.org/r/42247/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 42704: Fixed non-linux build involving glog drop_log_meory flag.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42704/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-920
https://issues.apache.org/jira/browse/MESOS-920


Repository: mesos


Description
---

The variable "FLAGS_drop_log_memory" is available only on Linux.


Diffs
-

  src/logging/logging.cpp 9cd6181b136e498facfb9cace33856d50f2c06de 

Diff: https://reviews.apache.org/r/42704/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 42705: Update docs for --weights flag and authorization.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42705/#review116046
---



Patch looks great!

Reviews applied: [42705]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 25, 2016, 5:54 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42705/
> ---
> 
> (Updated Jan. 25, 2016, 5:54 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3945
> https://issues.apache.org/jira/browse/MESOS-3945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update docs for --weights flag and authorization.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
> 
> Diff: https://reviews.apache.org/r/42705/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Review Request 42710: Moved docker containerizer to docker folder.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42710/
---

Review request for mesos, Jie Yu and Timothy Chen.


Repository: mesos


Description
---

The Mesos now support two kind for containerizers: Mesos and Docker.
The Mesos containerizer is under slave/containerizer/mesos and it
is better to move docker containerizer to slave/containerizer/docker.


Diffs
-

  src/CMakeLists.txt 47d0a7c0fe73b9297cd7dde6086b5e6e9e1f9e4e 
  src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
  src/slave/containerizer/containerizer.cpp 
fa6e279c3704255ff50f9be9f7b5b4e12da5757a 
  src/slave/containerizer/docker.hpp  
  src/slave/containerizer/docker.cpp d2b77e3e6790cbed5d40a53c18fda85719f7053c 

Diff: https://reviews.apache.org/r/42710/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 42705: Update docs for --weights flag and authorization.

[Yongqiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42705/
---

Review request for mesos and Adam B.


Bugs: MESOS-3945
https://issues.apache.org/jira/browse/MESOS-3945


Repository: mesos


Description
---

Update docs for --weights flag and authorization.


Diffs
-

  docs/authorization.md dbbfd60cb35cbb67e47b6a468d4f4ab824981e5d 
  docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 

Diff: https://reviews.apache.org/r/42705/diff/


Testing
---


Thanks,

Yongqiao Wang

Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
---

Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
---

Speed up FetcherCacheTest.Local* test cases.


Diffs
-

  src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 

Diff: https://reviews.apache.org/r/42696/diff/


Testing
---

Before apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2524 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
```


After apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (873 ms)
[   OK ] FetcherCacheTest.LocalCached (1609 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
```


Thanks,

haosdent huang

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/
---

(Updated Jan. 24, 2016, 3:26 p.m.)


Review request for mesos, Adam B and Joerg Schad.


Changes
---

Update style


Bugs: MESOS-4340
https://issues.apache.org/jira/browse/MESOS-4340


Repository: mesos


Description
---

Remove checkpointing field from SlaveInfo after deprecation.


Diffs (updated)
-

  docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
  include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
  src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
  src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d 
  src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 

Diff: https://reviews.apache.org/r/42697/diff/


Testing (updated)
---

make -j8 check


Thanks,

haosdent huang

Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/
---

Review request for mesos, Adam B and Joerg Schad.


Bugs: MESOS-4340
https://issues.apache.org/jira/browse/MESOS-4340


Repository: mesos


Description
---

Remove checkpointing field from SlaveInfo after deprecation.


Diffs
-

  docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
  include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
  src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d 
  src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 

Diff: https://reviews.apache.org/r/42697/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/#review116018
---



We planned to wait for this deprecation cycle, any reason to change this right 
now? The documentation look good nevertheless, so maybe just submit those?


include/mesos/mesos.proto 


We planned to wait for this deprecation cycle, any reason to change this 
right now?


- Joerg Schad


On Jan. 24, 2016, 3:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42697/
> ---
> 
> (Updated Jan. 24, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-4340
> https://issues.apache.org/jira/browse/MESOS-4340
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove checkpointing field from SlaveInfo after deprecation.
> 
> 
> Diffs
> -
> 
>   docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
>   src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d 
>   src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 
> 
> Diff: https://reviews.apache.org/r/42697/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

[haosdent huang]

> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote:
> > include/mesos/mesos.proto, line 482
> > 
> >
> > We planned to wait for this deprecation cycle, any reason to change 
> > this right now?

I saw
```
// TODO(joerg84): Remove checkpoint field after deprecation cycle starting
-  // with 0.27
```
Do you mean we need submit this since 0.28 here?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/#review116018
---


On Jan. 24, 2016, 3:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42697/
> ---
> 
> (Updated Jan. 24, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-4340
> https://issues.apache.org/jira/browse/MESOS-4340
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove checkpointing field from SlaveInfo after deprecation.
> 
> 
> Diffs
> -
> 
>   docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
>   src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d 
>   src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 
> 
> Diff: https://reviews.apache.org/r/42697/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

[Joerg Schad]

> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote:
> > include/mesos/mesos.proto, line 482
> > 
> >
> > We planned to wait for this deprecation cycle, any reason to change 
> > this right now?
> 
> haosdent huang wrote:
> I saw
> ```
> // TODO(joerg84): Remove checkpoint field after deprecation cycle starting
> -  // with 0.27
> ```
> Do you mean we need submit this since 0.28 here?

Afaik we have a six month compatability guarantee (after switching to the 
monthly releases), i.e. we should wait that period after all code using the 
flag has been removed (or we release 1.0). Discussed that a bit with adam as we 
were not really sure we need a deprecation cycle here, but as we decided to 
have one we should stick to it.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/#review116018
---


On Jan. 24, 2016, 3:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42697/
> ---
> 
> (Updated Jan. 24, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-4340
> https://issues.apache.org/jira/browse/MESOS-4340
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove checkpointing field from SlaveInfo after deprecation.
> 
> 
> Diffs
> -
> 
>   docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
>   src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d 
>   src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 
> 
> Diff: https://reviews.apache.org/r/42697/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

[haosdent huang]

> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote:
> > include/mesos/mesos.proto, line 482
> > 
> >
> > We planned to wait for this deprecation cycle, any reason to change 
> > this right now?
> 
> haosdent huang wrote:
> I saw
> ```
> // TODO(joerg84): Remove checkpoint field after deprecation cycle starting
> -  // with 0.27
> ```
> Do you mean we need submit this since 0.28 here?
> 
> Joerg Schad wrote:
> Afaik we have a six month compatability guarantee (after switching to the 
> monthly releases), i.e. we should wait that period after all code using the 
> flag has been removed (or we release 1.0). Discussed that a bit with adam as 
> we were not really sure we need a deprecation cycle here, but as we decided 
> to have one we should stick to it.

Sorry, I think my understand standing about this comment is incorrect. I think 
"starting with 0.27" means we could do it in 0.27 before. Let me discard this 
patch.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/#review116018
---


On Jan. 24, 2016, 3:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42697/
> ---
> 
> (Updated Jan. 24, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-4340
> https://issues.apache.org/jira/browse/MESOS-4340
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove checkpointing field from SlaveInfo after deprecation.
> 
> 
> Diffs
> -
> 
>   docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
>   src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d 
>   src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 
> 
> Diff: https://reviews.apache.org/r/42697/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42697: Remove checkpointing field from SlaveInfo after deprecation.

[Joerg Schad]

> On Jan. 24, 2016, 3:28 p.m., Joerg Schad wrote:
> > include/mesos/mesos.proto, line 482
> > 
> >
> > We planned to wait for this deprecation cycle, any reason to change 
> > this right now?
> 
> haosdent huang wrote:
> I saw
> ```
> // TODO(joerg84): Remove checkpoint field after deprecation cycle starting
> -  // with 0.27
> ```
> Do you mean we need submit this since 0.28 here?
> 
> Joerg Schad wrote:
> Afaik we have a six month compatability guarantee (after switching to the 
> monthly releases), i.e. we should wait that period after all code using the 
> flag has been removed (or we release 1.0). Discussed that a bit with adam as 
> we were not really sure we need a deprecation cycle here, but as we decided 
> to have one we should stick to it.
> 
> haosdent huang wrote:
> Sorry, I think my understand standing about this comment is incorrect. I 
> think "starting with 0.27" means we could do it in 0.27 before. Let me 
> discard this patch.

The deprecation cycle starts with that release. You can still submit the 
documentation part :-)...


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42697/#review116018
---


On Jan. 24, 2016, 3:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42697/
> ---
> 
> (Updated Jan. 24, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-4340
> https://issues.apache.org/jira/browse/MESOS-4340
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove checkpointing field from SlaveInfo after deprecation.
> 
> 
> Diffs
> -
> 
>   docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
>   src/internal/devolve.cpp 27918f1fc385b1770843697c16a29fd0d376f39d 
>   src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 
> 
> Diff: https://reviews.apache.org/r/42697/diff/
> 
> 
> Testing
> ---
> 
> make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42353: Correctted typo in fetcher.md.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42353/#review116032
---


Ship it!




Ship It!

- Bernd Mathiske


On Jan. 22, 2016, 4:54 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42353/
> ---
> 
> (Updated Jan. 22, 2016, 4:54 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Correctted typo in fetcher.md.
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md d9280e1611df13f8217c9a40a02a5391c44ed267 
> 
> Diff: https://reviews.apache.org/r/42353/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42695: Correct typo when create docker container.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42695/#review116017
---



Patch looks great!

Reviews applied: [42695]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 24, 2016, 1:33 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42695/
> ---
> 
> (Updated Jan. 24, 2016, 1:33 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Correct typo when create docker container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0 
> 
> Diff: https://reviews.apache.org/r/42695/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review116022
---



Patch looks great!

Reviews applied: [42696]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 24, 2016, 3:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Jan. 24, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>