Re: Review Request 65570: Attached/detached volume directory for task which has volume specified.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/#review197387
---



PASS: Mesos patch 65570 was successfully built and tested.

Reviews applied: `['65570']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65570

- Mesos Reviewbot Windows


On Feb. 13, 2018, 2:47 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65570/
> ---
> 
> (Updated Feb. 13, 2018, 2:47 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8565
> https://issues.apache.org/jira/browse/MESOS-8565
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Attached/detached volume directory for task which has volume specified.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39 
>   src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5 
> 
> 
> Diff: https://reviews.apache.org/r/65570/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/#review197388
---



PASS: Mesos patch 65593 was successfully built and tested.

Reviews applied: `['65445', '65504', '65446', '65449', '65448', '65626', 
'65593']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65593

- Mesos Reviewbot Windows


On Feb. 13, 2018, 6:26 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65593/
> ---
> 
> (Updated Feb. 13, 2018, 6:26 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Theses tests ensure that agent sends ExitedExecutorMessage when the
> task group fails to launch due to unschedule GC failure and when
> the task fails to launch due to task authorization failure.
> So that master's executor bookkeeping entry is removed.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 
> 
> 
> Diff: https://reviews.apache.org/r/65593/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65161: Removed some redundant `get` calls in libprocess.

[Benjamin Bannier]

> On Feb. 12, 2018, 8:09 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/libprocess/include/process/gtest.hpp
> > Lines 429-430 (original), 429-430 (patched)
> > 
> >
> > Ha! It's funny it caught the one in the string.

Sadly we still needed a human to look at the change on l.430 and make the 
change on l.429.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65161/#review197290
---


On Feb. 12, 2018, 3:07 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65161/
> ---
> 
> (Updated Feb. 12, 2018, 3:07 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed some redundant `get` calls in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/gmock.hpp 
> 231efcd989b829b5cfba8e5d69ca5cb2c4bf0428 
>   3rdparty/libprocess/include/process/gtest.hpp 
> eee726653d52af2e4a148819e420ebd22e5123a9 
>   3rdparty/libprocess/include/process/system.hpp 
> 21bd3300b104eaa56642f19c3dcb95950ab94830 
>   3rdparty/libprocess/src/http.cpp 76a65e02fd83219b198d0b8fde3f8208e1c606b5 
>   3rdparty/libprocess/src/http_proxy.cpp 
> f584238aadd86875d7c87736653f394e716397de 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> f79541853b4c826014ee969633345c3d51520ecf 
>   3rdparty/libprocess/src/openssl.cpp 
> f2fe90bfdf87dbc674b231f6392e95a95ebd9736 
>   3rdparty/libprocess/src/process.cpp 
> 42e7adf740b234ebf23d2dcb71440749c0ed87ec 
>   3rdparty/libprocess/src/ssl/utilities.cpp 
> 9b1d6229c3aa7d7045d492d377223d56bca16156 
>   3rdparty/libprocess/src/subprocess_posix.hpp 
> 25eb44ab7f68907c30008ae729403a986cb1898a 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 
> 48b5f5cf38d8fb4d77025f9723031075ca8ab677 
>   3rdparty/libprocess/src/tests/collect_tests.cpp 
> 7c2ba902d2fba340a5fae49a911a9e84223fe1ce 
>   3rdparty/libprocess/src/tests/future_tests.cpp 
> bd98154cfa2020b7423951f070fca7b0447d3cd5 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> a60f6b132aff00da42e733f5c5f387dff2428ed2 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> 5a5a2e581d0917ad5aa6aa93257ec0dddc895725 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 96b1675dea7df675667c61ff2bd1d1cc8231a457 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 
> f8a8593b685c5e5a9321d970a57e9ebdff127c24 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 71f2df8cd2377ae1be762ec7a0fb0d2f7b210e4b 
>   3rdparty/libprocess/src/tests/statistics_tests.cpp 
> 144b5109cfb7640b29bec8de8f5b2ad00665212f 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 8211ae63e75359705af2bb9ac02a7cbdb28e3252 
>   3rdparty/libprocess/src/tests/system_tests.cpp 
> 6beb973e079c00ba3e632d6fb6c3c332483d203f 
>   3rdparty/libprocess/src/tests/timeseries_tests.cpp 
> 4177fb673bbf510fe835af396cd76dae48a9ec85 
> 
> 
> Diff: https://reviews.apache.org/r/65161/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> These changes were made automatically with 
> https://github.com/mesos/clang-tools-extra/pull/13 with only a few minor 
> additions in surrounding code.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 65630: Updated the test `ROOT_PersistentResources` to check `/files` endpoint.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65630/
---

Review request for mesos, Gilbert Song and Vinod Kone.


Bugs: MESOS-8565
https://issues.apache.org/jira/browse/MESOS-8565


Repository: mesos


Description
---

Updated the test `ROOT_PersistentResources` to check `/files` endpoint.


Diffs
-

  src/tests/default_executor_tests.cpp cc97e0d1fea7f4d0bc544d850593d8d91921b552 


Diff: https://reviews.apache.org/r/65630/diff/1/


Testing
---

Manually ran this test 
(`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_PersistentResources/*`)
 100 times.


Thanks,

Qian Zhang

Re: Review Request 65587: Added hash function for mesos::UUID.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65587/#review197393
---


Ship it!




Ship It!

- Jan Schlicht


On Feb. 9, 2018, 6:27 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65587/
> ---
> 
> (Updated Feb. 9, 2018, 6:27 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Bugs: MESOS-8382
> https://issues.apache.org/jira/browse/MESOS-8382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added hash function for mesos::UUID.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp af2b187b9b59552e4ba515ad640fd4419eaf5075 
> 
> 
> Diff: https://reviews.apache.org/r/65587/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65518: Reaped the container process directly in Docker executor.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65518/#review197395
---



Patch looks great!

Reviews applied: [65518]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 13, 2018, 3:20 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65518/
> ---
> 
> (Updated Feb. 13, 2018, 3:20 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-8488
> https://issues.apache.org/jira/browse/MESOS-8488
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Due to a Docker issue (https://github.com/moby/moby/issues/33820),
> Docker daemon can fail to catch a container exit, i.e., the container
> process has already exited but the command `docker ps` shows the
> container still running, this will lead to the "docker run" command
> that we execute in Docker executor never returning, and it will also
> cause the `docker stop` command takes no effect, i.e., it will return
> without error but `docker ps` shows the container still running, so
> the task will stuck in `TASK_KILLING` state.
> 
> To workaround this Docker issue, in this patch we made Docker executor
> reaps the container process directly so Docker executor will be notified
> once the container process exits.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a 
> 
> 
> Diff: https://reviews.apache.org/r/65518/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 65588: Used proto UUID instead stout UUID internally for operation IDs.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65588/#review197394
---



Thanks for cleaning this up!

Looks great, only minor thing that I've noticed and which isn't in the scope of 
this diff is some inconsistent naming in `slave.cpp`. E.g., there's 
`operationUUID` vs. `operationUuid`, especially in 
`Slave::handleResourceProviderMessage`. It would be great I we could agree on a 
convention here.


src/common/protobuf_utils.cpp
Line 467 (original), 467 (patched)


How about we create a helper function `mesos::UUID createRandomUUID()` in 
`protobuf_utils` even if that function would be almost trivial? This would 
allow us to have the expectations of a UUID (i.e. it's 
`UUID::random().toBytes()`, not `UUID::random().toString()`) in a single place.

Here and below, where `->set_value(id::UUID::random().toBytes())` is used.


- Jan Schlicht


On Feb. 9, 2018, 6:27 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65588/
> ---
> 
> (Updated Feb. 9, 2018, 6:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8382
> https://issues.apache.org/jira/browse/MESOS-8382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used proto UUID instead stout UUID internally for operation IDs.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> e96a40493c351a7242465c8591cae981abc92f24 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 
>   src/master/master.cpp d7d22866f7a4eb87bd8949efafc97e828e7d4b94 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/resource_provider/message.hpp 2511af611edc94e3e3a78fce475bc8cd85ffc3f9 
>   src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39 
>   src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5 
> 
> 
> Diff: https://reviews.apache.org/r/65588/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65630: Updated the test `ROOT_PersistentResources` to check `/files` endpoint.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65630/#review197396
---



PASS: Mesos patch 65630 was successfully built and tested.

Reviews applied: `['65570', '65630']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65630

- Mesos Reviewbot Windows


On Feb. 13, 2018, 9:19 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65630/
> ---
> 
> (Updated Feb. 13, 2018, 9:19 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Vinod Kone.
> 
> 
> Bugs: MESOS-8565
> https://issues.apache.org/jira/browse/MESOS-8565
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the test `ROOT_PersistentResources` to check `/files` endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> cc97e0d1fea7f4d0bc544d850593d8d91921b552 
> 
> 
> Diff: https://reviews.apache.org/r/65630/diff/1/
> 
> 
> Testing
> ---
> 
> Manually ran this test 
> (`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_PersistentResources/*`)
>  100 times.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 65590: Added helper function to determine provider ID of a conversion.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65590/#review197397
---




src/common/resources_utils.cpp
Lines 290-311 (patched)


This can be simplified to
```
Option providerId = 
conversion.consumed.front().has_provider_id()
  ? resource.provider_id()
  : Option::none();

foreach (const Resource& resource, conversion.consumed) {
Option _providerId = resource.has_provider_id()
  ? resource.provider_id()
  : Option::none();

if (providerId != _providerId) {
  return Error("Conversion works on multiple resource providers");
}
}
```
or something else, as long as we can fail early when iterating over 
resources.



src/common/resources_utils.cpp
Lines 299-301 (patched)


Remove this.



src/common/resources_utils.cpp
Lines 313-327 (patched)


Do we need this here? This should be part of a validation that should have 
happened before calling this function. OTOH we can't be sure that this has been 
validated and we should document our assumptions made in this function.


- Jan Schlicht


On Feb. 9, 2018, 6:27 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65590/
> ---
> 
> (Updated Feb. 9, 2018, 6:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8382
> https://issues.apache.org/jira/browse/MESOS-8382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper function to determine provider ID of a conversion.
> 
> 
> Diffs
> -
> 
>   src/common/resources_utils.hpp 73d070d48eedf30468305e96fc4ad0005584fc79 
>   src/common/resources_utils.cpp 99b16e0d17b224eefa1e28f5f66c4284069c0e57 
> 
> 
> Diff: https://reviews.apache.org/r/65590/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65624: Added fetcher tests for `stderr` output.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65624/#review197400
---



Patch looks great!

Reviews applied: [65397, 65398, 65399, 65400, 65401, 65402, 65405, 65406, 
65407, 65408, 65409, 65465, 65403, 65467, 65574, 65469, 65624]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 13, 2018, 4:41 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65624/
> ---
> 
> (Updated Feb. 13, 2018, 4:41 a.m.)
> 
> 
> Review request for mesos, Akash Gupta and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The fetcher is supposed to log its `stderr` output to a redirected file
> called `stderr` in the given sandbox directory. There previously existed
> a bug on Windows due to incorrect handle inheritance where this
> redirection failed silently, leaving the log empty. These unit tests
> assert that the correct content is logged to the `stderr` file for both
> a success and failure fetch scenario.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 1b4ba1d286f218731c13180e5189e91f90e3d63f 
> 
> 
> Diff: https://reviews.apache.org/r/65624/diff/1/
> 
> 
> Testing
> ---
> 
> Windows (Linux pending):
> ```
> [ RUN  ] FetcherTest.LogSuccessToStderr
> [   OK ] FetcherTest.LogSuccessToStderr (197 ms)
> [ RUN  ] FetcherTest.LogFailureToStderr
> [   OK ] FetcherTest.LogFailureToStderr (320 ms)
> ```
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65570: Attached/detached volume directory for task which has volume specified.

[Qian Zhang]

> On Feb. 13, 2018, 9:38 a.m., Vinod Kone wrote:
> > Can you add tests for this in a subsequent review please?

Yes, here it is: https://reviews.apache.org/r/65630/


> On Feb. 13, 2018, 9:38 a.m., Vinod Kone wrote:
> > src/slave/slave.cpp
> > Lines 1109- (patched)
> > 
> >
> > I don't think we need this check. We want to show non PV directories 
> > too in the UI.

That was actually my original solution, but after more consideration and 
testing, I found we still need this check. The reason is, if we do not have 
this check, that means we will do attach as long as the task's ContainerInfo 
has a `SANDBOX_PATH` volume with type `PARENT`, but such attach will fail (see 
below) because the executor's volume directory is not created yet at the moment 
when `attachTaskVolumeDirectory` is called, it will actually be created by the 
`volume/sandbox_path` isolator when launching the nested container.
```
E0212 22:23:08.905462 10350 slave.cpp:1009] Failed to attach 
'/home/qzhang/opt/mesos/slaves/54de35d5-250f-4bf9-9444-3633c5e66e7d-S0/frameworks/54de35d5-250f-4bf9-9444-3633c5e66e7d-/executors/default-executor/runs/0ea4dc53-e543-42c4-8bb5-c5b667eee4c0/foo'
 to virtual path 
'/home/qzhang/opt/mesos/slaves/54de35d5-250f-4bf9-9444-3633c5e66e7d-S0/frameworks/54de35d5-250f-4bf9-9444-3633c5e66e7d-/executors/default-executor/runs/0ea4dc53-e543-42c4-8bb5-c5b667eee4c0/tasks/test/xxx':
 Failed to get realpath of 
'/home/qzhang/opt/mesos/slaves/54de35d5-250f-4bf9-9444-3633c5e66e7d-S0/frameworks/54de35d5-250f-4bf9-9444-3633c5e66e7d-/executors/default-executor/runs/0ea4dc53-e543-42c4-8bb5-c5b667eee4c0/foo':
 No such file or directory
```
So I think we still need this check which will ensure the executor's volume 
directory exists before we do the attach, the executor's volume directory will 
actually be created by the `filesystem/linux` isolator when launching the 
executor.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/#review197359
---


On Feb. 13, 2018, 5:20 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65570/
> ---
> 
> (Updated Feb. 13, 2018, 5:20 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Vinod Kone.
> 
> 
> Bugs: MESOS-8565
> https://issues.apache.org/jira/browse/MESOS-8565
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Attached/detached volume directory for task which has volume specified.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39 
>   src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5 
> 
> 
> Diff: https://reviews.apache.org/r/65570/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/
---

(Updated Feb. 13, 2018, 3:44 p.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Rebased and added more detailed description with screenshots.


Bugs: MESOS-3011
https://issues.apache.org/jira/browse/MESOS-3011


Repository: mesos


Description (updated)
---

This patch updates the website build process to allow for documentation to be 
generated for all versions of Mesos, based on the existing Git tags.  
Additionally, the website is updated with a dropdown list of the available 
versions of documentation.  If a user changes versions and the old version does 
not have the current page, a notice will be displayed and the user redirected 
to the home page for the desired version.

This is a temporary measure to "catchup" the documentation for the website by 
generating docs for all previous versions.  Going forward, as each new version 
of Mesos is released the documentation will be generated for that version only.

![Dropdown list of versions.](https://i.imgur.com/xvukEBGl.png)
Screenshot of the dropdown list of versions.

![404 Message](https://i.imgur.com/kqXNsxvl.png)
Screenshot of the message displayed if a page does not exist for the selected 
version.


Diffs (updated)
-

  site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
  site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
  site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
  site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
  site/data/releases.yml 56fd0fc7f5e34873c9b088778d77f9a6718a5933 
  site/source/assets/js/versions.js PRE-CREATION 
  site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 


Diff: https://reviews.apache.org/r/52064/diff/7/

Changes: https://reviews.apache.org/r/52064/diff/6-7/


Testing
---

Testing was done manually to verify that the documentation was built for each 
version of Mesos that is supported (some older versions do not have compatible 
documentation).


Thanks,

Tim Anderegg

Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65637/
---

Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone.


Bugs: MESOS-8577
https://issues.apache.org/jira/browse/MESOS-8577


Repository: mesos


Description
---

Previously, if `attachContainerOutput()` returned http error for
`LAUNCH_NESTED_CONTAINER_SESSION` call, we didn't destroy the nested
container. From the point of view of API user, if
`LAUNCH_NESTED_CONTAINER_SESSION` returns an error, then no nested
container should be in `RUNNING` state. This patch fixes the API
issue by destroying a nested container on http errors and failures
of `attachContainerOutput()`.


Diffs
-

  src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a 


Diff: https://reviews.apache.org/r/65637/diff/1/


Testing
---

internal CI


Thanks,

Andrei Budnik

Re: Review Request 65591: Explicitly tracked resource providers in master.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65591/#review197410
---




src/master/master.cpp
Line 7295 (original), 7329 (patched)


This should be `!contains`, right?



src/master/master.cpp
Lines 7334-7336 (patched)


You compare operations here for resource providers. This isn't done in the 
code above for agent operations. Please add a comment, why this is necessary 
here but not for agent operations.



src/master/master.cpp
Line 7392 (original), 7351 (patched)


Name this `resourceProvider` to be consistent with the code above (or use 
`provider` in the code above). Here and below when iterating over 
`message.resource_providers().providers()`.



src/master/master.cpp
Lines 7546-7547 (original), 7437-7438 (patched)


This makes no sense, slave operations are tracked separately from resource 
provider operations. Please remove.



src/master/master.cpp
Lines 7448 (patched)


This doesn't feel right. We don't want to add an operation to the agent 
here, only to the respective resource provider -- but might want to update used 
resources of the agent.



src/master/master.cpp
Lines 7516 (patched)


This is redundant, as we're iterating over `oldProvider.operations` here.



src/master/master.cpp
Lines 7517-7518 (patched)


Could iterate using `foreachpair` instead.



src/master/master.cpp
Lines 7520 (patched)


Also redundant, as that guaranteed by the `else` case we're currently in.



src/master/master.cpp
Line 7616 (original), 7527 (patched)


Agent shouldn't keep track of resource provider operations.



src/master/master.cpp
Lines 7626-7627 (original), 7537-7538 (patched)


Probably needs to be updated to handle resource provider operations.


- Jan Schlicht


On Feb. 9, 2018, 6:27 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65591/
> ---
> 
> (Updated Feb. 9, 2018, 6:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8382
> https://issues.apache.org/jira/browse/MESOS-8382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds explicit tracking of resource providers to the master
> process. While we already had explicitly send resource provider
> information in e.g., `UpdateSlaveMessage`, we only stored that
> information aggregated over the full agent in the master up to now.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 
>   src/master/master.cpp d7d22866f7a4eb87bd8949efafc97e828e7d4b94 
> 
> 
> Diff: https://reviews.apache.org/r/65591/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65617: Windows: Fixed problems with Hadoop URI handling on Windows.

[Jeff Coffler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65617/
---

(Updated Feb. 13, 2018, 4:52 p.m.)


Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Bugs: MESOS-6715
https://issues.apache.org/jira/browse/MESOS-6715


Repository: mesos


Description (updated)
---

Fixed Windows-specific issues (absolute path, subprocess invocation)
to allow Hadoop Fetcher Plugin to run properly.


Diffs
-

  src/hdfs/hdfs.cpp f9fc1cbb5556d4c1b2ee3a103b4f3bb4fe1d7589 


Diff: https://reviews.apache.org/r/65617/diff/2/


Testing
---

Full test pass on both Linux and Windows.

Additionally, on Windows platform:

```
[==] Running 3 tests from 1 test case.
[--] Global test environment set-up.
[--] 3 tests from HadoopFetcherPluginTest
[ RUN  ] HadoopFetcherPluginTest.FetchExistingFile

C:\Users\jeffcof\AppData\Local\Temp\UrtxvI>if "version" == "version" (exit 0 )
[   OK ] HadoopFetcherPluginTest.FetchExistingFile (235 ms)
[ RUN  ] HadoopFetcherPluginTest.FetchNonExistingFile

C:\Users\jeffcof\AppData\Local\Temp\YJVcTA>if "version" == "version" (exit 0 )
[   OK ] HadoopFetcherPluginTest.FetchNonExistingFile (217 ms)
[ RUN  ] HadoopFetcherPluginTest.InvokeFetchByName

C:\Users\jeffcof\AppData\Local\Temp\wsQjH1>if "version" == "version" (exit 0 )
[   OK ] HadoopFetcherPluginTest.InvokeFetchByName (217 ms)
[--] 3 tests from HadoopFetcherPluginTest (674 ms total)

[--] Global test environment tear-down
[==] 3 tests from 1 test case ran. (12790 ms total)
[  PASSED  ] 3 tests.
```


Thanks,

Jeff Coffler

Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65637/#review197414
---



PASS: Mesos patch 65637 was successfully built and tested.

Reviews applied: `['65637']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65637

- Mesos Reviewbot Windows


On Feb. 13, 2018, 7:52 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65637/
> ---
> 
> (Updated Feb. 13, 2018, 7:52 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8577
> https://issues.apache.org/jira/browse/MESOS-8577
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, if `attachContainerOutput()` returned http error for
> `LAUNCH_NESTED_CONTAINER_SESSION` call, we didn't destroy the nested
> container. From the point of view of API user, if
> `LAUNCH_NESTED_CONTAINER_SESSION` returns an error, then no nested
> container should be in `RUNNING` state. This patch fixes the API
> issue by destroying a nested container on http errors and failures
> of `attachContainerOutput()`.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a 
> 
> 
> Diff: https://reviews.apache.org/r/65637/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review197418
---



PASS: Mesos patch 52064 was successfully built and tested.

Reviews applied: `['52064']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/52064

- Mesos Reviewbot Windows


On Feb. 13, 2018, 7:44 a.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 13, 2018, 7:44 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the website build process to allow for documentation to be 
> generated for all versions of Mesos, based on the existing Git tags.  
> Additionally, the website is updated with a dropdown list of the available 
> versions of documentation.  If a user changes versions and the old version 
> does not have the current page, a notice will be displayed and the user 
> redirected to the home page for the desired version.
> 
> This is a temporary measure to "catchup" the documentation for the website by 
> generating docs for all previous versions.  Going forward, as each new 
> version of Mesos is released the documentation will be generated for that 
> version only.
> 
> ![Dropdown list of versions.](https://i.imgur.com/xvukEBGl.png)
> Screenshot of the dropdown list of versions.
> 
> ![404 Message](https://i.imgur.com/kqXNsxvl.png)
> Screenshot of the message displayed if a page does not exist for the selected 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml 56fd0fc7f5e34873c9b088778d77f9a6718a5933 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/7/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65637/#review197419
---


Ship it!




Ship It!

- Gilbert Song


On Feb. 13, 2018, 7:52 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65637/
> ---
> 
> (Updated Feb. 13, 2018, 7:52 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8577
> https://issues.apache.org/jira/browse/MESOS-8577
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, if `attachContainerOutput()` returned http error for
> `LAUNCH_NESTED_CONTAINER_SESSION` call, we didn't destroy the nested
> container. From the point of view of API user, if
> `LAUNCH_NESTED_CONTAINER_SESSION` returns an error, then no nested
> container should be in `RUNNING` state. This patch fixes the API
> issue by destroying a nested container on http errors and failures
> of `attachContainerOutput()`.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a 
> 
> 
> Diff: https://reviews.apache.org/r/65637/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65637/#review197421
---


Ship it!




Ship It!

- Gaston Kleiman


On Feb. 13, 2018, 7:52 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65637/
> ---
> 
> (Updated Feb. 13, 2018, 7:52 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8577
> https://issues.apache.org/jira/browse/MESOS-8577
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, if `attachContainerOutput()` returned http error for
> `LAUNCH_NESTED_CONTAINER_SESSION` call, we didn't destroy the nested
> container. From the point of view of API user, if
> `LAUNCH_NESTED_CONTAINER_SESSION` returns an error, then no nested
> container should be in `RUNNING` state. This patch fixes the API
> issue by destroying a nested container on http errors and failures
> of `attachContainerOutput()`.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a 
> 
> 
> Diff: https://reviews.apache.org/r/65637/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64211/#review197422
---



PASS: Mesos patch 64211 was successfully built and tested.

Reviews applied: `['65584', '65585', '64211']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64211

- Mesos Reviewbot Windows


On Feb. 11, 2018, 3:27 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64211/
> ---
> 
> (Updated Feb. 11, 2018, 3:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> An update of the discarded review /r/52543.
> 
> Works with Autotools and CMake.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 
>   cmake/MesosConfigure.cmake 0954a9cd31fa290ff9099be4b06d69d96b701f1e 
>   configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507 
>   docs/configuration/cmake.md 1e34657ea55fa324f65f865f7d0a67084c6719d9 
>   src/CMakeLists.txt 21fb47e29dd0b19681690b8de5261c68b574a7c8 
>   src/Makefile.am 45f0480be0ccb9d9adf90a8a7468eb2dadc84151 
>   src/python/cli_new/CMakeLists.txt PRE-CREATION 
>   src/python/cli_new/tests/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64211/diff/7/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25.
> 
> For Autotools:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ ../configure --enable-new-cli --disable-java --disable-python
> $ make check
> ```
> 
> For CMake:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1
> $ cmake --build . -- -j16
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> `build/src/cli` was as expected, and that `build/src/mesos` was correctly 
> running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65637/#review197426
---


Ship it!




Ship It!

- Greg Mann


On Feb. 13, 2018, 3:52 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65637/
> ---
> 
> (Updated Feb. 13, 2018, 3:52 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8577
> https://issues.apache.org/jira/browse/MESOS-8577
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, if `attachContainerOutput()` returned http error for
> `LAUNCH_NESTED_CONTAINER_SESSION` call, we didn't destroy the nested
> container. From the point of view of API user, if
> `LAUNCH_NESTED_CONTAINER_SESSION` returns an error, then no nested
> container should be in `RUNNING` state. This patch fixes the API
> issue by destroying a nested container on http errors and failures
> of `attachContainerOutput()`.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a 
> 
> 
> Diff: https://reviews.apache.org/r/65637/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65571/
---

(Updated Feb. 13, 2018, 8:05 p.m.)


Review request for mesos, Andrei Budnik and Vinod Kone.


Bugs: MESOS-8550
https://issues.apache.org/jira/browse/MESOS-8550


Repository: mesos


Description
---

The function `MasterDetector::detect()` returns a value of type
`Future>`, which, according to its documentation,
can be `None` if an election occured and no master is elected.

However, the code in `Master::detected()` was only handling the
cases of a failed future or a valid `MasterInfo` object.


Diffs (updated)
-

  src/master/master.cpp d7d22866f7a4eb87bd8949efafc97e828e7d4b94 
  src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9 
  src/tests/master_tests.cpp 28663c7a77096943949350abb3d13f9c04505f5b 


Diff: https://reviews.apache.org/r/65571/diff/3/

Changes: https://reviews.apache.org/r/65571/diff/2-3/


Testing
---

`./mesos-tests`


Thanks,

Benno Evers

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

[Benno Evers]

> On Feb. 8, 2018, 8:22 p.m., Vinod Kone wrote:
> > src/master/master.cpp
> > Lines 2186 (patched)
> > 
> >
> > s/Leader detector indicated no master elected/No master was elected/
> > 
> > More importantly, this changes the semantics a bit. Previously if this 
> > master was the current leader it committed suicide even in this case. But 
> > we don't anymore. Is that what we want?
> > 
> > 
> > Also, where in the interface does it say that None() is retryable. It 
> > says retryable errors are handled internally by the detector?
> 
> Benno Evers wrote:
> Ok, I guess I misinterpreted the documentation on 
> `MasterDetector::detect()`:
> 
> ```
>* Returns MasterInfo after an election has occurred and the elected
>* master is different than that specified (if any), or NONE if an
>* election occurs and no master is elected (e.g., all masters are
>* lost). A failed future is returned if the detector is unable to
>* detect the leading master due to a non-retryable error.
> ```
> 
> Since electing no master sounds like an error, and the future is not 
> failed, I assumed that this case was implicitly classifid as retryable error.
> 
> Anyways, for the semantics I assume that not aborting is at least what 
> the original author intended, otherwise there would be no point to 
> differentiate between `Error` and `None` in the API.
> 
> Additionally, the code that causes the master to crash in this situation 
> was introduced relatively recently (11 July 2017, a8c7ae44c8), before that 
> the `detected()`-handler would have just set `leader` to `None` and quietly 
> continued. So I would argue that this fix is actually restoring the 
> previously existing behaviour, not changing it.
> 
> Vinod Kone wrote:
> "...before that the detected()-handler would have just set leader to None 
> and quietly continued". Is this true? AFAICT the commit you mentioned only 
> adds leader domain related changes, doesn't change the behavior we are 
> talking about? See: https://reviews.apache.org/r/59763/

Oh, sorry, I thought you were talking about the case where a non-leading master 
is passed `None`, which also would have crashed before this fix but doesn't 
crash anymore.

I've updated the code path to restore the suicide in the case where `None` is 
passed to a leading master.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65571/#review197103
---


On Feb. 13, 2018, 8:05 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65571/
> ---
> 
> (Updated Feb. 13, 2018, 8:05 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Vinod Kone.
> 
> 
> Bugs: MESOS-8550
> https://issues.apache.org/jira/browse/MESOS-8550
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The function `MasterDetector::detect()` returns a value of type
> `Future>`, which, according to its documentation,
> can be `None` if an election occured and no master is elected.
> 
> However, the code in `Master::detected()` was only handling the
> cases of a failed future or a valid `MasterInfo` object.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp d7d22866f7a4eb87bd8949efafc97e828e7d4b94 
>   src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9 
>   src/tests/master_tests.cpp 28663c7a77096943949350abb3d13f9c04505f5b 
> 
> 
> Diff: https://reviews.apache.org/r/65571/diff/3/
> 
> 
> Testing
> ---
> 
> `./mesos-tests`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65571/#review197430
---



PASS: Mesos patch 65571 was successfully built and tested.

Reviews applied: `['65571']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65571

- Mesos Reviewbot Windows


On Feb. 13, 2018, 8:05 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65571/
> ---
> 
> (Updated Feb. 13, 2018, 8:05 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Vinod Kone.
> 
> 
> Bugs: MESOS-8550
> https://issues.apache.org/jira/browse/MESOS-8550
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The function `MasterDetector::detect()` returns a value of type
> `Future>`, which, according to its documentation,
> can be `None` if an election occured and no master is elected.
> 
> However, the code in `Master::detected()` was only handling the
> cases of a failed future or a valid `MasterInfo` object.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp d7d22866f7a4eb87bd8949efafc97e828e7d4b94 
>   src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9 
>   src/tests/master_tests.cpp 28663c7a77096943949350abb3d13f9c04505f5b 
> 
> 
> Diff: https://reviews.apache.org/r/65571/diff/3/
> 
> 
> Testing
> ---
> 
> `./mesos-tests`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 52064: Support for multiple versions of docs.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52064/#review197432
---



Patch looks great!

Reviews applied: [52064]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 13, 2018, 3:44 p.m., Tim Anderegg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52064/
> ---
> 
> (Updated Feb. 13, 2018, 3:44 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-3011
> https://issues.apache.org/jira/browse/MESOS-3011
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the website build process to allow for documentation to be 
> generated for all versions of Mesos, based on the existing Git tags.  
> Additionally, the website is updated with a dropdown list of the available 
> versions of documentation.  If a user changes versions and the old version 
> does not have the current page, a notice will be displayed and the user 
> redirected to the home page for the desired version.
> 
> This is a temporary measure to "catchup" the documentation for the website by 
> generating docs for all previous versions.  Going forward, as each new 
> version of Mesos is released the documentation will be generated for that 
> version only.
> 
> ![Dropdown list of versions.](https://i.imgur.com/xvukEBGl.png)
> Screenshot of the dropdown list of versions.
> 
> ![404 Message](https://i.imgur.com/kqXNsxvl.png)
> Screenshot of the message displayed if a page does not exist for the selected 
> version.
> 
> 
> Diffs
> -
> 
>   site/Gemfile 877fe914a9787c140848fdf9958571fec5fa58ff 
>   site/Gemfile.lock 909f3f3badeaa47c80929e243ce36307766edee4 
>   site/Rakefile 31ef6ffe225ce7ddc573054058af1070b9e96b09 
>   site/config.rb 04bc7aa1e0ac61ce5d89fd53d32f265532996913 
>   site/data/releases.yml 56fd0fc7f5e34873c9b088778d77f9a6718a5933 
>   site/source/assets/js/versions.js PRE-CREATION 
>   site/source/layouts/basic.erb 8a07488940f3793d6fdd291dbe896e098f321c96 
> 
> 
> Diff: https://reviews.apache.org/r/52064/diff/7/
> 
> 
> Testing
> ---
> 
> Testing was done manually to verify that the documentation was built for each 
> version of Mesos that is supported (some older versions do not have 
> compatible documentation).
> 
> 
> Thanks,
> 
> Tim Anderegg
> 
>

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65571/#review197434
---




src/master/master.cpp
Lines 2182-2185 (patched)


Why do we need this case? What problem does it solve?


- Andrei Budnik


On Feb. 13, 2018, 8:05 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65571/
> ---
> 
> (Updated Feb. 13, 2018, 8:05 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Vinod Kone.
> 
> 
> Bugs: MESOS-8550
> https://issues.apache.org/jira/browse/MESOS-8550
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The function `MasterDetector::detect()` returns a value of type
> `Future>`, which, according to its documentation,
> can be `None` if an election occured and no master is elected.
> 
> However, the code in `Master::detected()` was only handling the
> cases of a failed future or a valid `MasterInfo` object.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp d7d22866f7a4eb87bd8949efafc97e828e7d4b94 
>   src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9 
>   src/tests/master_tests.cpp 28663c7a77096943949350abb3d13f9c04505f5b 
> 
> 
> Diff: https://reviews.apache.org/r/65571/diff/3/
> 
> 
> Testing
> ---
> 
> `./mesos-tests`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileTests`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65640/
---

Review request for mesos, Jie Yu and Joseph Wu.


Bugs: MESOS-8567
https://issues.apache.org/jira/browse/MESOS-8567


Repository: mesos


Description
---

There was a race between `Clock::advance()` in the `FetchFromHTTP` test
and `delay()` in `UriDiskProfileAdaptorProcess::_poll`. This patch
avoids the race by enforcing an order between the dispatch of the
`__poll` function (previously `_poll`) and the clock manipulation
in the test. It also fixed two memory leaks in the test.


Diffs
-

  src/Makefile.am 45f0480be0ccb9d9adf90a8a7468eb2dadc84151 
  src/resource_provider/storage/uri_disk_profile.hpp 
22e9d8bee0c82807c8b06ef65751496fcd880acf 
  src/resource_provider/storage/uri_disk_profile.cpp 
665798fdb085ea34f93bd287fe6f9ab29a265cbf 
  src/tests/disk_profile_tests.cpp 1bbbde0d026e8e7388d341746587913926002144 


Diff: https://reviews.apache.org/r/65640/diff/1/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65594/
---

(Updated Feb. 13, 2018, 10:18 p.m.)


Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.


Changes
---

Reverted to revision 1 to remove the best-effort non-decreasing watch logic.


Bugs: MESOS-8492
https://issues.apache.org/jira/browse/MESOS-8492


Repository: mesos


Description
---

SLRP now checkpoints profiles associated with storage pools, and no
longer assumes that profiles won't be removed by the disk profile
adaptor. It will reject volume/block creation requests that use
missing profiles, but existing volumes/blocks will continue to work.
When a volume/block with a missing profiles is destroyed, it will be
converted to an empty resource, and SLRP will update the sizes of
storage pools for currently known profiles.


Diffs (updated)
-

  src/resource_provider/state.proto 8577b58b8cdb63b3daddf06ea5d12f80f9d42f2b 
  src/resource_provider/storage/provider.cpp 
33abc0e05a804969ae14da9cb9c58698ba1aaea5 
  src/resource_provider/storage/uri_disk_profile.cpp 
665798fdb085ea34f93bd287fe6f9ab29a265cbf 


Diff: https://reviews.apache.org/r/65594/diff/3/

Changes: https://reviews.apache.org/r/65594/diff/2-3/


Testing
---

sudo make check

NOTE: This patch does not change the URI disk profile daptor to allow missing 
profiles from upstream. Will have another patch to address this.


Thanks,

Chun-Hung Hsiao

Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileTests`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65640/#review197439
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65594', '65640']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65640

Relevant logs:

- 
[mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65640/logs/mesos-tests-cmake-stdout.log):

```
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(2601):
 warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3091):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3426):
 warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
 warning C4716: 'pthread_cond_broadcast': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
 warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3

Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileTests`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65640/
---

(Updated Feb. 13, 2018, 11:14 p.m.)


Review request for mesos, Jie Yu and Joseph Wu.


Bugs: MESOS-8567
https://issues.apache.org/jira/browse/MESOS-8567


Repository: mesos


Description
---

There was a race between `Clock::advance()` in the `FetchFromHTTP` test
and `delay()` in `UriDiskProfileAdaptorProcess::_poll`. This patch
avoids the race by enforcing an order between the dispatch of the
`__poll` function (previously `_poll`) and the clock manipulation
in the test. It also fixed two memory leaks in the test.


Diffs (updated)
-

  src/Makefile.am 45f0480be0ccb9d9adf90a8a7468eb2dadc84151 
  src/resource_provider/storage/uri_disk_profile.hpp 
22e9d8bee0c82807c8b06ef65751496fcd880acf 
  src/resource_provider/storage/uri_disk_profile.cpp 
665798fdb085ea34f93bd287fe6f9ab29a265cbf 
  src/tests/disk_profile_tests.cpp 1bbbde0d026e8e7388d341746587913926002144 


Diff: https://reviews.apache.org/r/65640/diff/2/

Changes: https://reviews.apache.org/r/65640/diff/1-2/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileTests`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65640/#review197447
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65594', '65640']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65640

Relevant logs:

- 
[mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65640/logs/mesos-tests-cmake-stdout.log):

```
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(1751):
 warning C4133: 'function': incompatible types - from 'int *' to 'char *' 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(1989):
 warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(2601):
 warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3091):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3426):
 warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
 warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxpro

Re: Review Request 65626: Added mock method for `__run()` in mock slave.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65626/#review197461
---


Ship it!




Ship It!

- Greg Mann


On Feb. 13, 2018, 6:25 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65626/
> ---
> 
> (Updated Feb. 13, 2018, 6:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added mock method for `__run()` in mock slave.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39 
>   src/tests/mock_slave.hpp 942ead57fc67bdd2a268c67575952349838dc280 
>   src/tests/mock_slave.cpp 597d7abef20dd5f89b16e4616233f02760b9d037 
> 
> 
> Diff: https://reviews.apache.org/r/65626/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65570: Attached/detached volume directory for task which has volume specified.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/
---

(Updated Feb. 14, 2018, 11:09 a.m.)


Review request for mesos, Gilbert Song and Vinod Kone.


Changes
---

Added more comments to `attachTaskVolumeDirectory`.


Bugs: MESOS-8565
https://issues.apache.org/jira/browse/MESOS-8565


Repository: mesos


Description
---

Attached/detached volume directory for task which has volume specified.


Diffs (updated)
-

  src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39 
  src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5 


Diff: https://reviews.apache.org/r/65570/diff/4/

Changes: https://reviews.apache.org/r/65570/diff/3-4/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/#review197470
---


Fix it, then Ship it!





src/tests/slave_tests.cpp
Lines 4841 (patched)


Dispatch this in the slave's context.



src/tests/slave_tests.cpp
Lines 4852-4854 (patched)


These are not required since `exitedExecutorMessage` is processed 
synchronously in the master's context.



src/tests/slave_tests.cpp
Lines 4986 (patched)


Ditto.



src/tests/slave_tests.cpp
Lines 4997-4999 (patched)


Ditto.


- Chun-Hung Hsiao


On Feb. 13, 2018, 6:26 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65593/
> ---
> 
> (Updated Feb. 13, 2018, 6:26 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Theses tests ensure that agent sends ExitedExecutorMessage when the
> task group fails to launch due to unschedule GC failure and when
> the task fails to launch due to task authorization failure.
> So that master's executor bookkeeping entry is removed.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 
> 
> 
> Diff: https://reviews.apache.org/r/65593/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/
---

(Updated Feb. 13, 2018, 7:33 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-1720
https://issues.apache.org/jira/browse/MESOS-1720


Repository: mesos


Description
---

Theses tests ensure that agent sends ExitedExecutorMessage when the
task group fails to launch due to unschedule GC failure and when
the task fails to launch due to task authorization failure.
So that master's executor bookkeeping entry is removed.


Diffs (updated)
-

  src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 


Diff: https://reviews.apache.org/r/65593/diff/4/

Changes: https://reviews.apache.org/r/65593/diff/3-4/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65448/#review197475
---


Fix it, then Ship it!





src/tests/slave_tests.cpp
Lines 4673 (patched)


Dispatch this into the slave's context to avoid races.



src/tests/slave_tests.cpp
Lines 4686-4688 (patched)


This is not required.


- Chun-Hung Hsiao


On Feb. 1, 2018, 2:04 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65448/
> ---
> 
> (Updated Feb. 1, 2018, 2:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test ensures that agent send exited executor message when the
> executor is never launched. So that master's executor bookkeeping
> entry is removed. See MESOS-1720.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp b54688add9949b9c4ac2ce3a42503a411e6da09f 
> 
> 
> Diff: https://reviews.apache.org/r/65448/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/#review197476
---



PASS: Mesos patch 65593 was successfully built and tested.

Reviews applied: `['65445', '65504', '65446', '65449', '65448', '65626', 
'65593']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65593

- Mesos Reviewbot Windows


On Feb. 14, 2018, 3:33 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65593/
> ---
> 
> (Updated Feb. 14, 2018, 3:33 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Theses tests ensure that agent sends ExitedExecutorMessage when the
> task group fails to launch due to unschedule GC failure and when
> the task fails to launch due to task authorization failure.
> So that master's executor bookkeeping entry is removed.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 
> 
> 
> Diff: https://reviews.apache.org/r/65593/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65593/#review197478
---



Patch looks great!

Reviews applied: [65445, 65504, 65446, 65449, 65448, 65626, 65593]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 14, 2018, 3:33 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65593/
> ---
> 
> (Updated Feb. 14, 2018, 3:33 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
> https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Theses tests ensure that agent sends ExitedExecutorMessage when the
> task group fails to launch due to unschedule GC failure and when
> the task fails to launch due to task authorization failure.
> So that master's executor bookkeeping entry is removed.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 
> 
> 
> Diff: https://reviews.apache.org/r/65593/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>