[GitHub] spark pull request: [SPARK-12199][DOC] Follow-up: Refine example c...

[yinxusen]

GitHub user yinxusen opened a pull request:

https://github.com/apache/spark/pull/10193

[SPARK-12199][DOC] Follow-up: Refine example code in ml-features.md

https://issues.apache.org/jira/browse/SPARK-12199

Follow-up PR of SPARK-11551. Fix some errors in ml-features.md

@mengxr 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yinxusen/spark SPARK-12199

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10193


commit 58488819e8ea34cd1112c9914a4479941f9ca0ae
Author: Xusen Yin 
Date:   2015-12-08T08:07:40Z

fix errors in markdown




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of predicates ...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10163#issuecomment-162833074
  
ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11605] [MLlib] ML 1.6 QA: API: Java com...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10102#issuecomment-162808918
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47320/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12198] [SparkR] SparkR support read.par...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10191#issuecomment-162808905
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47319/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12198] [SparkR] SparkR support read.par...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10191#issuecomment-162808902
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10393] use ML pipeline in LDA example

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/8551#issuecomment-162815826
  
**[Test build #47324 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47324/consoleFull)**
 for PR 8551 at commit 
[`672ce97`](https://github.com/apache/spark/commit/672ce97892c974994630527e0e724090b3ac52e5).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11652] [CORE] Remote code execution wit...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/9731#issuecomment-162823368
  
@XuTingjun commons-collections? just search Maven Central

http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22commons-collections%22%20AND%20a%3A%22commons-collections%22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12146] [SparkR] SparkR jsonFile should ...

[sun-rui]

Github user sun-rui commented on the pull request:

https://github.com/apache/spark/pull/10145#issuecomment-162807690
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MESOS]Add documentation about submitting Spar...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10086#issuecomment-162807762
  
**[Test build #47318 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47318/consoleFull)**
 for PR 10086 at commit 
[`952f116`](https://github.com/apache/spark/commit/952f1163254eddf1a3dd0b36761a7f7f0978964f).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:\n  * `If 
you like to run the MesosClusterDispatcher with Marathon, you need to run the 
MesosClusterDispatcher in the foreground (i.e: `bin/spark-class 
org.apache.spark.deploy.mesos.MesosClusterDispatcher`).`\n


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MESOS]Add documentation about submitting Spar...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10086#issuecomment-162807869
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12196][Core]Store blocks in storage dev...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10192#issuecomment-162807721
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11605] [MLlib] ML 1.6 QA: API: Java com...

[hhbyyh]

Github user hhbyyh commented on the pull request:

https://github.com/apache/spark/pull/10102#issuecomment-162810065
  
hudson.plugins.git.GitException: Failed to fetch from 
https://github.com/apache/spark.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:763)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1012)

need a retest


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11605] [MLlib] ML 1.6 QA: API: Java com...

[hhbyyh]

Github user hhbyyh commented on the pull request:

https://github.com/apache/spark/pull/10102#issuecomment-162810114
  
@jkbradley Thanks for the review. Updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12199][DOC] Follow-up: Refine example c...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10193#issuecomment-162812075
  
**[Test build #47322 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47322/consoleFull)**
 for PR 10193 at commit 
[`5848881`](https://github.com/apache/spark/commit/58488819e8ea34cd1112c9914a4479941f9ca0ae).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...

[taishi-oss]

Github user taishi-oss commented on the pull request:

https://github.com/apache/spark/pull/8534#issuecomment-162819270
  
Thank you for merging!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12201][SQL] add type coercion rule for ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10196#issuecomment-162824060
  
**[Test build #47325 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47325/consoleFull)**
 for PR 10196 at commit 
[`2081673`](https://github.com/apache/spark/commit/20816739decd6361c9fc65452a1415b065e08b9c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-12200 Add __contains__ implementation to...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10194#issuecomment-162811154
  
Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12198] [SparkR] SparkR support read.par...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10191#issuecomment-162811255
  
**[Test build #47321 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47321/consoleFull)**
 for PR 10191 at commit 
[`e507c31`](https://github.com/apache/spark/commit/e507c31385730af2de663497d88df42c33f6ac46).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MESOS]Add documentation about submitting Spar...

[dragos]

Github user dragos commented on the pull request:

https://github.com/apache/spark/pull/10086#issuecomment-162818586
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12201][SQL] add type coercion rule for ...

[cloud-fan]

GitHub user cloud-fan opened a pull request:

https://github.com/apache/spark/pull/10196

[SPARK-12201][SQL] add type coercion rule for greatest/least

checked with hive, greatest/least should cast their children to a tightest 
common type,
i.e. `(int, long) => long`, `(int, string) => error`, `(decimal(10,5), 
decimal(5, 10)) => error`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloud-fan/spark type-coercion

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10196


commit 20816739decd6361c9fc65452a1415b065e08b9c
Author: Wenchen Fan 
Date:   2015-12-08T08:57:51Z

add type coercion rule for greatest/least




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10393] use ML pipeline in LDA example

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8551#issuecomment-162822103
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47324/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11652] [CORE] Remote code execution wit...

[XuTingjun]

Github user XuTingjun commented on the pull request:

https://github.com/apache/spark/pull/9731#issuecomment-162828252
  
ok, please fix it as soon as possible, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11399] Add label support in include_exa...

[yinxusen]

Github user yinxusen commented on the pull request:

https://github.com/apache/spark/pull/9430#issuecomment-162828169
  
@mengxr Until now, all docs of ML and MLlib packages are substituted with 
`include_example` except for the `DataTypes`, `mllib-linear-methods` and 
`BasicStatistics` pages. As we talked before, these three files are dependent 
on this PR.

Shall we merge this PR so that we can modify all docs before v1.6? Or we 
defer it to v1.7?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12136] [STREAMING] rddToFileName does n...

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/10185#discussion_r46931863
  
--- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -892,12 +892,14 @@ object StreamingContext extends Logging {
   }
 
   private[streaming] def rddToFileName[T](prefix: String, suffix: String, 
time: Time): String = {
-if (prefix == null) {
-  time.milliseconds.toString
-} else if (suffix == null || suffix.length ==0) {
-  prefix + "-" + time.milliseconds
-} else {
-  prefix + "-" + time.milliseconds + "." + suffix
+var result = new StringBuilder()
+if (prefix != null && prefix.length > 0) {
+  result = result.append(prefix).append("-")
+}
+result = result.append(time.milliseconds)
+if (suffix != null && suffix.length > 0) {
+  result = result.append(".").append(suffix)
 }
+result.toString()
--- End diff --

I think it's fine; it might be simpler without bothering with 
`StringBuilder` but not by much.
(In your code you should use `val result` and you do not need to assign 
`result` each time.)

```
var result = time.milliseconds.toString
if (prefix != null && prefix.length > 0) {
  result = prefix + "-" result
}
if (suffix != null && suffix.length > 0) {
  result = result + "." + suffix
}
result
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of predicates ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10163#issuecomment-162834474
  
**[Test build #47328 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47328/consoleFull)**
 for PR 10163 at commit 
[`da46b1c`](https://github.com/apache/spark/commit/da46b1ca928a2f9c8cd910812de67aa36214c672).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12198] [SparkR] SparkR support read.par...

[sun-rui]

Github user sun-rui commented on the pull request:

https://github.com/apache/spark/pull/10191#issuecomment-162807338
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12198] [SparkR] SparkR support read.par...

[yanboliang]

Github user yanboliang commented on the pull request:

https://github.com/apache/spark/pull/10191#issuecomment-162809281
  
Jenkins, test this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12199][DOC] Follow-up: Refine example c...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10193#issuecomment-162814634
  
**[Test build #47322 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47322/consoleFull)**
 for PR 10193 at commit 
[`5848881`](https://github.com/apache/spark/commit/58488819e8ea34cd1112c9914a4479941f9ca0ae).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12198] [SparkR] SparkR support read.par...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10191#issuecomment-162814926
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47321/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12199][DOC] Follow-up: Refine example c...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10193#issuecomment-162814748
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47322/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11652] [CORE] Remote code execution wit...

[XuTingjun]

Github user XuTingjun commented on the pull request:

https://github.com/apache/spark/pull/9731#issuecomment-162814698
  
@srowen I can't find this jar file, can you give me a download url?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12198] [SparkR] SparkR support read.par...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10191#issuecomment-162814801
  
**[Test build #47321 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47321/consoleFull)**
 for PR 10191 at commit 
[`e507c31`](https://github.com/apache/spark/commit/e507c31385730af2de663497d88df42c33f6ac46).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12199][DOC] Follow-up: Refine example c...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10193#issuecomment-162814745
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11652] [CORE] Remote code execution wit...

[XuTingjun]

Github user XuTingjun commented on the pull request:

https://github.com/apache/spark/pull/9731#issuecomment-162819273
  
@srowen I only find below commons-collection file:
```
commons-collections
  commons-collections
  3.2.2
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8546] Add PMML export for Naive Bayes

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9057#issuecomment-162831905
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8546] Add PMML export for Naive Bayes

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9057#issuecomment-162831907
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47326/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8546] Add PMML export for Naive Bayes

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9057#issuecomment-162831899
  
**[Test build #47326 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47326/consoleFull)**
 for PR 9057 at commit 
[`5a89d9d`](https://github.com/apache/spark/commit/5a89d9dd5af22b08365efb70512932fd8cbf896d).
 * This patch **fails to build**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10123][Deploy] Support specifying deplo...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10195#issuecomment-162814625
  
**[Test build #47323 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47323/consoleFull)**
 for PR 10195 at commit 
[`7123967`](https://github.com/apache/spark/commit/7123967f032ecebaca813c13b24be5a1e803427e).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10393] use ML pipeline in LDA example

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/8551#issuecomment-162822008
  
**[Test build #47324 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47324/consoleFull)**
 for PR 8551 at commit 
[`672ce97`](https://github.com/apache/spark/commit/672ce97892c974994630527e0e724090b3ac52e5).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12201][SQL] add type coercion rule for ...

[cloud-fan]

Github user cloud-fan commented on the pull request:

https://github.com/apache/spark/pull/10196#issuecomment-162822122
  
cc @marmbrus @yhuai 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10393] use ML pipeline in LDA example

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/8551#issuecomment-162822102
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8546] Add PMML export for Naive Bayes

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9057#issuecomment-162830886
  
**[Test build #47326 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47326/consoleFull)**
 for PR 9057 at commit 
[`5a89d9d`](https://github.com/apache/spark/commit/5a89d9dd5af22b08365efb70512932fd8cbf896d).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11399] Add label support in include_exa...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9430#issuecomment-162833578
  
**[Test build #47327 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47327/consoleFull)**
 for PR 9430 at commit 
[`3c6ddd8`](https://github.com/apache/spark/commit/3c6ddd881ccd9dcf41551bcc59a246c095b21222).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [MESOS]Add documentation about submitting Spar...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10086#issuecomment-162807873
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47318/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: SPARK-12200 Add __contains__ implementation to...

[maver1ck]

GitHub user maver1ck opened a pull request:

https://github.com/apache/spark/pull/10194

SPARK-12200 Add __contains__ implementation to Row

__contains__ implementation to Row and tests
https://issues.apache.org/jira/browse/SPARK-12200

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maver1ck/spark master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10194


commit 70bfaefb284673e8d378874fdc12369298c71ea6
Author: Maciej Brynski 
Date:   2015-12-08T08:17:46Z

SPARK-12200 Add __contains__ implementation to Row




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10393] use ML pipeline in LDA example

[hhbyyh]

Github user hhbyyh commented on the pull request:

https://github.com/apache/spark/pull/8551#issuecomment-162812998
  
Thanks @jkbradley @BenFradet for the review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11652] [CORE] Remote code execution wit...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/9731#issuecomment-162825724
  
Oh dang it, yes the group is only `org.apache.commons` in version 4. Right 
now this does nothing. PR coming ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12198] [SparkR] SparkR support read.par...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10191#issuecomment-162814924
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11605] [MLlib] ML 1.6 QA: API: Java com...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10102#issuecomment-162808916
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12153][MLlib]add support of arbitrary l...

[ygcao]

Github user ygcao commented on a diff in the pull request:

https://github.com/apache/spark/pull/10152#discussion_r46925097
  
--- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -281,16 +280,17 @@ class Word2Vec extends Serializable with Logging {
 val expTable = sc.broadcast(createExpTable())
 val bcVocab = sc.broadcast(vocab)
 val bcVocabHash = sc.broadcast(vocabHash)
-
-val sentences: RDD[Array[Int]] = words.mapPartitions { iter =>
+//each partition is a collection of sentences, will be translated into 
arrays of Index integer
+val sentences: RDD[Array[Int]] = dataset.mapPartitions { iter =>
--- End diff --

Agreed. Will do.
Btw: the usage of maxsentencelenth in  the python code is different than 
the original mllib word2vec. It's actually respect sentence structure on 
condition that it's shorter than the max allowance, which is a mixture of my 
change with the adress of @srowen too long sentence concern. But as you 
mentioned and I mentioned below, the too long sentence should not be a concern 
in normal situation. The only exception I can think of is to use a poor 
sentence splitter plus using concatenated large portion of a big corpus as one 
individual document in the input.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10123][Deploy] Support specifying deplo...

[jerryshao]

GitHub user jerryshao opened a pull request:

https://github.com/apache/spark/pull/10195

[SPARK-10123][Deploy] Support specifying deploy mode from configuration

Please help to review, thanks a lot.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jerryshao/apache-spark SPARK-10123

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10195


commit 7123967f032ecebaca813c13b24be5a1e803427e
Author: jerryshao 
Date:   2015-12-08T08:30:30Z

Add configuration option to support specifying deploy mode through conf




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11652] [CORE] Remote code execution wit...

[XuTingjun]

Github user XuTingjun commented on the pull request:

https://github.com/apache/spark/pull/9731#issuecomment-162824623
  
I think the groupId should be "commons-collections", not 
"org.apache.commons", right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of predicates ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10163#issuecomment-162834720
  
**[Test build #47328 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47328/consoleFull)**
 for PR 10163 at commit 
[`da46b1c`](https://github.com/apache/spark/commit/da46b1ca928a2f9c8cd910812de67aa36214c672).
 * This patch **fails Scala style tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:\n  * 
`abstract class LogicalPlan extends QueryPlan[LogicalPlan] with PredicateHelper 
with Logging `\n


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of predicates ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10163#issuecomment-162834724
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12161][SQL] Ignore order of predicates ...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10163#issuecomment-162834726
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47328/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11399] Add label support in include_exa...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9430#issuecomment-162837063
  
**[Test build #47327 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47327/consoleFull)**
 for PR 9430 at commit 
[`3c6ddd8`](https://github.com/apache/spark/commit/3c6ddd881ccd9dcf41551bcc59a246c095b21222).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12166][TEST] Unset hadoop related envir...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10172


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11439][ML] Optimization of creating spa...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/9756#issuecomment-162851874
  
Merged to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12156] Make SPARK_EXECUTOR_INSTANCES be...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/10157#issuecomment-162853865
  
@KaiXinXiaoLei do you mind closing this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11551][DOC][EXAMPLE] Revert PR #10002

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10200


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8546] Add PMML export for Naive Bayes

[yinxusen]

Github user yinxusen commented on the pull request:

https://github.com/apache/spark/pull/9057#issuecomment-162856962
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/9940#issuecomment-162839835
  
@viirya Thanks for your efforts! Would you mind me revisiting this after 
1.6 release? I would like see whether we can have PARQUET-389 fixed in Parquet 
community ASAP, so that we may not need to work around it in Spark 1.7/2.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

[JoshRosen]

Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/10002#issuecomment-162841634
  
Looks like this broke the Python style tests:

```
PEP8 checks failed.
./examples/src/main/python/ml/binarizer_example.py:41:4: E114 indentation 
is not a multiple of four (comment)
./examples/src/main/python/ml/onehot_encoder_example.py:39:1: W293 blank 
line contains whitespace
./examples/src/main/python/ml/pca_example.py:33:9: E128 continuation line 
under-indented for visual indent
./examples/src/main/python/ml/pca_example.py:35:41: E231 missing whitespace 
after ','
./examples/src/main/python/ml/polynomial_expansion_example.py:34:9: E128 
continuation line under-indented for visual indent
./examples/src/main/python/ml/polynomial_expansion_example.py:35:9: E128 
continuation line under-indented for visual indent
```

I guess that Jenkins never tested this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11652] [CORE] Remote code execution wit...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10198#issuecomment-162853197
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47331/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11652] [CORE] Remote code execution wit...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10198#issuecomment-162853196
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Revert PR #10002 "[SPARK-11551][DOC][EXAMPLE] ...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10200#issuecomment-162853092
  
I'm merging this to bring back master build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10299][ML] word2vec should allow users ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/8513#issuecomment-162874704
  
**[Test build #2182 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2182/consoleFull)**
 for PR 8513 at commit 
[`c125c3b`](https://github.com/apache/spark/commit/c125c3bfd725a6668cca13d43f8c85af9a25ba38).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11399] Add label support in include_exa...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9430#issuecomment-162837178
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12203][STREAMING] Add KafkaDirectInputD...

[viirya]

GitHub user viirya opened a pull request:

https://github.com/apache/spark/pull/10197

[SPARK-12203][STREAMING] Add KafkaDirectInputDStream

JIRA: https://issues.apache.org/jira/browse/SPARK-12203

Currently, we have DirectKafkaInputDStream, which directly pulls messages 
from Kafka Brokers without any receivers, and KafkaInputDStream, which pulls 
messages from a Kafka Broker using receiver with zookeeper.

As we observed, because DirectKafkaInputDStream retrieves messages from 
Kafka after each batch finishes, it posts a latency compared with 
KafkaInputDStream that continues to pull messages during each batch window.

So we try to add KafkaDirectInputDStream that directly pulls messages from 
Kafka Brokers as DirectKafkaInputDStream, but it uses receivers as 
KafkaInputDStream and pulls messages as blocks during each batch window.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/viirya/spark-1 kafka-direct-receiver

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10197


commit 43351d134d007769f36b097601d46eb1cba62715
Author: Liang-Chi Hsieh 
Date:   2015-12-08T09:43:57Z

Add KafkaDirectInputDStream.

commit 3e3e1b821093e4cdf120493d22d2ce0d517f5263
Author: Liang-Chi Hsieh 
Date:   2015-12-08T09:58:23Z

Remove unnecessary spaces.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12203][STREAMING] Add KafkaDirectInputD...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10197#issuecomment-162840627
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12203][STREAMING] Add KafkaDirectInputD...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10197#issuecomment-162840628
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47329/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12203][STREAMING] Add KafkaDirectInputD...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10197#issuecomment-162840624
  
**[Test build #47329 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47329/consoleFull)**
 for PR 10197 at commit 
[`3e3e1b8`](https://github.com/apache/spark/commit/3e3e1b821093e4cdf120493d22d2ce0d517f5263).
 * This patch **fails Scala style tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:\n  * 
`public class JavaBinarizerExample `\n  * `public class JavaBucketizerExample 
`\n  * `public class JavaDCTExample `\n  * `public class 
JavaElementwiseProductExample `\n  * `public class JavaMinMaxScalerExample `\n  
* `public class JavaNGramExample `\n  * `public class JavaNormalizerExample `\n 
 * `public class JavaOneHotEncoderExample `\n  * `public class JavaPCAExample 
`\n  * `public class JavaPolynomialExpansionExample `\n  * `public class 
JavaRFormulaExample `\n  * `public class JavaSQLTransformerExample `\n  * 
`public class JavaStandardScalerExample `\n  * `public class 
JavaStopWordsRemoverExample `\n  * `public class JavaStringIndexerExample `\n  
* `public class JavaTokenizerExample `\n  * `public class 
JavaVectorAssemblerExample `\n  * `public class JavaVectorIndexerExample `\n  * 
`public class JavaVectorSlicerExample `\n  * `final class 
DecisionTreeClassifier @Since(\"1.4.0\") (`\n  * `final class GBTCl
 assifier @Since(\"1.4.0\") (`\n  * `class LogisticRegression @Since(\"1.2.0\") 
(`\n  * `class MultilayerPerceptronClassifier @Since(\"1.5.0\") (`\n  * `class 
NaiveBayes @Since(\"1.5.0\") (`\n  * `final class OneVsRest @Since(\"1.4.0\") 
(`\n  * `final class RandomForestClassifier @Since(\"1.4.0\") (`\n


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8546] Add PMML export for Naive Bayes

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9057#issuecomment-162860155
  
**[Test build #47334 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47334/consoleFull)**
 for PR 9057 at commit 
[`5a89d9d`](https://github.com/apache/spark/commit/5a89d9dd5af22b08365efb70512932fd8cbf896d).
 * This patch **fails to build**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-8546] Add PMML export for Naive Bayes

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9057#issuecomment-162860161
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47334/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11016] Move RoaringBitmap to explicit K...

[scwf]

Github user scwf commented on the pull request:

https://github.com/apache/spark/pull/9748#issuecomment-162860246
  
@davies here are some problems when deserialize for RoaringBitmap. see the 
examples below:
run this piece of code
```
import com.esotericsoftware.kryo.io.{Input => KryoInput, Output => 
KryoOutput}
import java.io.DataInput

class KryoInputDataInputBridge(input: KryoInput) extends DataInput {
  override def readLong(): Long = input.readLong()
  override def readChar(): Char = input.readChar()
  override def readFloat(): Float = input.readFloat()
  override def readByte(): Byte = input.readByte()
  override def readShort(): Short = input.readShort()
  override def readUTF(): String = input.readString() // readString in 
kryo does utf8
  override def readInt(): Int = input.readInt()
  override def readUnsignedShort(): Int = input.readShortUnsigned()
  override def skipBytes(n: Int): Int = input.skip(n.toLong).toInt
  override def readFully(b: Array[Byte]): Unit = input.read(b)
  override def readFully(b: Array[Byte], off: Int, len: Int): Unit = 
input.read(b, off, len)
  override def readLine(): String = throw new 
UnsupportedOperationException("readLine")
  override def readBoolean(): Boolean = input.readBoolean()
  override def readUnsignedByte(): Int = input.readByteUnsigned()
  override def readDouble(): Double = input.readDouble()
}

class KryoOutputDataOutputBridge(output: KryoOutput) extends DataOutput 
{
  override def writeFloat(v: Float): Unit = output.writeFloat(v)
  // There is no "readChars" counterpart, except maybe "readLine", 
which is not supported
  override def writeChars(s: String): Unit = throw new 
UnsupportedOperationException("writeChars")
  override def writeDouble(v: Double): Unit = output.writeDouble(v)
  override def writeUTF(s: String): Unit = output.writeString(s) // 
writeString in kryo does UTF8
  override def writeShort(v: Int): Unit = output.writeShort(v)
  override def writeInt(v: Int): Unit = output.writeInt(v)
  override def writeBoolean(v: Boolean): Unit = output.writeBoolean(v)
  override def write(b: Int): Unit = output.write(b)
  override def write(b: Array[Byte]): Unit = output.write(b)
  override def write(b: Array[Byte], off: Int, len: Int): Unit = 
output.write(b, off, len)
  override def writeBytes(s: String): Unit = output.writeString(s)
  override def writeChar(v: Int): Unit = output.writeChar(v.toChar)
  override def writeLong(v: Long): Unit = output.writeLong(v)
  override def writeByte(v: Int): Unit = output.writeByte(v)
}
val outStream = new FileOutputStream("D:\\wfserde")
val output = new KryoOutput(outStream)
val bitmap = new RoaringBitmap
bitmap.add(1)
bitmap.add(3)
bitmap.add(5)
bitmap.serialize(new KryoOutputDataOutputBridge(output))
output.flush()
output.close()

val inStream = new FileInputStream("D:\\wfserde")
val input = new KryoInput(inStream)
val ret = new RoaringBitmap
ret.deserialize(new KryoInputDataInputBridge(input))

println(ret)
```

this will throw `Buffer underflow` error:
```
com.esotericsoftware.kryo.KryoException: Buffer underflow.
at com.esotericsoftware.kryo.io.Input.require(Input.java:156)
at com.esotericsoftware.kryo.io.Input.skip(Input.java:131)
at com.esotericsoftware.kryo.io.Input.skip(Input.java:264)
at 
org.apache.spark.sql.SQLQuerySuite$$anonfun$6$KryoInputDataInputBridge$1.skipBytes
```

after same investigation,  i found this is caused by a bug of kryo's 
`Input.skip(long count)`(https://github.com/EsotericSoftware/kryo/issues/119) 
and we call this method in `KryoInputDataInputBridge`.

So i think we can fix this issue in this two ways:
1) upgrade the kryo version to 2.23.0 or 2.24.0, which has fix this bug in 
kryo (i am not sure the upgrade is safe in spark, can you check it? @davies )

2) we can bypass the  kryo's `Input.skip(long count)` by directly call 
another `skip` method in kryo's 
Input.java(https://github.com/EsotericSoftware/kryo/blob/kryo-2.21/src/com/esotericsoftware/kryo/io/Input.java#L124),
 i.e. write the bug-fixed version of `Input.skip(long count)` in 
KryoInputDataInputBridge's `skipBytes` method:
```
   class KryoInputDataInputBridge(input: KryoInput) extends DataInput {
  ...
  override def skipBytes(n: Int): Int = {
var remaining: Long = n
while (remaining > 0) {
  val skip = Math.min(Integer.MAX_VALUE, 
remaining).asInstanceOf[Int]
  input.skip(skip)
  remaining -= skip
}
n

[GitHub] spark pull request: [SPARK-8546] Add PMML export for Naive Bayes

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9057#issuecomment-162860159
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12204][SPARKR] Implement drop method fo...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10201#issuecomment-162864236
  
**[Test build #47335 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47335/consoleFull)**
 for PR 10201 at commit 
[`e4372d6`](https://github.com/apache/spark/commit/e4372d60e0c8ac8f7bf1c84c7467a10e08f004dc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12031][Core][BUG]: Integer overflow whe...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10023#issuecomment-162864287
  
**[Test build #2181 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2181/consoleFull)**
 for PR 10023 at commit 
[`3cafda5`](https://github.com/apache/spark/commit/3cafda5294c382f06d816bb2479db2e16d9bd6dc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12136] [STREAMING] rddToFileName does n...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10185#issuecomment-162837577
  
**[Test build #2179 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2179/consoleFull)**
 for PR 10185 at commit 
[`21d7bcd`](https://github.com/apache/spark/commit/21d7bcd6975140731a85204681829eaa827cc403).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10002#issuecomment-162842512
  
Reverting this one to bring back Spark builds.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12166][TEST] Unset hadoop related envir...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/10172#issuecomment-162851366
  
Merged to master/1.6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

[viirya]

Github user viirya commented on the pull request:

https://github.com/apache/spark/pull/9565#issuecomment-162852487
  
Don't know why it fails on Jenkins but passes on local.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12202][REPL] Parse Scala command line a...

[dragos]

Github user dragos commented on the pull request:

https://github.com/apache/spark/pull/10199#issuecomment-162856000
  
Spurious failure:

```
ERROR: Timeout after 15 minutes
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://github.com/apache/spark.git
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12195] [SQL] Adding BigDecimal, Date an...

[cloud-fan]

Github user cloud-fan commented on the pull request:

https://github.com/apache/spark/pull/10188#issuecomment-162857586
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12204][SPARKR] Implement drop method fo...

[sun-rui]

GitHub user sun-rui opened a pull request:

https://github.com/apache/spark/pull/10201

[SPARK-12204][SPARKR] Implement drop method for DataFrame in SparkR.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sun-rui/spark SPARK-12204

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10201.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10201


commit e4372d60e0c8ac8f7bf1c84c7467a10e08f004dc
Author: Sun Rui 
Date:   2015-12-08T12:09:14Z

[SPARK-12204][SPARKR] Implement drop method for DataFrame in SparkR.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12204][SPARKR] Implement drop method fo...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10201#issuecomment-162867871
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

[yinxusen]

Github user yinxusen commented on the pull request:

https://github.com/apache/spark/pull/10002#issuecomment-162848273
  
Sorry for that, I will help fixing them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12103][Streaming][Kafka][Doc] document ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10132


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11652] [CORE] Remote code execution wit...

[XuTingjun]

Github user XuTingjun commented on the pull request:

https://github.com/apache/spark/pull/10198#issuecomment-162851296
  
LGTM, thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: Revert PR #10002 "[SPARK-11551][DOC][EXAMPLE] ...

[liancheng]

GitHub user liancheng opened a pull request:

https://github.com/apache/spark/pull/10200

Revert PR #10002 "[SPARK-11551][DOC][EXAMPLE] Replace example code in 
ml-features.md using include_example"

This reverts PR #10002, commit 78209b0ccaf3f22b5e2345dfb2b98edfdb746819.

The original PR wasn't tested on Jenkins before being merged.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liancheng/spark revert-pr-10002

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10200


commit 425c8b3970330db538228cab18ce1072486e7724
Author: Cheng Lian 
Date:   2015-12-08T11:14:13Z

Revert "[SPARK-11551][DOC][EXAMPLE] Replace example code in ml-features.md 
using include_example"

This reverts commit 78209b0ccaf3f22b5e2345dfb2b98edfdb746819.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11551][DOC][Example]Replace example cod...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10002#issuecomment-162854335
  
Hit some network issue, just reverted this PR from master and branch-1.6 in 
#10200.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11551][DOC][EXAMPLE] Revert PR #10002

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10200#issuecomment-162854179
  
Merged to master and branch-1.6.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12204][SPARKR] Implement drop method fo...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10201#issuecomment-162867660
  
**[Test build #47335 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47335/consoleFull)**
 for PR 10201 at commit 
[`e4372d6`](https://github.com/apache/spark/commit/e4372d60e0c8ac8f7bf1c84c7467a10e08f004dc).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12204][SPARKR] Implement drop method fo...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10201#issuecomment-162867873
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47335/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9565#issuecomment-162842862
  
**[Test build #47330 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47330/consoleFull)**
 for PR 9565 at commit 
[`1ca2efc`](https://github.com/apache/spark/commit/1ca2efcaa2eb511a398b5db67dee5f340a524de2).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10123][Deploy] Support specifying deplo...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10195#issuecomment-162842765
  
**[Test build #47323 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47323/consoleFull)**
 for PR 10195 at commit 
[`7123967`](https://github.com/apache/spark/commit/7123967f032ecebaca813c13b24be5a1e803427e).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11955][SQL] Mark optional fields in mer...

[viirya]

Github user viirya commented on the pull request:

https://github.com/apache/spark/pull/9940#issuecomment-162843069
  
@liancheng Sure. Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10123][Deploy] Support specifying deplo...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10195#issuecomment-162842895
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47323/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10123][Deploy] Support specifying deplo...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10195#issuecomment-162842892
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11551][DOC][EXAMPLE] Revert PR #10002

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10200#issuecomment-162856544
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47333/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org