[GitHub] spark pull request: [SPARK-12438][SQL] hiveContext.table() throws ...

[marmbrus]

Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/10529#issuecomment-168152257
  
OK to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-4819] [WIP] Remove Guava's "Optional" f...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10513#issuecomment-168158630
  
If we are creating our own Optional, why don't we also support all the 
methods available on Guava, so we only need to break "import" compatibility?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10390#issuecomment-168150125
  
**[Test build #48547 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48547/consoleFull)**
 for PR 10390 at commit 
[`72446f1`](https://github.com/apache/spark/commit/72446f15ca26f2ea0570d01368756fed759a89fb).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168154343
  
**[Test build #48549 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48549/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-4819] [WIP] Remove Guava's "Optional" f...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/10513#issuecomment-168158788
  
My theory was that it makes it more compatible with Java 8 Optional. Later, 
moving to its implementation is a smaller change. We're taking the bigger 
change now. Or at least that was the motivation.

Another possibility is to add the Guava work-alike methods and deprecate 
them. Later they'd be removed I guess when Java 8 Optional gets used. I liked 
that less since it still just half of the breaking change farther down the 
road, when a major release seems like the time to do as much of the breaking as 
possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [Spark-10625] [SQL] Spark SQL JDBC read/write ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/8785#issuecomment-168148505
  
**[Test build #2280 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2280/consoleFull)**
 for PR 8785 at commit 
[`f6c0fde`](https://github.com/apache/spark/commit/f6c0fdeb839b43d9009d61187cb052f274ab11d2).
 * This patch **fails to build**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12039][SQL] Re-enable HiveSparkSubmitSu...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10533#issuecomment-168157967
  
I've merged this.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-5673] [MLlib] Implement Streaming wrapp...

[catap]

Github user catap commented on the pull request:

https://github.com/apache/spark/pull/4456#issuecomment-168152178
  
@rxin, ok, I will


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-4226][SQL]Add subquery (not) in/exists ...

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/9055#issuecomment-168152168
  
Found a related HIVE JIRA to support the left anti join: 
https://issues.apache.org/jira/browse/HIVE-12519 

However, their proposed solution has a hole. Anyway, if we can support the 
anti join at the run time, it is much efficient.  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12461] [SQL] Add ExpressionDescription ...

[vectorijk]

Github user vectorijk commented on a diff in the pull request:

https://github.com/apache/spark/pull/10489#discussion_r48650445
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
 ---
@@ -279,6 +330,9 @@ object Factorial {
   )
 }
 
+@ExpressionDescription(
+  usage = "_FUNC_(value) - Returns Factorial of the number",
--- End diff --

Thanks @rxin! I have updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10459#issuecomment-168148715
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48545/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10459#issuecomment-168148675
  
**[Test build #48545 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48545/consoleFull)**
 for PR 10459 at commit 
[`1aa9728`](https://github.com/apache/spark/commit/1aa9728bc238ebc69545b06b794127dc4a09e958).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10459#issuecomment-168148714
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12363][Mllib] Remove setRun and fix Pow...

[viirya]

Github user viirya commented on the pull request:

https://github.com/apache/spark/pull/10539#issuecomment-168149596
  
@yanboliang Because that test doesn't fail so this commit doesn't set 
`TripletFields.All`  there. However, I tried it and it also passes the test. Do 
you think we should set it also?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10390#issuecomment-168153873
  
**[Test build #48548 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48548/consoleFull)**
 for PR 10390 at commit 
[`62fa738`](https://github.com/apache/spark/commit/62fa738dca9e7848156772ec99d5f956622321d9).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-6724] [MLlib] Support model save/load f...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9267#issuecomment-168150628
  
**[Test build #48546 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48546/consoleFull)**
 for PR 9267 at commit 
[`7381b31`](https://github.com/apache/spark/commit/7381b31661df242b04f0d4151ea923e5b3fe3120).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10390#issuecomment-168150652
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10390#issuecomment-168150653
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48547/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12363][Mllib] Remove setRun and fix Pow...

[yanboliang]

Github user yanboliang commented on the pull request:

https://github.com/apache/spark/pull/10539#issuecomment-168150722
  
@viirya I'm not very familiar with GraphX and I just found they are do the 
same thing for different interface. Maybe we can hear others' opinions. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-6724] [MLlib] Support model save/load f...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9267#issuecomment-168150715
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48546/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-6724] [MLlib] Support model save/load f...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9267#issuecomment-168150714
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10390#issuecomment-168150645
  
**[Test build #48547 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48547/consoleFull)**
 for PR 10390 at commit 
[`72446f1`](https://github.com/apache/spark/commit/72446f15ca26f2ea0570d01368756fed759a89fb).
 * This patch **fails to build**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-3873] [streaming] Import order fixes fo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10532


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] hiveContext.table() throws ...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/10529#discussion_r48651665
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
 ---
@@ -104,7 +104,7 @@ class SimpleCatalog(val conf: CatalystConf) extends 
Catalog {
 val tableName = getTableName(tableIdent)
 val table = tables.get(tableName)
 if (table == null) {
-  throw new NoSuchTableException
+  throw new AnalysisException("The table named "+tableName+" was not 
found.")
--- End diff --

this will fail style checker. you will need to add a space before and after 
+.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12039][SQL] Re-enable HiveSparkSubmitSu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/10533


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-3873] [streaming] Import order fixes fo...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10532#issuecomment-168158419
  
I've merged this.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10459#issuecomment-168148942
  
I've merged it. Thanks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][TEST] Don't mute Spark logg...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10540#issuecomment-168181589
  
**[Test build #48551 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48551/consoleFull)**
 for PR 10540 at commit 
[`7d6e0e5`](https://github.com/apache/spark/commit/7d6e0e5c340c8ac4d4fc49b503adfb84eaa6cc5d).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168184217
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48553/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168184213
  
**[Test build #48553 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48553/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).
 * This patch **fails build dependency tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168184215
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][TEST] Don't mute Spark logg...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10540#issuecomment-168192401
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168194460
  
@JoshRosen these builds fail often and non-deterministically with a **fails 
build dependency** tests. The problem is that I cannot find the cause of this 
problem (the build fails with no helpfull message), these builds share this 
problem:
* 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48518/consoleFull
* 
https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2279/consoleFull
 (NewSparkPullRequestBuilder?)
* 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48550/consoleFull
* 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48552/consoleFull
* 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48553/consoleFull

After the initial error I thought I messed up the dependencies (I am 
messing with the build). I changed them and I got a correct build failure with 
'nice' error message:
* 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48521/consoleFull

Could you take a look?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168208226
  
**[Test build #48555 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48555/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168210083
  
**[Test build #48557 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48557/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168182227
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168178455
  
**[Test build #48550 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48550/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168182029
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48552/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168182024
  
**[Test build #48552 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48552/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).
 * This patch **fails build dependency tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168182027
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168184101
  
**[Test build #48553 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48553/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168190691
  
When running any test suite that extends `HiveComparisonTest`, detail logs 
can be found in `sql/hive/target/unit-tests.log`.  If a query string is 
convertible, we may see something like this (the triple-braces are added so 
that Vim recognizes them as fold marks.):

```
### Running SQL generation round-trip test {{{
Project [key#357,value#358,ds#356]
+- MetastoreRelation default, add_part_test, None

Original SQL:
select * from add_part_test

Generated SQL:
SELECT `add_part_test`.`key`, `add_part_test`.`value`, `add_part_test`.`ds` 
FROM `default`.`add_part_test`
}}}
```

Otherwise, we may see something like this:

```
### Cannot convert the following logical plan back to SQL {{{
Aggregate 
[(sum(cast(HiveGenericUDF#org.apache.hadoop.hive.ql.udf.generic.GenericUDFHash(key#2853,value#2854)
 as bigint)),mode=Complete,isDistinct=false) AS _c0#2855L]
+- MetastoreRelation default, dest_j1, None

Original SQL:
SELECT sum(hash(dest_j1.key,dest_j1.value)) FROM dest_j1
}}}
```

In this way we can figure out the percentage of convertible query plans. 
Ideally the percentage should be calculated automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168191048
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] hiveContext.table() throws ...

[thomastechs]

Github user thomastechs commented on a diff in the pull request:

https://github.com/apache/spark/pull/10529#discussion_r48653675
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
 ---
@@ -104,7 +104,7 @@ class SimpleCatalog(val conf: CatalystConf) extends 
Catalog {
 val tableName = getTableName(tableIdent)
 val table = tables.get(tableName)
 if (table == null) {
-  throw new NoSuchTableException
+  throw new AnalysisException("The table named "+tableName+" was not 
found.")
--- End diff --

Sure @rxin  .Will update the fix and create a new pull request


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] hiveContext.table() throws ...

[thomastechs]

Github user thomastechs commented on the pull request:

https://github.com/apache/spark/pull/10529#issuecomment-168173475
  
@rxin  I have updated the style check difference ,you mentioned. and 
committed to my branch. And I see it is reflected here in this same pull 
request. Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][TEST] Don't mute Spark logg...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10540#issuecomment-168179906
  
Hit this issue while working on canonicalized native view support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168179937
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168208273
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48555/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168208271
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168174676
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168174246
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48549/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168174243
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168178889
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168178887
  
**[Test build #48550 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48550/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).
 * This patch **fails build dependency tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168178890
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48550/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168191248
  
**[Test build #48554 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48554/consoleFull)**
 for PR 10541 at commit 
[`17e8fba`](https://github.com/apache/spark/commit/17e8fba3484d19e7ca7a993359fdc28004f9dfb8).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168191293
  
**[Test build #48555 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48555/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][TEST] Don't mute Spark logg...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10540#issuecomment-168192337
  
**[Test build #48551 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48551/consoleFull)**
 for PR 10540 at commit 
[`7d6e0e5`](https://github.com/apache/spark/commit/7d6e0e5c340c8ac4d4fc49b503adfb84eaa6cc5d).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][TEST] Don't mute Spark logg...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10540#issuecomment-168192402
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48551/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[hvanhovell]

Github user hvanhovell commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168209143
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10390#issuecomment-168165273
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10390#issuecomment-168165278
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48548/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10390#issuecomment-168165009
  
**[Test build #48548 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48548/consoleFull)**
 for PR 10390 at commit 
[`62fa738`](https://github.com/apache/spark/commit/62fa738dca9e7848156772ec99d5f956622321d9).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168174120
  
**[Test build #48549 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48549/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168194609
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12507][Streaming][Document]Expose close...

[brkyvz]

Github user brkyvz commented on the pull request:

https://github.com/apache/spark/pull/10453#issuecomment-168194624
  
@zsxwing Thanks! LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168194592
  
**[Test build #48554 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48554/consoleFull)**
 for PR 10541 at commit 
[`17e8fba`](https://github.com/apache/spark/commit/17e8fba3484d19e7ca7a993359fdc28004f9dfb8).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `abstract sealed class SortDirection `
  * `sealed abstract class JoinType `
  * `case class Subquery(alias: String, child: LogicalPlan)`
  * `case class NamedRelation(databaseName: String, tableName: String, 
output: Seq[Attribute])`
  * `class QueryNormalizer(sqlContext: SQLContext) extends 
RuleExecutor[LogicalPlan] `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168194610
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48554/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12470] [SQL] Fix size reduction calcula...

[robbinspg]

Github user robbinspg commented on the pull request:

https://github.com/apache/spark/pull/10421#issuecomment-168172679
  
re-merged with latest master

Please retest


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][TEST] Don't mute Spark logg...

[liancheng]

GitHub user liancheng opened a pull request:

https://github.com/apache/spark/pull/10540

[SPARK-12592][SQL][TEST] Don't mute Spark loggers in TestHive.reset()

There's a hack done in `TestHive.reset()`, which intended to mute noisy 
Hive loggers. However, Spark testing loggers are also muted.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liancheng/spark 
spark-12592.dont-mute-spark-loggers

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10540


commit 7d6e0e5c340c8ac4d4fc49b503adfb84eaa6cc5d
Author: Cheng Lian 
Date:   2015-12-31T11:37:39Z

Don't mute Spark loggers in TestHive.reset()




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168181912
  
**[Test build #48552 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48552/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[liancheng]

GitHub user liancheng opened a pull request:

https://github.com/apache/spark/pull/10541

[SPARK-12592][SQL][WIP] Converts resolved logical plan back to SQL

This PR tries to enable Spark SQL to convert resolved logical plans back to 
SQL query strings.  For now, the major use case is to canonicalize Spark SQL 
native view support.

The major entry point is `SQLBuilder.toSQL`, which returns an 
`Option[String]` if the logical plan is recognized.

The current version is still in WIP status, and is quite limited.  Known 
limitations include:

1.  The logical plan must be analyzed but not optimized

The optimizer erases `Subquery` operators, which contain necessary 
scope information for SQL generation.  Future versions should be able to 
recover erased scope information by inserting subqueries when necessary.

1.  The logical plan must be created using HiveQL query string

Query plans generated by composing arbitrary DataFrame API combinations 
are not supported yet.  Operators within these query plans need to be 
rearranged into a canonical form that is more suitable for direct SQL 
generation.  For example, the following query plan

```
Filter (a#1 < 10)
 +- MetastoreRelation default, src, None
```

need to be canonicalized into the following form before SQL generation:

```
Project [a#1, b#2, c#3]
 +- Filter (a#1 < 10)
 +- MetastoreRelation default, src, None
```

Otherwise, the SQL generation process will have to handle a large 
number of special cases.

1.  Only a fraction of expressions and basic logical plan operators are 
supported in this PR

Support for window functions, generators, and cubes etc. will be added 
in follow-up PRs.

This PR leverages `HiveCompatibilitySuite` for testing SQL generation in a 
"round-trip" manner:

*   For all select queries, we try to convert it back to SQL
*   If the query plan is convertible, we parse the generated SQL into a new 
logical plan
*   Run the new logical plan instead of the original one

If the query plan is inconvertible, the test case simply falls back to the 
original logic.

TODO

- [ ] Fix failed test cases
- [ ] Support for more basic expressions and logical plan operators (e.g. 
distinct aggregation etc.)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liancheng/spark sql-generation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10541.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10541


commit 17e8fba3484d19e7ca7a993359fdc28004f9dfb8
Author: Cheng Lian 
Date:   2015-12-28T10:12:10Z

WIP: Converting resolved logical plan back to SQL




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168191297
  
I found SQL generation in Slick can be a good reference for attacking 
limitations mentioned in the PR description. But the current approach should be 
enough for native view.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12541] [SQL] support cube/rollup as fun...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/10522#discussion_r48660161
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
@@ -203,15 +203,15 @@ class Analyzer(
  *  represented as the bit masks.
  */
 def bitmasks(c: Cube): Seq[Int] = {
-  Seq.tabulate(1 << c.groupByExprs.length)(i => i)
+  Seq.tabulate(1 << c.children.length)(i => i)
--- End diff --

Why not move this to the newly created ```Cube``` case class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12541] [SQL] support cube/rollup as fun...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/10522#discussion_r48660142
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
@@ -190,7 +190,7 @@ class Analyzer(
  *  represented as the bit masks.
  */
 def bitmasks(r: Rollup): Seq[Int] = {
-  Seq.tabulate(r.groupByExprs.length + 1)(idx => {(1 << idx) - 1})
+  Seq.tabulate(r.children.length + 1)(idx => {(1 << idx) - 1})
--- End diff --

Why not move these to the newly created ```Rollup``` case class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-6724][WIP][MLLIB]Model import/export fo...

[FlytxtRnD]

Github user FlytxtRnD closed the pull request at:

https://github.com/apache/spark/pull/7320


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [Spark-10625] [SQL] Spark SQL JDBC read/write ...

[tribbloid]

Github user tribbloid commented on the pull request:

https://github.com/apache/spark/pull/8785#issuecomment-168211061
  
Looks like the removed qualifier of Map in JDBCRelation has caused build to 
fail (Map is cast to immutable.Map). I'm adding back the qualifier 
scala.collection.Map now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168211120
  
**[Test build #48558 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48558/consoleFull)**
 for PR 10541 at commit 
[`af865a9`](https://github.com/apache/spark/commit/af865a9d5c3b4a7a3ba9af856c4f19250b004e4b).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168211126
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48556/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168211125
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168234676
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48557/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168234675
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168234652
  
**[Test build #48557 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48557/consoleFull)**
 for PR 10525 at commit 
[`e3e2f72`](https://github.com/apache/spark/commit/e3e2f72d8080f8e0040be351032c7e3b24289c77).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168220607
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48558/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168220278
  
**[Test build #48558 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48558/consoleFull)**
 for PR 10541 at commit 
[`af865a9`](https://github.com/apache/spark/commit/af865a9d5c3b4a7a3ba9af856c4f19250b004e4b).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `abstract sealed class SortDirection `
  * `sealed abstract class JoinType `
  * `case class Subquery(alias: String, child: LogicalPlan)`
  * `case class NamedRelation(databaseName: String, tableName: String, 
output: Seq[Attribute])`
  * `class QueryNormalizer(sqlContext: SQLContext) extends 
RuleExecutor[LogicalPlan] `
  * `class SQLBuilder(logicalPlan: LogicalPlan, sqlContext: SQLContext) 
extends Logging `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12592][SQL][WIP] Converts resolved logi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/10541#issuecomment-168220603
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-6724][WIP][MLLIB]Model import/export fo...

[FlytxtRnD]

Github user FlytxtRnD commented on the pull request:

https://github.com/apache/spark/pull/7320#issuecomment-168222327
  
@jkbradley Thank you for the review. I will close this issue and will 
surely help in testing the other PR. Also it would be great if you could take a 
look at #6880


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[JoshRosen]

Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168240969
  
I have a few hunches about what could be causing the dependency manifest 
checking problems. I'll keep investigating when I get home later tonight. I 
think I've spotted two potential problems: there might be some portability 
issues with how we're using `sort` and I think there might be a mistake in the 
exit-code-handling logic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12470] [SQL] Fix size reduction calcula...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10421#issuecomment-168259354
  
**[Test build #2282 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2282/consoleFull)**
 for PR 10421 at commit 
[`e5a8d1e`](https://github.com/apache/spark/commit/e5a8d1ed8f08b5cec16c207904c7bda6763179f2).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] hiveContext.table() throws ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10529#issuecomment-168259243
  
**[Test build #2281 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2281/consoleFull)**
 for PR 10529 at commit 
[`4463a95`](https://github.com/apache/spark/commit/4463a950e6f2b857314cdfd1871449a92ea652af).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168259081
  
Should we revert that dependency check thing first?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12594] [SQL] Outer Join Conversion: Out...

[gatorsmile]

GitHub user gatorsmile opened a pull request:

https://github.com/apache/spark/pull/10542

[SPARK-12594] [SQL] Outer Join Conversion: Outer/Right/Left to Inner and 
Outer to Left/Right

Conversion of outer joins, if the local predicates can restrict the result 
sets so that all null-supplying rows are eliminated. 

- full outer -> inner if both sides have such local predicates
- left outer -> inner if the right side has such local predicates
- right outer -> inner if the left side has such local predicates
- full outer -> left outer if only the left side has such local predicates
- full outer -> right outer if only the right side has such local predicates

If applicable, this can greatly improve the performance, since outer join 
is much slower than inner join, full outer join is much slower than left/right 
outer join. 

TODO: add extra test cases to Optimizer buckets.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gatorsmile/spark outerJoinConversion

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/10542.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10542


commit 2f6c80dc57f10171cb97e22f6fb3257f9b4e308d
Author: gatorsmile 
Date:   2015-12-31T23:48:32Z

Merge remote-tracking branch 'upstream/master' into outerJoinElimination

commit 90576aacb085e9192360505ac5687a3df5e54b6f
Author: gatorsmile 
Date:   2016-01-01T00:23:03Z

outer join conversion




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12594] [SQL] Outer Join Conversion: Out...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10542#issuecomment-168269686
  
**[Test build #48559 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48559/consoleFull)**
 for PR 10542 at commit 
[`90576aa`](https://github.com/apache/spark/commit/90576aacb085e9192360505ac5687a3df5e54b6f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12362][SQL][WIP] Inline Hive Parser

[JoshRosen]

Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/10525#issuecomment-168278782
  
Aha! It appears that there _is_ a portability issue in `sort`, or at least 
in how we're using it in the dependency-checking script.

When I run `echo -e "breeze-macros\nbreeze_2.0" | sort` on my Mac, I get 

```
breeze-macros
breeze_2.0
```

but I get the opposite ordering when running on AMPLab Jenknis.

On my mac, `sort --version` outputs `sort (GNU coreutils) 5.93`, whereas 
AMP Jenkins has `sort (GNU coreutils) 8.4`. But it turns out that this isn't 
the problem! It's a locale-dependent issue: 
https://stackoverflow.com/questions/28881/why-doesnt-sort-sort-the-same-on-every-machine

We need to set `LC_ALL=C` in order to make things portable. I'm going to 
open a hotfix PR to address these issues, then will retest this PR once my fix 
is in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10452#issuecomment-168271940
  
**[Test build #2283 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2283/consoleFull)**
 for PR 10452 at commit 
[`78e5d84`](https://github.com/apache/spark/commit/78e5d845c935623fdea60e1e79f35aebd9cddb60).
 * This patch passes all tests.
 * This patch **does not merge cleanly**.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

[sureshthalamati]

Github user sureshthalamati commented on the pull request:

https://github.com/apache/spark/pull/10452#issuecomment-168260505
  
Thanks, Michael. Updated the PR.  Please review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10452#issuecomment-168259705
  
**[Test build #2283 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2283/consoleFull)**
 for PR 10452 at commit 
[`78e5d84`](https://github.com/apache/spark/commit/78e5d845c935623fdea60e1e79f35aebd9cddb60).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12438][SQL] hiveContext.table() throws ...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10529#issuecomment-168261528
  
**[Test build #2281 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2281/consoleFull)**
 for PR 10529 at commit 
[`4463a95`](https://github.com/apache/spark/commit/4463a950e6f2b857314cdfd1871449a92ea652af).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-12470] [SQL] Fix size reduction calcula...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/10421#issuecomment-168268755
  
**[Test build #2282 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2282/consoleFull)**
 for PR 10421 at commit 
[`e5a8d1e`](https://github.com/apache/spark/commit/e5a8d1ed8f08b5cec16c207904c7bda6763179f2).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-10359][PROJECT-INFRA] Multiple fixes to...

[JoshRosen]

Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/10543#issuecomment-168279632
  
Actually, it occurred to me that I should really be setting `LC_ALL=C` at 
the top of the script to guard against future problems in case we add 
additional locale-sensitive command calls. Let me make that change now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org