[GitHub] Ngone51 commented on a change in pull request #23457: [SPARK-26539][CORE] Remove spark.memory.useLegacyMode and StaticMemoryManager
Ngone51 commented on a change in pull request #23457: [SPARK-26539][CORE] Remove spark.memory.useLegacyMode and StaticMemoryManager URL: https://github.com/apache/spark/pull/23457#discussion_r245469088 ## File path: core/src/main/scala/org/apache/spark/memory/package.scala ## @@ -61,15 +61,10 @@ package org.apache.spark * }}} * * - * There are two implementations of [[org.apache.spark.memory.MemoryManager]] which vary in how - * they handle the sizing of their memory pools: + * There is one implementations of [[org.apache.spark.memory.MemoryManager]]: Review comment: nit: `implementations` -> `implementation` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] Ngone51 commented on a change in pull request #23457: [SPARK-26539][CORE] Remove spark.memory.useLegacyMode and StaticMemoryManager
Ngone51 commented on a change in pull request #23457: [SPARK-26539][CORE]
Remove spark.memory.useLegacyMode and StaticMemoryManager
URL: https://github.com/apache/spark/pull/23457#discussion_r245470208
##
File path: core/src/test/scala/org/apache/spark/storage/MemoryStoreSuite.scala
##
@@ -291,11 +290,11 @@ class MemoryStoreSuite
blockInfoManager.removeBlock("b3")
putIteratorAsBytes("b3", smallIterator, ClassTag.Any)
-// Unroll huge block with not enough space. This should fail and kick out
b2 in the process.
+// Unroll huge block with not enough space.
val result4 = putIteratorAsBytes("b4", bigIterator, ClassTag.Any)
assert(result4.isLeft) // unroll was unsuccessful
assert(!memoryStore.contains("b1"))
-assert(!memoryStore.contains("b2"))
+assert(memoryStore.contains("b2")) // not necessarily evicted
Review comment:
isn't b2 takes 4000 and b4 takes 4 ?
I verified the test and I think the assertion is correct.
Actually, for current behaviour with `UnifiedMemoryManager`, there may be
12000 bytes available. When we try to put b4 into memory, it will require 24064
memory once it unrolled 16 elements (which hit the `memoryCheckPeriod` for
first time). And 24064 bytes exceed the maxMemory of 12000, so, it would just
return instread of evicting any blocks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown
AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-451634899 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6668/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown
AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-451634899 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6668/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown
AmplabJenkins commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-451634898 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown
AmplabJenkins removed a comment on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-451634898 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown
SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-451634896 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6668/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle`
AmplabJenkins removed a comment on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle` URL: https://github.com/apache/spark/pull/23459#issuecomment-451634768 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle`
AmplabJenkins removed a comment on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle` URL: https://github.com/apache/spark/pull/23459#issuecomment-451634769 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100769/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown
SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-451634795 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6668/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle`
AmplabJenkins commented on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle` URL: https://github.com/apache/spark/pull/23459#issuecomment-451634769 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100769/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle`
AmplabJenkins commented on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle` URL: https://github.com/apache/spark/pull/23459#issuecomment-451634768 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA removed a comment on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle`
SparkQA removed a comment on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle` URL: https://github.com/apache/spark/pull/23459#issuecomment-451622602 **[Test build #100769 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100769/testReport)** for PR 23459 at commit [`b57c974`](https://github.com/apache/spark/commit/b57c974dafdfbc7e325567b66a663483dd099777). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451634673 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451634674 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6669/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451634673 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle`
SparkQA commented on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle` URL: https://github.com/apache/spark/pull/23459#issuecomment-451634676 **[Test build #100769 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100769/testReport)** for PR 23459 at commit [`b57c974`](https://github.com/apache/spark/commit/b57c974dafdfbc7e325567b66a663483dd099777). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451634674 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6669/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451634501 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100768/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451634499 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451634501 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100768/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451634499 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
SparkQA removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451621980 **[Test build #100768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100768/testReport)** for PR 23447 at commit [`b83c9ea`](https://github.com/apache/spark/commit/b83c9ea9d586a29e459e1240d4fedce5432893c3). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown
SparkQA commented on issue #19045: [WIP][SPARK-20628][CORE][K8S] Keep track of nodes (/ spot instances) which are going to be shutdown URL: https://github.com/apache/spark/pull/19045#issuecomment-451634421 **[Test build #100775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100775/testReport)** for PR 19045 at commit [`bc07cf9`](https://github.com/apache/spark/commit/bc07cf9244a4c8e09340c65ff848af28c2c7f572). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
SparkQA commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451634407 **[Test build #100768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100768/testReport)** for PR 23447 at commit [`b83c9ea`](https://github.com/apache/spark/commit/b83c9ea9d586a29e459e1240d4fedce5432893c3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
SparkQA commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451634411 **[Test build #100774 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100774/testReport)** for PR 23447 at commit [`d5e1904`](https://github.com/apache/spark/commit/d5e190473f6beacdd2226a333a5792218cfba38f). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
SparkQA commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451633467 **[Test build #100772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100772/testReport)** for PR 23458 at commit [`74215de`](https://github.com/apache/spark/commit/74215de31cb68a5b6cf6c26ae0b6512926cdc150). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451633436 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified// Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
SparkQA commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451633466 **[Test build #100773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100773/testReport)** for PR 23450 at commit [`09cd28b`](https://github.com/apache/spark/commit/09cd28b3b981df6ba3abda28c9bb1373e5626838). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451633435 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451633435 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451633412 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6667/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451633412 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6667/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451633436 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified// Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451633411 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451633411 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] dongjoon-hyun commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
dongjoon-hyun commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451633264 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] dongjoon-hyun commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
dongjoon-hyun commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451633247 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451632744 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100765/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451632742 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451632744 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100765/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451632742 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
SparkQA removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451620444 **[Test build #100765 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100765/testReport)** for PR 23458 at commit [`74215de`](https://github.com/apache/spark/commit/74215de31cb68a5b6cf6c26ae0b6512926cdc150). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
SparkQA commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451632659 **[Test build #100765 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100765/testReport)** for PR 23458 at commit [`74215de`](https://github.com/apache/spark/commit/74215de31cb68a5b6cf6c26ae0b6512926cdc150). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451630872 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451630875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100764/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451630872 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
AmplabJenkins commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451630875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100764/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
SparkQA removed a comment on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451618962 **[Test build #100764 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100764/testReport)** for PR 23458 at commit [`9e1b8ce`](https://github.com/apache/spark/commit/9e1b8cef578258acb092265e7cefec6dc91a4224). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
SparkQA commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451630786 **[Test build #100764 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100764/testReport)** for PR 23458 at commit [`9e1b8ce`](https://github.com/apache/spark/commit/9e1b8cef578258acb092265e7cefec6dc91a4224). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451630342 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100770/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451630342 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100770/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451630340 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451630340 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
SparkQA removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451623434 **[Test build #100770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100770/testReport)** for PR 23450 at commit [`09cd28b`](https://github.com/apache/spark/commit/09cd28b3b981df6ba3abda28c9bb1373e5626838). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
SparkQA commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451630300 **[Test build #100770 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100770/testReport)** for PR 23450 at commit [`09cd28b`](https://github.com/apache/spark/commit/09cd28b3b981df6ba3abda28c9bb1373e5626838). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] dongjoon-hyun commented on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle`
dongjoon-hyun commented on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle` URL: https://github.com/apache/spark/pull/23459#issuecomment-451629701 Thank you for review and approval, @felixcheung . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] vanzin commented on issue #23302: [SPARK-24522][UI] Create filter to apply HTTP security checks consistently.
vanzin commented on issue #23302: [SPARK-24522][UI] Create filter to apply HTTP security checks consistently. URL: https://github.com/apache/spark/pull/23302#issuecomment-451629509 Probably, will check Monday. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] felixcheung commented on issue #23398: [SPARK-26493][SQL] Allow multiple spark.sql.extensions
felixcheung commented on issue #23398: [SPARK-26493][SQL] Allow multiple spark.sql.extensions URL: https://github.com/apache/spark/pull/23398#issuecomment-451628744 @hvanhovell @gatorsmile ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators
AmplabJenkins removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-451626255 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100763/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators
AmplabJenkins removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-451626252 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators
AmplabJenkins commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-451626255 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100763/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators
AmplabJenkins commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-451626252 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators
SparkQA removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-451609896 **[Test build #100763 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100763/testReport)** for PR 23278 at commit [`fcee568`](https://github.com/apache/spark/commit/fcee56821e27e66267b677428091820b8282b5f2). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators
SparkQA commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-451626194 **[Test build #100763 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100763/testReport)** for PR 23278 at commit [`fcee568`](https://github.com/apache/spark/commit/fcee56821e27e66267b677428091820b8282b5f2). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] maryannxue commented on a change in pull request #23036: [SPARK-26065][SQL] Change query hint from a `LogicalPlan` to a field
maryannxue commented on a change in pull request #23036: [SPARK-26065][SQL]
Change query hint from a `LogicalPlan` to a field
URL: https://github.com/apache/spark/pull/23036#discussion_r245466021
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/SameResultSuite.scala
##
@@ -72,4 +77,12 @@ class SameResultSuite extends SparkFunSuite {
val df2 = testRelation.join(testRelation)
assertSameResult(df1, df2)
}
+
+ test("join hint") {
+val df1 = testRelation.join(testRelation.hint("broadcast"))
+val df2 = testRelation.join(testRelation)
+val df1Optimized = Optimize.execute(df1.analyze)
+val df2Optimized = Optimize.execute(df2.analyze)
+assertSameResult(df1Optimized, df2Optimized)
Review comment:
No. This is to test `Join.doCanonicalize()`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] maryannxue commented on a change in pull request #23036: [SPARK-26065][SQL] Change query hint from a `LogicalPlan` to a field
maryannxue commented on a change in pull request #23036: [SPARK-26065][SQL]
Change query hint from a `LogicalPlan` to a field
URL: https://github.com/apache/spark/pull/23036#discussion_r245465982
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala
##
@@ -59,3 +76,41 @@ case class HintInfo(broadcast: Boolean = false) {
if (hints.isEmpty) "none" else hints.mkString("(", ", ", ")")
}
}
+
+/**
+ * Replaces [[ResolvedHint]] operators from the plan. Move the [[HintInfo]] to
associated [[Join]]
+ * operators, otherwise remove it if no [[Join]] operator is matched.
+ */
+object EliminateResolvedHint extends Rule[LogicalPlan] {
+ // This is also called in the beginning of the optimization phase, and as a
result
+ // is using transformUp rather than resolveOperators.
+ def apply(plan: LogicalPlan): LogicalPlan = {
+val pulledUp = plan transformUp {
+ case j: Join =>
+val leftHint = mergeHints(collectHints(j.left))
+val rightHint = mergeHints(collectHints(j.right))
+j.copy(hint = JoinHint(leftHint, rightHint))
+}
+pulledUp.transform {
+ case h: ResolvedHint => h.child
+}
+ }
+
+ def mergeHints(hints: Seq[HintInfo]): Option[HintInfo] = {
+hints.reduceOption((h1, h2) => HintInfo(
+ broadcast = h1.broadcast || h2.broadcast))
+ }
+
+ def collectHints(plan: LogicalPlan): Seq[HintInfo] = {
+plan match {
+ case h: ResolvedHint => collectHints(h.child) :+ h.hints
+ case u: UnaryNode => collectHints(u.child)
Review comment:
I'll start a follow-up PR if any hint behavior needs to be revisited
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] maryannxue commented on a change in pull request #23036: [SPARK-26065][SQL] Change query hint from a `LogicalPlan` to a field
maryannxue commented on a change in pull request #23036: [SPARK-26065][SQL]
Change query hint from a `LogicalPlan` to a field
URL: https://github.com/apache/spark/pull/23036#discussion_r245465954
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala
##
@@ -59,3 +76,41 @@ case class HintInfo(broadcast: Boolean = false) {
if (hints.isEmpty) "none" else hints.mkString("(", ", ", ")")
}
}
+
+/**
+ * Replaces [[ResolvedHint]] operators from the plan. Move the [[HintInfo]] to
associated [[Join]]
+ * operators, otherwise remove it if no [[Join]] operator is matched.
+ */
+object EliminateResolvedHint extends Rule[LogicalPlan] {
+ // This is also called in the beginning of the optimization phase, and as a
result
+ // is using transformUp rather than resolveOperators.
+ def apply(plan: LogicalPlan): LogicalPlan = {
+val pulledUp = plan transformUp {
+ case j: Join =>
+val leftHint = mergeHints(collectHints(j.left))
+val rightHint = mergeHints(collectHints(j.right))
+j.copy(hint = JoinHint(leftHint, rightHint))
+}
+pulledUp.transform {
+ case h: ResolvedHint => h.child
+}
+ }
+
+ def mergeHints(hints: Seq[HintInfo]): Option[HintInfo] = {
Review comment:
Added in JoinHintsSuite
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] maryannxue commented on a change in pull request #23036: [SPARK-26065][SQL] Change query hint from a `LogicalPlan` to a field
maryannxue commented on a change in pull request #23036: [SPARK-26065][SQL]
Change query hint from a `LogicalPlan` to a field
URL: https://github.com/apache/spark/pull/23036#discussion_r245465941
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
##
@@ -164,25 +167,35 @@ object ExtractFiltersAndInnerJoins extends
PredicateHelper {
* was involved in an explicit cross join. Also returns the entire list of
join conditions for
* the left-deep tree.
*/
- def flattenJoin(plan: LogicalPlan, parentJoinType: InnerLike = Inner)
+ def flattenJoin(
Review comment:
The tests are in JoinHintsSuite: "hint preserved after join reorder".
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451624586 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6665/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins removed a comment on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451624583 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451624586 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6665/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
AmplabJenkins commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451624583 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories
SparkQA commented on issue #23447: [SPARK-26462][CORE] Use ConfigEntry for hardcoded configs for execution categories URL: https://github.com/apache/spark/pull/23447#issuecomment-451624518 **[Test build #100771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100771/testReport)** for PR 23447 at commit [`10eebdd`](https://github.com/apache/spark/commit/10eebddbff3ec08ae5fa638aa6df9eba014f5eea). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] squito commented on issue #23302: [SPARK-24522][UI] Create filter to apply HTTP security checks consistently.
squito commented on issue #23302: [SPARK-24522][UI] Create filter to apply HTTP security checks consistently. URL: https://github.com/apache/spark/pull/23302#issuecomment-451624195 real failure in "org.apache.spark.ui.UISuite.add and remove handlers with custom user filter" ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] asfgit closed pull request #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4
asfgit closed pull request #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito
to 2.23.4
URL: https://github.com/apache/spark/pull/23452
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/network-common/src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java
b/common/network-common/src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java
index 6f15718bd8705..59adf9704cbf6 100644
---
a/common/network-common/src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java
+++
b/common/network-common/src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java
@@ -347,10 +347,10 @@ public void testRpcHandlerDelegate() throws Exception {
verify(handler).getStreamManager();
saslHandler.channelInactive(null);
-verify(handler).channelInactive(any(TransportClient.class));
+verify(handler).channelInactive(isNull());
saslHandler.exceptionCaught(null, null);
-verify(handler).exceptionCaught(any(Throwable.class),
any(TransportClient.class));
+verify(handler).exceptionCaught(isNull(), isNull());
}
@Test
diff --git
a/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandlerSuite.java
b/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandlerSuite.java
index 7846b71d5a8b1..4cc9a16e1449f 100644
---
a/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandlerSuite.java
+++
b/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandlerSuite.java
@@ -27,7 +27,7 @@
import org.mockito.ArgumentCaptor;
import static org.junit.Assert.*;
-import static org.mockito.Matchers.any;
+import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
import org.apache.spark.network.buffer.ManagedBuffer;
@@ -79,6 +79,8 @@ public void testRegisterExecutor() {
@SuppressWarnings("unchecked")
@Test
public void testOpenShuffleBlocks() {
+when(client.getClientId()).thenReturn("app0");
+
RpcResponseCallback callback = mock(RpcResponseCallback.class);
ManagedBuffer block0Marker = new NioManagedBuffer(ByteBuffer.wrap(new
byte[3]));
diff --git
a/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/OneForOneBlockFetcherSuite.java
b/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/OneForOneBlockFetcherSuite.java
index dc947a619bf02..95460637db89d 100644
---
a/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/OneForOneBlockFetcherSuite.java
+++
b/common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/OneForOneBlockFetcherSuite.java
@@ -28,10 +28,10 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
-import static org.mockito.Matchers.any;
-import static org.mockito.Matchers.anyInt;
-import static org.mockito.Matchers.anyLong;
-import static org.mockito.Matchers.eq;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyInt;
+import static org.mockito.ArgumentMatchers.anyLong;
+import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
diff --git
a/core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java
b/core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java
index e5fbafc23d957..ecfebf8f8287e 100644
---
a/core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java
+++
b/core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java
@@ -50,8 +50,8 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.mockito.Answers.RETURNS_SMART_NULLS;
-import static org.mockito.Matchers.any;
-import static org.mockito.Matchers.anyInt;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyInt;
import static org.mockito.Mockito.when;
diff --git
a/core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
b/core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
index d0389235cb724..38f5e8c9f0ac8 100644
--- a/core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
+++ b/core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
@@ -19,7 +19,7 @@ package org.apache.spark
import scala.collection.mutable
-import org.mockito.Matchers.{any, eq => meq}
+import org.mockito.ArgumentMatchers.{any, eq => meq}
import org.mockito.Mockito.{mock, never, verify, when}
import org.scalatest.{BeforeAndAfter, PrivateMethodTester}
[GitHub] AmplabJenkins removed a comment on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4
AmplabJenkins removed a comment on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4 URL: https://github.com/apache/spark/pull/23452#issuecomment-451623634 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100760/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4
AmplabJenkins removed a comment on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4 URL: https://github.com/apache/spark/pull/23452#issuecomment-451623632 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4
AmplabJenkins commented on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4 URL: https://github.com/apache/spark/pull/23452#issuecomment-451623632 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4
AmplabJenkins commented on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4 URL: https://github.com/apache/spark/pull/23452#issuecomment-451623634 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100760/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA removed a comment on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4
SparkQA removed a comment on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4 URL: https://github.com/apache/spark/pull/23452#issuecomment-451585209 **[Test build #100760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100760/testReport)** for PR 23452 at commit [`1dc2710`](https://github.com/apache/spark/commit/1dc27105605cc69032e0ea78061dc318aa499051). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] dongjoon-hyun commented on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4
dongjoon-hyun commented on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4 URL: https://github.com/apache/spark/pull/23452#issuecomment-451623604 Thank you all. Merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4
SparkQA commented on issue #23452: [SPARK-26536][BUILD][TEST] Upgrade Mockito to 2.23.4 URL: https://github.com/apache/spark/pull/23452#issuecomment-451623515 **[Test build #100760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100760/testReport)** for PR 23452 at commit [`1dc2710`](https://github.com/apache/spark/commit/1dc27105605cc69032e0ea78061dc318aa499051). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
SparkQA commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451623434 **[Test build #100770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100770/testReport)** for PR 23450 at commit [`09cd28b`](https://github.com/apache/spark/commit/09cd28b3b981df6ba3abda28c9bb1373e5626838). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451623353 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6664/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451623352 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451623353 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6664/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451623352 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] dongjoon-hyun commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
dongjoon-hyun commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451623247 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] dongjoon-hyun commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale
dongjoon-hyun commented on issue #23458: [SPARK-26540][SQL] Support PostgreSQL numeric arrays without precision/scale URL: https://github.com/apache/spark/pull/23458#issuecomment-451623231 Also, cc @gatorsmile and @mgaido91 . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451623011 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100762/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451623009 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
SparkQA removed a comment on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451609232 **[Test build #100762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100762/testReport)** for PR 23450 at commit [`09cd28b`](https://github.com/apache/spark/commit/09cd28b3b981df6ba3abda28c9bb1373e5626838). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451623011 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100762/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
AmplabJenkins commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451623009 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] SparkQA commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries
SparkQA commented on issue #23450: [SPARK-26078][SQL][BACKPORT-2.3] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23450#issuecomment-451622946 **[Test build #100762 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/100762/testReport)** for PR 23450 at commit [`09cd28b`](https://github.com/apache/spark/commit/09cd28b3b981df6ba3abda28c9bb1373e5626838). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] Ngone51 commented on a change in pull request #22806: [SPARK-25250][CORE] : Late zombie task completions handled correctly even before new taskset launched
Ngone51 commented on a change in pull request #22806: [SPARK-25250][CORE] :
Late zombie task completions handled correctly even before new taskset launched
URL: https://github.com/apache/spark/pull/22806#discussion_r245463774
##
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##
@@ -1383,6 +1383,8 @@ private[spark] class DAGScheduler(
if (!job.finished(rt.outputId)) {
job.finished(rt.outputId) = true
job.numFinished += 1
+
taskScheduler.markPartitionIdAsCompletedAndKillCorrespondingTaskAttempts(
Review comment:
Does this require the newest `TaskSet` has been created in
`TaskSetScheduler` at this point ? If so, can we make sure of that ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle`
AmplabJenkins removed a comment on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle` URL: https://github.com/apache/spark/pull/23459#issuecomment-451622644 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins removed a comment on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle`
AmplabJenkins removed a comment on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle` URL: https://github.com/apache/spark/pull/23459#issuecomment-451622645 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6663/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] AmplabJenkins commented on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle`
AmplabJenkins commented on issue #23459: [SPARK-26541][BUILD] Add `-Pdocker-integration-tests` to `dev/scalastyle` URL: https://github.com/apache/spark/pull/23459#issuecomment-451622645 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6663/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
