[GitHub] AmplabJenkins removed a comment on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #20691: [SPARK-18161] [Python] Update 
cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#issuecomment-455758656
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101426/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #20691: [SPARK-18161] [Python] Update 
cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#issuecomment-455758655
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #20691: [SPARK-18161] [Python] Update 
cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#issuecomment-455758655
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #20691: [SPARK-18161] [Python] Update 
cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#issuecomment-455758656
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101426/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA removed a comment on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
SparkQA removed a comment on issue #20691: [SPARK-18161] [Python] Update 
cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#issuecomment-455756949
 
 
   **[Test build #101426 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101426/testReport)**
 for PR 20691 at commit 
[`b0df927`](https://github.com/apache/spark/commit/b0df927d6ab842fd07e073aaad8b34307bdf26b0).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
SparkQA commented on issue #20691: [SPARK-18161] [Python] Update cloudpickle to 
v0.6.1
URL: https://github.com/apache/spark/pull/20691#issuecomment-455758598
 
 
   **[Test build #101426 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101426/testReport)**
 for PR 20691 at commit 
[`b0df927`](https://github.com/apache/spark/commit/b0df927d6ab842fd07e073aaad8b34307bdf26b0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #20691: [SPARK-18161] [Python] Update 
cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#issuecomment-455757016
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7226/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #20691: [SPARK-18161] [Python] Update 
cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#issuecomment-455757015
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #20691: [SPARK-18161] [Python] Update 
cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#issuecomment-455757016
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7226/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #20691: [SPARK-18161] [Python] Update 
cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#issuecomment-455757015
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
SparkQA commented on issue #20691: [SPARK-18161] [Python] Update cloudpickle to 
v0.6.1
URL: https://github.com/apache/spark/pull/20691#issuecomment-455756949
 
 
   **[Test build #101426 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101426/testReport)**
 for PR 20691 at commit 
[`b0df927`](https://github.com/apache/spark/commit/b0df927d6ab842fd07e073aaad8b34307bdf26b0).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] 10110346 commented on a change in pull request #23583: [MINOR][TEST]Correct some unit test mistakes

2019-01-18 Thread GitBox
10110346 commented on a change in pull request #23583: [MINOR][TEST]Correct 
some unit test mistakes
URL: https://github.com/apache/spark/pull/23583#discussion_r249237172
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLog.scala
 ##
 @@ -56,7 +56,6 @@ class OffsetSeqLog(sparkSession: SparkSession, path: String)
   throw new IllegalStateException("Incomplete log file")
 }
 
-val version = parseVersion(lines.next(), OffsetSeqLog.VERSION)
 
 Review comment:
   Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23583: [MINOR][TEST]Correct some unit test mistakes

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23583: [MINOR][TEST]Correct some unit 
test mistakes
URL: https://github.com/apache/spark/pull/23583#issuecomment-455756094
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23583: [MINOR][TEST]Correct some unit test mistakes

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23583: [MINOR][TEST]Correct some unit 
test mistakes
URL: https://github.com/apache/spark/pull/23583#issuecomment-455756095
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7225/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23583: [MINOR][TEST]Correct some unit test mistakes

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23583: [MINOR][TEST]Correct some unit test 
mistakes
URL: https://github.com/apache/spark/pull/23583#issuecomment-455756095
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7225/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23583: [MINOR][TEST]Correct some unit test mistakes

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23583: [MINOR][TEST]Correct some unit test 
mistakes
URL: https://github.com/apache/spark/pull/23583#issuecomment-455756094
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23583: [MINOR][TEST]Correct some unit test mistakes

2019-01-18 Thread GitBox
SparkQA commented on issue #23583: [MINOR][TEST]Correct some unit test mistakes
URL: https://github.com/apache/spark/pull/23583#issuecomment-455756065
 
 
   **[Test build #101425 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101425/testReport)**
 for PR 23583 at commit 
[`ffb0ca1`](https://github.com/apache/spark/commit/ffb0ca1743308f21736fe04769334c4791004fc4).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs in SHS

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New 
feature: apply custom log URL pattern for executor log URLs in SHS
URL: https://github.com/apache/spark/pull/23260#issuecomment-455754825
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101422/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs in SHS

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New 
feature: apply custom log URL pattern for executor log URLs in SHS
URL: https://github.com/apache/spark/pull/23260#issuecomment-455754823
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs in SHS

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs in SHS
URL: https://github.com/apache/spark/pull/23260#issuecomment-455754823
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs in SHS

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs in SHS
URL: https://github.com/apache/spark/pull/23260#issuecomment-455754825
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101422/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA removed a comment on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs in SHS

2019-01-18 Thread GitBox
SparkQA removed a comment on issue #23260: [SPARK-26311][CORE] New feature: 
apply custom log URL pattern for executor log URLs in SHS
URL: https://github.com/apache/spark/pull/23260#issuecomment-455742998
 
 
   **[Test build #101422 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101422/testReport)**
 for PR 23260 at commit 
[`7939043`](https://github.com/apache/spark/commit/79390431fbca77821cb9b647af7ff6138273e6c2).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs in SHS

2019-01-18 Thread GitBox
SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs in SHS
URL: https://github.com/apache/spark/pull/23260#issuecomment-455754749
 
 
   **[Test build #101422 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101422/testReport)**
 for PR 23260 at commit 
[`7939043`](https://github.com/apache/spark/commit/79390431fbca77821cb9b647af7ff6138273e6c2).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23589: [SPARK-26351][mllib]Update doc 
and minor correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455752344
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101423/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23589: [SPARK-26351][mllib]Update doc 
and minor correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455752342
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23589: [SPARK-26351][mllib]Update doc and 
minor correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455752344
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101423/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA removed a comment on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
SparkQA removed a comment on issue #23589: [SPARK-26351][mllib]Update doc and 
minor correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455749051
 
 
   **[Test build #101423 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101423/testReport)**
 for PR 23589 at commit 
[`a160561`](https://github.com/apache/spark/commit/a160561d8e77e2164ef1b36bafb19f82964eb1af).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23589: [SPARK-26351][mllib]Update doc and 
minor correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455752342
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
SparkQA commented on issue #23589: [SPARK-26351][mllib]Update doc and minor 
correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455752295
 
 
   **[Test build #101423 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101423/testReport)**
 for PR 23589 at commit 
[`a160561`](https://github.com/apache/spark/commit/a160561d8e77e2164ef1b36bafb19f82964eb1af).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] HyukjinKwon closed pull request #23591: [SPARK-24740][PYTHON][ML][BACKPORT-2.3] Make PySpark's tests compatible with NumPy 1.14+

2019-01-18 Thread GitBox
HyukjinKwon closed pull request #23591: [SPARK-24740][PYTHON][ML][BACKPORT-2.3] 
Make PySpark's tests compatible with NumPy 1.14+
URL: https://github.com/apache/spark/pull/23591
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23412: [SPARK-26477][CORE] Use ConfigEntry for hardcoded configs for unsafe category

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23412: [SPARK-26477][CORE] Use ConfigEntry 
for hardcoded configs for unsafe category 
URL: https://github.com/apache/spark/pull/23412#issuecomment-455751575
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23412: [SPARK-26477][CORE] Use ConfigEntry for hardcoded configs for unsafe category

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23412: [SPARK-26477][CORE] Use 
ConfigEntry for hardcoded configs for unsafe category 
URL: https://github.com/apache/spark/pull/23412#issuecomment-455751575
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23412: [SPARK-26477][CORE] Use ConfigEntry for hardcoded configs for unsafe category

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23412: [SPARK-26477][CORE] Use 
ConfigEntry for hardcoded configs for unsafe category 
URL: https://github.com/apache/spark/pull/23412#issuecomment-455751576
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101418/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23412: [SPARK-26477][CORE] Use ConfigEntry for hardcoded configs for unsafe category

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23412: [SPARK-26477][CORE] Use ConfigEntry 
for hardcoded configs for unsafe category 
URL: https://github.com/apache/spark/pull/23412#issuecomment-455751576
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101418/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA removed a comment on issue #23412: [SPARK-26477][CORE] Use ConfigEntry for hardcoded configs for unsafe category

2019-01-18 Thread GitBox
SparkQA removed a comment on issue #23412: [SPARK-26477][CORE] Use ConfigEntry 
for hardcoded configs for unsafe category 
URL: https://github.com/apache/spark/pull/23412#issuecomment-455730744
 
 
   **[Test build #101418 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101418/testReport)**
 for PR 23412 at commit 
[`66f9ef0`](https://github.com/apache/spark/commit/66f9ef054d8214539d09b340844bbc84f02d9d8d).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23412: [SPARK-26477][CORE] Use ConfigEntry for hardcoded configs for unsafe category

2019-01-18 Thread GitBox
SparkQA commented on issue #23412: [SPARK-26477][CORE] Use ConfigEntry for 
hardcoded configs for unsafe category 
URL: https://github.com/apache/spark/pull/23412#issuecomment-455751486
 
 
   **[Test build #101418 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101418/testReport)**
 for PR 23412 at commit 
[`66f9ef0`](https://github.com/apache/spark/commit/66f9ef054d8214539d09b340844bbc84f02d9d8d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] 10110346 commented on a change in pull request #23583: [MINOR]Remove unused symbols

2019-01-18 Thread GitBox
10110346 commented on a change in pull request #23583: [MINOR]Remove unused 
symbols
URL: https://github.com/apache/spark/pull/23583#discussion_r249234653
 
 

 ##
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##
 @@ -308,7 +308,6 @@ private[spark] class SparkSubmit extends Logging {
 val isMesosCluster = clusterManager == MESOS && deployMode == CLUSTER
 val isStandAloneCluster = clusterManager == STANDALONE && deployMode == 
CLUSTER
 val isKubernetesCluster = clusterManager == KUBERNETES && deployMode == 
CLUSTER
 
 Review comment:
   OK, thank you


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs in SHS

2019-01-18 Thread GitBox
SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs in SHS
URL: https://github.com/apache/spark/pull/23260#issuecomment-455749858
 
 
   **[Test build #101424 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101424/testReport)**
 for PR 23260 at commit 
[`0353a04`](https://github.com/apache/spark/commit/0353a04b1d6bcdee26fa4a2369cd226afdef1f15).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23589: [SPARK-26351][mllib]Update doc and 
minor correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455749103
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7224/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23589: [SPARK-26351][mllib]Update doc 
and minor correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455749103
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7224/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
SparkQA commented on issue #23589: [SPARK-26351][mllib]Update doc and minor 
correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455749051
 
 
   **[Test build #101423 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101423/testReport)**
 for PR 23589 at commit 
[`a160561`](https://github.com/apache/spark/commit/a160561d8e77e2164ef1b36bafb19f82964eb1af).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23589: [SPARK-26351][mllib]Update doc and 
minor correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455749102
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23589: [SPARK-26351][mllib]Update doc 
and minor correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455749102
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] shahidki31 commented on issue #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

2019-01-18 Thread GitBox
shahidki31 commented on issue #23589: [SPARK-26351][mllib]Update doc and minor 
correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#issuecomment-455748912
 
 
   Jenkins, retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] maropu commented on issue #23591: [SPARK-24740][PYTHON][ML][BACKPORT-2.3] Make PySpark's tests compatible with NumPy 1.14+

2019-01-18 Thread GitBox
maropu commented on issue #23591: [SPARK-24740][PYTHON][ML][BACKPORT-2.3] Make 
PySpark's tests compatible with NumPy 1.14+
URL: https://github.com/apache/spark/pull/23591#issuecomment-455747869
 
 
   Merged to branch-2.3


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] maropu edited a comment on issue #23580: [SPARK-26660]Add warning logs for large taskBinary size

2019-01-18 Thread GitBox
maropu edited a comment on issue #23580: [SPARK-26660]Add warning logs for 
large taskBinary size
URL: https://github.com/apache/spark/pull/23580#issuecomment-455720648
 
 
   +1 for @jerryshao suggestion, I feel its a bit confusing to add it...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] xy2953396112 commented on a change in pull request #23584: [SPARK-21213][SQL][FOLLOWUP] Compare with old partition stats instead of old table stats in AnalyzePartitionCommand

2019-01-18 Thread GitBox
xy2953396112 commented on a change in pull request #23584: 
[SPARK-21213][SQL][FOLLOWUP] Compare with old partition stats instead of old 
table stats in AnalyzePartitionCommand
URL: https://github.com/apache/spark/pull/23584#discussion_r249233254
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzePartitionCommand.scala
 ##
 @@ -110,7 +110,7 @@ case class AnalyzePartitionCommand(
   val newTotalSize = CommandUtils.calculateLocationSize(
 sessionState, tableMeta.identifier, p.storage.locationUri)
   val newRowCount = rowCounts.get(p.spec)
-  val newStats = CommandUtils.compareAndGetNewStats(tableMeta.stats, 
newTotalSize, newRowCount)
+  val newStats = CommandUtils.compareAndGetNewStats(p.stats, newTotalSize, 
newRowCount)
 
 Review comment:
   is there different?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23576: [SPARK-26655] [SS] Support multiple aggregates in append mode

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23576: [SPARK-26655] [SS] Support multiple 
aggregates in append mode
URL: https://github.com/apache/spark/pull/23576#issuecomment-455744855
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23576: [SPARK-26655] [SS] Support multiple aggregates in append mode

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23576: [SPARK-26655] [SS] Support 
multiple aggregates in append mode
URL: https://github.com/apache/spark/pull/23576#issuecomment-455744855
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23576: [SPARK-26655] [SS] Support multiple aggregates in append mode

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23576: [SPARK-26655] [SS] Support multiple 
aggregates in append mode
URL: https://github.com/apache/spark/pull/23576#issuecomment-455744857
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101415/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23576: [SPARK-26655] [SS] Support multiple aggregates in append mode

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23576: [SPARK-26655] [SS] Support 
multiple aggregates in append mode
URL: https://github.com/apache/spark/pull/23576#issuecomment-455744857
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101415/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23576: [SPARK-26655] [SS] Support multiple aggregates in append mode

2019-01-18 Thread GitBox
SparkQA commented on issue #23576: [SPARK-26655] [SS] Support multiple 
aggregates in append mode
URL: https://github.com/apache/spark/pull/23576#issuecomment-455744733
 
 
   **[Test build #101415 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101415/testReport)**
 for PR 23576 at commit 
[`3dc918c`](https://github.com/apache/spark/commit/3dc918c23a43074b260afe3fd6125f049820b60b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA removed a comment on issue #23576: [SPARK-26655] [SS] Support multiple aggregates in append mode

2019-01-18 Thread GitBox
SparkQA removed a comment on issue #23576: [SPARK-26655] [SS] Support multiple 
aggregates in append mode
URL: https://github.com/apache/spark/pull/23576#issuecomment-455717233
 
 
   **[Test build #101415 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101415/testReport)**
 for PR 23576 at commit 
[`3dc918c`](https://github.com/apache/spark/commit/3dc918c23a43074b260afe3fd6125f049820b60b).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] HyukjinKwon commented on a change in pull request #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
HyukjinKwon commented on a change in pull request #20691: [SPARK-18161] 
[Python] Update cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#discussion_r249232387
 
 

 ##
 File path: python/pyspark/serializers.py
 ##
 @@ -606,7 +604,7 @@ class PickleSerializer(FramedSerializer):
 """
 
 def dumps(self, obj):
-return pickle.dumps(obj, protocol)
+return pickle.dumps(obj, pickle.HIGHEST_PROTOCOL)
 
 Review comment:
   Let's poll out this as a constant variable for the possibility that users 
want to monkeypatch it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] HyukjinKwon commented on a change in pull request #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
HyukjinKwon commented on a change in pull request #20691: [SPARK-18161] 
[Python] Update cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#discussion_r249232099
 
 

 ##
 File path: python/pyspark/broadcast.py
 ##
 @@ -110,7 +110,7 @@ def __init__(self, sc=None, value=None, 
pickle_registry=None, path=None,
 
 def dump(self, value, f):
 try:
-pickle.dump(value, f, 2)
+pickle.dump(value, f, pickle.HIGHEST_PROTOCOL)
 
 Review comment:
   Yea, it should be great if we know the context about why it was set 2 
previously. I suspect there's no particular reason but should be good to double 
check and leave the reason if it's able to find.
   
   The highest pickle protocol will be 2 in Python 2 and 4 in Python 3.4+. So, 
we're changing it from 2 to 4 when Python 3.4+.
   
   One possibility is that it was set to 2 for the worry about writing and 
reading even in different Python versions but I don't think that's not 
guranteed in PySpark. Maybe we should explicitly note this somewhere as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23582: [SPARK-26661][SQL] Show actual class name of the writing command in CTAS explain

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23582: [SPARK-26661][SQL] Show actual 
class name of the writing command in CTAS explain
URL: https://github.com/apache/spark/pull/23582#issuecomment-455743161
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101419/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23582: [SPARK-26661][SQL] Show actual class name of the writing command in CTAS explain

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23582: [SPARK-26661][SQL] Show actual 
class name of the writing command in CTAS explain
URL: https://github.com/apache/spark/pull/23582#issuecomment-455743159
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23582: [SPARK-26661][SQL] Show actual class name of the writing command in CTAS explain

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23582: [SPARK-26661][SQL] Show actual class 
name of the writing command in CTAS explain
URL: https://github.com/apache/spark/pull/23582#issuecomment-455743161
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101419/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23582: [SPARK-26661][SQL] Show actual class name of the writing command in CTAS explain

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23582: [SPARK-26661][SQL] Show actual class 
name of the writing command in CTAS explain
URL: https://github.com/apache/spark/pull/23582#issuecomment-455743159
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23582: [SPARK-26661][SQL] Show actual class name of the writing command in CTAS explain

2019-01-18 Thread GitBox
SparkQA commented on issue #23582: [SPARK-26661][SQL] Show actual class name of 
the writing command in CTAS explain
URL: https://github.com/apache/spark/pull/23582#issuecomment-455743079
 
 
   **[Test build #101419 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101419/testReport)**
 for PR 23582 at commit 
[`50f02d5`](https://github.com/apache/spark/commit/50f02d53c26351d05141b6fd78c837303cee3ccb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA removed a comment on issue #23582: [SPARK-26661][SQL] Show actual class name of the writing command in CTAS explain

2019-01-18 Thread GitBox
SparkQA removed a comment on issue #23582: [SPARK-26661][SQL] Show actual class 
name of the writing command in CTAS explain
URL: https://github.com/apache/spark/pull/23582#issuecomment-455731482
 
 
   **[Test build #101419 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101419/testReport)**
 for PR 23582 at commit 
[`50f02d5`](https://github.com/apache/spark/commit/50f02d53c26351d05141b6fd78c837303cee3ccb).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455742998
 
 
   **[Test build #101422 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101422/testReport)**
 for PR 23260 at commit 
[`7939043`](https://github.com/apache/spark/commit/79390431fbca77821cb9b647af7ff6138273e6c2).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] HyukjinKwon commented on a change in pull request #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
HyukjinKwon commented on a change in pull request #20691: [SPARK-18161] 
[Python] Update cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#discussion_r249231927
 
 

 ##
 File path: python/pyspark/broadcast.py
 ##
 @@ -110,7 +110,7 @@ def __init__(self, sc=None, value=None, 
pickle_registry=None, path=None,
 
 def dump(self, value, f):
 try:
-pickle.dump(value, f, 2)
+pickle.dump(value, f, pickle.HIGHEST_PROTOCOL)
 
 Review comment:
   Ah, yea. this PR was previously setting the protocol to highest one to 
support 4gb+ pickle alone in the regular pickle (not including cloudpickle).
   
   So I suggested to target upgrade Cloudpickle because upper Cloudpickle has 
that change to use highest protocol even though upgrading Cloudpickle is 
slightly orthogonal.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New 
feature: apply custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455742124
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101421/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New 
feature: apply custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455742121
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455742115
 
 
   **[Test build #101421 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101421/testReport)**
 for PR 23260 at commit 
[`4620075`](https://github.com/apache/spark/commit/4620075619f6a524e21b6a420aec6d3478e3a772).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA removed a comment on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
SparkQA removed a comment on issue #23260: [SPARK-26311][CORE] New feature: 
apply custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455741521
 
 
   **[Test build #101421 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101421/testReport)**
 for PR 23260 at commit 
[`4620075`](https://github.com/apache/spark/commit/4620075619f6a524e21b6a420aec6d3478e3a772).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455742124
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101421/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455742121
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455741521
 
 
   **[Test build #101421 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101421/testReport)**
 for PR 23260 at commit 
[`4620075`](https://github.com/apache/spark/commit/4620075619f6a524e21b6a420aec6d3478e3a772).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New 
feature: apply custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455740527
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101420/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23260: [SPARK-26311][CORE] New 
feature: apply custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455740526
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA removed a comment on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
SparkQA removed a comment on issue #23260: [SPARK-26311][CORE] New feature: 
apply custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455739758
 
 
   **[Test build #101420 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101420/testReport)**
 for PR 23260 at commit 
[`fd764cf`](https://github.com/apache/spark/commit/fd764cfa7a0b8f3de0ff857cacf39de1539dd6d3).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455740527
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101420/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
SparkQA commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455740520
 
 
   **[Test build #101420 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101420/testReport)**
 for PR 23260 at commit 
[`fd764cf`](https://github.com/apache/spark/commit/fd764cfa7a0b8f3de0ff857cacf39de1539dd6d3).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply custom log URL pattern for executor log URLs

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23260: [SPARK-26311][CORE] New feature: apply 
custom log URL pattern for executor log URLs
URL: https://github.com/apache/spark/pull/23260#issuecomment-455740526
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] HeartSaVioR edited a comment on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr

2019-01-18 Thread GitBox
HeartSaVioR edited a comment on issue #23260: [SPARK-26311][YARN] New feature: 
custom log URL for stdout/stderr
URL: https://github.com/apache/spark/pull/23260#issuecomment-455739953
 
 
   @squito 
   I just added new config to toggle applying custom log url for incomplete 
applications. 
(`spark.history.custom.executor.log.url.applyIncompleteApplication`) 
   I guess this config can address both of use cases.
   
   Also addressed applying custom log url for driver logs as well when RM is 
yarn and the app is running in cluster mode.
   
   Tested from both UTs and YARN cluster.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] viirya commented on a change in pull request #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
viirya commented on a change in pull request #20691: [SPARK-18161] [Python] 
Update cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#discussion_r249229460
 
 

 ##
 File path: python/pyspark/broadcast.py
 ##
 @@ -110,7 +110,7 @@ def __init__(self, sc=None, value=None, 
pickle_registry=None, path=None,
 
 def dump(self, value, f):
 try:
-pickle.dump(value, f, 2)
+pickle.dump(value, f, pickle.HIGHEST_PROTOCOL)
 
 Review comment:
   Mind I ask about the context? why we always use protocol 2 previously?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] viirya commented on a change in pull request #20691: [SPARK-18161] [Python] Update cloudpickle to v0.6.1

2019-01-18 Thread GitBox
viirya commented on a change in pull request #20691: [SPARK-18161] [Python] 
Update cloudpickle to v0.6.1
URL: https://github.com/apache/spark/pull/20691#discussion_r249229523
 
 

 ##
 File path: python/pyspark/broadcast.py
 ##
 @@ -110,7 +110,7 @@ def __init__(self, sc=None, value=None, 
pickle_registry=None, path=None,
 
 def dump(self, value, f):
 try:
-pickle.dump(value, f, 2)
+pickle.dump(value, f, pickle.HIGHEST_PROTOCOL)
 
 Review comment:
   Is this change related to upgrading cloudpickle?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] HeartSaVioR commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr

2019-01-18 Thread GitBox
HeartSaVioR commented on issue #23260: [SPARK-26311][YARN] New feature: custom 
log URL for stdout/stderr
URL: https://github.com/apache/spark/pull/23260#issuecomment-455739953
 
 
   @squito 
   I just added new config to toggle applying custom log url for incomplete 
applications. 
(`spark.history.custom.executor.log.url.applyIncompleteApplication`) 
   I guess this config can address both of use cases.
   
   Also addressed applying custom log url for driver logs as well when RM is 
yarn and the app is running in cluster mode.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] kiszk commented on issue #23416: [SPARK-26463][CORE] Use ConfigEntry for hardcoded configs for scheduler categories.

2019-01-18 Thread GitBox
kiszk commented on issue #23416: [SPARK-26463][CORE] Use ConfigEntry for 
hardcoded configs for scheduler categories.
URL: https://github.com/apache/spark/pull/23416#issuecomment-455739840
 
 
   I will do this today


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23260: [SPARK-26311][YARN] New feature: custom log URL for stdout/stderr

2019-01-18 Thread GitBox
SparkQA commented on issue #23260: [SPARK-26311][YARN] New feature: custom log 
URL for stdout/stderr
URL: https://github.com/apache/spark/pull/23260#issuecomment-455739758
 
 
   **[Test build #101420 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101420/testReport)**
 for PR 23260 at commit 
[`fd764cf`](https://github.com/apache/spark/commit/fd764cfa7a0b8f3de0ff857cacf39de1539dd6d3).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23590: [SPARK-26665][Core]Fix a bug that BlockTransferService.fetchBlockSync may hang forever

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23590: [SPARK-26665][Core]Fix a bug 
that BlockTransferService.fetchBlockSync may hang forever
URL: https://github.com/apache/spark/pull/23590#issuecomment-455737545
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101413/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23590: [SPARK-26665][Core]Fix a bug that BlockTransferService.fetchBlockSync may hang forever

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23590: [SPARK-26665][Core]Fix a bug 
that BlockTransferService.fetchBlockSync may hang forever
URL: https://github.com/apache/spark/pull/23590#issuecomment-455737543
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23590: [SPARK-26665][Core]Fix a bug that BlockTransferService.fetchBlockSync may hang forever

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23590: [SPARK-26665][Core]Fix a bug that 
BlockTransferService.fetchBlockSync may hang forever
URL: https://github.com/apache/spark/pull/23590#issuecomment-455737543
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23590: [SPARK-26665][Core]Fix a bug that BlockTransferService.fetchBlockSync may hang forever

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23590: [SPARK-26665][Core]Fix a bug that 
BlockTransferService.fetchBlockSync may hang forever
URL: https://github.com/apache/spark/pull/23590#issuecomment-455737545
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101413/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA removed a comment on issue #23590: [SPARK-26665][Core]Fix a bug that BlockTransferService.fetchBlockSync may hang forever

2019-01-18 Thread GitBox
SparkQA removed a comment on issue #23590: [SPARK-26665][Core]Fix a bug that 
BlockTransferService.fetchBlockSync may hang forever
URL: https://github.com/apache/spark/pull/23590#issuecomment-455701716
 
 
   **[Test build #101413 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101413/testReport)**
 for PR 23590 at commit 
[`da1aaac`](https://github.com/apache/spark/commit/da1aaac7cb1b0687ec2e19c5049b96e216f9dce2).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23590: [SPARK-26665][Core]Fix a bug that BlockTransferService.fetchBlockSync may hang forever

2019-01-18 Thread GitBox
SparkQA commented on issue #23590: [SPARK-26665][Core]Fix a bug that 
BlockTransferService.fetchBlockSync may hang forever
URL: https://github.com/apache/spark/pull/23590#issuecomment-455737465
 
 
   **[Test build #101413 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101413/testReport)**
 for PR 23590 at commit 
[`da1aaac`](https://github.com/apache/spark/commit/da1aaac7cb1b0687ec2e19c5049b96e216f9dce2).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] HyukjinKwon commented on issue #23588: Diversity

2019-01-18 Thread GitBox
HyukjinKwon commented on issue #23588: Diversity
URL: https://github.com/apache/spark/pull/23588#issuecomment-455736902
 
 
   Please review http://spark.apache.org/contributing.html before opening a 
pull request.
   
   Also, I don't think it's worth to fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] HyukjinKwon closed pull request #23588: Diversity

2019-01-18 Thread GitBox
HyukjinKwon closed pull request #23588: Diversity
URL: https://github.com/apache/spark/pull/23588
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #22114: [SPARK-24938][Core] Prevent Netty from using onheap memory for headers without regard for configuration

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #22114: [SPARK-24938][Core] Prevent Netty from 
using onheap memory for headers without regard for configuration
URL: https://github.com/apache/spark/pull/22114#issuecomment-455736382
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101411/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #22114: [SPARK-24938][Core] Prevent Netty from using onheap memory for headers without regard for configuration

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #22114: [SPARK-24938][Core] Prevent 
Netty from using onheap memory for headers without regard for configuration
URL: https://github.com/apache/spark/pull/22114#issuecomment-455736382
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101411/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #22114: [SPARK-24938][Core] Prevent Netty from using onheap memory for headers without regard for configuration

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #22114: [SPARK-24938][Core] Prevent 
Netty from using onheap memory for headers without regard for configuration
URL: https://github.com/apache/spark/pull/22114#issuecomment-455736378
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #22114: [SPARK-24938][Core] Prevent Netty from using onheap memory for headers without regard for configuration

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #22114: [SPARK-24938][Core] Prevent Netty from 
using onheap memory for headers without regard for configuration
URL: https://github.com/apache/spark/pull/22114#issuecomment-455736378
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #22114: [SPARK-24938][Core] Prevent Netty from using onheap memory for headers without regard for configuration

2019-01-18 Thread GitBox
SparkQA commented on issue #22114: [SPARK-24938][Core] Prevent Netty from using 
onheap memory for headers without regard for configuration
URL: https://github.com/apache/spark/pull/22114#issuecomment-455736166
 
 
   **[Test build #101411 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101411/testReport)**
 for PR 22114 at commit 
[`23bc1f0`](https://github.com/apache/spark/commit/23bc1f00f5e3ea3fa384ea338f883cffe3e3fa6a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA removed a comment on issue #22114: [SPARK-24938][Core] Prevent Netty from using onheap memory for headers without regard for configuration

2019-01-18 Thread GitBox
SparkQA removed a comment on issue #22114: [SPARK-24938][Core] Prevent Netty 
from using onheap memory for headers without regard for configuration
URL: https://github.com/apache/spark/pull/22114#issuecomment-455681642
 
 
   **[Test build #101411 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101411/testReport)**
 for PR 22114 at commit 
[`23bc1f0`](https://github.com/apache/spark/commit/23bc1f00f5e3ea3fa384ea338f883cffe3e3fa6a).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA removed a comment on issue #23592: [SPARK-16838][PYTHON]Add PMML export for ML KMeans in PySpark

2019-01-18 Thread GitBox
SparkQA removed a comment on issue #23592: [SPARK-16838][PYTHON]Add PMML export 
for ML KMeans in PySpark
URL: https://github.com/apache/spark/pull/23592#issuecomment-455730739
 
 
   **[Test build #101417 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101417/testReport)**
 for PR 23592 at commit 
[`680e018`](https://github.com/apache/spark/commit/680e018db21ec9a89c501c617abe4c31571ddb65).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins removed a comment on issue #23592: [SPARK-16838][PYTHON]Add PMML export for ML KMeans in PySpark

2019-01-18 Thread GitBox
AmplabJenkins removed a comment on issue #23592: [SPARK-16838][PYTHON]Add PMML 
export for ML KMeans in PySpark
URL: https://github.com/apache/spark/pull/23592#issuecomment-455732927
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/101417/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] SparkQA commented on issue #23592: [SPARK-16838][PYTHON]Add PMML export for ML KMeans in PySpark

2019-01-18 Thread GitBox
SparkQA commented on issue #23592: [SPARK-16838][PYTHON]Add PMML export for ML 
KMeans in PySpark
URL: https://github.com/apache/spark/pull/23592#issuecomment-455732846
 
 
   **[Test build #101417 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/101417/testReport)**
 for PR 23592 at commit 
[`680e018`](https://github.com/apache/spark/commit/680e018db21ec9a89c501c617abe4c31571ddb65).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `class KMeansModel(JavaModel, GeneralJavaMLWritable, JavaMLReadable):`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] AmplabJenkins commented on issue #23592: [SPARK-16838][PYTHON]Add PMML export for ML KMeans in PySpark

2019-01-18 Thread GitBox
AmplabJenkins commented on issue #23592: [SPARK-16838][PYTHON]Add PMML export 
for ML KMeans in PySpark
URL: https://github.com/apache/spark/pull/23592#issuecomment-455732926
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



  1   2   3   4   5   6   >