[GitHub] [spark] gatorsmile commented on a change in pull request #24767: [WIP][SPARK-27918][SQL] Port boolean.sql

[GitBox]

gatorsmile commented on a change in pull request #24767: 
[WIP][SPARK-27918][SQL] Port boolean.sql
URL: https://github.com/apache/spark/pull/24767#discussion_r289695819
 
 

 ##
 File path: sql/core/src/test/resources/sql-tests/results/pgSQL/boolean.sql.out
 ##
 @@ -0,0 +1,710 @@
+-- Automatically generated by SQLQueryTestSuite
+-- Number of queries: 81
+
+
+-- !query 0
+SELECT 1 AS one
+-- !query 0 schema
+struct
+-- !query 0 output
+1
+
+
+-- !query 1
+SELECT true AS true
+-- !query 1 schema
+struct
+-- !query 1 output
+true
+
+
+-- !query 2
+SELECT false AS false
+-- !query 2 schema
+struct
+-- !query 2 output
+false
+
+
+-- !query 3
+SELECT cast('t' as boolean) AS true
+-- !query 3 schema
+struct
+-- !query 3 output
+true
+
+
+-- !query 4
+SELECT cast('   f   ' as boolean) AS false
+-- !query 4 schema
+struct
+-- !query 4 output
+NULL
+
+
+-- !query 5
+SELECT cast('true' as boolean) AS true
+-- !query 5 schema
+struct
+-- !query 5 output
+true
+
+
+-- !query 6
+SELECT cast('test' as boolean) AS error
+-- !query 6 schema
+struct
+-- !query 6 output
+NULL
+
+
+-- !query 7
+SELECT cast('false' as boolean) AS false
+-- !query 7 schema
+struct
+-- !query 7 output
+false
+
+
+-- !query 8
+SELECT cast('foo' as boolean) AS error
+-- !query 8 schema
+struct
+-- !query 8 output
+NULL
+
+
+-- !query 9
+SELECT cast('y' as boolean) AS true
+-- !query 9 schema
+struct
+-- !query 9 output
+true
+
+
+-- !query 10
+SELECT cast('yes' as boolean) AS true
+-- !query 10 schema
+struct
+-- !query 10 output
+true
+
+
+-- !query 11
+SELECT cast('yeah' as boolean) AS error
+-- !query 11 schema
+struct
+-- !query 11 output
+NULL
+
+
+-- !query 12
+SELECT cast('n' as boolean) AS false
+-- !query 12 schema
+struct
+-- !query 12 output
+false
+
+
+-- !query 13
+SELECT cast('no' as boolean) AS false
+-- !query 13 schema
+struct
+-- !query 13 output
+false
+
+
+-- !query 14
+SELECT cast('nay' as boolean) AS error
+-- !query 14 schema
+struct
+-- !query 14 output
+NULL
+
+
+-- !query 15
+SELECT cast('on' as boolean) AS true
+-- !query 15 schema
+struct
+-- !query 15 output
+NULL
+
+
+-- !query 16
+SELECT cast('off' as boolean) AS false
+-- !query 16 schema
+struct
+-- !query 16 output
+NULL
+
+
+-- !query 17
+SELECT cast('of' as boolean) AS false
+-- !query 17 schema
+struct
+-- !query 17 output
+NULL
+
+
+-- !query 18
+SELECT cast('o' as boolean) AS error
+-- !query 18 schema
+struct
+-- !query 18 output
+NULL
+
+
+-- !query 19
+SELECT cast('on_' as boolean) AS error
+-- !query 19 schema
+struct
+-- !query 19 output
+NULL
+
+
+-- !query 20
+SELECT cast('off_' as boolean) AS error
+-- !query 20 schema
+struct
+-- !query 20 output
+NULL
+
+
+-- !query 21
+SELECT cast('1' as boolean) AS true
+-- !query 21 schema
+struct
+-- !query 21 output
+true
+
+
+-- !query 22
+SELECT cast('11' as boolean) AS error
+-- !query 22 schema
+struct
+-- !query 22 output
+NULL
+
+
+-- !query 23
+SELECT cast('0' as boolean) AS false
+-- !query 23 schema
+struct
+-- !query 23 output
+false
+
+
+-- !query 24
+SELECT cast('000' as boolean) AS error
+-- !query 24 schema
+struct
+-- !query 24 output
+NULL
+
+
+-- !query 25
+SELECT cast('' as boolean) AS error
+-- !query 25 schema
+struct
+-- !query 25 output
+NULL
+
+
+-- !query 26
+SELECT cast('t' as boolean) or cast('f' as boolean) AS true
+-- !query 26 schema
+struct
+-- !query 26 output
+true
+
+
+-- !query 27
+SELECT cast('t' as boolean) and cast('f' as boolean) AS false
+-- !query 27 schema
+struct
+-- !query 27 output
+false
+
+
+-- !query 28
+SELECT not cast('f' as boolean) AS true
+-- !query 28 schema
+struct
+-- !query 28 output
+true
+
+
+-- !query 29
+SELECT cast('t' as boolean) = cast('f' as boolean) AS false
+-- !query 29 schema
+struct
+-- !query 29 output
+false
+
+
+-- !query 30
+SELECT cast('t' as boolean) <> cast('f' as boolean) AS true
+-- !query 30 schema
+struct
+-- !query 30 output
+true
+
+
+-- !query 31
+SELECT cast('t' as boolean) > cast('f' as boolean) AS true
+-- !query 31 schema
+struct
+-- !query 31 output
+true
+
+
+-- !query 32
+SELECT cast('t' as boolean) >= cast('f' as boolean) AS true
+-- !query 32 schema
+struct
+-- !query 32 output
+true
+
+
+-- !query 33
+SELECT cast('f' as boolean) < cast('t' as boolean) AS true
+-- !query 33 schema
+struct
+-- !query 33 output
+true
+
+
+-- !query 34
+SELECT cast('f' as boolean) <= cast('t' as boolean) AS true
+-- !query 34 schema
+struct
+-- !query 34 output
+true
+
+
+-- !query 35
+SELECT cast(cast('TrUe' as string) as boolean) AS true, cast(cast('fAlse' as 
string) as boolean) AS false
+-- !query 35 schema
+struct
+-- !query 35 output
+true   false
+
+
+-- !query 36
+SELECT cast(cast('true   ' as string) as boolean) AS true,
+   cast(cast(' FALSE' as string) as boolean) AS false
+-- !query 36 schema
+struct
+-- !query 36 output
+NULL   NULL
 
 Review comment:
   Create a JIRA?


This is an automated message from the Apache Git Service.

[GitHub] [spark] gatorsmile commented on a change in pull request #24767: [WIP][SPARK-27918][SQL] Port boolean.sql

[GitBox]

gatorsmile commented on a change in pull request #24767: 
[WIP][SPARK-27918][SQL] Port boolean.sql
URL: https://github.com/apache/spark/pull/24767#discussion_r289695720
 
 

 ##
 File path: sql/core/src/test/resources/sql-tests/results/pgSQL/boolean.sql.out
 ##
 @@ -0,0 +1,710 @@
+-- Automatically generated by SQLQueryTestSuite
+-- Number of queries: 81
+
+
+-- !query 0
+SELECT 1 AS one
+-- !query 0 schema
+struct
+-- !query 0 output
+1
+
+
+-- !query 1
+SELECT true AS true
+-- !query 1 schema
+struct
+-- !query 1 output
+true
+
+
+-- !query 2
+SELECT false AS false
+-- !query 2 schema
+struct
+-- !query 2 output
+false
+
+
+-- !query 3
+SELECT cast('t' as boolean) AS true
+-- !query 3 schema
+struct
+-- !query 3 output
+true
+
+
+-- !query 4
+SELECT cast('   f   ' as boolean) AS false
+-- !query 4 schema
+struct
+-- !query 4 output
+NULL
+
+
+-- !query 5
+SELECT cast('true' as boolean) AS true
+-- !query 5 schema
+struct
+-- !query 5 output
+true
+
+
+-- !query 6
+SELECT cast('test' as boolean) AS error
+-- !query 6 schema
+struct
+-- !query 6 output
+NULL
+
+
+-- !query 7
+SELECT cast('false' as boolean) AS false
+-- !query 7 schema
+struct
+-- !query 7 output
+false
+
+
+-- !query 8
+SELECT cast('foo' as boolean) AS error
+-- !query 8 schema
+struct
+-- !query 8 output
+NULL
+
+
+-- !query 9
+SELECT cast('y' as boolean) AS true
+-- !query 9 schema
+struct
+-- !query 9 output
+true
+
+
+-- !query 10
+SELECT cast('yes' as boolean) AS true
+-- !query 10 schema
+struct
+-- !query 10 output
+true
+
+
+-- !query 11
+SELECT cast('yeah' as boolean) AS error
+-- !query 11 schema
+struct
+-- !query 11 output
+NULL
+
+
+-- !query 12
+SELECT cast('n' as boolean) AS false
+-- !query 12 schema
+struct
+-- !query 12 output
+false
+
+
+-- !query 13
+SELECT cast('no' as boolean) AS false
+-- !query 13 schema
+struct
+-- !query 13 output
+false
+
+
+-- !query 14
+SELECT cast('nay' as boolean) AS error
+-- !query 14 schema
+struct
+-- !query 14 output
+NULL
+
+
+-- !query 15
+SELECT cast('on' as boolean) AS true
+-- !query 15 schema
+struct
+-- !query 15 output
+NULL
+
+
+-- !query 16
+SELECT cast('off' as boolean) AS false
+-- !query 16 schema
+struct
+-- !query 16 output
+NULL
 
 Review comment:
   Create a JIRA?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gatorsmile commented on a change in pull request #24767: [WIP][SPARK-27918][SQL] Port boolean.sql

[GitBox]

gatorsmile commented on a change in pull request #24767: 
[WIP][SPARK-27918][SQL] Port boolean.sql
URL: https://github.com/apache/spark/pull/24767#discussion_r289695705
 
 

 ##
 File path: sql/core/src/test/resources/sql-tests/results/pgSQL/boolean.sql.out
 ##
 @@ -0,0 +1,710 @@
+-- Automatically generated by SQLQueryTestSuite
+-- Number of queries: 81
+
+
+-- !query 0
+SELECT 1 AS one
+-- !query 0 schema
+struct
+-- !query 0 output
+1
+
+
+-- !query 1
+SELECT true AS true
+-- !query 1 schema
+struct
+-- !query 1 output
+true
+
+
+-- !query 2
+SELECT false AS false
+-- !query 2 schema
+struct
+-- !query 2 output
+false
+
+
+-- !query 3
+SELECT cast('t' as boolean) AS true
+-- !query 3 schema
+struct
+-- !query 3 output
+true
+
+
+-- !query 4
+SELECT cast('   f   ' as boolean) AS false
+-- !query 4 schema
+struct
+-- !query 4 output
+NULL
+
+
+-- !query 5
+SELECT cast('true' as boolean) AS true
+-- !query 5 schema
+struct
+-- !query 5 output
+true
+
+
+-- !query 6
+SELECT cast('test' as boolean) AS error
+-- !query 6 schema
+struct
+-- !query 6 output
+NULL
+
+
+-- !query 7
+SELECT cast('false' as boolean) AS false
+-- !query 7 schema
+struct
+-- !query 7 output
+false
+
+
+-- !query 8
+SELECT cast('foo' as boolean) AS error
+-- !query 8 schema
+struct
+-- !query 8 output
+NULL
 
 Review comment:
   Create a JIRA?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gatorsmile commented on a change in pull request #24767: [WIP][SPARK-27918][SQL] Port boolean.sql

[GitBox]

gatorsmile commented on a change in pull request #24767: 
[WIP][SPARK-27918][SQL] Port boolean.sql
URL: https://github.com/apache/spark/pull/24767#discussion_r289695728
 
 

 ##
 File path: sql/core/src/test/resources/sql-tests/results/pgSQL/boolean.sql.out
 ##
 @@ -0,0 +1,710 @@
+-- Automatically generated by SQLQueryTestSuite
+-- Number of queries: 81
+
+
+-- !query 0
+SELECT 1 AS one
+-- !query 0 schema
+struct
+-- !query 0 output
+1
+
+
+-- !query 1
+SELECT true AS true
+-- !query 1 schema
+struct
+-- !query 1 output
+true
+
+
+-- !query 2
+SELECT false AS false
+-- !query 2 schema
+struct
+-- !query 2 output
+false
+
+
+-- !query 3
+SELECT cast('t' as boolean) AS true
+-- !query 3 schema
+struct
+-- !query 3 output
+true
+
+
+-- !query 4
+SELECT cast('   f   ' as boolean) AS false
+-- !query 4 schema
+struct
+-- !query 4 output
+NULL
+
+
+-- !query 5
+SELECT cast('true' as boolean) AS true
+-- !query 5 schema
+struct
+-- !query 5 output
+true
+
+
+-- !query 6
+SELECT cast('test' as boolean) AS error
+-- !query 6 schema
+struct
+-- !query 6 output
+NULL
+
+
+-- !query 7
+SELECT cast('false' as boolean) AS false
+-- !query 7 schema
+struct
+-- !query 7 output
+false
+
+
+-- !query 8
+SELECT cast('foo' as boolean) AS error
+-- !query 8 schema
+struct
+-- !query 8 output
+NULL
+
+
+-- !query 9
+SELECT cast('y' as boolean) AS true
+-- !query 9 schema
+struct
+-- !query 9 output
+true
+
+
+-- !query 10
+SELECT cast('yes' as boolean) AS true
+-- !query 10 schema
+struct
+-- !query 10 output
+true
+
+
+-- !query 11
+SELECT cast('yeah' as boolean) AS error
+-- !query 11 schema
+struct
+-- !query 11 output
+NULL
+
+
+-- !query 12
+SELECT cast('n' as boolean) AS false
+-- !query 12 schema
+struct
+-- !query 12 output
+false
+
+
+-- !query 13
+SELECT cast('no' as boolean) AS false
+-- !query 13 schema
+struct
+-- !query 13 output
+false
+
+
+-- !query 14
+SELECT cast('nay' as boolean) AS error
+-- !query 14 schema
+struct
+-- !query 14 output
+NULL
+
+
+-- !query 15
+SELECT cast('on' as boolean) AS true
+-- !query 15 schema
+struct
+-- !query 15 output
+NULL
+
+
+-- !query 16
+SELECT cast('off' as boolean) AS false
+-- !query 16 schema
+struct
+-- !query 16 output
+NULL
+
+
+-- !query 17
+SELECT cast('of' as boolean) AS false
+-- !query 17 schema
+struct
+-- !query 17 output
+NULL
 
 Review comment:
   Create a JIRA?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gatorsmile commented on a change in pull request #24767: [WIP][SPARK-27918][SQL] Port boolean.sql

[GitBox]

gatorsmile commented on a change in pull request #24767: 
[WIP][SPARK-27918][SQL] Port boolean.sql
URL: https://github.com/apache/spark/pull/24767#discussion_r289695549
 
 

 ##
 File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/boolean.sql
 ##
 @@ -0,0 +1,265 @@
+--
+-- Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group
+--
+--
+-- BOOLEAN
+-- 
https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/sql/boolean.sql
+
+--
+-- sanity check - if this fails go insane!
+--
+SELECT 1 AS one;
+
+
+-- **testing built-in type bool
+
+-- check bool input syntax
+
+SELECT true AS true;
+
+SELECT false AS false;
+
+SELECT cast('t' as boolean) AS true;
 
 Review comment:
   Check the other SQL engines?   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gatorsmile commented on a change in pull request #24767: [WIP][SPARK-27918][SQL] Port boolean.sql

[GitBox]

gatorsmile commented on a change in pull request #24767: 
[WIP][SPARK-27918][SQL] Port boolean.sql
URL: https://github.com/apache/spark/pull/24767#discussion_r289695586
 
 

 ##
 File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/boolean.sql
 ##
 @@ -0,0 +1,265 @@
+--
+-- Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group
+--
+--
+-- BOOLEAN
+-- 
https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/sql/boolean.sql
+
+--
+-- sanity check - if this fails go insane!
+--
+SELECT 1 AS one;
+
+
+-- **testing built-in type bool
+
+-- check bool input syntax
+
+SELECT true AS true;
+
+SELECT false AS false;
+
+SELECT cast('t' as boolean) AS true;
+
+SELECT cast('   f   ' as boolean) AS false;
+
+SELECT cast('true' as boolean) AS true;
+
+SELECT cast('test' as boolean) AS error;
+
+SELECT cast('false' as boolean) AS false;
+
+SELECT cast('foo' as boolean) AS error;
+
+SELECT cast('y' as boolean) AS true;
+
+SELECT cast('yes' as boolean) AS true;
+
+SELECT cast('yeah' as boolean) AS error;
+
+SELECT cast('n' as boolean) AS false;
+
+SELECT cast('no' as boolean) AS false;
+
+SELECT cast('nay' as boolean) AS error;
+
+SELECT cast('on' as boolean) AS true;
+
+SELECT cast('off' as boolean) AS false;
+
+SELECT cast('of' as boolean) AS false;
+
+SELECT cast('o' as boolean) AS error;
+
+SELECT cast('on_' as boolean) AS error;
+
+SELECT cast('off_' as boolean) AS error;
+
+SELECT cast('1' as boolean) AS true;
+
+SELECT cast('11' as boolean) AS error;
+
+SELECT cast('0' as boolean) AS false;
+
+SELECT cast('000' as boolean) AS error;
+
+SELECT cast('' as boolean) AS error;
+
+-- and, or, not in qualifications
+
+SELECT cast('t' as boolean) or cast('f' as boolean) AS true;
+
+SELECT cast('t' as boolean) and cast('f' as boolean) AS false;
+
+SELECT not cast('f' as boolean) AS true;
+
+SELECT cast('t' as boolean) = cast('f' as boolean) AS false;
+
+SELECT cast('t' as boolean) <> cast('f' as boolean) AS true;
+
+SELECT cast('t' as boolean) > cast('f' as boolean) AS true;
+
+SELECT cast('t' as boolean) >= cast('f' as boolean) AS true;
+
+SELECT cast('f' as boolean) < cast('t' as boolean) AS true;
+
+SELECT cast('f' as boolean) <= cast('t' as boolean) AS true;
+
+-- explicit casts to/from text
+SELECT cast(cast('TrUe' as string) as boolean) AS true, cast(cast('fAlse' as 
string) as boolean) AS false;
+SELECT cast(cast('true   ' as string) as boolean) AS true,
+   cast(cast(' FALSE' as string) as boolean) AS false;
+SELECT cast(cast(true as boolean) as string) AS true, cast(cast(false as 
boolean) as string) AS false;
+
+SELECT cast(cast('  tru e ' as string) as boolean) AS invalid;-- error
+SELECT cast(cast('' as string) as boolean) AS invalid;-- error
+
+CREATE TABLE BOOLTBL1 (f1 boolean) USING parquet;
+
+INSERT INTO BOOLTBL1 VALUES (cast('t' as boolean));
+
+INSERT INTO BOOLTBL1 VALUES (cast('True' as boolean));
+
+INSERT INTO BOOLTBL1 VALUES (cast('true' as boolean));
+
+
+-- BOOLTBL1 should be full of true's at this point
+SELECT '' AS t_3, BOOLTBL1.* FROM BOOLTBL1;
+
+
+SELECT '' AS t_3, BOOLTBL1.*
+   FROM BOOLTBL1
+   WHERE f1 = cast('true' as boolean);
+
+
+SELECT '' AS t_3, BOOLTBL1.*
+   FROM BOOLTBL1
+   WHERE f1 <> cast('false' as boolean);
+
+-- SELECT '' AS zero, BOOLTBL1.*
+--FROM BOOLTBL1
+--WHERE booleq(cast('false' as boolean), f1);
+
+INSERT INTO BOOLTBL1 VALUES (cast('f' as boolean));
+
+SELECT '' AS f_1, BOOLTBL1.*
+   FROM BOOLTBL1
+   WHERE f1 = cast('false' as boolean);
+
+
+CREATE TABLE BOOLTBL2 (f1 boolean) USING parquet;
+
+INSERT INTO BOOLTBL2 VALUES (cast('f' as boolean));
+
+INSERT INTO BOOLTBL2 VALUES (cast('false' as boolean));
+
+INSERT INTO BOOLTBL2 VALUES (cast('False' as boolean));
+
+INSERT INTO BOOLTBL2 VALUES (cast('FALSE' as boolean));
+
+-- This is now an invalid expression
+-- For pre-v6.3 this evaluated to false - thomas 1997-10-23
+INSERT INTO BOOLTBL2
+   VALUES (cast('XXX' as boolean));
+
+-- BOOLTBL2 should be full of false's at this point
+SELECT '' AS f_4, BOOLTBL2.* FROM BOOLTBL2;
+
+
+SELECT '' AS tf_12, BOOLTBL1.*, BOOLTBL2.*
+   FROM BOOLTBL1, BOOLTBL2
+   WHERE BOOLTBL2.f1 <> BOOLTBL1.f1;
+
+
+--SELECT '' AS tf_12, BOOLTBL1.*, BOOLTBL2.*
+--   FROM BOOLTBL1, BOOLTBL2
+--   WHERE boolne(BOOLTBL2.f1,BOOLTBL1.f1);
+
+
+SELECT '' AS ff_4, BOOLTBL1.*, BOOLTBL2.*
+   FROM BOOLTBL1, BOOLTBL2
+   WHERE BOOLTBL2.f1 = BOOLTBL1.f1 and BOOLTBL1.f1 = cast('false' as boolean);
+
+
+SELECT '' AS tf_12_ff_4, BOOLTBL1.*, BOOLTBL2.*
+   FROM BOOLTBL1, BOOLTBL2
+   WHERE BOOLTBL2.f1 = BOOLTBL1.f1 or BOOLTBL1.f1 = cast('true' as boolean)
+   ORDER BY BOOLTBL1.f1, BOOLTBL2.f1;
+
+--
+-- SQL syntax
+-- Try all combinations to ensure that we get nothing when we expect nothing
+-- - thomas 2000-01-04
+--
+
+-- SELECT '' AS True, f1
+--FROM BOOLTBL1
+--WHERE f1 IS TRUE;
 
 Review comment:
   Check the other SQL engines?   

[GitHub] [spark] gatorsmile commented on a change in pull request #24767: [WIP][SPARK-27918][SQL] Port boolean.sql

[GitBox]

gatorsmile commented on a change in pull request #24767: 
[WIP][SPARK-27918][SQL] Port boolean.sql
URL: https://github.com/apache/spark/pull/24767#discussion_r289695456
 
 

 ##
 File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/boolean.sql
 ##
 @@ -0,0 +1,265 @@
+--
+-- Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group
+--
+--
+-- BOOLEAN
+-- 
https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/sql/boolean.sql
+
+--
+-- sanity check - if this fails go insane!
+--
+SELECT 1 AS one;
+
+
+-- **testing built-in type bool
+
+-- check bool input syntax
+
+SELECT true AS true;
+
+SELECT false AS false;
+
+SELECT cast('t' as boolean) AS true;
+
+SELECT cast('   f   ' as boolean) AS false;
+
+SELECT cast('true' as boolean) AS true;
+
+SELECT cast('test' as boolean) AS error;
+
+SELECT cast('false' as boolean) AS false;
+
+SELECT cast('foo' as boolean) AS error;
+
+SELECT cast('y' as boolean) AS true;
+
+SELECT cast('yes' as boolean) AS true;
+
+SELECT cast('yeah' as boolean) AS error;
+
+SELECT cast('n' as boolean) AS false;
+
+SELECT cast('no' as boolean) AS false;
+
+SELECT cast('nay' as boolean) AS error;
+
+SELECT cast('on' as boolean) AS true;
+
+SELECT cast('off' as boolean) AS false;
+
+SELECT cast('of' as boolean) AS false;
+
+SELECT cast('o' as boolean) AS error;
+
+SELECT cast('on_' as boolean) AS error;
+
+SELECT cast('off_' as boolean) AS error;
+
+SELECT cast('1' as boolean) AS true;
+
+SELECT cast('11' as boolean) AS error;
+
+SELECT cast('0' as boolean) AS false;
+
+SELECT cast('000' as boolean) AS error;
+
+SELECT cast('' as boolean) AS error;
+
+-- and, or, not in qualifications
+
+SELECT cast('t' as boolean) or cast('f' as boolean) AS true;
+
+SELECT cast('t' as boolean) and cast('f' as boolean) AS false;
+
+SELECT not cast('f' as boolean) AS true;
+
+SELECT cast('t' as boolean) = cast('f' as boolean) AS false;
+
+SELECT cast('t' as boolean) <> cast('f' as boolean) AS true;
+
+SELECT cast('t' as boolean) > cast('f' as boolean) AS true;
+
+SELECT cast('t' as boolean) >= cast('f' as boolean) AS true;
+
+SELECT cast('f' as boolean) < cast('t' as boolean) AS true;
+
+SELECT cast('f' as boolean) <= cast('t' as boolean) AS true;
+
+-- explicit casts to/from text
+SELECT cast(cast('TrUe' as string) as boolean) AS true, cast(cast('fAlse' as 
string) as boolean) AS false;
+SELECT cast(cast('true   ' as string) as boolean) AS true,
+   cast(cast(' FALSE' as string) as boolean) AS false;
+SELECT cast(cast(true as boolean) as string) AS true, cast(cast(false as 
boolean) as string) AS false;
+
+SELECT cast(cast('  tru e ' as string) as boolean) AS invalid;-- error
+SELECT cast(cast('' as string) as boolean) AS invalid;-- error
+
+CREATE TABLE BOOLTBL1 (f1 boolean) USING parquet;
+
+INSERT INTO BOOLTBL1 VALUES (cast('t' as boolean));
+
+INSERT INTO BOOLTBL1 VALUES (cast('True' as boolean));
+
+INSERT INTO BOOLTBL1 VALUES (cast('true' as boolean));
+
+
+-- BOOLTBL1 should be full of true's at this point
+SELECT '' AS t_3, BOOLTBL1.* FROM BOOLTBL1;
+
+
+SELECT '' AS t_3, BOOLTBL1.*
+   FROM BOOLTBL1
+   WHERE f1 = cast('true' as boolean);
+
+
+SELECT '' AS t_3, BOOLTBL1.*
+   FROM BOOLTBL1
+   WHERE f1 <> cast('false' as boolean);
+
+-- SELECT '' AS zero, BOOLTBL1.*
+--FROM BOOLTBL1
+--WHERE booleq(cast('false' as boolean), f1);
 
 Review comment:
   Is `booleq` PostgreSQL specific? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #24771: [SPARK-27873][SQL][BRANCH-2.4] columnNameOfCorruptRecord should not be checked with column names in CSV header when disabling enforceSchema

[GitBox]

HyukjinKwon commented on issue #24771: [SPARK-27873][SQL][BRANCH-2.4] 
columnNameOfCorruptRecord should not be checked with column names in CSV header 
when disabling enforceSchema
URL: https://github.com/apache/spark/pull/24771#issuecomment-498122081
 
 
   It's a bug in 2.4 since `enforceSchema` feature was added from 2.4 
(SPARK-25669). I don't think this is a regression - the bug was reported from 
2.4.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

HyukjinKwon commented on a change in pull request #24773: 
[SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#discussion_r289692376
 
 

 ##
 File path: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
 ##
 @@ -142,8 +142,6 @@ private[sql] class HiveSessionCatalog(
   // let's try to load it as a Hive's built-in function.
   // Hive is case insensitive.
   val functionName = funcName.unquotedString.toLowerCase(Locale.ROOT)
-  logWarning("Encountered a failure during looking up function:" +
 
 Review comment:
   Why don't we debug or info that we'll try fallback while we're here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gatorsmile commented on a change in pull request #24472: [SPARK-27578][SQL] Support INTERVAL ... HOUR TO SECOND syntax

[GitBox]

gatorsmile commented on a change in pull request #24472: [SPARK-27578][SQL] 
Support INTERVAL ... HOUR TO SECOND syntax
URL: https://github.com/apache/spark/pull/24472#discussion_r289694819
 
 

 ##
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ##
 @@ -1770,7 +1770,7 @@ class AstBuilder(conf: SQLConf) extends 
SqlBaseBaseVisitor[AnyRef] with Logging
* Create a [[CalendarInterval]] for a unit value pair. Two unit 
configuration types are
* supported:
* - Single unit.
-   * - From-To unit (only 'YEAR TO MONTH' and 'DAY TO SECOND' are supported).
+   * - From-To unit (only 'YEAR TO MONTH' and 'DAY TO SECOND' and 'HOUR to 
SECOND' are supported).
 
 Review comment:
   It sounds like we only added a very specific case. 
https://docs.teradata.com/reader/S0Fw2AVH8ff3MDA0wDOHlQ/RADkJCor1nDoyeD2T1VX5A 
   
   Any reason?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gatorsmile commented on issue #24472: [SPARK-27578][SQL] Support INTERVAL ... HOUR TO SECOND syntax

[GitBox]

gatorsmile commented on issue #24472: [SPARK-27578][SQL] Support INTERVAL ... 
HOUR TO SECOND syntax
URL: https://github.com/apache/spark/pull/24472#issuecomment-498120829
 
 
   In the next one month, Wenchen might not be able to respond your pings very 
soon. Normally, when we add a support like this, we need to know whether all 
the other SQL engines have similar supports? 
   
   @lipzhu Could you help do an investigation? For example, Oracle, DB2, SQL 
Server, MySQL, PostgreSQL, Hive?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

dongjoon-hyun commented on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a 
wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#issuecomment-498120025
 
 
   Thank you for review and approval, @gatorsmile !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gengliangwang commented on a change in pull request #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

gengliangwang commented on a change in pull request #24327: [SPARK-27418][SQL] 
Migrate Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#discussion_r289693400
 
 

 ##
 File path: 
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetLogRedirector.java
 ##
 @@ -25,11 +25,11 @@
 
 // Redirects the JUL logging for parquet-mr versions <= 1.8 to SLF4J logging 
using
 // SLF4JBridgeHandler. Parquet-mr versions >= 1.9 use SLF4J directly
-final class ParquetLogRedirector implements Serializable {
+public final class ParquetLogRedirector implements Serializable {
 
 Review comment:
   I have removed it in Parquet V2. Mark this thread as resolved.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.7-src.zip in Scala

[GitBox]

dongjoon-hyun commented on a change in pull request #24772: [MINOR][BRANCH-2.4] 
Avoid hardcoded py4j-0.10.7-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772#discussion_r289693259
 
 

 ##
 File path: core/src/main/scala/org/apache/spark/api/python/PythonUtils.scala
 ##
 @@ -27,12 +27,15 @@ import org.apache.spark.SparkContext
 import org.apache.spark.api.java.{JavaRDD, JavaSparkContext}
 
 private[spark] object PythonUtils {
+  val PY4J_ZIP_NAME = "py4j-0.10.7-src.zip"
+
   /** Get the PYTHONPATH for PySpark, either from SPARK_HOME, if it is set, or 
from our JAR */
   def sparkPythonPath: String = {
 val pythonPath = new ArrayBuffer[String]
 for (sparkHome <- sys.env.get("SPARK_HOME")) {
   pythonPath += Seq(sparkHome, "python", "lib", 
"pyspark.zip").mkString(File.separator)
-  pythonPath += Seq(sparkHome, "python", "lib", 
"py4j-0.10.7-src.zip").mkString(File.separator)
+  pythonPath +=
+Seq(sparkHome, "python", "lib", PY4J_ZIP_NAME).mkString(File.separator)
 
 Review comment:
   I see. Got it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gengliangwang commented on a change in pull request #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

gengliangwang commented on a change in pull request #24327: [SPARK-27418][SQL] 
Migrate Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#discussion_r289693239
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
 ##
 @@ -238,7 +240,8 @@ case class AlterTableAddColumnsCommand(
 // TextFileFormat only default to one column "value"
 // Hive type is already considered as hive serde table, so the logic 
will not
 // come in here.
-case _: JsonFileFormat | _: CSVDataSourceV2 | _: ParquetFileFormat | 
_: OrcDataSourceV2 =>
+case _: JsonFileFormat | _: CSVFileFormat | _: ParquetFileFormat =>
 
 Review comment:
   Got it, I will create another small PR with tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox]

AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] 
Flush each batch for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#issuecomment-498118359
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106083/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gatorsmile commented on issue #24771: [SPARK-27873][SQL][BRANCH-2.4] columnNameOfCorruptRecord should not be checked with column names in CSV header when disabling enforceSchema

[GitBox]

gatorsmile commented on issue #24771: [SPARK-27873][SQL][BRANCH-2.4] 
columnNameOfCorruptRecord should not be checked with column names in CSV header 
when disabling enforceSchema
URL: https://github.com/apache/spark/pull/24771#issuecomment-498118981
 
 
   Is it a regression? Could you check whether this is a long standing issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox]

AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] 
Flush each batch for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#issuecomment-498118357
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox]

AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each 
batch for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#issuecomment-498118359
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106083/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox]

AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each 
batch for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#issuecomment-498118357
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox]

SparkQA commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch 
for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#issuecomment-498118220
 
 
   **[Test build #106083 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106083/testReport)**
 for PR 24734 at commit 
[`6595509`](https://github.com/apache/spark/commit/659550928374f70e3e058ab1c6932967425535fb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox]

SparkQA removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush 
each batch for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#issuecomment-498100716
 
 
   **[Test build #106083 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106083/testReport)**
 for PR 24734 at commit 
[`6595509`](https://github.com/apache/spark/commit/659550928374f70e3e058ab1c6932967425535fb).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.7-src.zip in Scala

[GitBox]

HyukjinKwon commented on a change in pull request #24772: [MINOR][BRANCH-2.4] 
Avoid hardcoded py4j-0.10.7-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772#discussion_r289690764
 
 

 ##
 File path: core/src/main/scala/org/apache/spark/api/python/PythonUtils.scala
 ##
 @@ -27,12 +27,15 @@ import org.apache.spark.SparkContext
 import org.apache.spark.api.java.{JavaRDD, JavaSparkContext}
 
 private[spark] object PythonUtils {
+  val PY4J_ZIP_NAME = "py4j-0.10.7-src.zip"
 
 Review comment:
   Not sure if that works in production. Maybe that could work somehow but we 
need to update that project's property anyway :).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

dongjoon-hyun commented on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a 
wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#issuecomment-498116708
 
 
   Thank you for review and approval, @felixcheung .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

dongjoon-hyun commented on a change in pull request #24773: 
[SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#discussion_r289690629
 
 

 ##
 File path: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
 ##
 @@ -142,8 +142,6 @@ private[sql] class HiveSessionCatalog(
   // let's try to load it as a Hive's built-in function.
   // Hive is case insensitive.
   val functionName = funcName.unquotedString.toLowerCase(Locale.ROOT)
-  logWarning("Encountered a failure during looking up function:" +
-s" ${Utils.exceptionString(error)}")
 
 Review comment:
   Ya. Maybe, but I'm not sure about the original intention. For that line 138, 
since we already `throw error`, actually, we don't need print warning here with 
the same `error`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

dongjoon-hyun commented on a change in pull request #24773: 
[SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#discussion_r289690629
 
 

 ##
 File path: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
 ##
 @@ -142,8 +142,6 @@ private[sql] class HiveSessionCatalog(
   // let's try to load it as a Hive's built-in function.
   // Hive is case insensitive.
   val functionName = funcName.unquotedString.toLowerCase(Locale.ROOT)
-  logWarning("Encountered a failure during looking up function:" +
-s" ${Utils.exceptionString(error)}")
 
 Review comment:
   Ya. Maybe, but I'm not sure about the original intention. For that line, 
since we already `throw error`, actually, we don't need print warning here with 
the same `error`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

AmplabJenkins removed a comment on issue #24327: [SPARK-27418][SQL] Migrate 
Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#issuecomment-498116156
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.7-src.zip in Scala

[GitBox]

HyukjinKwon commented on a change in pull request #24772: [MINOR][BRANCH-2.4] 
Avoid hardcoded py4j-0.10.7-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772#discussion_r289690508
 
 

 ##
 File path: core/src/main/scala/org/apache/spark/api/python/PythonUtils.scala
 ##
 @@ -27,12 +27,15 @@ import org.apache.spark.SparkContext
 import org.apache.spark.api.java.{JavaRDD, JavaSparkContext}
 
 private[spark] object PythonUtils {
+  val PY4J_ZIP_NAME = "py4j-0.10.7-src.zip"
+
   /** Get the PYTHONPATH for PySpark, either from SPARK_HOME, if it is set, or 
from our JAR */
   def sparkPythonPath: String = {
 val pythonPath = new ArrayBuffer[String]
 for (sparkHome <- sys.env.get("SPARK_HOME")) {
   pythonPath += Seq(sparkHome, "python", "lib", 
"pyspark.zip").mkString(File.separator)
-  pythonPath += Seq(sparkHome, "python", "lib", 
"py4j-0.10.7-src.zip").mkString(File.separator)
+  pythonPath +=
+Seq(sparkHome, "python", "lib", PY4J_ZIP_NAME).mkString(File.separator)
 
 Review comment:
   Yup, just in case we backport other changes. I think it's better to keep the 
diff small comparing to the master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

AmplabJenkins removed a comment on issue #24327: [SPARK-27418][SQL] Migrate 
Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#issuecomment-498116161
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11345/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

SparkQA commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File 
Data Source V2
URL: https://github.com/apache/spark/pull/24327#issuecomment-498116455
 
 
   **[Test build #106093 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106093/testReport)**
 for PR 24327 at commit 
[`bff2a2d`](https://github.com/apache/spark/commit/bff2a2ddf6760ee4eea5e957599d4cb6e11c58b4).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

AmplabJenkins commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to 
File Data Source V2
URL: https://github.com/apache/spark/pull/24327#issuecomment-498116161
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11345/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

AmplabJenkins commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to 
File Data Source V2
URL: https://github.com/apache/spark/pull/24327#issuecomment-498116156
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] felixcheung commented on a change in pull request #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

felixcheung commented on a change in pull request #24773: 
[SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#discussion_r289690133
 
 

 ##
 File path: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
 ##
 @@ -142,8 +142,6 @@ private[sql] class HiveSessionCatalog(
   // let's try to load it as a Hive's built-in function.
   // Hive is case insensitive.
   val functionName = funcName.unquotedString.toLowerCase(Locale.ROOT)
-  logWarning("Encountered a failure during looking up function:" +
-s" ${Utils.exceptionString(error)}")
 
 Review comment:
   maybe this is intended for the true case of `if (super.functionExists(name)) 
` above? like L138?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gatorsmile commented on issue #24723: [SPARK-27857][SQL] Move ALTER TABLE parsing into Catalyst

[GitBox]

gatorsmile commented on issue #24723: [SPARK-27857][SQL] Move ALTER TABLE 
parsing into Catalyst
URL: https://github.com/apache/spark/pull/24723#issuecomment-498115603
 
 
   Normally, we check if it is possible to split it into multiple smaller, 
logical PRs or commits that can be quick to review. 
   - Keep refactors in separate PRs
   - Fix one issue/bug per PR. 
   
   @ueshin Please help review this PR and ensure these DDLs are well tested, 
especially when handling nested columns. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] felixcheung commented on a change in pull request #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.7-src.zip in Scala

[GitBox]

felixcheung commented on a change in pull request #24772: [MINOR][BRANCH-2.4] 
Avoid hardcoded py4j-0.10.7-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772#discussion_r289689900
 
 

 ##
 File path: core/src/main/scala/org/apache/spark/api/python/PythonUtils.scala
 ##
 @@ -27,12 +27,15 @@ import org.apache.spark.SparkContext
 import org.apache.spark.api.java.{JavaRDD, JavaSparkContext}
 
 private[spark] object PythonUtils {
+  val PY4J_ZIP_NAME = "py4j-0.10.7-src.zip"
 
 Review comment:
   this is better... is there a way not to hard code this at all? set from 
project properties?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

AmplabJenkins removed a comment on issue #24773: [SPARK-24544][SQL][FOLLOWUP] 
Remove a wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#issuecomment-498114966
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.7-src.zip in Scala

[GitBox]

SparkQA commented on issue #24772: [MINOR][BRANCH-2.4] Avoid hardcoded 
py4j-0.10.7-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772#issuecomment-498115265
 
 
   **[Test build #106092 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106092/testReport)**
 for PR 24772 at commit 
[`8ba5253`](https://github.com/apache/spark/commit/8ba5253dd6411f5d706d3a0bfe1f6e636346009a).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

SparkQA commented on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong 
warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#issuecomment-498115263
 
 
   **[Test build #106091 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106091/testReport)**
 for PR 24773 at commit 
[`5eac93d`](https://github.com/apache/spark/commit/5eac93dbec10e783f868ad50c42abc8c90d2aa12).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.7-src.zip in Scala

[GitBox]

AmplabJenkins removed a comment on issue #24772: [MINOR][BRANCH-2.4] Avoid 
hardcoded py4j-0.10.7-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772#issuecomment-498114989
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.7-src.zip in Scala

[GitBox]

AmplabJenkins removed a comment on issue #24772: [MINOR][BRANCH-2.4] Avoid 
hardcoded py4j-0.10.7-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772#issuecomment-498114994
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11344/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

AmplabJenkins removed a comment on issue #24773: [SPARK-24544][SQL][FOLLOWUP] 
Remove a wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#issuecomment-498114971
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11343/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.7-src.zip in Scala

[GitBox]

dongjoon-hyun commented on a change in pull request #24772: [MINOR][BRANCH-2.4] 
Avoid hardcoded py4j-0.10.7-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772#discussion_r289689529
 
 

 ##
 File path: core/src/main/scala/org/apache/spark/api/python/PythonUtils.scala
 ##
 @@ -27,12 +27,15 @@ import org.apache.spark.SparkContext
 import org.apache.spark.api.java.{JavaRDD, JavaSparkContext}
 
 private[spark] object PythonUtils {
+  val PY4J_ZIP_NAME = "py4j-0.10.7-src.zip"
+
   /** Get the PYTHONPATH for PySpark, either from SPARK_HOME, if it is set, or 
from our JAR */
   def sparkPythonPath: String = {
 val pythonPath = new ArrayBuffer[String]
 for (sparkHome <- sys.env.get("SPARK_HOME")) {
   pythonPath += Seq(sparkHome, "python", "lib", 
"pyspark.zip").mkString(File.separator)
-  pythonPath += Seq(sparkHome, "python", "lib", 
"py4j-0.10.7-src.zip").mkString(File.separator)
+  pythonPath +=
+Seq(sparkHome, "python", "lib", PY4J_ZIP_NAME).mkString(File.separator)
 
 Review comment:
   This line looks shorter than the existing line? Do we need to split?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.7-src.zip in Scala

[GitBox]

AmplabJenkins commented on issue #24772: [MINOR][BRANCH-2.4] Avoid hardcoded 
py4j-0.10.7-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772#issuecomment-498114994
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11344/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

AmplabJenkins commented on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a 
wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#issuecomment-498114966
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.7-src.zip in Scala

[GitBox]

AmplabJenkins commented on issue #24772: [MINOR][BRANCH-2.4] Avoid hardcoded 
py4j-0.10.7-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772#issuecomment-498114989
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

AmplabJenkins commented on issue #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a 
wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#issuecomment-498114971
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11343/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

dongjoon-hyun commented on a change in pull request #24773: 
[SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773#discussion_r289689347
 
 

 ##
 File path: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
 ##
 @@ -142,8 +142,6 @@ private[sql] class HiveSessionCatalog(
   // let's try to load it as a Hive's built-in function.
   // Hive is case insensitive.
   val functionName = funcName.unquotedString.toLowerCase(Locale.ROOT)
-  logWarning("Encountered a failure during looking up function:" +
-s" ${Utils.exceptionString(error)}")
 
 Review comment:
   We should not warn here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun opened a new pull request #24773: [SPARK-24544][SQL][FOLLOWUP] Remove a wrong warning on Hive fallback lookup

[GitBox]

dongjoon-hyun opened a new pull request #24773: [SPARK-24544][SQL][FOLLOWUP] 
Remove a wrong warning on Hive fallback lookup
URL: https://github.com/apache/spark/pull/24773
 
 
   ## What changes were proposed in this pull request?
   
   This PR is a follow-up of https://github.com/apache/spark/pull/21790 which 
causes a regression to show misleading warnings always at first invocation for 
all Hive function. Hive fallback lookup should not be warned. It's a normal 
process in function lookups.
   
   **CURRENT (Showing `NoSuchFunctionException` and working)**
   ```scala
   scala> sql("select histogram_numeric(a,2) from values(1) T(a)").show
   19/06/02 22:02:10 WARN HiveSessionCatalog: Encountered a failure during 
looking up function: 
org.apache.spark.sql.catalyst.analysis.NoSuchFunctionException: Undefined 
function: 'histogram_numeric'. This function is neither a registered temporary 
function nor a permanent function registered in the database 'default'.;
at 
org.apache.spark.sql.catalyst.catalog.SessionCatalog.failFunctionLookup(SessionCatalog.scala:1234)
at 
org.apache.spark.sql.catalyst.catalog.SessionCatalog.lookupFunction(SessionCatalog.scala:1302)
at ...
   ++
   |histogram_numeric( a, 2)|
   ++
   |[[1.0, 1.0]]|
   ++
   ```
   
   ## How was this patch tested?
   
   Manually execute the above query.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gatorsmile commented on a change in pull request #24723: [SPARK-27857][SQL] Move ALTER TABLE parsing into Catalyst

[GitBox]

gatorsmile commented on a change in pull request #24723: [SPARK-27857][SQL] 
Move ALTER TABLE parsing into Catalyst
URL: https://github.com/apache/spark/pull/24723#discussion_r289689043
 
 

 ##
 File path: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
 ##
 @@ -113,14 +113,26 @@ statement
 LIKE source=tableIdentifier locationSpec?  
#createTableLike
 | ANALYZE TABLE tableIdentifier partitionSpec? COMPUTE STATISTICS
 (identifier | FOR COLUMNS identifierSeq | FOR ALL COLUMNS)?#analyze
-| ALTER TABLE tableIdentifier
-ADD COLUMNS '(' columns=colTypeList ')'
#addTableColumns
+| ALTER TABLE multipartIdentifier
+ADD (COLUMN | COLUMNS) columns=newColumnList colPosition?  
#addTableColumns
 
 Review comment:
   Below is the example you can follow
   
   ```
   | ALTER TABLE tableIdentifier
   ADD COLUMNS '(' columns=qualifiedColTypeWithPositionList ')'   
#addTableColumns
   
   qualifiedColTypeWithPositionList
   : qualifiedColTypeWithPosition (',' qualifiedColTypeWithPosition)*
   ;
   
   qualifiedColTypeWithPosition
   : (path=qualifiedName '.')? colType colPosition?
   ;
   
   colType  <-- reuse the existing one
   : identifier dataType (COMMENT STRING)?
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

HyukjinKwon commented on issue #24772: [MINOR][BRANCH-2.4] Avoid hardcoded 
py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772#issuecomment-498114127
 
 
   cc @dongjoon-hyun 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] HyukjinKwon opened a new pull request #24772: [MINOR][BRANCH-2.4] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

HyukjinKwon opened a new pull request #24772: [MINOR][BRANCH-2.4] Avoid 
hardcoded py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24772
 
 
   ## What changes were proposed in this pull request?
   
   This PR targets to deduplicate hardcoded `py4j-0.10.8.1-src.zip` in order to 
make py4j upgrade easier.
   
   ## How was this patch tested?
   
   N/A
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on issue #21790: [SPARK-24544][SQL] Print actual failure cause when look up function failed

[GitBox]

dongjoon-hyun commented on issue #21790: [SPARK-24544][SQL] Print actual 
failure cause when look up function failed
URL: https://github.com/apache/spark/pull/21790#issuecomment-498113615
 
 
   Hi, All.
   This seems to cause a regression to show misleading warnings always at first 
invocation for all Hive function. Hive fallback lookup should not be warned. 
It's a normal process in function lookups. Since this bug is not exposed to the 
release, I'll make a followup on `master` branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

AmplabJenkins removed a comment on issue #24490: [SPARK-27300][GRAPH] Add Spark 
Graph modules and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498113268
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106090/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] gatorsmile commented on a change in pull request #24723: [SPARK-27857][SQL] Move ALTER TABLE parsing into Catalyst

[GitBox]

gatorsmile commented on a change in pull request #24723: [SPARK-27857][SQL] 
Move ALTER TABLE parsing into Catalyst
URL: https://github.com/apache/spark/pull/24723#discussion_r289688092
 
 

 ##
 File path: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
 ##
 @@ -113,14 +113,26 @@ statement
 LIKE source=tableIdentifier locationSpec?  
#createTableLike
 | ANALYZE TABLE tableIdentifier partitionSpec? COMPUTE STATISTICS
 (identifier | FOR COLUMNS identifierSeq | FOR ALL COLUMNS)?#analyze
-| ALTER TABLE tableIdentifier
-ADD COLUMNS '(' columns=colTypeList ')'
#addTableColumns
+| ALTER TABLE multipartIdentifier
+ADD (COLUMN | COLUMNS) columns=newColumnList colPosition?  
#addTableColumns
 
 Review comment:
   `colPosition` should be related to each column when you adding multiple new 
columns, right? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

AmplabJenkins removed a comment on issue #24490: [SPARK-27300][GRAPH] Add Spark 
Graph modules and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498113264
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

SparkQA removed a comment on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph 
modules and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498111905
 
 
   **[Test build #106090 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106090/testReport)**
 for PR 24490 at commit 
[`bf7db46`](https://github.com/apache/spark/commit/bf7db46d7dc548ffecb84d5696281951a46e5ae7).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

AmplabJenkins commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph 
modules and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498113264
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

AmplabJenkins commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph 
modules and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498113268
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106090/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

SparkQA commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules 
and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498113258
 
 
   **[Test build #106090 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106090/testReport)**
 for PR 24490 at commit 
[`bf7db46`](https://github.com/apache/spark/commit/bf7db46d7dc548ffecb84d5696281951a46e5ae7).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #24770: [MINOR] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

HyukjinKwon commented on issue #24770: [MINOR] Avoid hardcoded 
py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24770#issuecomment-498112929
 
 
   Thanks. Yea will do.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

SparkQA commented on issue #24766: [SPARK-27917][SQL] canonical form of 
CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#issuecomment-498111891
 
 
   **[Test build #106089 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106089/testReport)**
 for PR 24766 at commit 
[`009858c`](https://github.com/apache/spark/commit/009858c55439cffaeecc40dc277859e7e45867f0).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

SparkQA commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules 
and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498111905
 
 
   **[Test build #106090 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106090/testReport)**
 for PR 24490 at commit 
[`bf7db46`](https://github.com/apache/spark/commit/bf7db46d7dc548ffecb84d5696281951a46e5ae7).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

AmplabJenkins commented on issue #24766: [SPARK-27917][SQL] canonical form of 
CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#issuecomment-498111613
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

AmplabJenkins removed a comment on issue #24490: [SPARK-27300][GRAPH] Add Spark 
Graph modules and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498111656
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11342/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox]

AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] 
Flush each batch for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#issuecomment-498111642
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

AmplabJenkins removed a comment on issue #24766: [SPARK-27917][SQL] canonical 
form of CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#issuecomment-498111619
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11340/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox]

AmplabJenkins removed a comment on issue #24734: [SPARK-27870][SQL][PySpark] 
Flush each batch for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#issuecomment-498111644
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11341/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

AmplabJenkins commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph 
modules and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498111655
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

AmplabJenkins commented on issue #24766: [SPARK-27917][SQL] canonical form of 
CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#issuecomment-498111619
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11340/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox]

AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each 
batch for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#issuecomment-498111642
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

AmplabJenkins commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph 
modules and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498111656
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11342/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox]

AmplabJenkins commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each 
batch for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#issuecomment-498111644
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11341/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

AmplabJenkins removed a comment on issue #24766: [SPARK-27917][SQL] canonical 
form of CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#issuecomment-498111613
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

AmplabJenkins removed a comment on issue #24490: [SPARK-27300][GRAPH] Add Spark 
Graph modules and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498111655
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cryeo commented on issue #24335: [SPARK-27425][SQL] Add count_if functions

[GitBox]

cryeo commented on issue #24335: [SPARK-27425][SQL] Add count_if functions
URL: https://github.com/apache/spark/pull/24335#issuecomment-498111390
 
 
   @HyukjinKwon I just modified based on your review. Could you review it again?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] sandeep-katta commented on a change in pull request #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

sandeep-katta commented on a change in pull request #24766: [SPARK-27917][SQL] 
canonical form of CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#discussion_r289686231
 
 

 ##
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
 ##
 @@ -249,6 +251,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] 
extends Product {
 // `mapValues` is lazy and we need to force it to materialize
 m.mapValues(mapChild).view.force
   case arg: TreeNode[_] if containsChild(arg) => mapTreeNode(arg)
+  case Some(child) => Some(mapChild(child))
 
 Review comment:
   yes 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox]

SparkQA commented on issue #24734: [SPARK-27870][SQL][PySpark] Flush each batch 
for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#issuecomment-498110839
 
 
   **[Test build #106088 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106088/testReport)**
 for PR 24734 at commit 
[`8069a17`](https://github.com/apache/spark/commit/8069a176efa13cba37f272c19bd0da77585a280b).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph modules and dependencies

[GitBox]

dongjoon-hyun commented on issue #24490: [SPARK-27300][GRAPH] Add Spark Graph 
modules and dependencies
URL: https://github.com/apache/spark/pull/24490#issuecomment-498110869
 
 
   Retest this please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

AmplabJenkins removed a comment on issue #24766: [SPARK-27917][SQL] canonical 
form of CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#issuecomment-498110584
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

AmplabJenkins removed a comment on issue #24766: [SPARK-27917][SQL] canonical 
form of CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#issuecomment-498110586
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11339/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

dongjoon-hyun commented on a change in pull request #24766: [SPARK-27917][SQL] 
canonical form of CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#discussion_r289685892
 
 

 ##
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
 ##
 @@ -249,6 +251,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] 
extends Product {
 // `mapValues` is lazy and we need to force it to materialize
 m.mapValues(mapChild).view.force
   case arg: TreeNode[_] if containsChild(arg) => mapTreeNode(arg)
+  case Some(child) => Some(mapChild(child))
 
 Review comment:
   So, this is for `elseValue`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

AmplabJenkins commented on issue #24766: [SPARK-27917][SQL] canonical form of 
CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#issuecomment-498110584
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

AmplabJenkins commented on issue #24766: [SPARK-27917][SQL] canonical form of 
CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#issuecomment-498110586
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11339/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on issue #24770: [MINOR] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

dongjoon-hyun commented on issue #24770: [MINOR] Avoid hardcoded 
py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24770#issuecomment-498110322
 
 
   Although this is a minor, could you make a backport to `branch-2.4`? It 
would be good because `branch-2.4` is the last branch in `2.x` line.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

SparkQA commented on issue #24766: [SPARK-27917][SQL] canonical form of 
CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#issuecomment-498109738
 
 
   **[Test build #106087 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106087/testReport)**
 for PR 24766 at commit 
[`0403588`](https://github.com/apache/spark/commit/04035886684a9aad7fa43be2710ed08445d217cb).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] sandeep-katta commented on a change in pull request #24766: [SPARK-27917][SQL] canonical form of CaseWhen object is incorrect

[GitBox]

sandeep-katta commented on a change in pull request #24766: [SPARK-27917][SQL] 
canonical form of CaseWhen object is incorrect
URL: https://github.com/apache/spark/pull/24766#discussion_r289685148
 
 

 ##
 File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala
 ##
 @@ -248,4 +248,18 @@ class ConditionalExpressionSuite extends SparkFunSuite 
with ExpressionEvalHelper
   .contains("CASE WHEN ... THEN struct WHEN ... THEN struct 
" +
 "ELSE struct END"))
   }
+
+  test("SPARK-27917 test semantic equals of CaseWhen") {
+val attrRef = AttributeReference("ACCESS_CHECK", StringType)()
+val aliasAttrRef = attrRef.withName("access_check")
+// Test for Equality
+val caseWhenObj1 = CaseWhen(Seq((attrRef, Literal("A"
+var caseWhenObj2 = CaseWhen(Seq((aliasAttrRef, Literal("A"
+assert(caseWhenObj1.semanticEquals(caseWhenObj2))
+assert(caseWhenObj2.semanticEquals(caseWhenObj1))
+// Test for inEquality
+caseWhenObj2 = CaseWhen(Seq((attrRef, Literal("a"
+assert(!caseWhenObj1.semanticEquals(caseWhenObj2))
+assert(!caseWhenObj2.semanticEquals(caseWhenObj1))
 
 Review comment:
   thanks for noticing this out, I had missed this. Have updated the test and 
source code accordingly


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

AmplabJenkins removed a comment on issue #24327: [SPARK-27418][SQL] Migrate 
Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#issuecomment-498108630
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106082/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

AmplabJenkins removed a comment on issue #24327: [SPARK-27418][SQL] Migrate 
Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#issuecomment-498108625
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

SparkQA commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File 
Data Source V2
URL: https://github.com/apache/spark/pull/24327#issuecomment-498108530
 
 
   **[Test build #106082 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106082/testReport)**
 for PR 24327 at commit 
[`e9a6452`](https://github.com/apache/spark/commit/e9a6452bef096b5ec2011fd7bc9d9c9a22801cb7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `final class ParquetLogRedirector implements Serializable `


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

AmplabJenkins commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to 
File Data Source V2
URL: https://github.com/apache/spark/pull/24327#issuecomment-498108625
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #24770: [MINOR] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

dongjoon-hyun closed pull request #24770: [MINOR] Avoid hardcoded 
py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24770
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

AmplabJenkins commented on issue #24327: [SPARK-27418][SQL] Migrate Parquet to 
File Data Source V2
URL: https://github.com/apache/spark/pull/24327#issuecomment-498108630
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106082/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #24327: [SPARK-27418][SQL] Migrate Parquet to File Data Source V2

[GitBox]

SparkQA removed a comment on issue #24327: [SPARK-27418][SQL] Migrate Parquet 
to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#issuecomment-498098711
 
 
   **[Test build #106082 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106082/testReport)**
 for PR 24327 at commit 
[`e9a6452`](https://github.com/apache/spark/commit/e9a6452bef096b5ec2011fd7bc9d9c9a22801cb7).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on issue #24770: [MINOR] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

dongjoon-hyun commented on issue #24770: [MINOR] Avoid hardcoded 
py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24770#issuecomment-498108146
 
 
   Merged to master!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24770: [MINOR] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

AmplabJenkins removed a comment on issue #24770: [MINOR] Avoid hardcoded 
py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24770#issuecomment-498107488
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106080/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #24770: [MINOR] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

AmplabJenkins removed a comment on issue #24770: [MINOR] Avoid hardcoded 
py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24770#issuecomment-498107484
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24770: [MINOR] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

AmplabJenkins commented on issue #24770: [MINOR] Avoid hardcoded 
py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24770#issuecomment-498107484
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #24770: [MINOR] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

AmplabJenkins commented on issue #24770: [MINOR] Avoid hardcoded 
py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24770#issuecomment-498107488
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106080/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #24770: [MINOR] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

SparkQA removed a comment on issue #24770: [MINOR] Avoid hardcoded 
py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24770#issuecomment-498088098
 
 
   **[Test build #106080 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106080/testReport)**
 for PR 24770 at commit 
[`6881ef6`](https://github.com/apache/spark/commit/6881ef64eab4f8460b1236a460a396e92cf6bc3e).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #24770: [MINOR] Avoid hardcoded py4j-0.10.8.1-src.zip in Scala

[GitBox]

SparkQA commented on issue #24770: [MINOR] Avoid hardcoded 
py4j-0.10.8.1-src.zip in Scala
URL: https://github.com/apache/spark/pull/24770#issuecomment-498107226
 
 
   **[Test build #106080 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106080/testReport)**
 for PR 24770 at commit 
[`6881ef6`](https://github.com/apache/spark/commit/6881ef64eab4f8460b1236a460a396e92cf6bc3e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org