[GitHub] [spark] AmplabJenkins commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql
AmplabJenkins commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877#issuecomment-502338072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106540/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql
AmplabJenkins removed a comment on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877#issuecomment-502338070 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql
AmplabJenkins commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877#issuecomment-502338070 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql
AmplabJenkins removed a comment on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877#issuecomment-502338072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106540/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql
SparkQA removed a comment on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877#issuecomment-502329066 **[Test build #106540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106540/testReport)** for PR 24877 at commit [`c9784bf`](https://github.com/apache/spark/commit/c9784bf3a69f3b51f2a451e32a3a6349dc5ea7d8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql
SparkQA commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877#issuecomment-502337975 **[Test build #106540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106540/testReport)** for PR 24877 at commit [`c9784bf`](https://github.com/apache/spark/commit/c9784bf3a69f3b51f2a451e32a3a6349dc5ea7d8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #24843: [SPARK-28004][UI] Update jquery to 3.4.1
dongjoon-hyun commented on issue #24843: [SPARK-28004][UI] Update jquery to 3.4.1 URL: https://github.com/apache/spark/pull/24843#issuecomment-502336639 cc @gatorsmile and @gengliangwang This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24843: [SPARK-28004][UI] Update jquery to 3.4.1
dongjoon-hyun commented on a change in pull request #24843: [SPARK-28004][UI] Update jquery to 3.4.1 URL: https://github.com/apache/spark/pull/24843#discussion_r294034909 ## File path: core/src/main/resources/org/apache/spark/ui/static/jquery.mustache.js ## @@ -45,6 +45,19 @@ return obj != null && typeof obj === 'object' && (propName in obj); } + /** Review comment: I also checked this. This file is identical with `mustache.js` v3.0.1. Only the trailing spaces are removed in a few lines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24843: [SPARK-28004][UI] Update jquery to 3.4.1
dongjoon-hyun commented on a change in pull request #24843: [SPARK-28004][UI] Update jquery to 3.4.1 URL: https://github.com/apache/spark/pull/24843#discussion_r294034909 ## File path: core/src/main/resources/org/apache/spark/ui/static/jquery.mustache.js ## @@ -45,6 +45,19 @@ return obj != null && typeof obj === 'object' && (propName in obj); } + /** Review comment: I also checked this. This file is identical with `mustache.js` v3.0.1. Only the trailing spaces are removed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #24843: [SPARK-28004][UI] Update jquery to 3.4.1
dongjoon-hyun closed pull request #24843: [SPARK-28004][UI] Update jquery to 3.4.1 URL: https://github.com/apache/spark/pull/24843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24843: [SPARK-28004][UI] Update jquery to 3.4.1
dongjoon-hyun commented on a change in pull request #24843: [SPARK-28004][UI]
Update jquery to 3.4.1
URL: https://github.com/apache/spark/pull/24843#discussion_r294035019
##
File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
##
@@ -104,7 +104,7 @@ $(document).ready(function() {
});
var historySummary = $("#history-summary");
-var searchString = historySummary["context"]["location"]["search"];
+var searchString = window.location.search;
Review comment:
I also verified that this works in the same way.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24843: [SPARK-28004][UI] Update jquery to 3.4.1
dongjoon-hyun commented on a change in pull request #24843: [SPARK-28004][UI]
Update jquery to 3.4.1
URL: https://github.com/apache/spark/pull/24843#discussion_r294034951
##
File path: docs/js/main.js
##
@@ -93,5 +93,5 @@ $(function() {
// Scroll now too in case we had opened the page on a hash, but wait a bit
because some browsers
// will try to do *their* initial scroll after running the onReady handler.
- $(window).load(function() { setTimeout(function() { maybeScrollToHash(); },
25); });
+ $(window).on('load', function() { setTimeout(function() {
maybeScrollToHash(); }, 25); });
Review comment:
Yep. This is the correct update based on the upgrade-guide.
-
https://jquery.com/upgrade-guide/3.0/#breaking-change-load-unload-and-error-removed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24843: [SPARK-28004][UI] Update jquery to 3.4.1
dongjoon-hyun commented on a change in pull request #24843: [SPARK-28004][UI] Update jquery to 3.4.1 URL: https://github.com/apache/spark/pull/24843#discussion_r294034909 ## File path: core/src/main/resources/org/apache/spark/ui/static/jquery.mustache.js ## @@ -45,6 +45,19 @@ return obj != null && typeof obj === 'object' && (propName in obj); } + /** Review comment: I also checked that. This file is identical with `mustache.js` v3.0.1. Only the trailing spaces are removed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
AmplabJenkins removed a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502334631 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106538/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
AmplabJenkins removed a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502334630 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
AmplabJenkins commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502334631 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106538/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
AmplabJenkins commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502334630 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
SparkQA removed a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502325093 **[Test build #106538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106538/testReport)** for PR 24866 at commit [`fa4dfe9`](https://github.com/apache/spark/commit/fa4dfe9811db3150cc9dd92fcd6a47af6faeeb37). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
SparkQA commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502334559 **[Test build #106538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106538/testReport)** for PR 24866 at commit [`fa4dfe9`](https://github.com/apache/spark/commit/fa4dfe9811db3150cc9dd92fcd6a47af6faeeb37). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
AmplabJenkins removed a comment on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502334361 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106537/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
AmplabJenkins removed a comment on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502334359 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
AmplabJenkins commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502334361 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106537/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
SparkQA removed a comment on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502324690 **[Test build #106537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106537/testReport)** for PR 24873 at commit [`d626559`](https://github.com/apache/spark/commit/d6265595ce460c7303189b51098c77d67c3a6f2f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
AmplabJenkins commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502334359 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
SparkQA commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502334273 **[Test build #106537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106537/testReport)** for PR 24873 at commit [`d626559`](https://github.com/apache/spark/commit/d6265595ce460c7303189b51098c77d67c3a6f2f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #20045: [SPARK-22360][SQL][TEST] Add unit tests for Window Specifications
dongjoon-hyun commented on issue #20045: [SPARK-22360][SQL][TEST] Add unit tests for Window Specifications URL: https://github.com/apache/spark/pull/20045#issuecomment-502333977 Do you still need this, @jiangxb1987 ? Also, gentle ping, @smurakozi . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL
AmplabJenkins removed a comment on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL URL: https://github.com/apache/spark/pull/24706#issuecomment-502333551 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL
AmplabJenkins removed a comment on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL URL: https://github.com/apache/spark/pull/24706#issuecomment-502333552 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106536/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL
AmplabJenkins commented on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL URL: https://github.com/apache/spark/pull/24706#issuecomment-502333552 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106536/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL
AmplabJenkins commented on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL URL: https://github.com/apache/spark/pull/24706#issuecomment-502333551 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL
SparkQA removed a comment on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL URL: https://github.com/apache/spark/pull/24706#issuecomment-502323226 **[Test build #106536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106536/testReport)** for PR 24706 at commit [`e265104`](https://github.com/apache/spark/commit/e2651049c408f211b225f40c93adf5b741b14eb4). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL
SparkQA commented on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL URL: https://github.com/apache/spark/pull/24706#issuecomment-502333466 **[Test build #106536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106536/testReport)** for PR 24706 at commit [`e265104`](https://github.com/apache/spark/commit/e2651049c408f211b225f40c93adf5b741b14eb4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #24857: [MINOR][CORE] Remove unused variables, unused imports, etc.
HyukjinKwon commented on issue #24857: [MINOR][CORE] Remove unused variables, unused imports, etc. URL: https://github.com/apache/spark/pull/24857#issuecomment-502333299 It's fine since it fixes multiple instances. I see some committers are actively reviewing this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql
AmplabJenkins commented on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql URL: https://github.com/apache/spark/pull/24853#issuecomment-502333268 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql
AmplabJenkins removed a comment on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql URL: https://github.com/apache/spark/pull/24853#issuecomment-502333268 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql
AmplabJenkins commented on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql URL: https://github.com/apache/spark/pull/24853#issuecomment-502333270 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106535/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql
AmplabJenkins removed a comment on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql URL: https://github.com/apache/spark/pull/24853#issuecomment-502333270 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106535/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql
SparkQA removed a comment on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql URL: https://github.com/apache/spark/pull/24853#issuecomment-502323225 **[Test build #106535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106535/testReport)** for PR 24853 at commit [`b7a62b6`](https://github.com/apache/spark/commit/b7a62b6177a0f6b1f2af9e15afd85e53cc31e133). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql
SparkQA commented on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql URL: https://github.com/apache/spark/pull/24853#issuecomment-502333195 **[Test build #106535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106535/testReport)** for PR 24853 at commit [`b7a62b6`](https://github.com/apache/spark/commit/b7a62b6177a0f6b1f2af9e15afd85e53cc31e133). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
dongjoon-hyun edited a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502332323 Hi, @yeshengm . Please create a JIRA since this already touches over 7 files. I'm looking forward to see the benchmark result. Thanks for this effort! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
dongjoon-hyun commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502332323 Hi, @yeshengm . Please create a JIRA since this already touches over 7 files. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #24842: [SPARK-28002][SQL] Support WITH clause column aliases
dongjoon-hyun closed pull request #24842: [SPARK-28002][SQL] Support WITH clause column aliases URL: https://github.com/apache/spark/pull/24842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases
dongjoon-hyun commented on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases URL: https://github.com/apache/spark/pull/24842#issuecomment-502331545 Merged to master. Thank you so much, @peter-toth , @liancheng, @hvanhovell , @gatorsmile ! @peter-toth . Please proceed to #24831 and #24860 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] kiszk commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
kiszk commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502331465 LGTM, pending Jenkins This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #24871: [SPARK-28051][INFRA] Exposing JIRA issue component types at GitHub PRs
dongjoon-hyun closed pull request #24871: [SPARK-28051][INFRA] Exposing JIRA issue component types at GitHub PRs URL: https://github.com/apache/spark/pull/24871 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #23850: [SPARK-26949][SS] Prevent 'purge' to remove needed batch files in CompactibleFileStreamLog
dongjoon-hyun closed pull request #23850: [SPARK-26949][SS] Prevent 'purge' to remove needed batch files in CompactibleFileStreamLog URL: https://github.com/apache/spark/pull/23850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #24871: [SPARK-28051][INFRA] Exposing JIRA issue component types at GitHub PRs
dongjoon-hyun commented on issue #24871: [SPARK-28051][INFRA] Exposing JIRA issue component types at GitHub PRs URL: https://github.com/apache/spark/pull/24871#issuecomment-502331005 Thank you, @felixcheung and @HyukjinKwon . Merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #23850: [SPARK-26949][SS] Prevent 'purge' to remove needed batch files in CompactibleFileStreamLog
dongjoon-hyun commented on issue #23850: [SPARK-26949][SS] Prevent 'purge' to remove needed batch files in CompactibleFileStreamLog URL: https://github.com/apache/spark/pull/23850#issuecomment-502330869 Merged to master. Thank you, @HeartSaVioR and @gaborgsomogyi . cc @tdas , @jose-torres , @zsxwing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502330208 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106539/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502330206 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502330206 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
SparkQA removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502325522 **[Test build #106539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106539/testReport)** for PR 24798 at commit [`2bf4b5f`](https://github.com/apache/spark/commit/2bf4b5fb1c5c9480bba59627a7b61865619f5502). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502330208 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106539/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
SparkQA commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502330157 **[Test build #106539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106539/testReport)** for PR 24798 at commit [`2bf4b5f`](https://github.com/apache/spark/commit/2bf4b5fb1c5c9480bba59627a7b61865619f5502). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql
AmplabJenkins removed a comment on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877#issuecomment-502328558 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql
AmplabJenkins removed a comment on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877#issuecomment-502328559 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11781/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql
SparkQA commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877#issuecomment-502329066 **[Test build #106540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106540/testReport)** for PR 24877 at commit [`c9784bf`](https://github.com/apache/spark/commit/c9784bf3a69f3b51f2a451e32a3a6349dc5ea7d8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql
AmplabJenkins commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877#issuecomment-502328559 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11781/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql
AmplabJenkins commented on issue #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877#issuecomment-502328558 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum opened a new pull request #24877: [SPARK-28059][SQL][TEST] Port int4.sql
wangyum opened a new pull request #24877: [SPARK-28059][SQL][TEST] Port int4.sql URL: https://github.com/apache/spark/pull/24877 ## What changes were proposed in this pull request? This PR is to port int2.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/sql/int4.sql The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/expected/int4.out When porting the test cases, found two PostgreSQL specific features that do not exist in Spark SQL: [SPARK-28023](https://issues.apache.org/jira/browse/SPARK-28023): Trim the string when cast string type to other types [SPARK-28027](https://issues.apache.org/jira/browse/SPARK-28027): Add bitwise shift left/right operators Also, found a bug: [SPARK-28024](https://issues.apache.org/jira/browse/SPARK-28024): Incorrect value when out of range Also, found four inconsistent behavior: [SPARK-27923](https://issues.apache.org/jira/browse/SPARK-27923): Invalid input syntax for integer: "34.5" at PostgreSQL [SPARK-28027](https://issues.apache.org/jira/browse/SPARK-28027) Our `!` and `!!` has different meanings [SPARK-28028](https://issues.apache.org/jira/browse/SPARK-28028): Cast numeric to integral type need round [SPARK-2659](https://issues.apache.org/jira/browse/SPARK-2659): HiveQL: Division operator should always perform fractional division, for example: ```sql select 1/2; ``` ## How was this patch tested? N/A This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] imback82 commented on issue #24857: [MINOR][CORE] Remove unused variables, unused imports, etc.
imback82 commented on issue #24857: [MINOR][CORE] Remove unused variables, unused imports, etc. URL: https://github.com/apache/spark/pull/24857#issuecomment-502327081 @srowen any update on this? @HyukjinKwon I just noticed that you referenced this PR from #24858. Do you have the same concern with this PR? If messing with imports is a concern for you, I could revert those changes. Please let me know. Thanks in advance! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases
AmplabJenkins removed a comment on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases URL: https://github.com/apache/spark/pull/24842#issuecomment-502326540 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases
AmplabJenkins removed a comment on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases URL: https://github.com/apache/spark/pull/24842#issuecomment-502326542 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106533/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases
AmplabJenkins commented on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases URL: https://github.com/apache/spark/pull/24842#issuecomment-502326540 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases
AmplabJenkins commented on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases URL: https://github.com/apache/spark/pull/24842#issuecomment-502326542 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106533/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases
SparkQA removed a comment on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases URL: https://github.com/apache/spark/pull/24842#issuecomment-502306733 **[Test build #106533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106533/testReport)** for PR 24842 at commit [`0a00a03`](https://github.com/apache/spark/commit/0a00a036148e898bd88bf3dd6e7b7ca0c67fa270). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases
SparkQA commented on issue #24842: [SPARK-28002][SQL] Support WITH clause column aliases URL: https://github.com/apache/spark/pull/24842#issuecomment-502326421 **[Test build #106533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106533/testReport)** for PR 24842 at commit [`0a00a03`](https://github.com/apache/spark/commit/0a00a036148e898bd88bf3dd6e7b7ca0c67fa270). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zuotingbing commented on a change in pull request #24848: [SPARK-28014][core] All waiting apps will be changed to the wrong state of Running after master changed.
zuotingbing commented on a change in pull request #24848: [SPARK-28014][core] All waiting apps will be changed to the wrong state of Running after master changed. URL: https://github.com/apache/spark/pull/24848#discussion_r294031222 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -561,7 +561,7 @@ private[deploy] class Master( apps.filter(_.state == ApplicationState.UNKNOWN).foreach(finishApplication) // Update the state of recovered apps to RUNNING -apps.filter(_.state == ApplicationState.WAITING).foreach(_.state = ApplicationState.RUNNING) +apps.filter(_.coresLeft == 0).foreach(_.state = ApplicationState.RUNNING) Review comment: Yes you are right. Update it , thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
SparkQA commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502325522 **[Test build #106539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106539/testReport)** for PR 24798 at commit [`2bf4b5f`](https://github.com/apache/spark/commit/2bf4b5fb1c5c9480bba59627a7b61865619f5502). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502325408 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11780/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502325407 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502325407 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502325408 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11780/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2
mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-502325252 @rdblue addressed the last set of comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
SparkQA commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502325093 **[Test build #106538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106538/testReport)** for PR 24866 at commit [`fa4dfe9`](https://github.com/apache/spark/commit/fa4dfe9811db3150cc9dd92fcd6a47af6faeeb37). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
AmplabJenkins removed a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502324963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11779/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
AmplabJenkins removed a comment on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502324962 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
AmplabJenkins commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502324962 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression
AmplabJenkins commented on issue #24866: [WIP][SQL] Micro-optimization to avoid expensive reference computation in QueryPlan and Expression URL: https://github.com/apache/spark/pull/24866#issuecomment-502324963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11779/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] kiszk commented on a change in pull request #24865: [SPARK-27100][SQL] dag-scheduler-event-loop" java.lang.StackOverflowError
kiszk commented on a change in pull request #24865: [SPARK-27100][SQL]
dag-scheduler-event-loop" java.lang.StackOverflowError
URL: https://github.com/apache/spark/pull/24865#discussion_r294030627
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##
@@ -381,7 +381,7 @@ case class FileSourceScanExec(
fsRelation: HadoopFsRelation): RDD[InternalRow] = {
logInfo(s"Planning with ${bucketSpec.numBuckets} buckets")
val filesGroupedToBuckets =
- selectedPartitions.flatMap { p =>
+ selectedPartitions.toArray.flatMap { p =>
Review comment:
Does it make sense to apply the same change to `selectedPartitions.flatMap`
in `createNonBucketedReadRDD(...)`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
SparkQA commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502324690 **[Test build #106537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106537/testReport)** for PR 24873 at commit [`d626559`](https://github.com/apache/spark/commit/d6265595ce460c7303189b51098c77d67c3a6f2f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
AmplabJenkins removed a comment on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502324593 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11778/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
AmplabJenkins removed a comment on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502324592 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
AmplabJenkins commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502324593 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11778/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
AmplabJenkins commented on issue #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#issuecomment-502324592 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] hehuiyuan commented on a change in pull request #24839: [SPARK-27258][K8S]Deal with the k8s resource names that don't match their own regular expression
hehuiyuan commented on a change in pull request #24839: [SPARK-27258][K8S]Deal
with the k8s resource names that don't match their own regular expression
URL: https://github.com/apache/spark/pull/24839#discussion_r294030214
##
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
##
@@ -198,6 +198,7 @@ private[spark] object KubernetesConf {
.replaceAll("\\.", "-")
.replaceAll("[^a-z0-9\\-]", "")
.replaceAll("-+", "-")
+ .replaceAll("^-", "")
Review comment:
> Is this still needed then, if you're simply validating and replacing the
name if it starts with "-"?
The '^-' is used for all kubernetes resources. If the resource name starts
with "-",we replace it with `""` ,which can run normally .
The service name that starts with `0-9` is replace.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
ueshin commented on a change in pull request #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic. URL: https://github.com/apache/spark/pull/24873#discussion_r294030317 ## File path: docs/sql-migration-guide-upgrade.md ## @@ -139,6 +139,8 @@ license: | - Since Spark 3.0, we use a new protocol for fetching shuffle blocks, for external shuffle service users, we need to upgrade the server correspondingly. Otherwise, we'll get the error message `UnsupportedOperationException: Unexpected message: FetchShuffleBlocks`. If it is hard to upgrade the shuffle service right now, you can still use the old protocol by setting `spark.shuffle.useOldFetchProtocol` to `true`. + - Since Spark 3.0, a higher-order function `exists` follows the three-valued boolean logic. The previous behaviour can be restored by setting `spark.sql.legacy.arrayExistsFollowsThreeValuedLogic` to `false`. Review comment: Sure, I added some more note and an example. Could you check it again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #24873: [SPARK-28052][SQL] Make `ArrayExists` follow the three-valued boolean logic.
ueshin commented on a change in pull request #24873: [SPARK-28052][SQL] Make
`ArrayExists` follow the three-valued boolean logic.
URL: https://github.com/apache/spark/pull/24873#discussion_r294030319
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
##
@@ -409,16 +424,23 @@ case class ArrayExists(
override def nullSafeEval(inputRow: InternalRow, argumentValue: Any): Any = {
val arr = argumentValue.asInstanceOf[ArrayData]
val f = functionForEval
-var exists = false
+var foundNull = false
var i = 0
-while (i < arr.numElements && !exists) {
+while (i < arr.numElements) {
elementVar.value.set(arr.get(i, elementVar.dataType))
- if (f.eval(inputRow).asInstanceOf[Boolean]) {
-exists = true
+ val ret = f.eval(inputRow)
+ if (ret == null) {
+foundNull = true
+ } else if (ret.asInstanceOf[Boolean]) {
+return true
Review comment:
Sure, I updated to use `exists` back.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] hehuiyuan commented on a change in pull request #24839: [SPARK-27258][K8S]Deal with the k8s resource names that don't match their own regular expression
hehuiyuan commented on a change in pull request #24839: [SPARK-27258][K8S]Deal
with the k8s resource names that don't match their own regular expression
URL: https://github.com/apache/spark/pull/24839#discussion_r294030214
##
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
##
@@ -198,6 +198,7 @@ private[spark] object KubernetesConf {
.replaceAll("\\.", "-")
.replaceAll("[^a-z0-9\\-]", "")
.replaceAll("-+", "-")
+ .replaceAll("^-", "")
Review comment:
> Is this still needed then, if you're simply validating and replacing the
name if it starts with "-"?
The '^-' is used for all kubernetes resources. If the resource name starts
with "-",we replace it with `""` ,which can run normally
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series
AmplabJenkins removed a comment on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series URL: https://github.com/apache/spark/pull/24643#issuecomment-502323958 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106534/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series
AmplabJenkins removed a comment on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series URL: https://github.com/apache/spark/pull/24643#issuecomment-502323956 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series
AmplabJenkins commented on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series URL: https://github.com/apache/spark/pull/24643#issuecomment-502323958 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106534/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series
AmplabJenkins commented on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series URL: https://github.com/apache/spark/pull/24643#issuecomment-502323956 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series
SparkQA removed a comment on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series URL: https://github.com/apache/spark/pull/24643#issuecomment-502306766 **[Test build #106534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106534/testReport)** for PR 24643 at commit [`f0ba0a9`](https://github.com/apache/spark/commit/f0ba0a99ff6f7a98ab4222546a5678dcaee6f665). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series
SparkQA commented on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series URL: https://github.com/apache/spark/pull/24643#issuecomment-502323802 **[Test build #106534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106534/testReport)** for PR 24643 at commit [`f0ba0a9`](https://github.com/apache/spark/commit/f0ba0a99ff6f7a98ab4222546a5678dcaee6f665). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql
SparkQA commented on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql URL: https://github.com/apache/spark/pull/24853#issuecomment-502323225 **[Test build #106535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106535/testReport)** for PR 24853 at commit [`b7a62b6`](https://github.com/apache/spark/commit/b7a62b6177a0f6b1f2af9e15afd85e53cc31e133). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL
SparkQA commented on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL URL: https://github.com/apache/spark/pull/24706#issuecomment-502323226 **[Test build #106536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/106536/testReport)** for PR 24706 at commit [`e265104`](https://github.com/apache/spark/commit/e2651049c408f211b225f40c93adf5b741b14eb4). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql
AmplabJenkins removed a comment on issue #24853: [SPARK-28029][SQL][TEST] Port int2.sql URL: https://github.com/apache/spark/pull/24853#issuecomment-502323069 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL
AmplabJenkins removed a comment on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL URL: https://github.com/apache/spark/pull/24706#issuecomment-502323082 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11777/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL
AmplabJenkins removed a comment on issue #24706: [SPARK-23128][SQL] A new approach to do adaptive execution in Spark SQL URL: https://github.com/apache/spark/pull/24706#issuecomment-502323079 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
