[GitHub] [spark] AmplabJenkins removed a comment on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
AmplabJenkins removed a comment on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271#issuecomment-546663830 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112724/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
SparkQA removed a comment on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271#issuecomment-546659905 **[Test build #112724 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112724/testReport)** for PR 26271 at commit [`1ce53bb`](https://github.com/apache/spark/commit/1ce53bb87cae7893421b5e60412422c9f3f896a5). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
AmplabJenkins removed a comment on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271#issuecomment-546663827 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
AmplabJenkins commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271#issuecomment-546663830 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112724/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
AmplabJenkins commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271#issuecomment-546663827 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
SparkQA commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271#issuecomment-546663799 **[Test build #112724 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112724/testReport)** for PR 26271 at commit [`1ce53bb`](https://github.com/apache/spark/commit/1ce53bb87cae7893421b5e60412422c9f3f896a5). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
dongjoon-hyun edited a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546663576 The following failure happens in `master` branch, too. It seems that irrelevant to this PR. ``` org.scalatest.exceptions.TestFailedException: 15722172 was not 15722136 plus or minus 3000 ``` - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-sbt-hadoop-3.2/653/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
dongjoon-hyun commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546663576 The following failure happens in `master` branch, too. It seems that irrelevant to this PR. ``` org.scalatest.exceptions.TestFailedException: 15722172 was not 15722136 plus or minus 3000 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] 07ARB commented on issue #26259: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
07ARB commented on issue #26259: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab. URL: https://github.com/apache/spark/pull/26259#issuecomment-546663195 @shahidki31 and @srowen now I think fixed is ok? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] 07ARB commented on a change in pull request #26259: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
07ARB commented on a change in pull request #26259: [SPARK-29453][WEBUI]
Improve tooltips information for SQL tab.
URL: https://github.com/apache/spark/pull/26259#discussion_r339324715
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
##
@@ -397,9 +408,16 @@ private[ui] class ExecutionPagedTable(
val desc = if (execution.description != null &&
execution.description.nonEmpty) {
-{execution.description}
+
+ {execution.description}
+
Review comment:
Ok, I will modify.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] 07ARB commented on a change in pull request #26259: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
07ARB commented on a change in pull request #26259: [SPARK-29453][WEBUI]
Improve tooltips information for SQL tab.
URL: https://github.com/apache/spark/pull/26259#discussion_r339324715
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
##
@@ -397,9 +408,16 @@ private[ui] class ExecutionPagedTable(
val desc = if (execution.description != null &&
execution.description.nonEmpty) {
-{execution.description}
+
+ {execution.description}
+
Review comment:
Ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546660847 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546660849 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17670/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546660849 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17670/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546660847 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
SparkQA commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546660771 **[Test build #112725 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112725/testReport)** for PR 26269 at commit [`e61f6bb`](https://github.com/apache/spark/commit/e61f6bb1623e77a87bd7322e171d9154d13616d9). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #26266: [SPARK-29611][WEBUI] Sort Kafka metadata by the number of messages
dongjoon-hyun commented on issue #26266: [SPARK-29611][WEBUI] Sort Kafka metadata by the number of messages URL: https://github.com/apache/spark/pull/26266#issuecomment-546660774 BTW, thank you for making a PR to Apache Spark, @dengziming . :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #26266: [SPARK-29611][WEBUI] Sort Kafka metadata by the number of messages
dongjoon-hyun edited a comment on issue #26266: [SPARK-29611][WEBUI] Sort Kafka metadata by the number of messages URL: https://github.com/apache/spark/pull/26266#issuecomment-546660695 @dengziming . Your branch is behind more than 2 years. The last commit before your patch is `Commits on Jun 29, 2017`. - https://github.com/dengziming/spark/commits/feature_ui_optimize This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #26266: [SPARK-29611][WEBUI] Sort Kafka metadata by the number of messages
dongjoon-hyun commented on issue #26266: [SPARK-29611][WEBUI] Sort Kafka metadata by the number of messages URL: https://github.com/apache/spark/pull/26266#issuecomment-546660695 @dengziming . Your branch is behind more than 2 yours. The last commit before your patch is `Commits on Jun 29, 2017`. - https://github.com/dengziming/spark/commits/feature_ui_optimize This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
huaxingao commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546660564 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26270: [SPARK-26544][SQL] Escape struct string in spark thriftserver to keep alignment with hive
dongjoon-hyun commented on a change in pull request #26270: [SPARK-26544][SQL]
Escape struct string in spark thriftserver to keep alignment with hive
URL: https://github.com/apache/spark/pull/26270#discussion_r339324465
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -758,6 +758,11 @@ object SQLConf {
.intConf
.createWithDefault(200)
+ val THRIFTSERVER_RESULT_ESCAPE_STRUCT_STRING =
buildConf("spark.sql.thriftserver.result.escapeStructString.enabled")
Review comment:
`GitHub Action` seems to complain for this line. Could you check by running
`dev/scalastyle`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
AmplabJenkins commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271#issuecomment-546660004 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
AmplabJenkins removed a comment on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271#issuecomment-546660007 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17669/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
AmplabJenkins commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271#issuecomment-546660007 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17669/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
AmplabJenkins removed a comment on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271#issuecomment-546660004 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
SparkQA commented on issue #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271#issuecomment-546659905 **[Test build #112724 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112724/testReport)** for PR 26271 at commit [`1ce53bb`](https://github.com/apache/spark/commit/1ce53bb87cae7893421b5e60412422c9f3f896a5). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun opened a new pull request #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1
dongjoon-hyun opened a new pull request #26271: [SPARK-29613][BUILD][SS] Upgrade to Kafka 2.3.1 URL: https://github.com/apache/spark/pull/26271 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce any user-facing change? ### How was this patch tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
AngersZh commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546659641 > Just need to resolve the merge conflict too Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
AmplabJenkins commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546659321 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
SparkQA commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546659308 **[Test build #112723 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112723/testReport)** for PR 26253 at commit [`59697bc`](https://github.com/apache/spark/commit/59697bc08d1b3c4dd19e20b2fbceefb72244928f). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `abstract class BitAggregate extends DeclarativeAggregate with ExpectsInputTypes ` * `case class BitAndAgg(child: Expression) extends BitAggregate ` * `case class BitOrAgg(child: Expression) extends BitAggregate ` * `case class BitXorAgg(child: Expression) extends BitAggregate ` * `case class Version() extends LeafExpression with CodegenFallback ` * `case class ShowCreateTableStatement(tableName: Seq[String]) extends ParsedStatement` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
SparkQA removed a comment on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546658387 **[Test build #112723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112723/testReport)** for PR 26253 at commit [`59697bc`](https://github.com/apache/spark/commit/59697bc08d1b3c4dd19e20b2fbceefb72244928f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
AmplabJenkins removed a comment on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546659322 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112723/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
AmplabJenkins removed a comment on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546659321 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
AmplabJenkins commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546659322 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112723/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol
AngersZh commented on a change in pull request #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol URL: https://github.com/apache/spark/pull/26221#discussion_r339323915 ## File path: sql/thriftserver/if/TCLIService.thrift ## @@ -0,0 +1,1298 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Coding Conventions for this file: +// +// Structs/Enums/Unions +// * Struct, Enum, and Union names begin with a "T", +// and use a capital letter for each new word, with no underscores. +// * All fields should be declared as either optional or required. +// +// Functions +// * Function names start with a capital letter and have a capital letter for +// each new word, with no underscores. +// * Each function should take exactly one parameter, named TFunctionNameReq, +// and should return either void or TFunctionNameResp. This convention allows +// incremental updates. +// +// Services +// * Service names begin with the letter "T", use a capital letter for each +// new word (with no underscores), and end with the word "Service". + +namespace java org.apache.spark.sql.thriftserver.cli.thrift +namespace cpp apache.spark.sql.thriftserver.cli.thrift + +// List of protocol versions. A new token should be +// added to the end of this list every time a change is made. Review comment: @juliuszsompolski Ok with this package name? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
AmplabJenkins removed a comment on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546658453 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17668/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
AmplabJenkins commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546658452 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
AmplabJenkins commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546658453 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17668/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
AmplabJenkins removed a comment on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546658452 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
SparkQA commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546658387 **[Test build #112723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112723/testReport)** for PR 26253 at commit [`59697bc`](https://github.com/apache/spark/commit/59697bc08d1b3c4dd19e20b2fbceefb72244928f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #26267: [SPARK-29008][SQL][FOLLOW-UP] Checks correct param lengths of split methods
viirya commented on a change in pull request #26267:
[SPARK-29008][SQL][FOLLOW-UP] Checks correct param lengths of split methods
URL: https://github.com/apache/spark/pull/26267#discussion_r339323688
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##
@@ -1050,7 +1050,10 @@ class CodegenContext extends Logging {
}
val codes = if (commonExprVals.map(_.code.length).sum >
SQLConf.get.methodSplitThreshold) {
- if (commonExprs.map(calculateParamLength).forall(isValidParamLength)) {
+ val inputVarsForAllFuncs = commonExprs.map { expr =>
+getLocalInputVariableValues(this, expr.head).toSeq
+ }
+ if
(inputVarsForAllFuncs.map(calculateParamLengthFromExprValues).forall(isValidParamLength))
{
Review comment:
yea, good catch! We should check param length for input parameters to common
expressions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] shahidki31 commented on issue #26246: [SPARK-29589][WEBUI] Support pagination for sqlstats session table in JDBC/ODBC Session page
shahidki31 commented on issue #26246: [SPARK-29589][WEBUI] Support pagination for sqlstats session table in JDBC/ODBC Session page URL: https://github.com/apache/spark/pull/26246#issuecomment-546657324 Thanks @srowen This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] shahidki31 commented on a change in pull request #26259: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
shahidki31 commented on a change in pull request #26259: [SPARK-29453][WEBUI]
Improve tooltips information for SQL tab.
URL: https://github.com/apache/spark/pull/26259#discussion_r339323359
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
##
@@ -397,9 +408,16 @@ private[ui] class ExecutionPagedTable(
val desc = if (execution.description != null &&
execution.description.nonEmpty) {
-{execution.description}
+
+ {execution.description}
+
Review comment:
@07ARB Yes, I think both cases we need not show the tool tips for every row
as we are already showing in the header.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26270: [SPARK-26544][SQL] Escape struct string in spark thriftserver to keep alignment with hive
AmplabJenkins removed a comment on issue #26270: [SPARK-26544][SQL] Escape struct string in spark thriftserver to keep alignment with hive URL: https://github.com/apache/spark/pull/26270#issuecomment-546655091 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26270: [SPARK-26544][SQL] Escape struct string in spark thriftserver to keep alignment with hive
AmplabJenkins commented on issue #26270: [SPARK-26544][SQL] Escape struct string in spark thriftserver to keep alignment with hive URL: https://github.com/apache/spark/pull/26270#issuecomment-546655157 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26270: [SPARK-26544][SQL] Escape struct string in spark thriftserver to keep alignment with hive
AmplabJenkins commented on issue #26270: [SPARK-26544][SQL] Escape struct string in spark thriftserver to keep alignment with hive URL: https://github.com/apache/spark/pull/26270#issuecomment-546655091 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] WangGuangxin commented on issue #26270: [SPARK-26544][SQL] Escape struct string in spark thriftserver to keep alignment with hive
WangGuangxin commented on issue #26270: [SPARK-26544][SQL] Escape struct string in spark thriftserver to keep alignment with hive URL: https://github.com/apache/spark/pull/26270#issuecomment-546655026 cc @wangyum This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] WangGuangxin opened a new pull request #26270: [SPARK-26544][SQL] Escape struct string in spark thriftserver to keep alignment with hive
WangGuangxin opened a new pull request #26270: [SPARK-26544][SQL] Escape struct
string in spark thriftserver to keep alignment with hive
URL: https://github.com/apache/spark/pull/26270
### What changes were proposed in this pull request?
In this PR, I proposed to escape strings when serializing Map/Array/Struct
type in Spark ThriftServer, so that the result is always a valid JSON, which is
what Hive does.
Add a conf to make sure it doesn't break compatibility.
### Why are the changes needed?
The string serialized from Map/Array/Struct type in Spark ThriftServer is
not a valid JSON when the elements of Map/Array/Struct contain special
characters such as `"`.
For example, select a field whose type is map, the spark
thrift server returns
BEFORE
```{"author_id":"123","log_pb":"{"impr_id":"20181231"}","request_id":"001"}```
AFTER
```{"author_id":"123",
"log_pb":"{\"impr_id\":\"20181231\"}","request_id":"001"}```
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
HiveResultSuite.scala
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] 07ARB commented on a change in pull request #26259: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
07ARB commented on a change in pull request #26259: [SPARK-29453][WEBUI]
Improve tooltips information for SQL tab.
URL: https://github.com/apache/spark/pull/26259#discussion_r339322098
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
##
@@ -397,9 +408,16 @@ private[ui] class ExecutionPagedTable(
val desc = if (execution.description != null &&
execution.description.nonEmpty) {
-{execution.description}
+
+ {execution.description}
+
Review comment:
Ok fine, @shahidki31 and @srowen, one more thing if execution.descrition
value is null then hyperlink is getting enable in execution.id, in this case,
description we need to change for ID?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546654853 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112722/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
SparkQA removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546650134 **[Test build #112722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112722/testReport)** for PR 26269 at commit [`e61f6bb`](https://github.com/apache/spark/commit/e61f6bb1623e77a87bd7322e171d9154d13616d9). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546654852 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546654853 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112722/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546654852 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
SparkQA commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546654829 **[Test build #112722 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112722/testReport)** for PR 26269 at commit [`e61f6bb`](https://github.com/apache/spark/commit/e61f6bb1623e77a87bd7322e171d9154d13616d9). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class AlterTableRecoverPartitionsStatement(` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546653646 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112721/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
SparkQA removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546648403 **[Test build #112721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112721/testReport)** for PR 26261 at commit [`a6fbc4d`](https://github.com/apache/spark/commit/a6fbc4d30bcce55d154112ae856c5e4b20dbfd5d). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546653644 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546653646 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112721/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
SparkQA commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546653595 **[Test build #112721 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112721/testReport)** for PR 26261 at commit [`a6fbc4d`](https://github.com/apache/spark/commit/a6fbc4d30bcce55d154112ae856c5e4b20dbfd5d). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546653644 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #26267: [SPARK-29008][SQL][FOLLOW-UP] Checks correct param lengths of split methods
maropu commented on issue #26267: [SPARK-29008][SQL][FOLLOW-UP] Checks correct param lengths of split methods URL: https://github.com/apache/spark/pull/26267#issuecomment-546651888 @viirya many thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546650209 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17667/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546650207 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546650207 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546650209 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17667/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
SparkQA commented on issue #26269: [SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269#issuecomment-546650134 **[Test build #112722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112722/testReport)** for PR 26269 at commit [`e61f6bb`](https://github.com/apache/spark/commit/e61f6bb1623e77a87bd7322e171d9154d13616d9). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] huaxingao opened a new pull request #26269: [SPARK-29481][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands
huaxingao opened a new pull request #26269: [SPARK-29481][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26269 ### What changes were proposed in this pull request? Add AlterTableRecoverPartitionsStatement and make ALTER TABLE ... RECOVER PARTITIONS go through the same catalog/table resolution framework of v2 commands. ### Why are the changes needed? It's important to make all the commands have the same table resolution behavior, to avoid confusing end-users. e.g. ``` USE my_catalog DESC t // success and describe the table t from my_catalog SHOW CREATE TABLE t // report table not found as there is no table t in the session catalog ``` ### Does this PR introduce any user-facing change? Yes. When running ALTER TABLE ... RECOVER PARTITIONS Spark fails the command if the current catalog is set to a v2 catalog, or the table name specified a v2 catalog. ### How was this patch tested? Unit tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26268: Fix SPARK-29594: Create a Dataset from a Sequence of Case class where a field name started with a number
AmplabJenkins commented on issue #26268: Fix SPARK-29594: Create a Dataset from a Sequence of Case class where a field name started with a number URL: https://github.com/apache/spark/pull/26268#issuecomment-546649061 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26268: Fix SPARK-29594: Create a Dataset from a Sequence of Case class where a field name started with a number
AmplabJenkins removed a comment on issue #26268: Fix SPARK-29594: Create a Dataset from a Sequence of Case class where a field name started with a number URL: https://github.com/apache/spark/pull/26268#issuecomment-546649016 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26268: Fix SPARK-29594: Create a Dataset from a Sequence of Case class where a field name started with a number
AmplabJenkins commented on issue #26268: Fix SPARK-29594: Create a Dataset from a Sequence of Case class where a field name started with a number URL: https://github.com/apache/spark/pull/26268#issuecomment-546649016 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] PedroCorreiaLuis opened a new pull request #26268: Fix SPARK-29594: Create a Dataset from a Sequence of Case class where a field name started with a number
PedroCorreiaLuis opened a new pull request #26268: Fix SPARK-29594: Create a Dataset from a Sequence of Case class where a field name started with a number URL: https://github.com/apache/spark/pull/26268 ### What changes were proposed in this pull request? This pr is to fix a bug discovered by me, [SPARK-29594], when creating a Dataset using .toDS() in a sequence of a case class that had a field name starting with a number. Also changed the behaviour when it is a java keyword now toDS() handles it. ### Why are the changes needed? Bug fix ### Does this PR introduce any user-facing change? Yes, now it is possible to create Datasets from case classes with field names as java keywords ### How was this patch tested? Tests were modified, but following the new logic: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen closed pull request #23614: [SPARK-26689][CORE]Support blacklisting bad disk directory and retry in DiskBlockManager
srowen closed pull request #23614: [SPARK-26689][CORE]Support blacklisting bad disk directory and retry in DiskBlockManager URL: https://github.com/apache/spark/pull/23614 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546648431 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546648432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17666/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546648432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17666/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546648431 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
SparkQA commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546648403 **[Test build #112721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112721/testReport)** for PR 26261 at commit [`a6fbc4d`](https://github.com/apache/spark/commit/a6fbc4d30bcce55d154112ae856c5e4b20dbfd5d). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on issue #25095: [SPARK-28332][SQL] SQLMetric wrong initValue
srowen commented on issue #25095: [SPARK-28332][SQL] SQLMetric wrong initValue URL: https://github.com/apache/spark/pull/25095#issuecomment-546647235 Ping @windpiger ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546642439 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112720/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546642433 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
SparkQA removed a comment on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546635350 **[Test build #112720 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112720/testReport)** for PR 26261 at commit [`e443921`](https://github.com/apache/spark/commit/e443921bef1a0f116e5bd0f896698d3b66e1b361). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546642439 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112720/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
AmplabJenkins commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546642433 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils
SparkQA commented on issue #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#issuecomment-546642383 **[Test build #112720 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112720/testReport)** for PR 26261 at commit [`e443921`](https://github.com/apache/spark/commit/e443921bef1a0f116e5bd0f896698d3b66e1b361). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] planga82 commented on issue #26182: [SPARK-29523][SQL] SHOW COLUMNS should do multi-catalog resolution.
planga82 commented on issue #26182: [SPARK-29523][SQL] SHOW COLUMNS should do multi-catalog resolution. URL: https://github.com/apache/spark/pull/26182#issuecomment-546639211 I am reviewing it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen closed pull request #13617: [SPARK-10409] [ML] Add Multilayer Perceptron Regression to ML
srowen closed pull request #13617: [SPARK-10409] [ML] Add Multilayer Perceptron Regression to ML URL: https://github.com/apache/spark/pull/13617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on issue #25470: [SPARK-28751][Core][WIP] Improve java serializer deserialization performance
srowen commented on issue #25470: [SPARK-28751][Core][WIP] Improve java serializer deserialization performance URL: https://github.com/apache/spark/pull/25470#issuecomment-546638906 I'd like to see a benchmark to prove there's much real-world benefit. The difference is just small here as the JVM caches the classes. `Class.forName` takes a bit of time, sure, but that is very small compared to even a single RPC's overhead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen closed pull request #25556: [SPARK-28853][SQL] Support conf to organize file partitions by file path
srowen closed pull request #25556: [SPARK-28853][SQL] Support conf to organize file partitions by file path URL: https://github.com/apache/spark/pull/25556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen closed pull request #25489: [PYTHON][WIP] pyspark.sql.functions.col as C
srowen closed pull request #25489: [PYTHON][WIP] pyspark.sql.functions.col as C URL: https://github.com/apache/spark/pull/25489 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab
srowen commented on issue #26253: [SPARK-29599][WEBUI] Support pagination for session table in JDBC/ODBC Tab URL: https://github.com/apache/spark/pull/26253#issuecomment-546638119 Just need to resolve the merge conflict too This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on issue #26246: [SPARK-29589][WEBUI] Support pagination for sqlstats session table in JDBC/ODBC Session page
srowen commented on issue #26246: [SPARK-29589][WEBUI] Support pagination for sqlstats session table in JDBC/ODBC Session page URL: https://github.com/apache/spark/pull/26246#issuecomment-546638030 Merged to master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen closed pull request #26246: [SPARK-29589][WEBUI] Support pagination for sqlstats session table in JDBC/ODBC Session page
srowen closed pull request #26246: [SPARK-29589][WEBUI] Support pagination for sqlstats session table in JDBC/ODBC Session page URL: https://github.com/apache/spark/pull/26246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-546636645 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #25898: [SPARK-29209][BUILD] Print build environment variables to Github
srowen commented on a change in pull request #25898: [SPARK-29209][BUILD] Print build environment variables to Github URL: https://github.com/apache/spark/pull/25898#discussion_r339314593 ## File path: dev/run-tests-jenkins.py ## @@ -183,6 +183,8 @@ def main(): os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop2.7" if "test-hadoop3.2" in ghprb_pull_title: os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop3.2" +if "test-java11" in ghprb_pull_title: Review comment: Maybe I'm not remembering that it was resolved - do we compile with `-release 8` now? I don't see that in the build and recall there was some issue with it previously, but maybe I'm forgetting. Either way I don't think it's necessary to set the compilation JDK here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-546636648 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112719/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-546636648 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112719/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-546636645 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
SparkQA removed a comment on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-546619666 **[Test build #112719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112719/testReport)** for PR 26178 at commit [`a95d001`](https://github.com/apache/spark/commit/a95d001733ca92179c9fb3a6dcade495d6d4ae19). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands
SparkQA commented on issue #26178: [SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26178#issuecomment-546636520 **[Test build #112719 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112719/testReport)** for PR 26178 at commit [`a95d001`](https://github.com/apache/spark/commit/a95d001733ca92179c9fb3a6dcade495d6d4ae19). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
