[GitHub] spark issue #17985: Add "full_outer" name to join types
Github user BartekH commented on the issue: https://github.com/apache/spark/pull/17985 Does your Jenkins work properly? It failed again, and again cause is different. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17985: Add "full_outer" name to join types
Github user BartekH commented on the issue: https://github.com/apache/spark/pull/17985 It has failed again. It's not my fault, please retest it one more time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17985: Add "full_outer" name to join types
Github user BartekH commented on the issue: https://github.com/apache/spark/pull/17985 Please rerun jenkins job. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18219: tests for JoinTypes
Github user BartekH closed the pull request at: https://github.com/apache/spark/pull/18219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17985: Add "full_outer" name to join types
Github user BartekH commented on the issue: https://github.com/apache/spark/pull/17985 @ HyukjinKwon Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18219: tests for JoinTypes
GitHub user BartekH opened a pull request: https://github.com/apache/spark/pull/18219 tests for JoinTypes tests for JoinType object ## What changes were proposed in this pull request? Tests for this code have been suggested during discussion on another problem, ## How was this patch tested? (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) Please review http://spark.apache.org/contributing.html before opening a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/BartekH/spark patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/18219.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18219 commit 71d65e84b326ad94a98e46dfedee172a14525cbd Author: BartekH <bartekhamie...@gmail.com> Date: 2017-06-06T14:55:00Z Create JoinTypesTest.scala tests for JoinType object --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17985: Add "full_outer" name to join types
Github user BartekH commented on the issue: https://github.com/apache/spark/pull/17985 I'll make pull request today. Sorry for delay --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17455: [Spark-20044][Web UI] Support Spark UI behind front-end ...
Github user BartekH commented on the issue: https://github.com/apache/spark/pull/17455 Any update? It's very urgent case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17985: Add "full_outer" name to join types
Github user BartekH commented on the issue: https://github.com/apache/spark/pull/17985 That's ok, but "full_outer" is invisible in exception information. Please consider add it, because is is possible to use "full_outer". When wrong name is provided and exception occurs, there is no information about "full_outer" option. It's a little bit misleading. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #17985: Add "full_outer" name to join types
GitHub user BartekH opened a pull request: https://github.com/apache/spark/pull/17985 Add "full_outer" name to join types I have discovered that "full_outer" name option is working in Spark 2.0, but it is not printed in exception. Please verify. ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) Please review http://spark.apache.org/contributing.html before opening a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/BartekH/spark patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/17985.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17985 commit f4b85576cb381fd5cd68c854af6a855779d939e8 Author: BartekH <bartekhamie...@gmail.com> Date: 2017-05-15T12:08:41Z Add "full_outer" name to join types I have discovered that "full_outer" name option is working in Spark 2.0, but it is not printed in exception. Please verify. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
