[GitHub] spark issue #18457: [SPARK-21241][MLlib]- Add setIntercept to StreamingLinea...

2018-10-03 Thread SoulGuedria
Github user SoulGuedria commented on the issue:

https://github.com/apache/spark/pull/18457
  
cc @HyukjinKwon can you take a look at this please. Thanks :)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18457: [SPARK-21241][MLlib]- Add setIntercept to StreamingLinea...

2018-09-29 Thread SoulGuedria
Github user SoulGuedria commented on the issue:

https://github.com/apache/spark/pull/18457
  
Can one of the admins verify this patch? Thanks


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18457: [SPARK-21241][MLlib]- Add setIntercept to StreamingLinea...

2018-07-16 Thread SoulGuedria
Github user SoulGuedria commented on the issue:

https://github.com/apache/spark/pull/18457
  
Yes i will do it very soon :) Thanks 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #18457: [SPARK-21241][MLlib]- Add setIntercept to Streami...

2017-06-28 Thread SoulGuedria
GitHub user SoulGuedria opened a pull request:

https://github.com/apache/spark/pull/18457

[SPARK-21241][MLlib]- Add setIntercept to StreamingLinearRegressionWi…

…thSGD in Pyspark.
## What changes were proposed in this pull request?
StreamingLinearRegressionWithSGD class in PySpark is missing the 
setIntercept Method which offers the possibility to turn on/off the intercept 
value. API parity is not respected between Python and Scala. We added the 
setIntercept Method to StreamingLinearRegressionWithSGD class which calls 
setIntercept Method in LinearRegressionModel class in order to turn on/off the 
intercept. A big thanks to Matthieu CANEILL for his precious help in solving 
this issue.

## How was this patch tested?
This patch was tested by running all tests with ./dev/run-tests.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SoulGuedria/spark fix-21241

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18457






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org