[GitHub] spark pull request: [SPARK-12499] [build] don't force MAVEN_OPTS
Github user abridgett commented on a diff in the pull request:
https://github.com/apache/spark/pull/10448#discussion_r56180120
--- Diff: make-distribution.sh ---
@@ -159,7 +159,7 @@ fi
# Build uber fat JAR
cd "$SPARK_HOME"
-export MAVEN_OPTS="-Xmx2g -XX:MaxPermSize=512M
-XX:ReservedCodeCacheSize=512m"
+export MAVEN_OPTS="${MAVEN_OPTS:--Xmx2g -XX:MaxPermSize=512M
-XX:ReservedCodeCacheSize=512m}"
--- End diff --
Indeed. POSIX shell too FYI- so should work with pretty much anything:
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_02
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12499] [build] don't force MAVEN_OPTS
GitHub user abridgett opened a pull request: https://github.com/apache/spark/pull/10448 [SPARK-12499] [build] don't force MAVEN_OPTS allow the user to override MAVEN_OPTS (2GB wasn't sufficient for me) You can merge this pull request into a Git repository by running: $ git pull https://github.com/abridgett/spark feature/do_not_force_maven_opts Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/10448.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10448 commit 2f90b4db1fe52b7d80250137105bd6127e94bda0 Author: Adrian Bridgett <adr...@smop.co.uk> Date: 2015-12-23T15:44:25Z don't force MAVEN_OPTS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
