[GitHub] spark pull request #15195: [SPARK-17632][SQL]make console sink and other sin...
Github user chuanlei closed the pull request at: https://github.com/apache/spark/pull/15195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15195: [SPARK-17632][SQL]make console sink and other sinks work...
Github user chuanlei commented on the issue: https://github.com/apache/spark/pull/15195 ok, I will close this pr. Thanks for the reply. @jerryshao @lw-lin @marmbrus @tdas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #15195: [SPARK-17632][SQL]make console sink and other sinks work...
Github user chuanlei commented on the issue: https://github.com/apache/spark/pull/15195 @marmbrus Could you have a look at this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15195: [SPARK-17632][SQL]make console sink and other sin...
Github user chuanlei commented on a diff in the pull request:
https://github.com/apache/spark/pull/15195#discussion_r80401708
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -290,8 +284,8 @@ final class DataStreamWriter[T] private[sql](ds:
Dataset[T]) {
df,
dataSource.createSink(outputMode),
outputMode,
-useTempCheckpointLocation = useTempCheckpointLocation,
-recoverFromCheckpointLocation = recoverFromCheckpointLocation,
+useTempCheckpointLocation = true,
--- End diff --
Actually, I am implementing kafka source for kafka0.8. When I ran the tests
for my implementation, I find the `ConsoleSink` cannot **continue** to process
data.
So I think if we provide `checkPointLocation` for the **sinks**, it can
continue to process data. If we do not provide this option, it is ok to start
from beginning. Not only the **other sinks**, I think all the sinks should
follow the pattern above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15195: [SPARK-17632][SQL]make console sink and other sin...
Github user chuanlei commented on a diff in the pull request:
https://github.com/apache/spark/pull/15195#discussion_r80357457
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
---
@@ -290,8 +284,8 @@ final class DataStreamWriter[T] private[sql](ds:
Dataset[T]) {
df,
dataSource.createSink(outputMode),
outputMode,
-useTempCheckpointLocation = useTempCheckpointLocation,
-recoverFromCheckpointLocation = recoverFromCheckpointLocation,
+useTempCheckpointLocation = true,
--- End diff --
Firstly, if **users want** to use temporary checkpoint location for
'**other sinks**', it is ok even if we will lost the processed data history.
User has the control of sql behavior.
Secondly, If users want to **continue** the process of data even for`
ConsoleSink` under the condition of 'set checkpoint location', we should give
the freedom to users. Again, users has the control of sql behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15195: [SPARK-17632][SQL]make console sink and other sin...
GitHub user chuanlei opened a pull request: https://github.com/apache/spark/pull/15195 [SPARK-17632][SQL]make console sink and other sinks work with recoverFromCheckpointLoca⦠## What changes were proposed in this pull request? make console sink and other sinks work with 'recoverFromCheckpointLocation' option enabled ## How was this patch tested? it is so trivial that no test needed Author: Chuanlei Ni <nichuan...@gmail.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/chuanlei/spark fix-console-sink-work-with-recoverFromCheckpointLocation-enabled Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/15195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15195 commit 4d64ac68b187e5e93bf2e47ffd45ef2f6aadc407 Author: nichuanlei <nichuan...@360.cn> Date: 2016-09-22T07:59:35Z make console sink and other sinks work with recoverFromCheckpointLocation option enabled --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
