[GitHub] spark issue #9276: [SPARK-9858][SPARK-9859][SPARK-9861][SQL] Add an Exchange...

2016-11-30 Thread dreamworks007
Github user dreamworks007 commented on the issue:

https://github.com/apache/spark/pull/9276
  
@yhuai , could you please let us know is there any known issues / 
limitation with this feature ? Has this feature been tested under some large 
jobs ? 

We are also considering automatical determining shuffle partitions, and 
happened to see this PR, and therefore interested in exploring this feature a 
little bit to see if we could productionize it for all jobs (by default).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15616: [SPARK-16827][Shuffle] add disk spill bytes to UnsafeExt...

2016-11-30 Thread dreamworks007
Github user dreamworks007 commented on the issue:

https://github.com/apache/spark/pull/15616
  
ping .. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15616: [SPARK-16827][Shuffle] add disk spill bytes to UnsafeExt...

2016-11-02 Thread dreamworks007
Github user dreamworks007 commented on the issue:

https://github.com/apache/spark/pull/15616
  
ping ... @JoshRosen 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15616: [SPARK-16827][Shuffle] add disk spill bytes to UnsafeExt...

2016-10-31 Thread dreamworks007
Github user dreamworks007 commented on the issue:

https://github.com/apache/spark/pull/15616
  
@joshrosen - could you take a look ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15616: [SPARK-16827][Shuffle] add disk spill bytes to UnsafeExt...

2016-10-25 Thread dreamworks007
Github user dreamworks007 commented on the issue:

https://github.com/apache/spark/pull/15616
  
ping  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #15616: [SPARK-16827][Shuffle] add disk spill bytes to Un...

2016-10-24 Thread dreamworks007
GitHub user dreamworks007 opened a pull request:

https://github.com/apache/spark/pull/15616

[SPARK-16827][Shuffle] add disk spill bytes to UnsafeExternalSorter

## What changes were proposed in this pull request?

disk spill bytes metrics was disabled due to apache/spark#15347. This PR 
adds that metrics.

## How was this patch tested?

Integration test with the following query:
val hc = new org.apache.spark.sql.hive.PlasmaHiveContext(sc).xyz_namespace
hc.sql("SET spark.sql.shuffle.partitions=800")
val sqlString  = """
SELECT  a.target_id AS userid
 FROM  table_a a
   JOIN table_b b
 ONa.ds = '2016-07-15'
  AND  b.ds = '2016-07-15'
  AND  a.source_id = b.id"""
hc.sql(sqlString).count()

in 1.6, in stage 2 , it does not have spill bytes metrics reporting, and in 
2.0 (with my change) , in stage 2, it has the spill bytes metrics reported
Spark 1.6 - 
![spark_1 
6](https://cloud.githubusercontent.com/assets/5782653/19664266/76a095c8-99f4-11e6-90ad-5111e3959a38.jpg)

Spark 2.0 - 
![spark_2 
0](https://cloud.githubusercontent.com/assets/5782653/19664274/7fa35980-99f4-11e6-8863-6e6b851c262b.jpg)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dreamworks007/spark oss_spill_metrics

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/15616.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15616


commit cbf933d0b20bfbd9840506270885caa14bbb5bce
Author: dreamworks007 <pliu.um...@gmail.com>
Date:   2016-10-24T21:09:17Z

first commit -  oss add spill metrics for UnsafeExternalSorter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #15347: [SPARK-16827] Stop reporting spill metrics as shuffle me...

2016-10-12 Thread dreamworks007
Github user dreamworks007 commented on the issue:

https://github.com/apache/spark/pull/15347
  
@rxin , "Can you also work on reporting spill metrics?" --> here , you mean 
reporting spill time metrics , right ?  Since I think write spill bytes is 
already included - 
https://github.com/facebook/FB-Spark/blob/fb-2.0/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java#L232


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org