[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()
Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49160379 thx @willb, maybe protected val SUBSTRING = Keyword(SUBSTRING) as well, but this will cause the code redundance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()
Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49161743 fine, that's great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SQL]Extract the joinkeys from join condition
Github user egraldlo commented on a diff in the pull request:
https://github.com/apache/spark/pull/1190#discussion_r14230460
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -65,7 +64,7 @@ private[sql] abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
def broadcastTables: Seq[String] =
sqlContext.joinBroadcastTables.split(,).toBuffer
def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
- case HashFilteredJoin(
+ case ExtractEquiJoinKeys(
--- End diff --
maybe annotation on line 48 can be modified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2049] [sql] Avg function may cause over...
Github user egraldlo closed the pull request at: https://github.com/apache/spark/pull/978 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2049] [sql] Avg function may cause over...
Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/978#issuecomment-45579617 yes, maybe I don't make the version of test branch to be up-to-date at that time. I will close the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: do best to avoid overflow in avg function
GitHub user egraldlo opened a pull request: https://github.com/apache/spark/pull/977 do best to avoid overflow in avg function since we define the return data type of avg() to DoubleType, I think we can do our best to extend the scope to avoid the overflowing, so I think we can transform the datatype to DoubleType before sum. You can merge this pull request into a Git repository by running: $ git pull https://github.com/egraldlo/spark stringoperator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/977.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #977 commit 13d3267c1c542ddd577fce2e8552b75a92b76f38 Author: egraldlo egral...@gmail.com Date: 2014-06-01T14:50:58Z system function upper and lower supported commit 1f0bbb5d672856764901cc9676ea7795d08e4ddb Author: egraldlo egral...@gmail.com Date: 2014-06-01T15:02:31Z system function upper and lower supported commit b49f25e6f2d976ae441aa6e27986ea59663f5080 Author: egraldlo egral...@gmail.com Date: 2014-06-02T05:04:42Z modify the formatting issues commit ea76d0a44e91488161eebd8ab28046960773b4e9 Author: egraldlo egral...@gmail.com Date: 2014-06-02T05:19:05Z modify the formatting issues commit 3c6c60a9d6d363ad2cf1f8d0482662d575ab3e18 Author: egraldlo egral...@gmail.com Date: 2014-06-02T08:53:01Z Add UPPER, LOWER, MAX and MIN into hive parser commit 8775c68465045b8a6d0426262c67c6a9c6938155 Author: egraldlo egral...@gmail.com Date: 2014-06-05T07:01:16Z avoid overflowing in function avg commit 1793a42fe2d2946f1633f2f20cca5ebb84e2c238 Author: egraldlo egral...@gmail.com Date: 2014-06-05T07:10:40Z Merge remote-tracking branch '0605/master' into stringoperator --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: do best to avoid overflow in avg function
Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/977#issuecomment-45195256 maybe something wrong with my branch, I will create a new one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: do best to avoid overflow in avg function
Github user egraldlo closed the pull request at: https://github.com/apache/spark/pull/977 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: do best to avoid overflowing in function avg
GitHub user egraldlo opened a pull request: https://github.com/apache/spark/pull/978 do best to avoid overflowing in function avg since we define the return data type of avg() to DoubleType, I think we can do our best to extend the scope to avoid the overflowing, so I think we can transform the datatype to DoubleType before sum. You can merge this pull request into a Git repository by running: $ git pull https://github.com/egraldlo/spark function-avg Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/978.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #978 commit 1153f752b0c3e9cb27250eb842c83a3f84e00362 Author: egraldlo egral...@gmail.com Date: 2014-06-05T08:31:43Z do best to avoid overflowing in function avg(). commit d414cd70a719e6ace60b588da65457300970a8f1 Author: egraldlo egral...@gmail.com Date: 2014-06-05T08:42:36Z fommatting issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: system function upper and lower can be support...
GitHub user egraldlo opened a pull request: https://github.com/apache/spark/pull/936 system function upper and lower can be supported I don't know whether it's time to implement system function about string operation in spark sql now. You can merge this pull request into a Git repository by running: $ git pull https://github.com/egraldlo/spark stringoperator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/936.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #936 commit 13d3267c1c542ddd577fce2e8552b75a92b76f38 Author: egraldlo egral...@gmail.com Date: 2014-06-01T14:50:58Z system function upper and lower supported commit 1f0bbb5d672856764901cc9676ea7795d08e4ddb Author: egraldlo egral...@gmail.com Date: 2014-06-01T15:02:31Z system function upper and lower supported --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: system function upper and lower can be support...
Github user egraldlo commented on the pull request: https://github.com/apache/spark/pull/936#issuecomment-44802398 thanks @liancheng and @marmbrus, I have modified the formatting issues and nullable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
