[GitHub] spark issue #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler options...

2018-06-18 Thread felixb
Github user felixb commented on the issue:

https://github.com/apache/spark/pull/20641
  
@krcz 
@felixcheung <- different felix ;)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10471] [CORE] [MESOS] prevent getting o...

2015-10-25 Thread felixb
Github user felixb commented on the pull request:

https://github.com/apache/spark/pull/8639#issuecomment-150916898
  
Is there anything else I can do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10471] [CORE] [MESOS] prevent getting o...

2015-10-18 Thread felixb
Github user felixb commented on the pull request:

https://github.com/apache/spark/pull/8639#issuecomment-149103542
  
I worked in all your comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10471] [CORE] [MESOS] prevent getting o...

2015-10-14 Thread felixb
Github user felixb commented on the pull request:

https://github.com/apache/spark/pull/8639#issuecomment-147971302
  
friendly reminder.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10471] [CORE] [MESOS] prevent getting o...

2015-10-07 Thread felixb
Github user felixb commented on the pull request:

https://github.com/apache/spark/pull/8639#issuecomment-146421117
  
Is there anything I can do to get this merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10471] [CORE] [MESOS] prevent getting o...

2015-09-17 Thread felixb
Github user felixb commented on the pull request:

https://github.com/apache/spark/pull/8639#issuecomment-141348584
  
added to table of parameters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: docs/running-on-mesos.md: state default values...

2015-09-17 Thread felixb
GitHub user felixb opened a pull request:

https://github.com/apache/spark/pull/8810

docs/running-on-mesos.md: state default values in default column

This PR simply uses the default value column for defaults.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/felixb/spark fix_mesos_doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/8810.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8810


commit 09b4e15f0dfe903ac70c0d6f4a8fcf06dac6d78b
Author: Felix Bechstein <felix.bechst...@otto.de>
Date:   2015-09-18T05:25:00Z

docs/running-on-mesos.md: state default values in default column




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: docs/running-on-mesos.md: state default values...

2015-09-17 Thread felixb
Github user felixb commented on a diff in the pull request:

https://github.com/apache/spark/pull/8810#discussion_r39825730
  
--- Diff: docs/running-on-mesos.md ---
@@ -332,21 +332,21 @@ See the [configuration page](configuration.html) for 
information on Spark config
 
 
   spark.mesos.principal
-  Framework principal to authenticate to Mesos
+  (none)
   
 Set the principal with which Spark framework will use to authenticate 
with Mesos.
   
 
 
   spark.mesos.secret
-  Framework secret to authenticate to Mesos
+  (none)/td>
   
 Set the secret with which Spark framework will use to authenticate 
with Mesos.
   
 
 
   spark.mesos.role
-  Role for the Spark framework
+  *
--- End diff --

I don't see anything.
Should I set it to `"*"`, `(*)` or ` * ` with blanks on each side?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10471] [CORE] [MESOS] prevent getting o...

2015-09-16 Thread felixb
Github user felixb commented on the pull request:

https://github.com/apache/spark/pull/8639#issuecomment-140650576
  
fixed typo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10471] [CORE] [MESOS] prevent getting o...

2015-09-15 Thread felixb
Github user felixb commented on the pull request:

https://github.com/apache/spark/pull/8639#issuecomment-140345640
  
I just rebased to the current upstream/master.
Any hint, why the tests keep failing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10471] [CORE] [MESOS] prevent getting o...

2015-09-11 Thread felixb
Github user felixb commented on the pull request:

https://github.com/apache/spark/pull/8639#issuecomment-139482353
  
Added the same logic for fine grained scheduler.
All mesos configuration is only available in `running-on-mesos.md`. So we 
skipped adding it to `configurations.md`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10471] [CORE] [MESOS] prevent getting o...

2015-09-10 Thread felixb
Github user felixb commented on the pull request:

https://github.com/apache/spark/pull/8639#issuecomment-139127892
  
I made the duration configurable. Still need to add it to fine grained 
scheduler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-10471] [CORE] [MESOS] prevent getting o...

2015-09-07 Thread felixb
GitHub user felixb opened a pull request:

https://github.com/apache/spark/pull/8639

[SPARK-10471] [CORE] [MESOS] prevent getting offers for unmet constraints

this change rejects offers for slaves with unmet constraints for 120s to 
mitigate offer starvation.
this prevents mesos to send us these offers again and again.
in return, we get more offers for slaves which might meet our constraints.
and it enables mesos to send the rejected offers to other frameworks.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/felixb/spark 
decline_offers_constraint_mismatch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/8639.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8639


commit c1efb1fdd20f45260040d7f4dd5cd3aef13c5558
Author: Felix Bechstein <felix.bechst...@otto.de>
Date:   2015-09-04T12:29:22Z

[SPARK-10471] [CORE] [MESOS] prevent getting offers for unmet constraints

this change rejects offers for slaves with unmet constraints for 120s to 
mitigate offer starvation.
this prevents mesos to send us these offers again and again.
in return, we get more offers for slaves which might meet our constraints.
and it enables mesos to send the rejected offers to other frameworks.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-4449][Core] Specify port range in spark

2015-04-02 Thread felixb
Github user felixb commented on the pull request:

https://github.com/apache/spark/pull/3314#issuecomment-5888
  
Does this configuration include the akka port as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org