GitHub user jooseong opened a pull request:
https://github.com/apache/spark/pull/20791
[SPARK-23618][BUILD] Initialize BUILD_ARGS in docker-image-tool.sh
## What changes were proposed in this pull request?
This change initializes BUILD_ARGS to an empty array when
$SPARK_HOME/RELEASE exists.
In function build, "local BUILD_ARGS" effectively creates an array of one
element where the first and only element is an empty string, so
"${BUILD_ARGS[@]}" expands to "" and passes an extra argument to docker.
Setting BUILD_ARGS to an empty array makes "${BUILD_ARGS[@]}" expand to
nothing.
## How was this patch tested?
Manually tested.
$ cat RELEASE
Spark 2.3.0 (git revision a0d7949896) built for Hadoop 2.7.3
Build flags: -Phadoop-2.7 -Phive -Phive-thriftserver -Pkafka-0-8 -Pmesos
-Pyarn -Pkubernetes -Pflume -Psparkr -DzincPort=3036
$ ./bin/docker-image-tool.sh -m t testing build
Sending build context to Docker daemon 256.4MB
...
@vanzin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jooseong/spark SPARK-23618
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20791.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20791
commit 096e99287a72b3ea164dbdf6c90edf4b256a2623
Author: Jooseong Kim <jooseong@...>
Date: 2018-03-10T05:21:18Z
[SPARK-23618][BUILD] Initialize BUILD_ARGS in docker-image-tool.sh
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
