[GitHub] [spark] 07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-12-24 Thread GitBox
07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid 
value when parameter is empty
URL: https://github.com/apache/spark/pull/26477#issuecomment-568835396
 
 
   sure i will update the migration guide also.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] 07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-12-24 Thread GitBox
07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid 
value when parameter is empty
URL: https://github.com/apache/spark/pull/26477#issuecomment-568739767
 
 
   @maropu , i have modified exiting end to end test cases , please review.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] 07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-12-23 Thread GitBox
07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid 
value when parameter is empty
URL: https://github.com/apache/spark/pull/26477#issuecomment-568660010
 
 
   ok @maropu 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] 07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-12-23 Thread GitBox
07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid 
value when parameter is empty
URL: https://github.com/apache/spark/pull/26477#issuecomment-568650148
 
 
   I refer other DBMS and analyse in other project like HIVE they have fixed 
this issue.
   It's good to handle in spark.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] 07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-12-23 Thread GitBox
07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid 
value when parameter is empty
URL: https://github.com/apache/spark/pull/26477#issuecomment-568649892
 
 
   @HyukjinKwon , please verify this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] 07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-11-13 Thread GitBox
07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid 
value when parameter is empty
URL: https://github.com/apache/spark/pull/26477#issuecomment-553346885
 
 
   @HyukjinKwon, this we can fix it now ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] 07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid value when parameter is empty

2019-11-11 Thread GitBox
07ARB commented on issue #26477: [SPARK-29776][SQL] rpad returning invalid 
value when parameter is empty
URL: https://github.com/apache/spark/pull/26477#issuecomment-552759351
 
 
   @HyukjinKwon , please verify this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org