[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

2019-12-28 Thread GitBox
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function 
should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569399704
 
 
   oh , ok got it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

2019-12-28 Thread GitBox
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function 
should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569397537
 
 
   @maropu , you mean i should use TypeCoercion.scala functionality to resolve 
this issue ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

2019-12-28 Thread GitBox
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function 
should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569397076
 
 
   in Hive : SELECT lpad('hihhh', 'Expected int', 
'');
Error: Error while compiling statement: FAILED: SemanticException [Error 
10016]: Line 1:67 Argument type mismatch '''': lpad only takes 
INT/SHORT/BYTE types as 2-ths argument, got DECIMAL (state=42000,code=10016)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

2019-12-27 Thread GitBox
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function 
should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395593
 
 
   yes , we need to discuss whether we need to handle or not.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

2019-12-27 Thread GitBox
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function 
should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395064
 
 
   @maropu , Thank you


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

2019-12-27 Thread GitBox
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function 
should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569245404
 
 
   @cloud-fan, please help me to review this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org