[GitHub] [spark] AngersZhuuuu commented on issue #25878: [SPARK-29162][SQL] Simplify NOT(IsNull(x)) and NOT(IsNotNull(x))
AngersZh commented on issue #25878: [SPARK-29162][SQL] Simplify NOT(IsNull(x)) and NOT(IsNotNull(x)) URL: https://github.com/apache/spark/pull/25878#issuecomment-533879418 > @AngersZh . Thank you for your contributions. I left two minor comments. Please address them. Can you trigger restart test. Thanks . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #25878: [SPARK-29162][SQL] Simplify NOT(IsNull(x)) and NOT(IsNotNull(x))
AngersZh commented on issue #25878: [SPARK-29162][SQL] Simplify NOT(IsNull(x)) and NOT(IsNotNull(x)) URL: https://github.com/apache/spark/pull/25878#issuecomment-533848397 > @AngersZh . Thank you for your contributions. I left two minor comments. Please address them. Thank you for your advise. All for better job. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x))
AngersZh commented on issue #25878: [SPARK-29162][SQL]Simplify NOT(IsNull(x)) and NOT(IsNotNull(x)) URL: https://github.com/apache/spark/pull/25878#issuecomment-533766516 gentle ping @juliuszsompolski I agree a lot that we should simplify these expression. It's really useful for judge query canonicalization equal. Meet this problem when I am doing some cache framework . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org