[GitHub] [spark] EnricoMi commented on pull request #39131: [SPARK-41162][SQL] Fix anti- and semi-join for self-join with aggregations

2023-01-05 Thread GitBox


EnricoMi commented on PR #39131:
URL: https://github.com/apache/spark/pull/39131#issuecomment-1372499446

   > @EnricoMi can you help to create backport PRs for 3.3/3.2/3.1? It has 
conflicts. Thanks!
   
   @cloud-fan Backport for 3.3 (and 3.2) in #39409.
   Looks like 3.1 is not needed: 
https://github.com/apache/spark/pull/39411#pullrequestreview-1237749350.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] EnricoMi commented on pull request #39131: [SPARK-41162][SQL] Fix anti- and semi-join for self-join with aggregations

2023-01-04 Thread GitBox


EnricoMi commented on PR #39131:
URL: https://github.com/apache/spark/pull/39131#issuecomment-1371848352

   > @EnricoMi thanks for the fix! which spark version starts to have this bug?
   
   This was introduced in Spark 3.0.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] EnricoMi commented on pull request #39131: [SPARK-41162][SQL] Fix anti- and semi-join for self-join with aggregations

2022-12-19 Thread GitBox


EnricoMi commented on PR #39131:
URL: https://github.com/apache/spark/pull/39131#issuecomment-1358939935

   @cloud-fan I think this is a better approach to fix correctness bug 
SPARK-41162 than #38676.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org