[GitHub] [spark] HeartSaVioR commented on a change in pull request #25562: [SPARK-27330][SS] call foreach writer close on abort
HeartSaVioR commented on a change in pull request #25562: [SPARK-27330][SS] call foreach writer close on abort URL: https://github.com/apache/spark/pull/25562#discussion_r316974056 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterSuite.scala ## @@ -154,6 +154,9 @@ class ForeachWriterSuite extends StreamTest with SharedSQLContext with BeforeAnd val errorEvent = allEvents(0)(2).asInstanceOf[ForeachWriterSuite.Close] assert(errorEvent.error.get.isInstanceOf[RuntimeException]) assert(errorEvent.error.get.getMessage === "ForeachSinkSuite error") + Review comment: nit: unnecessary newline This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #25562: [SPARK-27330][SS] call foreach writer close on abort
HeartSaVioR commented on a change in pull request #25562: [SPARK-27330][SS] call foreach writer close on abort URL: https://github.com/apache/spark/pull/25562#discussion_r316973937 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterSuite.scala ## @@ -258,6 +261,35 @@ class ForeachWriterSuite extends StreamTest with SharedSQLContext with BeforeAnd query.stop() } } + Review comment: nit: unnecessary newline This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #25562: [SPARK-27330][SS] call foreach writer close on abort
HeartSaVioR commented on a change in pull request #25562: [SPARK-27330][SS] call foreach writer close on abort URL: https://github.com/apache/spark/pull/25562#discussion_r316973836 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterProvider.scala ## @@ -112,6 +113,8 @@ class ForeachDataWriter[T]( // If open returns false, we should skip writing rows. private val opened = writer.open(partitionId, epochId) + private var closeCalled: Boolean = false + Review comment: nit: unnecessary newline This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
