[GitHub] [spark] Hisoka-X commented on pull request #41467: [SPARK-40850][SQL] Fix test case interpreted queries may execute Codegen

2023-06-28 Thread via GitHub


Hisoka-X commented on PR #41467:
URL: https://github.com/apache/spark/pull/41467#issuecomment-1611392393

   > @Hisoka-X How about other places, like:
   > 
   > 
https://github.com/apache/spark/blob/f26bdb7bfde56e4856a2f962162f204ba2dbb1c1/sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala#L81
   > 
   > Could you re-check them too, please ... or open an JIRA if you don't have 
time.
   
   Ok, I will do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Hisoka-X commented on pull request #41467: [SPARK-40850][SQL] Fix test case interpreted queries may execute Codegen

2023-06-28 Thread via GitHub


Hisoka-X commented on PR #41467:
URL: https://github.com/apache/spark/pull/41467#issuecomment-1611391822

   Thanks @MaxGekk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Hisoka-X commented on pull request #41467: [SPARK-40850][SQL] Fix test case interpreted queries may execute Codegen

2023-06-16 Thread via GitHub


Hisoka-X commented on PR #41467:
URL: https://github.com/apache/spark/pull/41467#issuecomment-1594594385

   cc @holdenk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] Hisoka-X commented on pull request #41467: [SPARK-40850][SQL] Fix test case interpreted queries may execute Codegen

2023-06-05 Thread via GitHub


Hisoka-X commented on PR #41467:
URL: https://github.com/apache/spark/pull/41467#issuecomment-1576999749

   cc @HyukjinKwon @MaxGekk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org