HyukjinKwon commented on a change in pull request #25622:
[SPARK-28915][CORE]The new keyword is not used when instantiating the
WorkerOffer.
URL: https://github.com/apache/spark/pull/25622#discussion_r319341164
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##########
@@ -270,7 +270,7 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
val activeExecutors = executorDataMap.filterKeys(executorIsAlive)
val workOffers = activeExecutors.map {
case (id, executorData) =>
- new WorkerOffer(id, executorData.executorHost,
executorData.freeCores,
+ WorkerOffer(id, executorData.executorHost, executorData.freeCores,
Review comment:
I think we don't have to change this - it's going to cause a lot of
conflicts when we backport but the gain here is virtually nothing. Either way
is legitimate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
