[GitHub] [spark] HyukjinKwon commented on a change in pull request #28427: [SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of ExpressionsSchemaSuite

2020-04-30 Thread GitBox


HyukjinKwon commented on a change in pull request #28427:
URL: https://github.com/apache/spark/pull/28427#discussion_r418420692



##
File path: sql/core/src/test/resources/sql-functions/sql-expression-schema.md
##
@@ -206,9 +204,6 @@
 | org.apache.spark.sql.catalyst.expressions.Pow | power | SELECT power(2, 3) | 
struct |
 | org.apache.spark.sql.catalyst.expressions.Quarter | quarter | SELECT 
quarter('2016-08-31') | struct |
 | org.apache.spark.sql.catalyst.expressions.RLike | rlike | SELECT 
'%SystemDrive%\Users\John' rlike '%SystemDrive%\\Users.*' | 
struct<%SystemDrive%UsersJohn RLIKE %SystemDrive%\Users.*:boolean> |
-| org.apache.spark.sql.catalyst.expressions.Rand | random | SELECT random() | 
struct |
-| org.apache.spark.sql.catalyst.expressions.Rand | rand | SELECT rand() | 
struct |
-| org.apache.spark.sql.catalyst.expressions.Randn | randn | SELECT randn() | 
struct |

Review comment:
   I think @beliefer meant https://github.com/apache/spark/pull/28392 is 
only landed into master and we should keep these just as are at 
https://github.com/apache/spark/pull/28194. I assume `rand(seed)` was printed 
out because this test was ran against the latest `master` instead of 
`branch-3.0` at 
https://github.com/apache/spark/pull/28427/commits/948a54e7059b29a1a001315b0ed2d69ec4104314
 (?).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] HyukjinKwon commented on a change in pull request #28427: [SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of ExpressionsSchemaSuite

2020-04-30 Thread GitBox


HyukjinKwon commented on a change in pull request #28427:
URL: https://github.com/apache/spark/pull/28427#discussion_r418420692



##
File path: sql/core/src/test/resources/sql-functions/sql-expression-schema.md
##
@@ -206,9 +204,6 @@
 | org.apache.spark.sql.catalyst.expressions.Pow | power | SELECT power(2, 3) | 
struct |
 | org.apache.spark.sql.catalyst.expressions.Quarter | quarter | SELECT 
quarter('2016-08-31') | struct |
 | org.apache.spark.sql.catalyst.expressions.RLike | rlike | SELECT 
'%SystemDrive%\Users\John' rlike '%SystemDrive%\\Users.*' | 
struct<%SystemDrive%UsersJohn RLIKE %SystemDrive%\Users.*:boolean> |
-| org.apache.spark.sql.catalyst.expressions.Rand | random | SELECT random() | 
struct |
-| org.apache.spark.sql.catalyst.expressions.Rand | rand | SELECT rand() | 
struct |
-| org.apache.spark.sql.catalyst.expressions.Randn | randn | SELECT randn() | 
struct |

Review comment:
   I think @beliefer meant https://github.com/apache/spark/pull/28392 is 
only landed into master and we should keep these just as are at 
https://github.com/apache/spark/pull/28194. I assume this seed were printed out 
because this test was ran against the latest `master` instead of `branch-3.0` 
at 
https://github.com/apache/spark/pull/28427/commits/948a54e7059b29a1a001315b0ed2d69ec4104314





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org